Re: [Dev] GoogleAuth library for TOTP authenticator

2016-04-08 Thread Keerthika Mahendralingam
Hi Johann,
Thank you for your suggestion. I have removed the GoogleAuth code from TOTP
repo. Able to use the library by adding it to the lib folder.

Thanks,

On Thu, Apr 7, 2016 at 4:54 PM, Johann Nallathamby  wrote:

> Hi Keerthika,
>
> First of all you should always copy such mails to dev.
>
> Why do you need to fork the entire code? If its the POM that you are
> modifying can't we do it like a orbit bundle without forking the entire
> code? I think that should be the way to do it.
>
> Regards,
> Johann.
>
> On Thu, Apr 7, 2016 at 6:14 AM, Keerthika Mahendralingam <
> keerth...@wso2.com> wrote:
>
>> Hi All,
>> For TOTP authenticator I have done some changes in GoogleAuth library pom
>> file so that it can be added into the dropins folder(Otherwise it is not
>> getting deployed). So I have added modified GoggleAuth library inside the
>> TOTP component[1].
>>
>> Any concern on this?
>>
>> [1]. https://github.com/keerthu/identity-outbound-auth-totp
>>
>> Thanks,
>> --
>> 
>> Keerthika Mahendralingam
>> Associate Software Engineer
>> Mobile :+94 (0) 776 121144
>> keerth...@wso2.com
>> WSO2, Inc.
>> lean . enterprise . middleware
>>
>
>
>
> --
> Thanks & Regards,
>
> *Johann Dilantha Nallathamby*
> Technical Lead & Product Lead of WSO2 Identity Server
> Governance Technologies Team
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - *+9476950*
> Blog - *http://nallaa.wordpress.com *
>



-- 

Keerthika Mahendralingam
Associate Software Engineer
Mobile :+94 (0) 776 121144
keerth...@wso2.com
WSO2, Inc.
lean . enterprise . middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] GoogleAuth library for TOTP authenticator

2016-04-07 Thread Johann Nallathamby
Hi Keerthika,

First of all you should always copy such mails to dev.

Why do you need to fork the entire code? If its the POM that you are
modifying can't we do it like a orbit bundle without forking the entire
code? I think that should be the way to do it.

Regards,
Johann.

On Thu, Apr 7, 2016 at 6:14 AM, Keerthika Mahendralingam  wrote:

> Hi All,
> For TOTP authenticator I have done some changes in GoogleAuth library pom
> file so that it can be added into the dropins folder(Otherwise it is not
> getting deployed). So I have added modified GoggleAuth library inside the
> TOTP component[1].
>
> Any concern on this?
>
> [1]. https://github.com/keerthu/identity-outbound-auth-totp
>
> Thanks,
> --
> 
> Keerthika Mahendralingam
> Associate Software Engineer
> Mobile :+94 (0) 776 121144
> keerth...@wso2.com
> WSO2, Inc.
> lean . enterprise . middleware
>



-- 
Thanks & Regards,

*Johann Dilantha Nallathamby*
Technical Lead & Product Lead of WSO2 Identity Server
Governance Technologies Team
WSO2, Inc.
lean.enterprise.middleware

Mobile - *+9476950*
Blog - *http://nallaa.wordpress.com *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev