Re: [Dev] NotificationSendingImpl class in identity management endpoint

[Isura Karunaratne]

On Fri, Feb 23, 2018 at 9:00 AM, Pulasthi Mahawithana 
wrote:

> Hi,
>
> Seems like this class [1] is not needed and it contains some test code.
> Shall we remove this?
>
+1.

Removed from 5.11.x branch with [1].

Please review and merge the PR for the maser [2]

>
> [1] https://github.com/wso2/carbon-identity-framework/blob/
> master/components/identity-mgt/org.wso2.carbon.identity.
> mgt.endpoint/src/main/java/org/wso2/carbon/identity/mgt/
> endpoint/client/implementation/NotificationSendingImpl.java
>


[1] https://github.com/wso2/carbon-identity-framework/pull/1386
[2] https://github.com/wso2/carbon-identity-framework/pull/1385

Thanks
Isura.

>
> --
> *Pulasthi Mahawithana*
> Associate Technical Lead
> WSO2 Inc., http://wso2.com/
> Mobile: +94-71-5179022 <+94%2071%20517%209022>
> Blog: https://medium.com/@pulasthi7/
>
> 
>



-- 

*Isura Dilhara Karunaratne*
Associate Technical Lead | WSO2
Email: is...@wso2.com
Mob : +94 772 254 810
Blog : http://isurad.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] NotificationSendingImpl class in identity management endpoint

[Pulasthi Mahawithana]

Hi,

Seems like this class [1] is not needed and it contains some test code.
Shall we remove this?

[1] https://github.com/wso2/carbon-identity-framework/
blob/master/components/identity-mgt/org.wso2.carbon.
identity.mgt.endpoint/src/main/java/org/wso2/carbon/
identity/mgt/endpoint/client/implementation/NotificationSendingImpl.java

-- 
*Pulasthi Mahawithana*
Associate Technical Lead
WSO2 Inc., http://wso2.com/
Mobile: +94-71-5179022 <+94%2071%20517%209022>
Blog: https://medium.com/@pulasthi7/


___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev