Re: [Dev] Please commit CARBON-14929
Done On Tue, Sep 2, 2014 at 7:31 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, The patch has been attached to the JIRA. Added a workaround to avoid the public method with proper comments. Regards, Chamil On Tue, Sep 2, 2014 at 6:13 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, For now that method is only used by four Log Handler classes. But there may be other usages in the future as a utility method. As we discussed I will change the code so that it avoids the public method for carbon 4.2.0 patch. Regards, Chamil On Tue, Sep 2, 2014 at 6:00 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, I noticed that you've added a public method to LoggingUtils class. Whats the purpose of that method? Thanks, Sameera. On Tue, Sep 2, 2014 at 2:07 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I have attached the fix-only diff to the JIRA and sent the pull request [1] [1] https://github.com/wso2-dev/carbon4-kernel/pull/88 On Tue, Sep 2, 2014 at 1:15 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I will attach the only diff against the fresh bootstrap to the JIRA. On Tue, Sep 2, 2014 at 12:33 PM, Sagara Gunathunga sag...@wso2.com wrote: On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma
Re: [Dev] Please commit CARBON-14929
Thanks Sameera, I will proceed. Regards, Chamil On Wed, Sep 3, 2014 at 11:40 AM, Sameera Jayasoma same...@wso2.com wrote: Done On Tue, Sep 2, 2014 at 7:31 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, The patch has been attached to the JIRA. Added a workaround to avoid the public method with proper comments. Regards, Chamil On Tue, Sep 2, 2014 at 6:13 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, For now that method is only used by four Log Handler classes. But there may be other usages in the future as a utility method. As we discussed I will change the code so that it avoids the public method for carbon 4.2.0 patch. Regards, Chamil On Tue, Sep 2, 2014 at 6:00 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, I noticed that you've added a public method to LoggingUtils class. Whats the purpose of that method? Thanks, Sameera. On Tue, Sep 2, 2014 at 2:07 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I have attached the fix-only diff to the JIRA and sent the pull request [1] [1] https://github.com/wso2-dev/carbon4-kernel/pull/88 On Tue, Sep 2, 2014 at 1:15 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I will attach the only diff against the fresh bootstrap to the JIRA. On Tue, Sep 2, 2014 at 12:33 PM, Sagara Gunathunga sag...@wso2.com wrote: On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect,
Re: [Dev] Please commit CARBON-14929
Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456 Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456 Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services;http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Sameera, I will attach the only diff against the fresh bootstrap to the JIRA. On Tue, Sep 2, 2014 at 12:33 PM, Sagara Gunathunga sag...@wso2.com wrote: On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456 Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services;http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Chamil, I noticed that you've added a public method to LoggingUtils class. Whats the purpose of that method? Thanks, Sameera. On Tue, Sep 2, 2014 at 2:07 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I have attached the fix-only diff to the JIRA and sent the pull request [1] [1] https://github.com/wso2-dev/carbon4-kernel/pull/88 On Tue, Sep 2, 2014 at 1:15 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I will attach the only diff against the fresh bootstrap to the JIRA. On Tue, Sep 2, 2014 at 12:33 PM, Sagara Gunathunga sag...@wso2.com wrote: On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456 Lean . Enterprise . Middleware ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Sagara Gunathunga Senior Technical Lead; WSO2, Inc.; http://wso2.com V.P Apache Web Services;http://ws.apache.org/ Linkedin; http://www.linkedin.com/in/ssagara Blog ; http://ssagara.blogspot.com -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate
Re: [Dev] Please commit CARBON-14929
Hi Sameera, The patch has been attached to the JIRA. Added a workaround to avoid the public method with proper comments. Regards, Chamil On Tue, Sep 2, 2014 at 6:13 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, For now that method is only used by four Log Handler classes. But there may be other usages in the future as a utility method. As we discussed I will change the code so that it avoids the public method for carbon 4.2.0 patch. Regards, Chamil On Tue, Sep 2, 2014 at 6:00 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, I noticed that you've added a public method to LoggingUtils class. Whats the purpose of that method? Thanks, Sameera. On Tue, Sep 2, 2014 at 2:07 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I have attached the fix-only diff to the JIRA and sent the pull request [1] [1] https://github.com/wso2-dev/carbon4-kernel/pull/88 On Tue, Sep 2, 2014 at 1:15 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, I will attach the only diff against the fresh bootstrap to the JIRA. On Tue, Sep 2, 2014 at 12:33 PM, Sagara Gunathunga sag...@wso2.com wrote: On Tue, Sep 2, 2014 at 12:20 PM, Sameera Jayasoma same...@wso2.com wrote: Hi Chamil, Looks like you have attached whole bootstrap component in the patch. We cannot see the patch you did in that manner. Please attach only the changes.. Send a pull request to 4.3.0 repo also You can find original fix from here https://github.com/sagaragu/carbon4-kernel/commit/9c29e215b6c93a74c4d37c14ea3be0fb509e1100 Thanks ! Thanks, Sameera. On Mon, Sep 1, 2014 at 11:58 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Sameera Jayasoma, Software Architect, WSO2, Inc. (http://wso2.com) email: same...@wso2.com blog: http://sameera.adahas.org twitter: https://twitter.com/sameerajayasoma flickr: http://www.flickr.com/photos/sameera-jayasoma/collections Mobile: 0094776364456
Re: [Dev] Please commit CARBON-14929
Hi Sameera, Can you please commit the [1] [1] https://wso2.org/jira/browse/CARBON-14929 On Mon, Sep 1, 2014 at 10:44 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Geeth, Supun ran the build tests successfully in his local environment. Can you please commit this patch since he is not available. Regards, Chamil On Mon, Sep 1, 2014 at 10:23 AM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, Any update on this? On Fri, Aug 29, 2014 at 3:12 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Please commit CARBON-14929
$subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please commit CARBON-14929
Hi Supun, I have re-attached the patch to the issue. Please proceed. Regards, Chamil On Fri, Aug 29, 2014 at 2:57 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, I had a chat with Sameera as well. Let's go ahead with the above approach. thanks, On Fri, Aug 29, 2014 at 2:37 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi All, I'm adding org.wso2.carbon.bootstrap*.jar into patch0009. This jar should go into CARBON_HOME/bin So I think we can add a bin folder to the patch.zip and copy this jar to that folder. Theadd a step in README to copy it manually to CARBON_HOME/bin WDYT? Is there a better way of doing that? On Fri, Aug 29, 2014 at 1:49 PM, Chamil Jeewantha cha...@wso2.com wrote: Hi Supun, org.wso2.carbon.bootstrap*.jar does not go into the plugin directory. it goes to the CARBON_HOME/bin directory. Do we still need to add it to the patch zip? Regards, Chamil On Fri, Aug 29, 2014 at 12:34 PM, Supun Malinga sup...@wso2.com wrote: Hi Chamil, As discussed let's add the entries to include the built jar into patch zip as well. thanks, On Fri, Aug 29, 2014 at 12:29 PM, Chamil Jeewantha cha...@wso2.com wrote: $subject. https://wso2.org/jira/browse/CARBON-14929 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com email: sup...@wso2.com sup...@wso2.com mobile: +94 (0)71 56 91 321 -- K.D. Chamil Jeewantha Associate Technical Lead WSO2, Inc.; http://wso2.com http://kdchamil.blogspot.com Mobile: +94716813892 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
