Re: [Dev] Simplifying the claim-config.xml file in Identity Server

2017-05-04 Thread Isura Karunaratne 
Hi Malithi,

I didn't test. But, according to the [1], should be able to change the
claim manager using *initializeNewClaimManager* property in user-mgt.xml
file.

[1] [Architecture] [IS] Improvements to Claim Management


Thanks
Isura.

On Fri, May 5, 2017 at 9:17 AM, Malithi Edirisinghe 
wrote:

>
>
> On Thu, May 4, 2017 at 10:16 PM, Isura Karunaratne  wrote:
>
>> Hi Lanka,
>>
>> I think that is done to support both old claim management module and new
>> module from the same claim-mgt.xml.
>>
>
> How do we opt for the old claim module in IS 5.3.0 ?
> Isn't it always the new module is being picked.
>
>
>>
>> Thanks
>> Isura.
>>
>>
>>
>> On Thu, May 4, 2017 at 9:03 PM Pushpalanka Jayawardhana 
>> wrote:
>>
>>> Hi All,
>>>
>>> As we know we define default claim mappings between dialects in this
>>> file named calim-config.xml.
>>> There we have default claim dialect(wso2.org) defined with all its
>>> required attributes. Then we also define other dialects and map each claim
>>> dialect URI to some local claim URI as suitable.
>>> Following is a fraction of such from SCIM dialect mapping.
>>>
>>> From 5.3.0 onwards we are depending on mapping the localClaim to other
>>> external claims URIs.
>>> In such case it seems '**' is not really neccessary to
>>> define here, as it is already defined in local claim definition.
>>>
>>> 
>>> urn:scim:schemas:core:1.0:name.givenName
>>> Name - Given Name
>>> *givenName*
>>> Given Name
>>> 
>>> 1
>>> 
>>> http://wso2.org/claims/givenname
>>> 
>>>
>>> This is not a critical issue, but would be better to simplify the file
>>> removing this, if we can agree this is not necessary here.
>>>
>>> Thanks,
>>> --
>>> Pushpalanka.
>>> --
>>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons).
>>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd;  wso2.com/
>>> Mobile: +94779716248
>>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/p
>>> ushpalanka/ | Twitter: @pushpalanka
>>>
>>> --
>>
>> *Isura Dilhara Karunaratne*
>> Senior Software Engineer | WSO2
>> Email: is...@wso2.com
>> Mob : +94 772 254 810 <+94%2077%20225%204810>
>> Blog : http://isurad.blogspot.com/
>>
>>
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Malithi Edirisinghe*
> Associate Technical Lead
> WSO2 Inc.
>
> Mobile : +94 (0) 718176807
> malit...@wso2.com
>



-- 

*Isura Dilhara Karunaratne*
Senior Software Engineer | WSO2
Email: is...@wso2.com
Mob : +94 772 254 810
Blog : http://isurad.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Simplifying the claim-config.xml file in Identity Server

2017-05-04 Thread Malithi Edirisinghe 
On Thu, May 4, 2017 at 10:16 PM, Isura Karunaratne  wrote:

> Hi Lanka,
>
> I think that is done to support both old claim management module and new
> module from the same claim-mgt.xml.
>

How do we opt for the old claim module in IS 5.3.0 ?
Isn't it always the new module is being picked.


>
> Thanks
> Isura.
>
>
>
> On Thu, May 4, 2017 at 9:03 PM Pushpalanka Jayawardhana 
> wrote:
>
>> Hi All,
>>
>> As we know we define default claim mappings between dialects in this file
>> named calim-config.xml.
>> There we have default claim dialect(wso2.org) defined with all its
>> required attributes. Then we also define other dialects and map each claim
>> dialect URI to some local claim URI as suitable.
>> Following is a fraction of such from SCIM dialect mapping.
>>
>> From 5.3.0 onwards we are depending on mapping the localClaim to other
>> external claims URIs.
>> In such case it seems '**' is not really neccessary to
>> define here, as it is already defined in local claim definition.
>>
>> 
>> urn:scim:schemas:core:1.0:name.givenName
>> Name - Given Name
>> *givenName*
>> Given Name
>> 
>> 1
>> 
>> http://wso2.org/claims/givenname
>> 
>>
>> This is not a critical issue, but would be better to simplify the file
>> removing this, if we can agree this is not necessary here.
>>
>> Thanks,
>> --
>> Pushpalanka.
>> --
>> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons).
>> Senior Software Engineer, WSO2 Lanka (pvt) Ltd;  wso2.com/
>> Mobile: +94779716248
>> Blog: pushpalankajaya.blogspot.com/ | LinkedIn: lk.linkedin.com/in/
>> pushpalanka/ | Twitter: @pushpalanka
>>
>> --
>
> *Isura Dilhara Karunaratne*
> Senior Software Engineer | WSO2
> Email: is...@wso2.com
> Mob : +94 772 254 810 <+94%2077%20225%204810>
> Blog : http://isurad.blogspot.com/
>
>
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 

*Malithi Edirisinghe*
Associate Technical Lead
WSO2 Inc.

Mobile : +94 (0) 718176807
malit...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Simplifying the claim-config.xml file in Identity Server

2017-05-04 Thread Isura Karunaratne 
Hi Lanka,

I think that is done to support both old claim management module and new
module from the same claim-mgt.xml.

Thanks
Isura.



On Thu, May 4, 2017 at 9:03 PM Pushpalanka Jayawardhana 
wrote:

> Hi All,
>
> As we know we define default claim mappings between dialects in this file
> named calim-config.xml.
> There we have default claim dialect(wso2.org) defined with all its
> required attributes. Then we also define other dialects and map each claim
> dialect URI to some local claim URI as suitable.
> Following is a fraction of such from SCIM dialect mapping.
>
> From 5.3.0 onwards we are depending on mapping the localClaim to other
> external claims URIs.
> In such case it seems '**' is not really neccessary to
> define here, as it is already defined in local claim definition.
>
> 
> urn:scim:schemas:core:1.0:name.givenName
> Name - Given Name
> *givenName*
> Given Name
> 
> 1
> 
> http://wso2.org/claims/givenname
> 
>
> This is not a critical issue, but would be better to simplify the file
> removing this, if we can agree this is not necessary here.
>
> Thanks,
> --
> Pushpalanka.
> --
> Pushpalanka Jayawardhana, B.Sc.Eng.(Hons).
> Senior Software Engineer, WSO2 Lanka (pvt) Ltd;  wso2.com/
> Mobile: +94779716248
> Blog: pushpalankajaya.blogspot.com/ | LinkedIn:
> lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka
>
> --

*Isura Dilhara Karunaratne*
Senior Software Engineer | WSO2
Email: is...@wso2.com
Mob : +94 772 254 810
Blog : http://isurad.blogspot.com/
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Simplifying the claim-config.xml file in Identity Server

2017-05-04 Thread Pushpalanka Jayawardhana 
Hi All,

As we know we define default claim mappings between dialects in this file
named calim-config.xml.
There we have default claim dialect(wso2.org) defined with all its required
attributes. Then we also define other dialects and map each claim dialect
URI to some local claim URI as suitable.
Following is a fraction of such from SCIM dialect mapping.

>From 5.3.0 onwards we are depending on mapping the localClaim to other
external claims URIs.
In such case it seems '**' is not really neccessary to define
here, as it is already defined in local claim definition.


urn:scim:schemas:core:1.0:name.givenName
Name - Given Name
*givenName*
Given Name

1

http://wso2.org/claims/givenname


This is not a critical issue, but would be better to simplify the file
removing this, if we can agree this is not necessary here.

Thanks,
-- 
Pushpalanka.
-- 
Pushpalanka Jayawardhana, B.Sc.Eng.(Hons).
Senior Software Engineer, WSO2 Lanka (pvt) Ltd;  wso2.com/
Mobile: +94779716248
Blog: pushpalankajaya.blogspot.com/ | LinkedIn:
lk.linkedin.com/in/pushpalanka/ | Twitter: @pushpalanka
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev