Re: [Dev] [APIM 2.0.0] Shouldn't Update application go through workflow approval process?

[Sewmini Jayaweera]

Any thoughts ?

Sewmini Jayaweera
*Software Engineer - QA Team*
Mobile: +94 (0) 773 381 250
sewm...@wso2.com

On Thu, Jun 30, 2016 at 10:31 AM, Sewmini Jayaweera 
wrote:

> Hi Nuwan,
>
> My mistake that I misunderstood the type of use cases we support with
> application creation workflow we provide out of the box.
>
> By going through your explanation a possible use case I could think of is
> a scenario where the organisation allows a specific developer group (EX:
> developers in their different departments) to create applications. In other
> words allowing application creation to a restricted audience, not to all
> users who have login permission to the API store. (Please correct me if I'm
> wrong)
>
> The reason why I thought that administrator validates application details
> and grant permission, is that; when an application creator adds an
> application, until administrator approves the particular application, edit
> option is being removed from the 'Actions' column on API store >
> applications page. I thought reason why we don't allow inactive
> applications to be edited is that application details would be considered
> in approval human task.
>
> [1]
> Is there any specific reason why we have removed edit option from the
> inactive application's 'Actions' column?
>
> [2]Also I noticed that the rejected applications are given a view option
> and once user clicks on the view link an edit option is also available for
> the user. (When user edits a rejected application changes will not get
> saved) Since we are not providing a functionality to resubmit application
> creation request after changing the content why don't we just have delete
> link so it is more straight forward to the user that request cannot be
> resubmitted?
>
> Regards,
> Sewmini
>
> Sewmini Jayaweera
> *Software Engineer - QA Team*
> Mobile: +94 (0) 773 381 250
> sewm...@wso2.com
>
> On Wed, Jun 29, 2016 at 5:05 PM, Nuwan Dias  wrote:
>
>> Yes, it is ideal to have a feature which allows you to have workflows for
>> Updates as well. And you are free to contribute the feature too :).
>>
>> Anyhow, this is not a bug but rather a request for a new feature
>> (Application Update Workflow). I think you see this as a bug is because the
>> sample workflow is for a "Approval" process. Workflows have many other use
>> cases and even in the case of approvals, they operate in many contexts.
>> Most see this on the angle of the permission to create an App and not
>> really validate the App details. After all, these details effect the
>> developers own App. Its unlikely someone would put details that harm his
>> own Application.
>>
>> On Wed, Jun 29, 2016 at 4:46 PM, Sewmini Jayaweera 
>> wrote:
>>
>>> Hi All,
>>>
>>> Your answers will be highly appreciated.
>>>
>>> I have also logged a Jira [1] in order to track this issue.
>>>
>>> [1]. https://wso2.org/jira/browse/APIMANAGER-5148
>>>
>>> Kind regards,
>>> Sewmini
>>>
>>> Sewmini Jayaweera
>>> *Software Engineer - QA Team*
>>> Mobile: +94 (0) 773 381 250
>>> sewm...@wso2.com
>>>
>>> On Tue, Jun 28, 2016 at 8:05 PM, Sewmini Jayaweera 
>>> wrote:
>>>
 Hi All,

 When I tested application creation workflow I observed below.

 - When application creation request is submitted, until admin user
 approves, the request editoption is not enabled for the inactive
 application.

 - Once Application creation request is approved user can edit the
 application and change  'Application name', 'Per token quota', callback
 URL and description as desired andupdate application doesn't  go
 through any approval process.


 [1]. If user wants to change application name or 'per token quota'
 shouldn't it go through an workflow approval process?

 Thank You.
 Kind regards,
 Sewmini

 Sewmini Jayaweera
 *Software Engineer - QA Team*
 Mobile: +94 (0) 773 381 250
 sewm...@wso2.com

>>>
>>>
>>
>>
>> --
>> Nuwan Dias
>>
>> Technical Lead - WSO2, Inc. http://wso2.com
>> email : nuw...@wso2.com
>> Phone : +94 777 775 729
>>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [APIM 2.0.0] Shouldn't Update application go through workflow approval process?

[Sewmini Jayaweera]

Hi Nuwan,

My mistake that I misunderstood the type of use cases we support with
application creation workflow we provide out of the box.

By going through your explanation a possible use case I could think of is a
scenario where the organisation allows a specific developer group (EX:
developers in their different departments) to create applications. In other
words allowing application creation to a restricted audience, not to all
users who have login permission to the API store. (Please correct me if I'm
wrong)

The reason why I thought that administrator validates application details
and grant permission, is that; when an application creator adds an
application, until administrator approves the particular application, edit
option is being removed from the 'Actions' column on API store >
applications page. I thought reason why we don't allow inactive
applications to be edited is that application details would be considered
in approval human task.

[1]
Is there any specific reason why we have removed edit option from the
inactive application's 'Actions' column?

[2]Also I noticed that the rejected applications are given a view option
and once user clicks on the view link an edit option is also available for
the user. (When user edits a rejected application changes will not get
saved) Since we are not providing a functionality to resubmit application
creation request after changing the content why don't we just have delete
link so it is more straight forward to the user that request cannot be
resubmitted?

Regards,
Sewmini

Sewmini Jayaweera
*Software Engineer - QA Team*
Mobile: +94 (0) 773 381 250
sewm...@wso2.com

On Wed, Jun 29, 2016 at 5:05 PM, Nuwan Dias  wrote:

> Yes, it is ideal to have a feature which allows you to have workflows for
> Updates as well. And you are free to contribute the feature too :).
>
> Anyhow, this is not a bug but rather a request for a new feature
> (Application Update Workflow). I think you see this as a bug is because the
> sample workflow is for a "Approval" process. Workflows have many other use
> cases and even in the case of approvals, they operate in many contexts.
> Most see this on the angle of the permission to create an App and not
> really validate the App details. After all, these details effect the
> developers own App. Its unlikely someone would put details that harm his
> own Application.
>
> On Wed, Jun 29, 2016 at 4:46 PM, Sewmini Jayaweera 
> wrote:
>
>> Hi All,
>>
>> Your answers will be highly appreciated.
>>
>> I have also logged a Jira [1] in order to track this issue.
>>
>> [1]. https://wso2.org/jira/browse/APIMANAGER-5148
>>
>> Kind regards,
>> Sewmini
>>
>> Sewmini Jayaweera
>> *Software Engineer - QA Team*
>> Mobile: +94 (0) 773 381 250
>> sewm...@wso2.com
>>
>> On Tue, Jun 28, 2016 at 8:05 PM, Sewmini Jayaweera 
>> wrote:
>>
>>> Hi All,
>>>
>>> When I tested application creation workflow I observed below.
>>>
>>> - When application creation request is submitted, until admin user
>>> approves, the request editoption is not enabled for the inactive
>>> application.
>>>
>>> - Once Application creation request is approved user can edit the
>>> application and change  'Application name', 'Per token quota', callback
>>> URL and description as desired andupdate application doesn't  go
>>> through any approval process.
>>>
>>>
>>> [1]. If user wants to change application name or 'per token quota'
>>> shouldn't it go through an workflow approval process?
>>>
>>> Thank You.
>>> Kind regards,
>>> Sewmini
>>>
>>> Sewmini Jayaweera
>>> *Software Engineer - QA Team*
>>> Mobile: +94 (0) 773 381 250
>>> sewm...@wso2.com
>>>
>>
>>
>
>
> --
> Nuwan Dias
>
> Technical Lead - WSO2, Inc. http://wso2.com
> email : nuw...@wso2.com
> Phone : +94 777 775 729
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [APIM 2.0.0] Shouldn't Update application go through workflow approval process?

[Nuwan Dias]

Yes, it is ideal to have a feature which allows you to have workflows for
Updates as well. And you are free to contribute the feature too :).

Anyhow, this is not a bug but rather a request for a new feature
(Application Update Workflow). I think you see this as a bug is because the
sample workflow is for a "Approval" process. Workflows have many other use
cases and even in the case of approvals, they operate in many contexts.
Most see this on the angle of the permission to create an App and not
really validate the App details. After all, these details effect the
developers own App. Its unlikely someone would put details that harm his
own Application.

On Wed, Jun 29, 2016 at 4:46 PM, Sewmini Jayaweera  wrote:

> Hi All,
>
> Your answers will be highly appreciated.
>
> I have also logged a Jira [1] in order to track this issue.
>
> [1]. https://wso2.org/jira/browse/APIMANAGER-5148
>
> Kind regards,
> Sewmini
>
> Sewmini Jayaweera
> *Software Engineer - QA Team*
> Mobile: +94 (0) 773 381 250
> sewm...@wso2.com
>
> On Tue, Jun 28, 2016 at 8:05 PM, Sewmini Jayaweera 
> wrote:
>
>> Hi All,
>>
>> When I tested application creation workflow I observed below.
>>
>> - When application creation request is submitted, until admin user
>> approves, the request editoption is not enabled for the inactive
>> application.
>>
>> - Once Application creation request is approved user can edit the
>> application and change  'Application name', 'Per token quota', callback
>> URL and description as desired andupdate application doesn't  go
>> through any approval process.
>>
>>
>> [1]. If user wants to change application name or 'per token quota'
>> shouldn't it go through an workflow approval process?
>>
>> Thank You.
>> Kind regards,
>> Sewmini
>>
>> Sewmini Jayaweera
>> *Software Engineer - QA Team*
>> Mobile: +94 (0) 773 381 250
>> sewm...@wso2.com
>>
>
>


-- 
Nuwan Dias

Technical Lead - WSO2, Inc. http://wso2.com
email : nuw...@wso2.com
Phone : +94 777 775 729
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [APIM 2.0.0] Shouldn't Update application go through workflow approval process?

[Sewmini Jayaweera]

Hi All,

Your answers will be highly appreciated.

I have also logged a Jira [1] in order to track this issue.

[1]. https://wso2.org/jira/browse/APIMANAGER-5148

Kind regards,
Sewmini

Sewmini Jayaweera
*Software Engineer - QA Team*
Mobile: +94 (0) 773 381 250
sewm...@wso2.com

On Tue, Jun 28, 2016 at 8:05 PM, Sewmini Jayaweera  wrote:

> Hi All,
>
> When I tested application creation workflow I observed below.
>
> - When application creation request is submitted, until admin user
> approves, the request editoption is not enabled for the inactive
> application.
>
> - Once Application creation request is approved user can edit the
> application and change  'Application name', 'Per token quota', callback
> URL and description as desired andupdate application doesn't  go
> through any approval process.
>
>
> [1]. If user wants to change application name or 'per token quota'
> shouldn't it go through an workflow approval process?
>
> Thank You.
> Kind regards,
> Sewmini
>
> Sewmini Jayaweera
> *Software Engineer - QA Team*
> Mobile: +94 (0) 773 381 250
> sewm...@wso2.com
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev