Re: [Dev] Error log when configurationmap does not contain the requested namespace.

2017-06-23 Thread Ishara Cooray
Thanks.

Thanks & Regards,
Ishara Cooray
Senior Software Engineer
Mobile : +9477 262 9512
WSO2, Inc. | http://wso2.com/
Lean . Enterprise . Middleware

On Fri, Jun 23, 2017 at 12:41 PM, Danesh Kuruppu  wrote:

> Create a git issue in carbon-config[1]. We will change it in release.
>
> 1. https://github.com/wso2/carbon-config/issues
>
>
> On Fri, Jun 23, 2017 at 12:35 PM, Thusitha Thilina Dayaratne <
> thusit...@wso2.com> wrote:
>
>> Hi Ishara,
>>
>> +1
>> We can change that log level to warning. Would you create a GitHub issue
>> for that?
>>
>> Thanks
>> Thusitha
>>
>> On Fri, Jun 23, 2017 at 12:29 PM, Ishara Cooray  wrote:
>>
>>> Hi,
>>>
>>> Please refer [1] which prints an error lo when the namespace it not
>>> found in the configuration map.
>>>
>>> In our usecase, namespace is not found in the map is also a valid use
>>> case. Therefore printing an error log is misleading.
>>>
>>> IMO this log should be a warn log.
>>>
>>> wdyt?
>>>
>>> [1] https://github.com/wso2/carbon-kernel/blob/v5.2.0-m3/core/sr
>>> c/main/java/org/wso2/carbon/kernel/internal/configprovider/
>>> ConfigProviderImpl.java#L124
>>>
>>> Thanks & Regards,
>>> Ishara Cooray
>>> Senior Software Engineer
>>> Mobile : +9477 262 9512 <+94%2077%20262%209512>
>>> WSO2, Inc. | http://wso2.com/
>>> Lean . Enterprise . Middleware
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Thusitha Dayaratne
>> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>>
>> Mobile  +94712756809 <+94%2071%20275%206809>
>> Blog  alokayasoya.blogspot.com
>> Abouthttp://about.me/thusithathilina
>> 
>>
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Danesh Kuruppu*
> Senior Software Engineer | WSO2
>
> Email: dan...@wso2.com
> Mobile: +94 (77) 1690552 <+94%2077%20169%200552>
> Web: WSO2 Inc 
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Error log when configurationmap does not contain the requested namespace.

2017-06-23 Thread Danesh Kuruppu
Create a git issue in carbon-config[1]. We will change it in release.

1. https://github.com/wso2/carbon-config/issues


On Fri, Jun 23, 2017 at 12:35 PM, Thusitha Thilina Dayaratne <
thusit...@wso2.com> wrote:

> Hi Ishara,
>
> +1
> We can change that log level to warning. Would you create a GitHub issue
> for that?
>
> Thanks
> Thusitha
>
> On Fri, Jun 23, 2017 at 12:29 PM, Ishara Cooray  wrote:
>
>> Hi,
>>
>> Please refer [1] which prints an error lo when the namespace it not found
>> in the configuration map.
>>
>> In our usecase, namespace is not found in the map is also a valid use
>> case. Therefore printing an error log is misleading.
>>
>> IMO this log should be a warn log.
>>
>> wdyt?
>>
>> [1] https://github.com/wso2/carbon-kernel/blob/v5.2.0-m3/core/
>> src/main/java/org/wso2/carbon/kernel/internal/configprovider
>> /ConfigProviderImpl.java#L124
>>
>> Thanks & Regards,
>> Ishara Cooray
>> Senior Software Engineer
>> Mobile : +9477 262 9512 <+94%2077%20262%209512>
>> WSO2, Inc. | http://wso2.com/
>> Lean . Enterprise . Middleware
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Thusitha Dayaratne
> WSO2 Inc. - lean . enterprise . middleware |  wso2.com
>
> Mobile  +94712756809 <+94%2071%20275%206809>
> Blog  alokayasoya.blogspot.com
> Abouthttp://about.me/thusithathilina
> 
>
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 

*Danesh Kuruppu*
Senior Software Engineer | WSO2

Email: dan...@wso2.com
Mobile: +94 (77) 1690552
Web: WSO2 Inc 
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Error log when configurationmap does not contain the requested namespace.

2017-06-23 Thread Thusitha Thilina Dayaratne
Hi Ishara,

+1
We can change that log level to warning. Would you create a GitHub issue
for that?

Thanks
Thusitha

On Fri, Jun 23, 2017 at 12:29 PM, Ishara Cooray  wrote:

> Hi,
>
> Please refer [1] which prints an error lo when the namespace it not found
> in the configuration map.
>
> In our usecase, namespace is not found in the map is also a valid use
> case. Therefore printing an error log is misleading.
>
> IMO this log should be a warn log.
>
> wdyt?
>
> [1] https://github.com/wso2/carbon-kernel/blob/v5.2.0-m3/
> core/src/main/java/org/wso2/carbon/kernel/internal/configprovider/
> ConfigProviderImpl.java#L124
>
> Thanks & Regards,
> Ishara Cooray
> Senior Software Engineer
> Mobile : +9477 262 9512 <+94%2077%20262%209512>
> WSO2, Inc. | http://wso2.com/
> Lean . Enterprise . Middleware
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Thusitha Dayaratne
WSO2 Inc. - lean . enterprise . middleware |  wso2.com

Mobile  +94712756809
Blog  alokayasoya.blogspot.com
Abouthttp://about.me/thusithathilina

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev