Re: [Dev] Why do we maintain same configuration files inside both feature level and product level ?
On Mon, Jul 1, 2013 at 2:28 PM, Dinusha Senanayaka dinu...@wso2.com wrote: Hi All, There are some places where we bundle the config-files, dbscripts etcinside feature and we maintain copies of these configs inside product level as well. Aren't we should copy these configsinto product from feature without duplicating them at product level as well.. or are there any-other reasons to do so ? The main reason is while installing the features to other product(using P2- repo) we need to copy the feature specific configurations. +1 to keep in one place as much as possible. Thanks Ajith. Regards, Dinusha. -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Ajith Vitharana. WSO2 Inc. - http://wso2.org Email : aji...@wso2.com Mobile : +94772217350 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Why do we maintain same configuration files inside both feature level and product level ?
On Mon, Jul 1, 2013 at 2:43 PM, Ajith Vitharana aji...@wso2.com wrote: On Mon, Jul 1, 2013 at 2:28 PM, Dinusha Senanayaka dinu...@wso2.comwrote: Hi All, There are some places where we bundle the config-files, dbscripts etcinside feature and we maintain copies of these configs inside product level as well. Aren't we should copy these configs into product from feature without duplicating them at product level as well.. or are there any-other reasons to do so ? The main reason is while installing the features to other product(using P2-repo) we need to copy the feature specific configurations. +1 to keep in one place as much as possible. It is better to allow to create and define all the config files only in a product. We can allow features only to modify the existing config files but not to create them. This will avoid collision between config files with the same name coming from different features to the same product location. Thanks Ajith. Regards, Dinusha. -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Ajith Vitharana. WSO2 Inc. - http://wso2.org Email : aji...@wso2.com Mobile : +94772217350 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Why do we maintain same configuration files inside both feature level and product level ?
Hi, Can we do something like this?. * Keep the configs in the features (as much as possible) * When installing the features to another product, can we detect if the config already exist?. * If already exists we should be able to update the existing config according to the requirements of the installing feature. What I'm thinking is that, we can solve issues with registry.xml, while installing registry features into other products. This could be a possible improvement in p2 (via p2 touchpoints?). thanks, On Mon, Jul 1, 2013 at 5:16 PM, Maninda Edirisooriya mani...@wso2.comwrote: On Mon, Jul 1, 2013 at 2:43 PM, Ajith Vitharana aji...@wso2.com wrote: On Mon, Jul 1, 2013 at 2:28 PM, Dinusha Senanayaka dinu...@wso2.comwrote: Hi All, There are some places where we bundle the config-files, dbscripts etcinside feature and we maintain copies of these configs inside product level as well. Aren't we should copy these configs into product from feature without duplicating them at product level as well.. or are there any-other reasons to do so ? The main reason is while installing the features to other product(using P2-repo) we need to copy the feature specific configurations. +1 to keep in one place as much as possible. It is better to allow to create and define all the config files only in a product. We can allow features only to modify the existing config files but not to create them. This will avoid collision between config files with the same name coming from different features to the same product location. Thanks Ajith. Regards, Dinusha. -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Ajith Vitharana. WSO2 Inc. - http://wso2.org Email : aji...@wso2.com Mobile : +94772217350 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- Supun Malinga, Senior Software Engineer, WSO2 Inc. http://wso2.com http://wso2.org email - sup...@wso2.com sup...@wso2.com mobile - 071 56 91 321 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Why do we maintain same configuration files inside both feature level and product level ?
On Mon, Jul 1, 2013 at 2:28 PM, Dinusha Senanayaka dinu...@wso2.com wrote: Hi All, There are some places where we bundle the config-files, dbscripts etc inside feature and we maintain copies of these configs inside product level as well. Aren't we should copy these configs into product from feature without duplicating them at product level as well.. or are there any-other reasons to do so ? you need to remove those duplications. It is enough to keep the config files only at the feature level. thanks, Amila. Regards, Dinusha. -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- *Amila Suriarachchi* Software Architect WSO2 Inc. ; http://wso2.com lean . enterprise . middleware phone : +94 71 3082805 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Why do we maintain same configuration files inside both feature level and product level ?
On Mon, Jul 1, 2013 at 5:56 PM, Amila Suriarachchi am...@wso2.com wrote: On Mon, Jul 1, 2013 at 2:28 PM, Dinusha Senanayaka dinu...@wso2.comwrote: Hi All, There are some places where we bundle the config-files, dbscripts etc inside feature and we maintain copies of these configs inside product level as well. Aren't we should copy these configs into product from feature without duplicating them at product level as well.. or are there any-other reasons to do so ? I guess we have already added some of common config files to features and removed from product level. We have done that for APIM, stratos common and etc. We can follow same here. you need to remove those duplications. It is enough to keep the config files only at the feature level. thanks, Amila. Regards, Dinusha. -- Dinusha Dilrukshi Senior Software Engineer WSO2 Inc.: http://wso2.com/ Mobile: +94725255071 Blog: http://dinushasblog.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- *Amila Suriarachchi* Software Architect WSO2 Inc. ; http://wso2.com lean . enterprise . middleware phone : +94 71 3082805 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev -- * * *Sanjeewa Malalgoda* WSO2 Inc. Mobile : +94713068779 http://sanjeewamalalgoda.blogspot.com/blog :http://sanjeewamalalgoda.blogspot.com/http://sanjeewamalalgoda.blogspot.com/ ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
