[GitHub] zeppelin pull request #971: [ZEPPELIN-961] Longer names to the notebook make...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/971


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1084: [HOTFIX] Fix flaky AuthenticationIT

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1084
  
@minahlee @bzz @Leemoonsoo After merging this CI is now failing (Build 
#5323.1) with  

```
---
 T E S T S
---
Running org.apache.zeppelin.python.PythonInterpreterTest
SLF4J: Class path contains multiple SLF4J bindings.
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/zeppelin-interpreter-0.6.0-SNAPSHOT.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/build/apache/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: Found binding in 
[jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class]
SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an 
explanation.
SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory]
log4j:WARN No appenders could be found for logger 
(org.apache.zeppelin.interpreter.Interpreter).
log4j:WARN Please initialize the log4j system properly.
log4j:WARN See http://logging.apache.org/log4j/1.2/faq.html#noconfig for 
more info.
Tests run: 5, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.365 sec 
<<< FAILURE! - in org.apache.zeppelin.python.PythonInterpreterTest
testClose(org.apache.zeppelin.python.PythonInterpreterTest)  Time elapsed: 
0.262 sec  <<< FAILURE!
java.lang.AssertionError: null
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Assert.java:41)
at org.junit.Assert.assertFalse(Assert.java:64)
at org.junit.Assert.assertFalse(Assert.java:74)
at 
org.apache.zeppelin.python.PythonInterpreterTest.testClose(PythonInterpreterTest.java:168)


Results :

Failed tests: 
  PythonInterpreterTest.testClose:168 null
```

https://s3.amazonaws.com/archive.travis-ci.org/jobs/140172363/log.txt




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1084: [HOTFIX] Fix flaky AuthenticationIT

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1084


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1084: [HOTFIX] Fix flaky AuthenticationIT

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1084
  
Awesome!!! let's merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1087: Shell intepreter test and doc

[fvaleri]

GitHub user fvaleri opened a pull request:

https://github.com/apache/zeppelin/pull/1087

Shell intepreter test and doc

### What is this PR for?
Small refactoring to Shell interpreter.
Add missing unit test and initial doc.

### What type of PR is it?
Improvement, Documentation, Refactoring

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fvaleri/zeppelin shell-intepreter-test

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1087


commit 247c4e50d1663eaa1fffbc4b304dfe7d4bbbc84e
Author: fvaleri 
Date:   2016-06-25T00:09:41Z

shell interpreter refactoring
add shell doc and test

commit 6aa2cb69e36f802bb519c53de14735ec03d8a037
Author: fvaleri 
Date:   2016-06-25T00:18:57Z

\n on doc




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1085: [MINOR]Removed some codes using interpreterClassList

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1085
  
@Leemoonsoo I've figured out what you said. This PR changes the way to find 
a default interpreter, isn't it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1085: [MINOR]Removed some codes using interpreterClas...

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/1085

[MINOR]Removed some codes using interpreterClassList

### What is this PR for?
Removing dependency from interpreterClassList because this prevent new 
interpreter without interpreterClassList from registering in Zeppelin.

### What type of PR is it?
[Bug Fix | Refactoring]

### Todos
* [ ] - Removed codes

### What is the Jira issue?
N/A

### How should this be tested?
It doesn't have any change on user level.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
minor-remove-usage-of-interpreterclasslist

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1085.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1085


commit 0caa63943423c289eef1f8dcae813bafcbf1c737
Author: Jongyoul Lee 
Date:   2016-06-24T18:52:24Z

Revmoed some codes using interpreterClassList




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1072: [MINOR] Remove unused util methods and its test...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1072


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #971: [ZEPPELIN-961] Longer names to the notebook make the na...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/971
  
LGTM merging it into master and branch-0.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1071: [ZEPPELIN-1052] Application does not logout user when ...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1071
  
@prabhjyotsingh Thanks for the fix!
Seems like this PR is bringing CI error in master, branch-0.6:
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 81.986 sec 
<<< FAILURE! - in org.apache.zeppelin.integration.AuthenticationIT
testGroupPermission(org.apache.zeppelin.integration.AuthenticationIT)  Time 
elapsed: 42.459 sec  <<< ERROR!
org.openqa.selenium.TimeoutException: Timed out after 30 seconds waiting 
for org.apache.zeppelin.AbstractZeppelinIT$1@4c156b4b
Build info: version: '2.48.2', revision: 
'41bccdd10cf2c0560f637404c2d96164b67d9d67', time: '2015-10-09 13:08:06'
System info: host: 'testing-worker-linux-docker-8fa71dca-3379-linux-8', ip: 
'172.17.9.181', os.name: 'Linux', os.arch: 'amd64', os.version: 
'3.13.0-40-generic', java.version: '1.7.0_76'
Driver info: driver.version: unknown
at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
at 
sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:57)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at java.lang.reflect.Constructor.newInstance(Constructor.java:526)
at 
org.openqa.selenium.remote.ErrorHandler.createThrowable(ErrorHandler.java:206)
at 
org.openqa.selenium.remote.ErrorHandler.throwIfResponseFailed(ErrorHandler.java:158)
at 
org.openqa.selenium.remote.RemoteWebDriver.execute(RemoteWebDriver.java:647)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:353)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElementByXPath(RemoteWebDriver.java:490)
at org.openqa.selenium.By$ByXPath.findElement(By.java:361)
at 
org.openqa.selenium.remote.RemoteWebDriver.findElement(RemoteWebDriver.java:345)
at 
org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:116)
at 
org.apache.zeppelin.AbstractZeppelinIT$1.apply(AbstractZeppelinIT.java:114)
at org.openqa.selenium.support.ui.FluentWait.until(FluentWait.java:238)
at 
org.apache.zeppelin.AbstractZeppelinIT.pollingWait(AbstractZeppelinIT.java:114)
at 
org.apache.zeppelin.integration.AuthenticationIT.authenticationUser(AuthenticationIT.java:109)
at 
org.apache.zeppelin.integration.AuthenticationIT.testGroupPermission(AuthenticationIT.java:177)
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate 
element: {"method":"xpath","selector":"//div[contains(@class, 
'navbar-collapse')]//li//button[contains(.,'Login')]"}
```
I was able to reproduce error that logout doesn't work by following:
1. start zeppelin with default shiro.ini
2. create `Untitled Note 1` and set permissions to (admin, admin, admin)
3. go back to zeppelin main page (http://localhost:8080)
4. click `Untitled Note 1`
5. login as admin
6. click logout button -> doesn't work
Could you take a look please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1066
  
Merge if there is no more dicussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1080: [ZEPPELIN-1060] validate user before saving

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/1080

[ZEPPELIN-1060] validate user before saving

### What is this PR for?
Zeppelin notebook permissions change has an issue while reconfiguring 
permissions by clearing textbox

### What type of PR is it?
[Bug Fix]

### Todos
* [x] - Validate user list before saving
* [x] - getPermissions from server again before showing popup

### What is the Jira issue?
* [ZEPPELIN-1060](https://issues.apache.org/jira/browse/ZEPPELIN-1060)

### How should this be tested?
1) I log in as user 'admin'
2) I create a notebook 'Untitled Notebbok 1' as user admin
3) I setup permissions of the notebook as owners = admin, readers= admin, 
writers= admin and click save button
It works file
4) Now I again try to give owners permission to 'All users' by clearing 
owners field. Since in step-3 owners = admin ; it allows me to save these 
changes successfully
5) Now I again try to toggle permissions of the notebook. Since in step-4 I 
cleared owners field, it should allow all users to change permissions. But it 
is not happening, instead it gives an error box that only User = [] has 
sufficient permissions


### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? n/a



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-1060

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1080.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1080


commit f735133de90c39a6d3a517ccc87e761cf6fe4066
Author: Prabhjyot Singh 
Date:   2016-06-24T16:32:11Z

validate user before saving




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1060) Zeppelin notebook permissions change has an issue while reconfiguring permissions by clearing textbox

[Prabhjyot Singh (JIRA)]

Prabhjyot Singh created ZEPPELIN-1060:
-

 Summary: Zeppelin notebook permissions change has an issue while 
reconfiguring permissions by clearing textbox
 Key: ZEPPELIN-1060
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1060
 Project: Zeppelin
  Issue Type: Bug
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh


1) I log in as user 'admin'
2) I create a notebook 'Untitled Notebbok 1' as user admin
3) I setup permissions of the notebook as owners = admin, readers= admin, 
writers= admin and click save button
It works file
4) Now I again try to give owners permission to 'All users' by clearing owners 
field. Since in step-3 owners = admin ; it allows me to save these changes 
successfully
5) Now I again try to toggle permissions of the notebook. Since in step-4 I 
cleared owners field, it should allow all users to change permissions. But it 
is not happening, instead it gives an error box that only User = [] has 
sufficient permissions



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1055: [ZEPPELIN-1028] Fix exported notebook importing...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1055


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1072: [MINOR] Remove unused util methods and its tests

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1072
  
Merging it into master and branch-0.6


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

[suvam97]

Github user suvam97 commented on the issue:

https://github.com/apache/zeppelin/pull/1066
  
@minahlee Conflict Resolved


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1079
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1079: Prevent menubar hide notebook title and control button...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1079
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1079: Prevent menubar hide notebook title and control...

[Leemoonsoo]

GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/1079

Prevent menubar hide notebook title and control buttons depending on screen 
size

### What is this PR for?
Prevent menubar hide notebook title and control buttons, depending on 
screen size

### What type of PR is it?
Bug Fix

### Todos
* [x] - Make search input box smaller

### How should this be tested?
Resize your browser

### Screenshots (if appropriate)
before

![menubar_before](https://cloud.githubusercontent.com/assets/1540981/16331737/0ea27b88-39a7-11e6-8db5-e14326aecbaf.gif)
after

![menubar_after](https://cloud.githubusercontent.com/assets/1540981/16331742/19ea0cc2-39a7-11e6-9535-16c5d7926694.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin change_search_input_size

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1079.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1079


commit ffb94907231763abd77e0c2715094bcf38bdcdf0
Author: Lee moon soo 
Date:   2016-06-24T07:58:08Z

Change search input box size




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1066: [ZEPPELIN-1047] Add filter to handle upper case

[suvam97]

Github user suvam97 commented on the issue:

https://github.com/apache/zeppelin/pull/1066
  
@minahlee Conflict resolved.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---