[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1472 @djKooks Yeah I just saw the commit right after you pushed. It's not a silly bug :) But the port part should be updated as well. Some users can use other port number not `8080`. Could you check again please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1472: Add message of localhost:port on script
Github user djKooks commented on the issue: https://github.com/apache/zeppelin/pull/1472 @AhyoungRyu Oh, it was my mistake. Sorry for silly bugs. I just updated script to find public IP. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/1429 @corneadoug removed the redundant beforeEach b8b4f24 Will merge if there are no more discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/418 Awesome, Merging it --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/418 Yea I think I merged it or something. I fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1472: Add message of localhost:port on script
GitHub user djKooks opened a pull request: https://github.com/apache/zeppelin/pull/1472 Add message of localhost:port on script ### What is this PR for? To show the localhost:port number info when running zeppelin.sh script. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * Not an issue. ### How should this be tested? Run ./zeppelin.sh or ./zeppelin_daemon.sh and see the message about localhost is appearing. You can merge this pull request into a Git repository by running: $ git pull https://github.com/djKooks/zeppelin master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1472.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1472 commit fb9fa6c9ac97f8b75bdba2675538f43105cdb970 Author: Dennis JungDate: 2016-09-29T04:22:48Z Add message of localhost:port on script --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
GitHub user corneadoug reopened a pull request: https://github.com/apache/zeppelin/pull/1469 [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code ### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit 5080b8de464303cc812e2ed771b7a67c017b9c7f Author: Damien CORNEAUDate: 2016-09-27T08:43:34Z Add IIFE to app.controller.js commit 21a591eed164436189569a7ccc9a683b60ca65cc Author: Damien CORNEAU Date: 2016-09-27T08:48:36Z Move use strict outside IFFE commit be8f24c80652c1d9cbcee24bf31198518da9d016 Author: Damien CORNEAU Date: 2016-09-27T08:59:03Z Add congiguration.controller.js commit 268477bd12bae7fbcd106869d4d39960f1699485 Author: Damien CORNEAU Date: 2016-09-28T05:36:38Z Refactor for IIFE credential, home and interpreter controller commit 14dd6ccf026be31c1734ca53c9cea47c05fd07ef Author: Damien CORNEAU Date: 2016-09-28T07:02:12Z IIFE refactoring of job page commit e9f38fc69f05b8ece3c5c2bc48f1dd35214351d3 Author: Damien CORNEAU Date: 2016-09-28T07:18:37Z Finish refactoring of App commit eb82887f8aa3ce47d53c816960a9bdaf52ede482 Author: Damien CORNEAU Date: 2016-09-28T07:35:46Z Refactor components service and factory commit 76662ff1b6e4dc20e0383978a4deedb766e12af3 Author: Damien CORNEAU Date: 2016-09-28T07:55:27Z Refactor components directives commit 9e8fec04b71b0436dc8be1836753ca878f1e4d0d Author: Damien CORNEAU Date: 2016-09-28T08:56:28Z refactor components controllers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
Github user corneadoug closed the pull request at: https://github.com/apache/zeppelin/pull/1469 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1469 Ready for review. Re-triggering the CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1468: [ZEPPELIN-1502] Highlights initialization code editor ...
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1468 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1304: [ZEPPELIN-1190] [WIP] Visit Notebook Revision
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1304 @corneadoug I've just tried the scenario you have, and it was running correctly (without np) when you switch to different revisions. the only thing is that it was running the `head` version which is expected behaviour. so could you check it out again? possibly that np error was due to different problem. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1465: [ZEPPELIN-1500] pyspark completion doesn't work.
Github user fanlu commented on the issue: https://github.com/apache/zeppelin/pull/1465 @astroshim It worked, thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1471: [WIP][ZEPPELIN-1505] Add Scio interpreter
Github user ravwojdyla commented on the issue: https://github.com/apache/zeppelin/pull/1471 @AhyoungRyu @zjffdu thanks for prompt review. I have some questions in the comments, plus fixes coming in. I have also changed the topic of the PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1390: [WIP] [ZEPPELIN-1339] [ZEPPELIN-1000] [ZEPPELIN-1338] ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1390 @echarles you can also push gradually to facilitate review process --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1429: ZEPPELIN-1440 Notebook clone: prefix name with "Copy o...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1429 @r-kamath do you want to try and merge this ? [This](https://cwiki.apache.org/confluence/display/ZEPPELIN/Committer+Guide) will help you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/1454 Merging this if no more discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1464: [Zeppelin 796] [WIP] Duplicated notebook names should ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1464 @rajarajan-g why do you think it's a problem having same note title/name with existing one. could you give more context? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1451: [ZEPPELIN-1279] Zeppelin with CDH5.x docker document.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1451 @astroshim Appreciate for your effort! Merge into master if there are no more discussions :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1465: [ZEPPELIN-1500] pyspark completion doesn't work.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1465 @fanlu That error seems like occurs before launching pyspark interpreter. Could you please try completion after launching pyspark interpreter if works or not like following? ![o](https://cloud.githubusercontent.com/assets/3348133/18938909/2cba37aa-8637-11e6-9f45-fad0a0f605f6.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1471: Closes ZEPPELIN-1505: Add Scio interpreter
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1471 @ravwojdyla Thanks for your contribution and welcome! I assume this PR is not finished but `Work In Process` since there are some unchecked TODOs. So how about changing the title of this PR from `Closes ZEPPELIN-1505: Add Scio interpreter ` to `[WIP][ZEPPELIN-1505] Add Scio interpreter` or sth? It would be more helpful to anyone who want to understand the purpose of this PR at a glance and start review :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user corneadoug commented on the issue: https://github.com/apache/zeppelin/pull/1445 Tested using ``` %sh echo -e "%table name\tval\nhello\thello\you\"good\nhello2\theelow,world" ``` LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1471: Closes ZEPPELIN-1505: Add Scio interpreter
GitHub user ravwojdyla opened a pull request: https://github.com/apache/zeppelin/pull/1471 Closes ZEPPELIN-1505: Add Scio interpreter ### What is this PR for? Closes #ZEPPELIN-1505. Adds Scio interpreter. Scio is a Scala DSL on top of Dataflow/Beam. ### What type of PR is it? Improvement - ZEPPELIN-1505 ### Todos * [ ] - test integration with zeppelin context * [ ] - what to do about code completion? * [ ] - add more tests? ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1505 ### How should this be tested? ``` mvn -pl scio,zeppelin-display,zeppelin-interpreter -Dtest='org.apache.zeppelin.scio.*' -DfailIfNoTests=false test ``` You can merge this pull request into a Git repository by running: $ git pull https://github.com/ravwojdyla/incubator-zeppelin scio Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1471.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1471 commit b85c3c028f13064345cb149f1d162c41d5bc4dba Author: Rafal WojdylaDate: 2016-09-28T04:36:20Z Add Scio interpreter commit c8463c6540021b782851090ce359c263717905eb Author: Rafal Wojdyla Date: 2016-09-29T01:16:42Z Add Scio interpreter tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1470 @Leemoonsoo please review, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1470: ZEPPELIN-1423 - Allow users to specify pre/post...
GitHub user agoodm opened a pull request: https://github.com/apache/zeppelin/pull/1470 ZEPPELIN-1423 - Allow users to specify pre/post-execute hooks for interpreters ### What is this PR for? See #1439. This is a second attempt based on prior feedback, particularly from @Leemoonsoo who advised that it would be better to contain all of the code inside of the Interpreter Process. Aside from this, the major changes since the previous PR are: - The terminology "hooks" is used instead of "callbacks". Since the information being passed to the interpreter isn't actually a "callback", strictly speaking, the more general term "hook" is probably a better choice. All variable / class names were updated correspondingly. - The registry is now keyed by class name rather than the `replName` specified by the magic on top of the paragraph. The interface provided by `ZeppelinContext` allows for a `replName` to be converted to `className` through an internal mapping. - Two new event codes, "PRE_EXEC_DEV" and "POST_EXEC_DEV" have been added. This is primarily intended to separate use cases for the interpreter maintainers (via subclasses of `Interpreter`) and the notebook users (via the `ZeppelinContext` class), as otherwise user attempts at registering a hook would overwrite that set by the interpreter maintainer. - Global scope for hook registration is supported for the developer use cases. ### What type of PR is it? New Feature ### What is the Jira issue? [ZEPPELIN-1423](https://issues.apache.org/jira/browse/ZEPPELIN-1423) ### How should this be tested? In a new note, add the following lines of code to a paragraph: ```python %pyspark z.registerCallback("post_exec", "print 'This code should be executed before the parapgraph code!'") z.registerCallback("pre_exec", "print 'This code should be executed after the paragraph code!'") ``` Then run any other paragraph in the note containing some other code, eg ```python %pyspark print "This code should be entered into the paragraph by the user!" ``` The output should be: ``` This code should be executed before the paragraph code! This code should be entered into the paragraph by the user! This code should be executed after the paragraph code! ``` You should also test out the other two methods (`getCallback()` and `unregisterCallback()`) specified in `ZeppelinContext.java`. One final caveat that should be mentioned: If there are errors in the code you specify for a pre-execute event, it will render the interpreter useless since the current implementation prepends the the code specified in `pre_exec` directly to the paragraph entered code before calling `interpret()`. The current workaround for this would be to either restart the interpreter group or call `unregisterCallback()` via a different REPL within the interpreter group (eg, `z.unregisterCallback("pre_exec", "pyspark")` from the spark interpreter). I would appreciate if anyone here would be willing to share any better approaches here. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/agoodm/zeppelin ZEPPELIN-1423v2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1470.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1470 commit 8fad93674420da1faf4d63ed3f4902c630f2ca26 Author: Alex GoodmanDate: 2016-09-28T19:27:12Z Added Interpreter Hooks to Interpreter Process commit 07cac65e99f643971b171756d26e7e8da92b76d3 Author: Alex Goodman Date: 2016-09-29T00:28:50Z Implemented user-defined hook registry system for spark/pyspark interpreters commit 1331fe1bd3d89394f74d5f7a0543a56911138f0b Author: Alex Goodman Date: 2016-09-29T00:38:49Z Update interpreters.md --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1439: [ZEPPELIN-1423] Allow users to specify pre/post-execut...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1439 Going to close this for now since I have made another implementation on a separate branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #418: [DOCS] Zeppelin Flink Spark tutorial
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/418 @corneadoug done and done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #928: [ZEPPELIN-116] Add Apache Mahout Interpreter
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/928 Refactored as previously discussed. Added script that sets up two new terps, one for mahout on flink, one for mahout on spark. Added docs and a robust tutorial that shows useage. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1505) Interpreter for Scio
Rafal Wojdyla created ZEPPELIN-1505: --- Summary: Interpreter for Scio Key: ZEPPELIN-1505 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1505 Project: Zeppelin Issue Type: New Feature Components: Interpreters Affects Versions: 0.7.0 Reporter: Rafal Wojdyla Scio is a DSL for Apache Beam/Dataflow. Project is available at https://github.com/spotify/scio -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1465: [ZEPPELIN-1500] pyspark completion doesn't work.
Github user fanlu commented on the issue: https://github.com/apache/zeppelin/pull/1465 @astroshim Another problem has emerged ERROR [2016-09-28 23:29:20,018] ({pool-1-thread-2} TThreadPoolServer.java[run]:296) - Error occurred during processing of message. java.lang.NullPointerException at org.apache.zeppelin.spark.PySparkInterpreter.completion(PySparkInterpreter.java:453) at org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:122) at org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.completion(RemoteInterpreterServer.java:469) at org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1742) at org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1727) at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39) at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39) at org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #530: ZEPPELIN-497 ] pyspark completion
Github user fanlu commented on the issue: https://github.com/apache/zeppelin/pull/530 @astroshim sorry, the problem is still there https://github.com/apache/zeppelin/pull/1465#issuecomment-250201113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1451: [ZEPPELIN-1279] Zeppelin with CDH5.x docker document.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1451 @AhyoungRyu Thank you so much for taking care of this!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1465: [ZEPPELIN-1500] pyspark completion doesn't work.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1465 @felixcheung you mean test case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1454: [ZEPPELIN-1483] Zeppelin home page list notebooks does...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1454 adding group permissions to listed notes makes sense. tested and works as expected. maybe would makes sense to add integration tests to differentiate the cases of user and groups, maybe in diffent PR as improvement. CI looks irrelevant, LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1504) Spark Interpreter: error message are not shown
Furcy Pin created ZEPPELIN-1504: --- Summary: Spark Interpreter: error message are not shown Key: ZEPPELIN-1504 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1504 Project: Zeppelin Issue Type: Bug Affects Versions: 0.6.1 Reporter: Furcy Pin Priority: Critical Attachments: zep.png How to reproduce : - Open a notebook with a spark interpreter - Write this code {code} println("A!") throw new Exception("AAArgh!") println("B!") {code} The only feedback we get is : {code} A {code} (see screenshot) In the logs, we have {code} ==> logs/zeppelin-user-machine.out <== _binder: java.util.HashMap[String,Object] = {} z: org.apache.zeppelin.spark.ZeppelinContext = org.apache.zeppelin.spark.ZeppelinContext@2f19abb1 sc: org.apache.spark.SparkContext = org.apache.spark.SparkContext@23972a76 sqlc: org.apache.spark.sql.SQLContext = org.apache.spark.sql.SQLContext@6dd6a63f sqlContext: org.apache.spark.sql.SQLContext = org.apache.spark.sql.SQLContext@6dd6a63f spark: org.apache.spark.sql.SparkSession = org.apache.spark.sql.SparkSession@4b8eb464 import org.apache.spark.SparkContext._ java.lang.Exception: AAArgh! ... 43 elided {code} This makes this version of zeppelin impossible to use in practice. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...
Github user rajarajan-g commented on the issue: https://github.com/apache/zeppelin/pull/1467 CI build is green.Please review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1462: ZEPPELIN-1477. Add Integration Test for LivyInterprete...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1462 I have asked the livy community to publish these artifacts, suppose I can delete these livy artifacts in zeppelin after livy 0.3 is released. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1503) Option in the Zeppelin GUI to clear the output in a specific note from the main menu
Rivkin Andrey created ZEPPELIN-1503: --- Summary: Option in the Zeppelin GUI to clear the output in a specific note from the main menu Key: ZEPPELIN-1503 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1503 Project: Zeppelin Issue Type: New Feature Components: GUI Affects Versions: 0.6.1 Reporter: Rivkin Andrey Priority: Trivial Sometimes SVG plots can hang and make whole notebook unusable. The main reason - very huge amount of points on the plot. In such case it's a problem to open notebook and to hide output, or change some code. So to fix this I sugest to add option to clean whole notebook output from the main menu. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...
GitHub user corneadoug opened a pull request: https://github.com/apache/zeppelin/pull/1469 [Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code ### What is this PR for? This is some refactoring of zeppelin-web to apply the IIFE as stated in the Good Practice Guide #1 (https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html) ### What type of PR is it? Refactoring ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1496 ### How should this be tested? Run The webapp, and go around the page, things should work like usual. But overall, just need to check that there is no type or parameter mismatch during the refactoring process (controller to controller, params in $inject etc...) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1469.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1469 commit b7b94b5ff3f87a535e3521f7551fd035e46744bf Author: Damien CORNEAUDate: 2016-09-27T08:43:34Z Add IIFE to app.controller.js commit f179474f1482c8ca89f52511608c9c90db39efa0 Author: Damien CORNEAU Date: 2016-09-27T08:48:36Z Move use strict outside IFFE commit b946304b72395554165c95551d2b56784d431199 Author: Damien CORNEAU Date: 2016-09-27T08:59:03Z Add congiguration.controller.js commit bf4462c1f11a3994fa73022c976eccdab5e6a068 Author: Damien CORNEAU Date: 2016-09-28T05:36:38Z Refactor for IIFE credential, home and interpreter controller commit 66dd14debfb5a86d1906a7616b21c9c86c5fa4f2 Author: Damien CORNEAU Date: 2016-09-28T07:02:12Z IIFE refactoring of job page commit 56b2103bc8e902f5ec1c6b4bfa8070f4963ecbbd Author: Damien CORNEAU Date: 2016-09-28T07:18:37Z Finish refactoring of App commit e7dcc2e9201bc9abfeb957c44b054ada085c72b6 Author: Damien CORNEAU Date: 2016-09-28T07:35:46Z Refactor components service and factory commit b45d0fa270dda72006297a0a4077b40a672d0cc0 Author: Damien CORNEAU Date: 2016-09-28T07:55:27Z Refactor components directives commit 3964e26663feee016ea0b50faa3e1c8c9490ea35 Author: Damien CORNEAU Date: 2016-09-28T08:56:28Z refactor components controllers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1468: [ZEPPELIN-1502] Highlights initialization code ...
GitHub user cloverhearts opened a pull request: https://github.com/apache/zeppelin/pull/1468 [ZEPPELIN-1502] Highlights initialization code editor bugs ### What is this PR for? When there are a variety of para graph interpreter present, When you refresh the page, the code highlights are incorrectly applied. ### What type of PR is it? Bug Fix ### Todos - [x] - Create orderId key in getEditorMode function. ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1502 ### How should this be tested? 1. Create a para-graph form below. ``` %spark println("spark syn 01"); ``` ``` %spark println("spark syn 02"); ``` ``` %spark println("spark syn 03"); ``` ``` %spark println("spark syn 04"); ``` ``` %spark println("spark syn 05"); ``` ``` %pyspark print ("pyspark syn); ``` ``` %sql SELECT * FROM SQL_HIGH WHERE ONMYCOM ``` 2. Check the highlights of each of the para graphs. 3. Refresh the page and check the highlights again. ### Screenshots (if appropriate) bug (focus on pyspark) ![codeeidtorhigh](https://cloud.githubusercontent.com/assets/10525473/18906890/66b8ede0-85a4-11e6-96fb-6cc000edf477.png) this pr (focus on pyspark) ![code](https://cloud.githubusercontent.com/assets/10525473/18907220/bcc9f818-85a5-11e6-949c-db94fa753d3c.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/cloverhearts/zeppelin dev/codeeditor-bugfixed Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1468.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1468 commit eaa1b86978015e0746dfd5cdae7e08b3c86fbff5 Author: CloverHeartsDate: 2016-09-28T08:32:45Z bug fixed for page refresh initialize editor mode commit de03a06006878f38c544d7f6ea4c4733b36b0982 Author: CloverHearts Date: 2016-09-28T08:59:43Z remove whitespace - jslint --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 CI build passed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1467: [ZEPPELIN-1488] JDBC Interpreter throws error w...
GitHub user rajarajan-g opened a pull request: https://github.com/apache/zeppelin/pull/1467 [ZEPPELIN-1488] JDBC Interpreter throws error while the interpreter is downloading dependencies ### What is this PR for? For first time, when we add dependencies for JDBC interpreter, dependencies will start getting downloaded in background. During that time, if user runs a paragraph of JDBC interpreter now user getting error , But instead paragraph execution should be put on 'PENDING' state and wait for dependencies to get downloaded and then run the paragraph ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? [ZEPPELIN-1488] https://issues.apache.org/jira/browse/ZEPPELIN-1488 ### How should this be tested? prerequisites: 1. Any DB setup.(For my testing, i considered hive) Steps: 1. Delete the local-repo folder under zeppelin project, if it exists 2. Go to interpreter settings page, provide hive connection details under JDBC interprepreter 3. For hive interpreter to run, it needs some dependencies to be added in interpreter settings page For hive below dependencies needs to added 1. org.apache.hive:hive-jdbc:0.14.0 2. org.apache.hadoop:hadoop-common:2.6.0 4. Once the settings for JDBC interpreter is saved, dependencies will start getting downloaded in background. 5. Run any paragraph with JDBC as interpreter, paragraph should not throw error, status of the paragraph should change to 'pending' while the dependencies are getting downloaded in background. 6. Once the downloading of dependencies is done, the paragraph which were in pending will start executing in order depending on the execution mode of the interpreter (i.e Shared, Scoped, Isolated) ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/rajarajan-g/zeppelin ZEPPELIN-1488 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1467.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1467 commit 4f7b9381713537a9e90e3cb1e90c128f2833be81 Author: rajarajan-gDate: 2016-09-27T15:17:02Z code fix for ZEPPELIN-1488 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1502) initialize to default CodeEditor Highlight mode after page refresh
CloverHearts created ZEPPELIN-1502: -- Summary: initialize to default CodeEditor Highlight mode after page refresh Key: ZEPPELIN-1502 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1502 Project: Zeppelin Issue Type: Bug Reporter: CloverHearts If each of the other interpreter short circuit is present, After pages of the update, highlight all of the code will be reflected in the form incorrect. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekarDate: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 Re opening the pull request to run CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekarDate: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 Re opening the pull request to run CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---