[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml

2016-10-03 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1475
  
Thank you @minahlee Please help me to solve PR problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1475: [ZEPPELIN-1509] Bug of testcase path in .travis.yml

2016-10-03 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1475
  
Nice catch! I think it is better to fix CI failures in this PR since it 
will break CI if we merge this. I am willing to help you if you need any :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...

2016-10-03 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/133
  
@doanduyhai Thanks, since it wasn't in the description, I didn't know
@Leemoonsoo Can I merge this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1516) NPE LivySparkSQLInterpreter thrown with %livy.sql interpreter function

2016-10-03 Thread Greg Senia (JIRA)
Greg Senia created ZEPPELIN-1516:


 Summary: NPE LivySparkSQLInterpreter thrown with %livy.sql 
interpreter function
 Key: ZEPPELIN-1516
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1516
 Project: Zeppelin
  Issue Type: Bug
  Components: livy-interpreter
Affects Versions: 0.6.1, 0.6.0, 0.7.0
Reporter: Greg Senia
Priority: Blocker


The LivySparkSQLInterpreter class does not correctly process the userSessionMap 
throwing back an NPE as show below. I determined this by adding a bunch of 
debug statements inside of the code before making the code operate more like 
LivySparkRInterpreter and LivyPySparkInterpreter. This error keeps %livy.sql 
from functioning in any way shape or form both on 0.6.0, 0.6.1 and 0.7.0. 

LivyPySparkInterpreter code snippit:
public class LivyPySparkInterpreter extends Interpreter {

  Logger LOGGER = LoggerFactory.getLogger(LivyPySparkInterpreter.class);

  protected Map userSessionMap;
  protected LivyHelper livyHelper;

  public LivyPySparkInterpreter(Properties property) {
super(property);
userSessionMap = new HashMap<>();
livyHelper = new LivyHelper(property);
  }

LivySparkRInterpreter code snippit:
public class LivySparkRInterpreter extends Interpreter {

  Logger LOGGER = LoggerFactory.getLogger(LivySparkRInterpreter.class);

  protected Map userSessionMap;
  private LivyHelper livyHelper;

  public LivySparkRInterpreter(Properties property) {
super(property);
userSessionMap = new HashMap<>();
livyHelper = new LivyHelper(property);
  }

Broken LivySparkSQLInterpreter snippit:
public class LivySparkSQLInterpreter extends Interpreter {

  Logger LOGGER = LoggerFactory.getLogger(LivySparkSQLInterpreter.class);

  protected Map userSessionMap;
  private LivyHelper livyHelper;

  public LivySparkSQLInterpreter(Properties property) {
super(property);
livyHelper = new LivyHelper(property);
userSessionMap = LivySparkInterpreter.getUserSessionMap();

Working LivySparkSQLInterpreter snippit:
public class LivySparkSQLInterpreter extends Interpreter {

  Logger LOGGER = LoggerFactory.getLogger(LivySparkSQLInterpreter.class);

  protected Map userSessionMap;
  private LivyHelper livyHelper;

  public LivySparkSQLInterpreter(Properties property) {
super(property);
livyHelper = new LivyHelper(property);
userSessionMap = new HashMap<>();
  }


ERROR [2016-09-29 23:44:30,891] ({pool-2-thread-2} 
LivySparkSQLInterpreter.java[interpret]:119) - Exception in 
LivySparkSQLInterpreter while interpret 
java.lang.NullPointerException 
at 
org.apache.zeppelin.livy.LivySparkSQLInterpreter.interpret(LivySparkSQLInterpreter.java:60)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.interpret(LazyOpenInterpreter.java:94)
 
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer$InterpretJob.jobRun(RemoteInterpreterServer.java:390)
 
at org.apache.zeppelin.scheduler.Job.run(Job.java:176) 
at 
org.apache.zeppelin.scheduler.FIFOScheduler$1.run(FIFOScheduler.java:139) 
at 
java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) 
at java.util.concurrent.FutureTask.run(FutureTask.java:266) 
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
 
at 
java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
 
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) 
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) 
at java.lang.Thread.run(Thread.java:745) 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...

2016-10-03 Thread doanduyhai
Github user doanduyhai commented on the issue:

https://github.com/apache/zeppelin/pull/133
  
@corneadoug Comment updated with original issue description.

The JIRA is already created: 
https://issues.apache.org/jira/browse/ZEPPELIN-127


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1369: [ZEPPELIN-1376] Add proxy credentials for dependency r...

2016-10-03 Thread doanduyhai
Github user doanduyhai commented on the issue:

https://github.com/apache/zeppelin/pull/1369
  
@astroshim @AhyoungRyu 

Please see the final result, it should make you both happy :)

![fixed error 
popups](https://cloud.githubusercontent.com/assets/1532977/19050426/d23f560e-89ae-11e6-9ffc-b57cdbb1a28e.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1480: [ZEPPELIN-1489] Remove jdbc-like interpreter ex...

2016-10-03 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1480

[ZEPPELIN-1489] Remove jdbc-like interpreter example properties and improve 
JDBC docs

### What is this PR for?
Currently we can use `%jdbc(prefix)` for multi database connections(e.g. 
configuring both postgresql and hive in one JDBC interpreter). But after #1360 
merged, Zeppelin doesn't support `%jdbc(prefix)` to `%prefix` anymore. So 
auto-prefix feature is not working for `%jdbc(prefix)`. The auto-prefix only 
works for `%prefix` now. Considering this status, it would be better we remove 
the JDBC connection examples in `jdbc/interpreter-setting.json` (this is come 
from #1096) so that users can create several JDBC interpreters instead of using 
multiple connections with one JDBC interpreter.  I removed the related contents 
in `jdbc.md` as well.

Also, the contents of [current JDBC documentation 
page](http://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html) is 
quite confusing and unorganized. So I updated the contents with some screenshot 
images to guide "How to create JDBC interpreter", "How to edit the interpreter 
properties for the connection", "How to use `%prefix` with the interpreter", 
and so on.

### What type of PR is it?
Improvement & Documentation

### What is the Jira issue?
* [ZEPPELIN-1489](https://issues.apache.org/jira/browse/ZEPPELIN-1489)

### How should this be tested?
* Removing example properties in `interpreter-setting.json`
  1. after applying this patch and build with `mvn clean package 
-DskipTests -Pspark-1.6 -pl 
'jdbc,zeppelin-interpreter,zeppelin-web,zeppelin-server,zeppelin-zengine,zeppelin-display`
  2. create JDBC interpreter and check whether the example settings are 
gone or not  

* JDBC docs
  1. Build only `docs/` dir as described in 
[here](https://github.com/apache/zeppelin/blob/master/docs/README.md#build-documentation)
  2. Go to `interpreter -> JDBC` and just compare this locally builded page 
with [the original JDBC 
page](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/interpreter/jdbc.html)

### Screenshots (if appropriate)
 - Before 
https://cloud.githubusercontent.com/assets/10060731/19045323/1ff0c706-89d3-11e6-9b6f-dc75877f81f3.png;>

 - After 
https://cloud.githubusercontent.com/assets/10060731/19045324/24a9187a-89d3-11e6-90d6-b80acbc6af7c.png;>

 - Some parts of updated JDBC docs
Since many contentst are changed, it would be better to build `docs/` 
locally to review all of the updated contents.

https://cloud.githubusercontent.com/assets/10060731/19043794/9d9a32fc-89cc-11e6-9d15-f6036a1b738e.png;>

https://cloud.githubusercontent.com/assets/10060731/19043800/a62fc90e-89cc-11e6-976d-5c697729eca4.png;>

https://cloud.githubusercontent.com/assets/10060731/19043807/acbc9766-89cc-11e6-8c73-eab1cc18440b.png;>

https://cloud.githubusercontent.com/assets/10060731/19043816/b06b5690-89cc-11e6-9298-a20b49fea622.png;>

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1489

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1480.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1480


commit 223ee1ea76f7472341d0d5c041d63799917bf9df
Author: AhyoungRyu 
Date:   2016-10-03T14:44:42Z

Redshit -> Redshift in JDBCInterpreter.java

commit bf946ade5a72b68544b5c28d201664d206245967
Author: AhyoungRyu 
Date:   2016-10-03T15:38:37Z

Update jdbc.md

commit a90470db78dd7b9ad77f0e91cfddb65d9be1498c
Author: AhyoungRyu 
Date:   2016-10-03T15:39:54Z

Remove jdbc setting examples in interpreter-setting.json

commit 16a39cef69fe2aae6018969d9d5ca54a6100ce7e
Author: AhyoungRyu 
Date:   2016-10-03T15:40:26Z

Add screenshot images

commit a0b7849b7b742bbeba49bd3fda6d928a43a5f48b
Author: AhyoungRyu 
Date:   2016-10-03T15:44:03Z

Remove useless screenshot images




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...

2016-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1468: [ZEPPELIN-1502] Highlights initialization code ...

2016-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1468


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...

2016-10-03 Thread corneadoug
Github user corneadoug closed the pull request at:

https://github.com/apache/zeppelin/pull/1469


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1469: [Zeppelin-1496] Apply Zeppelin-Web Good Practic...

2016-10-03 Thread corneadoug
GitHub user corneadoug reopened a pull request:

https://github.com/apache/zeppelin/pull/1469

[Zeppelin-1496] Apply Zeppelin-Web Good Practice Guide #1 to the code

### What is this PR for?
This is some refactoring of zeppelin-web to apply the IIFE as stated in the 
Good Practice Guide #1 
(https://zeppelin.apache.org/contribution/zeppelinweb/goodPracticeGuide01.html)

### What type of PR is it?
Refactoring

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1496

### How should this be tested?
Run The webapp, and go around the page, things should work like usual.
But overall, just need to check that there is no type or parameter mismatch 
during the refactoring process (controller to controller, params in $inject 
etc...)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/corneadoug/incubator-zeppelin ZEPPELIN-1496

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1469.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1469


commit 91d6e8d843760eea5953f3815b40e8757ecba02f
Author: Damien CORNEAU 
Date:   2016-09-27T08:43:34Z

Add IIFE to app.controller.js

commit c5a3f541a51da23fbaed5abc68f4ca806cebe49b
Author: Damien CORNEAU 
Date:   2016-09-27T08:48:36Z

Move use strict outside IFFE

commit 9b4c043b634e3770856416ec52e47edd6f03d0d4
Author: Damien CORNEAU 
Date:   2016-09-27T08:59:03Z

Add congiguration.controller.js

commit ab47378358a66c7e41055aa36efb6dc2cd4720dd
Author: Damien CORNEAU 
Date:   2016-09-28T05:36:38Z

Refactor for IIFE credential, home and interpreter controller

commit 309347e76d667f5cd370df61e3600b63828127b3
Author: Damien CORNEAU 
Date:   2016-09-28T07:02:12Z

IIFE refactoring of job page

commit 50003726c2b68bc562365944d397403ea3346166
Author: Damien CORNEAU 
Date:   2016-09-28T07:18:37Z

Finish refactoring of App

commit a33fb6347ce58c9472dbb588b1c0981e93d48da0
Author: Damien CORNEAU 
Date:   2016-09-28T07:35:46Z

Refactor components service and factory

commit a58705d8a18e9e1444afbd1f9030d79ae0998a43
Author: Damien CORNEAU 
Date:   2016-09-28T07:55:27Z

Refactor components directives

commit d3758bc5f41da94b12a0757b07df7ea4e4ae0e8a
Author: Damien CORNEAU 
Date:   2016-09-28T08:56:28Z

refactor components controllers




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #777: D3 Plotting change and Allow custom location for interp...

2016-10-03 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/777
  
@michrawson Could you split this PR in two?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1478: [ZEPPELIN-1514] Make atom, rss, sitemap file not to be...

2016-10-03 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1478
  
Thanks @corneadoug!  :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1478: [ZEPPELIN-1514] Make atom, rss, sitemap file not to be...

2016-10-03 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1478
  
CI failure is irrelevant.
Tested, Merging it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #152: ZEPPELIN-157: Adding Map Visualization for Zeppe...

2016-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/152


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #49: Fix Duplicate import bug

2016-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/49


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #47: Zeppelin 26

2016-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/47


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1470: ZEPPELIN-1423 - Allow users to specify pre/post-execut...

2016-10-03 Thread agoodm
Github user agoodm commented on the issue:

https://github.com/apache/zeppelin/pull/1470
  
@Leemoonsoo Thanks for the review, I have provided some responses. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...

2016-10-03 Thread meenakshisekar
Github user meenakshisekar commented on the issue:

https://github.com/apache/zeppelin/pull/1445
  
OOPS ! 
It is 
meenakshi.chandrase...@imaginea.com


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...

2016-10-03 Thread corneadoug
Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1445
  
@meenakshisekar I can't find you with this username


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1467: [ZEPPELIN-1488] JDBC Interpreter throws error while th...

2016-10-03 Thread rajarajan-g
Github user rajarajan-g commented on the issue:

https://github.com/apache/zeppelin/pull/1467
  
Ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1473: [ZEPPELIN-908] Apply new mechanism to CassandraInterpr...

2016-10-03 Thread kavinkumarks
Github user kavinkumarks commented on the issue:

https://github.com/apache/zeppelin/pull/1473
  
Thanks @doanduyhai and @jongyoul 

Kavin
MailTo: kavin.ku...@imaginea.com


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...

2016-10-03 Thread meenakshisekar
Github user meenakshisekar commented on the issue:

https://github.com/apache/zeppelin/pull/1445
  
@corneadoug 
My jira user name is meenakshisekar



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---