[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
@lresende Thanks! Will check again. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-29 Thread lresende
Github user lresende commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
@felixcheung and @AhyoungRyu Sorry for the delay, as I was a little offline 
in the last few days. I have implemented the suggestion and this should be 
ready to merge.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@khalidhuseynov How about disable "Interpreter binding" & "Note permission" 
buttons as well? Currently I can change the bound interpreters and note 
permission for the readonly-mode note. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1817: remove usage of non-standard string method

2016-12-29 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1817
  
Tested it and works as expected.
But CI is fail. Could you check CI again?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1816: [MINOR] Fix broken CSS for plain text paragraph result

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1816
  
@soralee Thanks for testing! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section under not...

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1825
  
@anthonycorbacho As a creator of this operations, could you please help 
review this PR? :D


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1877) Documentation for get/set note permission info using rest api

2016-12-29 Thread Ahyoung Ryu (JIRA)
Ahyoung Ryu created ZEPPELIN-1877:
-

 Summary: Documentation for get/set note permission info using rest 
api
 Key: ZEPPELIN-1877
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1877
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Ahyoung Ryu
Assignee: Ahyoung Ryu
Priority: Minor






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1825: [DOCS][ZEPPELIN-1586] Add 'Security' section un...

2016-12-29 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1825

[DOCS][ZEPPELIN-1586] Add 'Security' section under notebook restapi docs

### What is this PR for?
After #1567 merged we can get/set note permission information for a certain 
note. But this info is not described in anywhere. So I added "Security" section 
under 
[docs/rest-api/rest-notebook.md](https://github.com/apache/zeppelin/blob/master/docs/rest-api/rest-notebook.md).
 

And currently so many operations are placed under one section like below.
https://cloud.githubusercontent.com/assets/10060731/21560964/c55d41cc-cea9-11e6-96ac-68f762c68bff.png;
 width="400px">

So I split them under each `Note opersions`, `Paragraph operations`, `Cron 
jobs`, and `Security`.
https://cloud.githubusercontent.com/assets/10060731/21560971/cd57cf46-cea9-11e6-9a41-95c817594c9c.png;
 width="400px">


### What type of PR is it?
Documentation

### What is the Jira issue?
[ZEPPELIN-1877](https://issues.apache.org/jira/browse/ZEPPELIN-1877)

### How should this be tested?
Please see the below screenshots :)

### Screenshots (if appropriate)
![screen shot 2016-12-30 at 3 58 39 
pm](https://cloud.githubusercontent.com/assets/10060731/21561001/1b83f2b2-ceaa-11e6-813d-6885c8dad3fc.png)
![screen shot 2016-12-30 at 3 58 46 
pm](https://cloud.githubusercontent.com/assets/10060731/21561004/1d6695da-ceaa-11e6-8460-7a95377ede3b.png)
![screen shot 2016-12-30 at 3 58 50 
pm](https://cloud.githubusercontent.com/assets/10060731/21561006/2001ee5c-ceaa-11e6-90a1-7619d1b29bee.png)


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin ZEPPELIN-1586/docs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1825.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1825


commit 09d22d30ff8f927a5754c9c6f0f74ffb28ef8a71
Author: AhyoungRyu 
Date:   2016-12-30T06:59:20Z

Add 'Security' section under notebook restapi docs




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1823: [ZEPPELIN-1850] Remove strip-loader (webpack)

2016-12-29 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1823
  
Thanks for fix! I faced this error after merging master into 
https://github.com/apache/zeppelin/pull/1775 and applied temporary fix by 
deleting `\'`. It seems to be problem with `strip-loader`. tested and LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (gru...

2016-12-29 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1824

[ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)

### What is this PR for?

Replaced `grunt-contrib-clean` to 
[rimraf](https://github.com/isaacs/rimraf) 

- to remove `Gruntfile.js`
- to have npm managed scripts in `package.json` while running `rm -rf` in 
multiple platforms including windows
- Also, fixed invalid `prestart` npm command to `predev`

This PR related to

- https://github.com/apache/zeppelin/pull/1812 (Using yarn)
- https://github.com/apache/zeppelin/pull/1818 (Removing jscs)

### What type of PR is it?

[Improvement]

### Todos

Done at once

### What is the Jira issue?

[ZEPPELIN-1850](https://issues.apache.org/jira/browse/ZEPPELIN-1850)

### How should this be tested?

- `npm run test`, `npm run build`, `npm run dev` should work

### Screenshots (if appropriate)

None

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-1850/remove-grunt-clean

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1824.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1824


commit 86fddb9e4263b39dccb0e959f5e46210be7e3516
Author: 1ambda <1am...@gmail.com>
Date:   2016-12-30T06:55:33Z

fix: Remove grunt-contrib-clean




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1816: [MINOR] Fix broken CSS for plain text paragraph result

2016-12-29 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1816
  
@AhyoungRyu What a nice catch!
Tested and It works very well :+1: 

[Before]

![z1816_b](https://cloud.githubusercontent.com/assets/8110458/21560618/49767bfe-cea5-11e6-869a-650177440e1b.png)

[After]

![z1816_a](https://cloud.githubusercontent.com/assets/8110458/21560620/4b901f44-cea5-11e6-8570-3c080a198daf.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

2016-12-29 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@Leemoonsoo @cloverhearts @1ambda thanks for the review! I addressed all 
your comments and updated the screenshot above. Please check it out and let me 
know what you think. 

Also [CI 
logs](https://s3.amazonaws.com/archive.travis-ci.org/jobs/187629252/log.txt) 
seems to be failing only in selenium profile with flaky test from 
[ZEPPELIN-1836](https://issues.apache.org/jira/browse/ZEPPELIN-1836).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1761: [ZEPPELIN-1711] Create Docker Images for Released Zepp...

2016-12-29 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1761
  
My apologies if discussed before, but is there a reason for separating into 
Scala, Python, R individual Docker images? Don't people want to run Python and 
R together, for example?

Also, +1 for graphing being important for Python and R.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
@felixcheung Yes. So I can handle it later if you don't mind. I think it'll 
be faster. Shall we merge then? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

2016-12-29 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
looks like we only have a minor comment - could we update and then we could 
merge?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1807: ZEPPELIN-1861 Support custom interpreter.sh script to ...

2016-12-29 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1807
  
interesting. should we have documentation for this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1

2016-12-29 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1787
  
2.1.0 artifacts are on central repo. @zjffdu do you want to update this PR 
to add build against 2.1?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1821: [ZEPPELIN-1875] permission dialog code is not s...

2016-12-29 Thread cloverhearts
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1821

[ZEPPELIN-1875] permission dialog code is not stable

### What is this PR for?
The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.


### What type of PR is it?
Bug Fix , Improvement

### Todos
- [x] changed method name  (getBlockNotAuthenticatedUserErrorMsg)
- [x] permission dialog pop-up change logic.
- [x] added check logic for anonymous user in checkIfUserIsAnon method

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1875

### How should this be tested?
1. when you do have turn on the shiro and login and click to note 
permission button.
2. or turn off the shiro.
### Screenshots (if appropriate)

![dialog](https://cloud.githubusercontent.com/assets/10525473/21549451/141cca5c-cda7-11e6-9c4b-94cbf882face.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-PERMMIT-FIX

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1821.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1821


commit 4248c0b590986e59891f4289df93237a9b4284da
Author: cloverhearts 
Date:   2016-12-29T07:55:08Z

refix




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1875) permission dialog code is not stable

2016-12-29 Thread CloverHearts (JIRA)
CloverHearts created ZEPPELIN-1875:
--

 Summary: permission dialog code is not stable
 Key: ZEPPELIN-1875
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1875
 Project: Zeppelin
  Issue Type: Wish
Reporter: CloverHearts
Assignee: CloverHearts


The code for the notification pop-up is not stable.
Sometime when response to slow for backend.
Then the permission box and the dialogue open together.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...

2016-12-29 Thread cloverhearts
GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1814

[ZEPPELIN-1869] changed the API response to generate to 200.

### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html


### What type of PR is it?
Documentation | change

### Todos
- [x] replace to doc
- [x] change response 201 -> 200

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1869


### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
ZEPPELIN-STATUS-CHANGE-API

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1814.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1814


commit 754309ed4c68e408e48a95d53a460d80fc2935f9
Author: cloverhearts 
Date:   2016-12-29T06:42:07Z

Apply to api success status code 200

commit ed317886f250c246734bb9a947d0bcdfaa352f9b
Author: cloverhearts 
Date:   2016-12-29T07:55:08Z

refix

commit f9fcbc8fbd5a4d6686c0ef4f033694365372deaa
Author: cloverhearts 
Date:   2016-12-29T07:58:58Z

Revert "refix"

This reverts commit ed317886f250c246734bb9a947d0bcdfaa352f9b.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1814: [ZEPPELIN-1869] changed the API response to gen...

2016-12-29 Thread cloverhearts
Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1814


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1736: [ZEPPELIN-1757] Menu of paragraph includes keyb...

2016-12-29 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1736


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...

2016-12-29 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1819
  
Thanks!! LGTM. Will merge it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...

2016-12-29 Thread DrIgor
Github user DrIgor commented on the issue:

https://github.com/apache/zeppelin/pull/1819
  
Travis fails with:
```
testBasicIntp(org.apache.zeppelin.spark.PySparkInterpreterTest)  Time 
elapsed: 58.947 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
```
Known issue: 
[ZEPPELIN-1746](https://issues.apache.org/jira/browse/ZEPPELIN-1746)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1820: [ZEPPELIN-1841] Some of shortcut key is not wor...

2016-12-29 Thread soralee
GitHub user soralee opened a pull request:

https://github.com/apache/zeppelin/pull/1820

[ZEPPELIN-1841] Some of shortcut key is not working

### What is this PR for?
Some of note shortcut key is not working on Ubuntu.

### What type of PR is it?
[ Bug Fix ]

### Todos
* N/A

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1841

### How should this be tested?
If you don't have keyboard shortcut in your OS system, please test shortcut 
key in paragraph like the following key and check work well.

```
Ctrl + Alt + a : Insert new paragraph above
Ctrl + Alt + k : Move paragraph Up
Ctrl + Alt + e : Toggle editor
Ctrl + Alt + t : Toggle title
```

### Screenshots (if appropriate)
 - Ctrl + Alt + a : Insert new paragraph above

![z1841_a](https://cloud.githubusercontent.com/assets/8110458/21543796/ea98a83e-ce0c-11e6-84b6-bab09964d40a.gif)

 - Ctrl + Alt + k : Move paragraph Up

![z1841_k](https://cloud.githubusercontent.com/assets/8110458/21543837/41158fc4-ce0d-11e6-8338-102a28b816bf.gif)

 - Ctrl + Alt + e : Toggle editor

![z1841_e](https://cloud.githubusercontent.com/assets/8110458/21543845/57cc980c-ce0d-11e6-86d6-9f232ee336f9.gif)

 - Ctrl + Alt + t : Toggle title

![z1841_t](https://cloud.githubusercontent.com/assets/8110458/21543849/5c2d6282-ce0d-11e6-9b73-ce1df437b87d.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1841

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1820.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1820


commit 3cd53a02ba7109a028836a75618e0bfccf2d0afc
Author: soralee 
Date:   2016-12-29T11:54:37Z

[ZEPPELIN-1841] shortcut key is not working on Ubuntu




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1813
  
Yeah it makes sense. Tested and it's working well 👍  


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInterprete...

2016-12-29 Thread DrIgor
Github user DrIgor commented on the issue:

https://github.com/apache/zeppelin/pull/1819
  
Original pull request #1561 

IgniteSqlInterpreterTest is known flaky test: 
[ZEPPELIN-1738](https://issues.apache.org/jira/browse/ZEPPELIN-1738)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...

2016-12-29 Thread DrIgor
Github user DrIgor commented on the issue:

https://github.com/apache/zeppelin/pull/1561
  
New pull request #1819

I rebased it on the latest master and fixed failing test


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1819: [ZEPPELIN-914] Apply new mechanism to IgniteInt...

2016-12-29 Thread DrIgor
GitHub user DrIgor opened a pull request:

https://github.com/apache/zeppelin/pull/1819

[ZEPPELIN-914] Apply new mechanism to IgniteInterpreter

### What is this PR for?
This handles replacing the registration of interpreter with static block by 
the interpreter-setting.json file

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-914](https://issues.apache.org/jira/browse/ZEPPELIN-914)

### How should this be tested?
There shouldn't be any warning like below on starting the server
```
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN 
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter 
Ignite, You should change it to use interpreter-setting.json in your jar or 
interpreter/{interpreter}/interpreter-setting.json
INFO 2016-09-29 00:25:46,250 - Inclass=org.apache.zeppelin.ignite
```

And ensure that the Ignite related paragraphs run without any error

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-914

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1819.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1819


commit c1b5bb4745de9eb0a6a2c93d741c660d6397cff1
Author: meenakshisekar 
Date:   2016-10-24T12:40:12Z

Added interpreter setting and removed registration from interperter.

commit d140d9ce56a342b1a6b23e2cebc3fdd83a725417
Author: Igor Drozdov 
Date:   2016-12-28T09:47:13Z

Fixed typo in default value and description

commit ddba11a43c5c8159e922ab149ed4a88f8ad4bfd6
Author: Igor Drozdov 
Date:   2016-12-28T11:28:19Z

Add missing property to make test green

Default value is set in `interpreter-setting.json` but test doesn't use 
this file




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1874) zeppelin sparkr could not show all the result

2016-12-29 Thread xinzhang (JIRA)
xinzhang created ZEPPELIN-1874:
--

 Summary: zeppelin sparkr could not show all the result
 Key: ZEPPELIN-1874
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1874
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.6.2
 Environment: web : chrome 55.0.2883.87 m
linux :centos6
spark2.0.0
scala2.11
R3.3.2
 
Reporter: xinzhang


zeppelin sparkr could not show all the result
in my zeppelin web:
%spark.r
mtcarsDF <- createDataFrame(mtcars)
model <- glm(vs ~ mpg + disp + hp + wt , data = mtcarsDF, family = "binomial")
summary(model)

results:
Deviance Residuals: 
(Note: These are approximate quantiles with relative error = 0.01)
 Min1QMedian3Q   Max
-2.11025  -0.08567  -0.00069   0.13214   1.10483

in my linux tty shell:

> summary(model)

Deviance Residuals: 
(Note: These are approximate quantiles with relative error <= 0.01)
 Min1QMedian3Q   Max  
-2.11025  -0.08567  -0.00069   0.13214   1.10483  

Coefficients:
 Estimate   Std. Error  t value  Pr(>|t|)
(Intercept)  -23.62323.144  -1.0207  0.30739 
mpg  0.784750.65026 1.2068   0.2275  
disp -0.031549  0.027342-1.1539  0.24854 
hp   -0.072188  0.045509-1.5862  0.11269 
wt   7.335  5.2336  1.4015   0.16105 

(Dispersion parameter for binomial family taken to be 1)

Null deviance: 43.860  on 31  degrees of freedom
Residual deviance: 12.873  on 27  degrees of freedom
AIC: 22.87

Number of Fisher Scoring iterations: 9

> 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1818: [ZEPPELIN-1873] Use exclusively eslint for java...

2016-12-29 Thread felizbear
GitHub user felizbear opened a pull request:

https://github.com/apache/zeppelin/pull/1818

[ZEPPELIN-1873] Use exclusively eslint for javascript code linting

### What is this PR for?
[jscs](http://jscs.info) has merged with [eslint](http://eslint.org), 
therefore both should be unified as eslint and jscs should be removed

### What type of PR is it?
Improvement

### Todos
* [x] - Move jscs config to eslint
* [x] - Remove jscs
* [x] - Upgrade eslint

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1873

### How should this be tested?
Build and dev modes should lint as expected



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felizbear/zeppelin devops-eslint

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1818.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1818


commit 3a35792831255e994a7831af2d10eb416927549d
Author: felizbear 
Date:   2016-12-29T09:21:14Z

move jscs rules over to eslint

commit e0e0ba2906b4150a6e2f4e8ff4b7e2aee29fb8f0
Author: felizbear 
Date:   2016-12-29T09:22:01Z

remove jscs

commit 753bf4f5ed8539adff9cae16732be35965b1541e
Author: felizbear 
Date:   2016-12-29T09:35:18Z

update eslint version




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1873) Use exclusively eslint for javascript code linting (remove jscs)

2016-12-29 Thread Ilya Malyanov (JIRA)
Ilya Malyanov created ZEPPELIN-1873:
---

 Summary: Use exclusively eslint for javascript code linting 
(remove jscs)
 Key: ZEPPELIN-1873
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1873
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Ilya Malyanov
Assignee: Ilya Malyanov






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1811
  
@cuspymd I tried to make the browser width narrower and tried to change the 
paragraph width itself , but still couldn't reproduce. 

![changeparagraphwidth](https://cloud.githubusercontent.com/assets/10060731/21540765/f2e89d04-cdf4-11e6-9f27-9cbd89b25e7d.gif)


Am I missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1808: [ZEPPELIN-1843] Error on invoking the REST API to run ...

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1808
  
@kavinkumarks Thanks for your contribution! Seems this bug is only shown at 
the first time after starting Zeppelin. Tested and works well. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1872) pyspark run error with the paragraph

2016-12-29 Thread Oseong Kwon (JIRA)
Oseong Kwon created ZEPPELIN-1872:
-

 Summary: pyspark run error with the paragraph
 Key: ZEPPELIN-1872
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1872
 Project: Zeppelin
  Issue Type: Bug
  Components: GUI
Affects Versions: 0.6.0
 Environment: HDP2.5 sandbox
Reporter: Oseong Kwon
Priority: Minor


Unlike in the paragraph title edit box, it is difficult to input Korean in the 
code edit box.
After typing Korean strings in title, I tried to input "% pyspark" in the code 
box. After accidentally inputting Korean characters, and deleting it, enter "% 
pyspark" and execute python spark code, it will not run but generate error.
If enter the same code in another paragraph and execute it, the code runs 
normally.

Also, I could run this by typing the scala spark code after clearing everything 
in the problematic paragraph edit box.

I guess, probably because there is a residue of Korean input characters in the 
first input of the edit box of the problem paragraph, and the interpreter 
command of% pyspark

I guess, maybe the problem is that the first input of the edit box in the 
paragraph still contains the remnant of the previous input with unvisible 
Korean characters, so it can not interpret the interpreter command of %pyspark.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu

2016-12-29 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1811
  
@cuspymd Thanks. Let me try :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1811: [MINOR] Fix paragraph id misalignment in dropdown menu

2016-12-29 Thread cuspymd
Github user cuspymd commented on the issue:

https://github.com/apache/zeppelin/pull/1811
  
Let's try to change the width of browser.
It is reprouced  when the width of browser is narrow.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2016-12-29 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1804
  
@Leemoonsoo @AhyoungRyu I always appreciate your review for my PR.
Could you check this PR if you have time? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2016-12-29 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1804
  
@AhyoungRyu Thanks for quick information!
I just resolved it :smile:  



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

2016-12-29 Thread felizbear
GitHub user felizbear opened a pull request:

https://github.com/apache/zeppelin/pull/1817

remove usage of non-standard string method

### What is this PR for?
This PR removes a non-standard string prototype method `contains` that can 
cause potential bugs in the future maintenance.

### What type of PR is it?
Bug Fix 

### Todos
* [x] - remove usage of non-standard string method `contains` in favor of 
standard `indexOf`

### How should this be tested?
Download as `csv / tsv` (graph view) should work as expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felizbear/zeppelin remove-prototype-method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1817


commit d8e9005ccdfcac296be89f5227966589f11a6fa2
Author: felizbear 
Date:   2016-12-29T08:08:52Z

remove usage of non-standard string method

use standard `indexOf` method instead of proprietary `contains` defined
on string by unknown library; it is a potential bug; also it doesn't add
much value at all, compare:
  stringValue.contains(delimiter)
  stringValue.indexOf(delimiter) > -1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---