[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

Github user tae-jun closed the pull request at:

https://github.com/apache/zeppelin/pull/1730


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit 94407574e4182f93dfd9dce39e7e63fde824e461
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 1a2a7c5a719a3127720c40cdbafe054008200988
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit 423748811b1a56f4ed4df0950aa8b30f89cd7927
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 51cc60de3c709a2c7bc45cd8713521c87738d5aa
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit eb2d64b82afb260933f6f1d0ee59388eeece47bf
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit da00e3cc0db8ef896706f9a2263c929bc1cd929a
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 6ddeeb729e97f8408504627f26caa2ffdcbeee59
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit beaf265ac1eef802588d42cc5967323bfdbe96ff
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 35aca48d83ec971068aab63a8e222feb269ab5e2
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit e627ae7eee7cfc93585c0d438d5822daa11e6d1d
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit dd1f506ae8e7617ec257b52634540a44e4f0159f
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 0f10bb59384c81bfd0b2c73122d1188dd670e776
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@khalidhuseynov Thanks for your consideration! Tested again and it works 
well as we said :)
And there is one minor thing in lookandfeel setting menu. Is this intended 
behavior? 
 - Head 
https://cloud.githubusercontent.com/assets/10060731/21576429/4727add2-cf72-11e6-96cc-d096bafbae40.png;>


 - Read-only mode
https://cloud.githubusercontent.com/assets/10060731/21576423/0b1be682-cf72-11e6-88d1-a5b662b632e4.png;>
 





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@AhyoungRyu I think it makes sense and addressed your feedback. please 
check it out and let me know if it's fine. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1827: [ZEPPELIN-1878] added npm-debug.log on gitignore

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1827
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1716
  
Tested and LGTM.
Merge to master if there're no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1721: [ZEPPELIN-969] order by note name in job menu

[cloverhearts]

Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/1721


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1721: [ZEPPELIN-969] order by note name in job menu

[cloverhearts]

GitHub user cloverhearts reopened a pull request:

https://github.com/apache/zeppelin/pull/1721

[ZEPPELIN-969] order by note name in job menu

### What is this PR for?
we can sort by note name in job menu.
Sorting supports ascending and descending order.
Sort by note name.

### What type of PR is it?
Feature

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-969

### How should this be tested?
click to name order button.

### Screenshots (if appropriate)

![nameorder](https://cloud.githubusercontent.com/assets/10525473/20826460/66a7e7a6-b8ae-11e6-8e03-e2b00698e069.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin jobm/nameOrder

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1721.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1721


commit 2d9fc27aaf5f5c46d4b05ee481b81d4707d7f6d7
Author: CloverHearts 
Date:   2016-12-02T07:40:33Z

order by note name in job menu

commit da095273e3a564fbd3aa8a83c21e01b55c8f5f28
Author: CloverHearts 
Date:   2016-12-02T15:04:53Z

Rename notebook to note.

commit e8a6588cee8f635ddb18646d51aa0e859a123485
Author: CloverHearts 
Date:   2016-12-05T06:23:51Z

Merge branch 'master' into jobm/nameOrder

commit 3b698fbd60ec4454a22cfe2f42bf9cd86bf9dc69
Author: CloverHearts 
Date:   2016-12-05T06:27:33Z

change sortBy to orderby

commit 6142b8e76d5d9ffba7fa129d78e961dcc1661960
Author: CloverHearts 
Date:   2016-12-05T07:01:40Z

Revert "change sortBy to orderby"

This reverts commit 3b698fbd60ec4454a22cfe2f42bf9cd86bf9dc69.

commit ff442451f06c79d856888322c0528141ac3c64fa
Author: CloverHearts 
Date:   2016-12-09T05:34:10Z

Merge branch 'master' into jobm/nameOrder

commit 88d47081f1902a5caac928f64d920b52a2c33395
Author: CloverHearts 
Date:   2016-12-09T06:27:36Z

fix code style

commit 5383a2ea3731a11ffbebbd02c55e9e597978ad13
Author: CloverHearts 
Date:   2016-12-13T05:33:37Z

Merge branch 'master' into jobm/nameOrder

commit ead26f4b04519a913f8dd6e3b76ec8373e4a57f7
Author: CloverHearts 
Date:   2016-12-20T03:18:07Z

Merge branch 'master' into jobm/nameOrder

commit 57347c213320d9528905d546289ac986ed349c41
Author: cloverhearts 
Date:   2016-12-23T06:20:41Z

change filter icon

commit 11ffe68837c2b0d10cbf68cf005517e54513422f
Author: cloverhearts 
Date:   2016-12-29T05:40:14Z

Merge branch 'master' into jobm/nameOrder




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1827: [ZEPPELIN-1878] added npm-debug.log on gitignor...

[cloverhearts]

GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/1827

[ZEPPELIN-1878] added npm-debug.log on gitignore

### What is this PR for?
zeppelin-web/npm-debug.log file is only used debugging.
So, we do not tracking.

### What type of PR is it?
Improvement

### Todos
- [x] - fix .gitignore

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1878

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-ignore-npmdebug

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1827.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1827


commit 9585dd74cffc69903972f3e3ac104617006d4cbe
Author: cloverhearts 
Date:   2016-12-30T18:29:20Z

add ignore file npm-debug.log on gitignore




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1878) add ignore file npm-debug.log on gitignore

[CloverHearts (JIRA)]

CloverHearts created ZEPPELIN-1878:
--

 Summary: add ignore file npm-debug.log on gitignore
 Key: ZEPPELIN-1878
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1878
 Project: Zeppelin
  Issue Type: Improvement
Reporter: CloverHearts
Assignee: CloverHearts


npm-debug.log file is only use debug.




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1817: remove usage of non-standard string method

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1817
  
LGTM and merge to master if there're no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Supp...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1757


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
CI failure is not related with this change and already reported in 
[ZEPPELIN-1857](https://issues.apache.org/jira/browse/ZEPPELIN-1857). So I'm 
merging this now :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1826: [WIP][ZEPPELIN-1859] Add MongoNotebookRepo

[tae-jun]

GitHub user tae-jun opened a pull request:

https://github.com/apache/zeppelin/pull/1826

[WIP][ZEPPELIN-1859] Add MongoNotebookRepo

### What is this PR for?
This PR adds Mongo notebook storage.

The reason that I made this feature is for HA(High Availability).
S3 and Git storage are the only available method for HA as far as I know.

I'm managing Ambari cluster in my lab, but Zeppelin is the most vulnerable 
part of it.
Because one server contains all Zeppelin notes.

Therefore, by deploying MongoDB's [replica 
set](https://docs.mongodb.com/manual/replication/) and using it as Zeppelin 
notebook storage, I would like to achieve HA.

 The way to use Mongo DB as notebook storage
```sh
export 
ZEPPELIN_NOTEBOOK_STORAGE=org.apache.zeppelin.notebook.repo.MongoNotebookRepo 
```

or at `zeppelin-site.xml`:
```xml

  zeppelin.notebook.storage
  org.apache.zeppelin.notebook.repo.MongoNotebookRepo
  notebook persistence layer implementation

```
 Configurable environment variables
* `ZEPPELIN_NOTEBOOK_MONGO_URI` MongoDB connection URI
* `ZEPPELIN_NOTEBOOK_MONGO_DATABASE` Database name
* `ZEPPELIN_NOTEBOOK_MONGO_COLLECTION` Collection name
* `ZEPPELIN_NOTEBOOK_MONGO_AUTOIMPORT` If `true`, automatically import your 
local notes. Default `false`

They can be configured at `zeppelin-site.xml` as well:
* `zeppelin.notebook.mongo.uri`
* `zeppelin.notebook.mongo.database`
* `zeppelin.notebook.mongo.collection`
* `zeppelin.notebook.mongo.autoimport`


 Future work
If we use Mongo DB's [oplog 
tailing](https://docs.mongodb.com/manual/core/replica-set-oplog/), maybe 
multi-server architecture is possible.

### What type of PR is it?
[Feature]

### Todos
* [ ] - Write a documentation for Mongo storage

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1859

### How should this be tested?
 Install MongoDB (if you don't have)
```sh
brew update
brew install mongodb
```
 Build Zepppelin
```sh
mvn clean package -DskipTests
```
 Run Zeppelin wih Mongo storage
```sh
export 
ZEPPELIN_NOTEBOOK_STORAGE=org.apache.zeppelin.notebook.repo.MongoNotebookRepo
export ZEPPELIN_NOTEBOOK_MONGO_AUTOIMPORT=true
bin/zeppelin-daemon.sh restart
```
The default database and collection names are `zeppelin`, `notes` 
respectively.
And `ZEPPELIN_NOTEBOOK_MONGO_AUTOIMPORT` option will automatically import 
your `local notes` that don't exist in MongoDB.
 Check whether a document in MongoDB updated
Create, update, remove a note and open mongo shell:
```sh
mongo zeppelin
```
And check state of the note is the same as you think:
```sh
db.notes.findOne({_id: ''})
```
 Confirm that configurations works
```sh
export 
ZEPPELIN_NOTEBOOK_STORAGE=org.apache.zeppelin.notebook.repo.MongoNotebookRepo
export ZEPPELIN_NOTEBOOK_MONGO_AUTOIMPORT=true
export ZEPPELIN_NOTEBOOK_MONGO_DATABASE=otherdb
export ZEPPELIN_NOTEBOOK_MONGO_COLLECTION=mynotes
export ZEPPELIN_NOTEBOOK_MONGO_URI=mongodb://localhost:27017
bin/zeppelin-daemon.sh restart
```
The collection `mynotes` should be created in db `otherdb`.
Let's check it!
```sh
mongo otherdb
db.mynotes.count()
```
The result should not be zero.

 Confirm that configurations from `zeppelin-site.xml` works
Open your `conf/zeppelin-site.xml` file (copy from 
`zeppelin-site.xml.template` if you don't have one), and comment lines below:
```xml

```
And add lines below:
```xml

  zeppelin.notebook.storage
  org.apache.zeppelin.notebook.repo.MongoNotebookRepo
  notebook persistence layer implementation



  zeppelin.notebook.mongo.uri
  mongodb://localhost
  MongoDB connection URI used to connect to a MongoDB database 
server



  zeppelin.notebook.mongo.database
  zepl
  database name for notebook storage



  zeppelin.notebook.mongo.collection
  notes
  collection name for notebook storage



  zeppelin.notebook.mongo.autoimport
  false
  import local notes into MongoDB automatically on 
startup

```

This time we will import a note via `mongoimport`. I made it possible to 
import a note from JSON just in case.
```sh
cd $ZEPPELIN_HOME/notebook/
mongoimport --db zepl --collection notes --file note.json
```

Ensure that your environment variables are clean(just reopen your terminal 
if you are not), and restart zeppelin:
```sh
bin/zeppelin-daemon.sh restart
```
Open browser and go to `localhost:8080`. The note that you imported should 
be shown.

### Questions:
* Does the licenses files need 

[GitHub] zeppelin pull request #1730: [ZEPPELIN-1736] Introduce trash & enable removi...

[tae-jun]

GitHub user tae-jun reopened a pull request:

https://github.com/apache/zeppelin/pull/1730

[ZEPPELIN-1736] Introduce trash & enable removing folder

### What is this PR for?

![image](https://cloud.githubusercontent.com/assets/8201019/20925378/03a722f8-bbfa-11e6-9afc-c62cfe6b0e2a.png)
This PR introduces the trash! (which is essential, I think ^^;)

I added basic operations of the trash:
 Added operations of trash
* `Move` a folder to the trash
* `Move` a note to the trash
* `Restore` a folder
* `Restore` a note
* `Remove` a folder in the trash for good
* `Remove` a note in the trash for good
* `Empty` the trash
* `Restore all` in the trash
* `Move` a note to the trash from the notebook view
* `Remove` a note to the trash for good from the notebook view
* If there is a folder that has the same name, suffix current data rather 
than just merging(please see screenshot below!)


### What type of PR is it?
[Feature]

### Future work
Maybe it would be better if notebook view notices that a note is in the 
trash.

### What is the Jira issue?
[ZEPPELIN-1736](https://issues.apache.org/jira/browse/ZEPPELIN-1736)

### How should this be tested?
* Build this PR
* Move some folders or notes to the trash
* Restore them
* Empty the trash
* Restore all notes in the trash
* Remove folders or notes in the trash
* Remove a folder which has the same folder name in the trash

### Screenshots (if appropriate)
## Move, restore, remove a note from the main page

![note_from_main](https://cloud.githubusercontent.com/assets/8201019/20925760/13b0d91c-bbfc-11e6-94c5-2211c9d9a282.gif)

## Move, restore, remove a folder from the main page

![folder_test](https://cloud.githubusercontent.com/assets/8201019/20925774/2884abde-bbfc-11e6-9ba9-7b1f8a935a41.gif)

## Move, remove a note from the notebook view

![noteview_test](https://cloud.githubusercontent.com/assets/8201019/20925837/83564162-bbfc-11e6-9a92-c6bc1984b30d.gif)

## Restore, empty the trash

![restore_empty_trash](https://cloud.githubusercontent.com/assets/8201019/20925841/8f6d78d0-bbfc-11e6-90a9-6f67c95371a5.gif)

## Suffix current date if the folder exists in the trash

![same_folder_name_test](https://cloud.githubusercontent.com/assets/8201019/20926085/e8cb6954-bbfd-11e6-9cdf-acf9b785d833.gif)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tae-jun/zeppelin ZEPPELIN-1736

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1730.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1730


commit a010f8724329efe198bcb9406c8ed5892deea7d7
Author: Jun Kim 
Date:   2016-12-06T11:21:38Z

Introduce trash & removing folder

commit 6fc1846a044cc27ef5e5c69519b54cead25034a2
Author: Jun Kim 
Date:   2016-12-06T12:54:54Z

Satisfy style check

commit bf4641007ea209a44278514f0c5251b4a5732ac1
Author: Jun Kim 
Date:   2016-12-06T12:55:19Z

Remove if note is in the trash from the notebook view

commit 7ab945fbfef0da222e2291d32863931a81933edd
Author: Jun Kim 
Date:   2016-12-07T17:12:51Z

Use trash folder id provided by constant service

commit b4f42b26f781c341a1d035e685024bef229370ba
Author: Jun Kim 
Date:   2016-12-07T17:14:00Z

Change “for good” -> “permanently”

commit 43cf08bac15f1e979a2ff6f1e1b7d21f9e07c62a
Author: Jun Kim 
Date:   2016-12-07T17:15:51Z

Make the order of the trash folder last

commit 3490494a087f16e6d4b12101e829da571756e27f
Author: Jun Kim 
Date:   2016-12-08T15:28:15Z

Restore a folder without removed date

commit d7131799c9f614a986400e8d9ee7830fb3d602a7
Author: Jun Kim 
Date:   2016-12-08T15:42:26Z

Define isTrash function on notebook controller

commit 25d7b8f633639b9335b7eefd22e53e7b9b8a9070
Author: Jun Kim 
Date:   2016-12-08T15:59:10Z

Define notebook list button style

commit cb84473046b40e229e5f95f00608805b676f6e06
Author: Jun Kim 
Date:   2016-12-08T16:03:39Z

Fix stylecheck issue

commit 2407844911184e6cd750d20b7ad76d5dd9c11a8e
Author: Jun Kim 
Date:   2016-12-11T13:52:14Z

Fix white space bug @marchpig addressed

commit 5a33b176fc4d79fb47e033e438ed49c2c6b728dc
Author: Jun Kim 
Date:   2016-12-11T14:07:37Z

Change selenium test codes affected by chaging ‘removeNote’ button to 

[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1813
  
Tested and It works as expected like below!!

[Before]

![z_1813_b](https://cloud.githubusercontent.com/assets/8110458/21563310/650e0eb2-cec4-11e6-845b-0a028ddd1755.png)

[After]

![z_1813_a](https://cloud.githubusercontent.com/assets/8110458/21563311/67309c6e-cec4-11e6-942b-674e2f2c75c7.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1775
  
@AhyoungRyu actually i thought about it and couldn't find a reason why not 
let user change "Interpreter bindings" and "Note permissions" even in read-only 
mode, since they're still not able to run or edit. Do you think it's not common 
sense and confusing? Let me know what you think and we can change that easily. 
I wasn't also sure about it


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1817: remove usage of non-standard string method

[felizbear]

Github user felizbear commented on the issue:

https://github.com/apache/zeppelin/pull/1817
  
I've retriggered CI a few times. Current error is

```
Failed tests: 

  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:
```

obviously not related to the change. Can we ignore it and merge anyway?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1813
  
@astroshim It's great work! I will test it!
But, I would like to suggest one thing. According to what I understand, 
your screenshot and `Then you can see the login button like as screen shot.` is 
the content before fixing bug in this PR description, right?
I think in this part, It makes confusing for your description of PR. 
So, it would be clear if there is content after fixing the bug.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

[felizbear]

GitHub user felizbear reopened a pull request:

https://github.com/apache/zeppelin/pull/1817

remove usage of non-standard string method

### What is this PR for?
Recreating #1701 that was lost in refactoring.
This PR removes a non-standard string prototype method `contains` that can 
cause potential bugs in the future maintenance.

### What type of PR is it?
Bug Fix 

### Todos
* [x] - remove usage of non-standard string method `contains` in favor of 
standard `indexOf`

### How should this be tested?
Download as `csv / tsv` (graph view) should work as expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felizbear/zeppelin remove-prototype-method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1817


commit d8e9005ccdfcac296be89f5227966589f11a6fa2
Author: felizbear 
Date:   2016-12-29T08:08:52Z

remove usage of non-standard string method

use standard `indexOf` method instead of proprietary `contains` defined
on string by unknown library; it is a potential bug; also it doesn't add
much value at all, compare:
  stringValue.contains(delimiter)
  stringValue.indexOf(delimiter) > -1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

[felizbear]

Github user felizbear closed the pull request at:

https://github.com/apache/zeppelin/pull/1817


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1757
  
@lresende Looks good 👍 
Merge this into master if there are no more comments. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

[felizbear]

Github user felizbear closed the pull request at:

https://github.com/apache/zeppelin/pull/1817


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1817: remove usage of non-standard string method

[felizbear]

GitHub user felizbear reopened a pull request:

https://github.com/apache/zeppelin/pull/1817

remove usage of non-standard string method

### What is this PR for?
Recreating #1701 that was lost in refactoring.
This PR removes a non-standard string prototype method `contains` that can 
cause potential bugs in the future maintenance.

### What type of PR is it?
Bug Fix 

### Todos
* [x] - remove usage of non-standard string method `contains` in favor of 
standard `indexOf`

### How should this be tested?
Download as `csv / tsv` (graph view) should work as expected

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/felizbear/zeppelin remove-prototype-method

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1817.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1817


commit d8e9005ccdfcac296be89f5227966589f11a6fa2
Author: felizbear 
Date:   2016-12-29T08:08:52Z

remove usage of non-standard string method

use standard `indexOf` method instead of proprietary `contains` defined
on string by unknown library; it is a potential bug; also it doesn't add
much value at all, compare:
  stringValue.contains(delimiter)
  stringValue.indexOf(delimiter) > -1




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---