[GitHub] zeppelin issue #1954: [ZEPPELIN-525] Test failing in zeppelin-interpreter

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1954
  
look reasonable.
CI is green,  merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-28 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
I think it is related, right?
```
Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate 
element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[contains(@class,
 'control')]//span[1][contains(.,'READY')]"}
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/1955

[ZEPPELIN-2025] Cleanup R Tutorial

### What is this PR for?

1. Remove useless paragraphs in R tutorial
2. Prettify layout

I attached screenshots for comparison. See the screenshot section below.

### What type of PR is it?
[Improvement]

### Todos

Done

### What is the Jira issue?

[ZEPPELIN-2025](https://issues.apache.org/jira/browse/ZEPPELIN-2025)

### How should this be tested?

1. Run Zeppelin
2. See the R tutorial


### Screenshots (if appropriate)

 Before


![before](https://cloud.githubusercontent.com/assets/4968473/22393959/5266c76a-e556-11e6-8501-34d87c31908e.gif)

 After


![after](https://cloud.githubusercontent.com/assets/4968473/22393961/5394bc50-e556-11e6-83f8-23ccaa05c12a.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2025/cleanup-r-tutorial

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1955


commit 178178eb275c677acf13ccbe1051ccc50b93ca90
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-28T03:32:12Z

fix: Cleanup R Tutorial

commit 20d551e4195ecdcf8560c9b45eaddc4de240f995
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-28T18:26:28Z

fix: Prettify layout in medium size




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
Github user 1ambda closed the pull request at:

https://github.com/apache/zeppelin/pull/1955


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1663: ZEPPELIN-1692: Ability to access Spark jobs UI ...

2017-01-28 Thread karuppayya
GitHub user karuppayya reopened a pull request:

https://github.com/apache/zeppelin/pull/1663

ZEPPELIN-1692: Ability to access Spark jobs UI from the paragraph

### What is this PR for?
A paragraph execution may result in spark job(s).
Adding ability to access the spark job UI(corresponding to the job 
generated by the paragraph run), directly from the paragraph.

### What type of PR is it?
Improvement

### Todos
* [x]  Write tests

### What is the Jira issue?
ZEPPELIN-1692

### How should this be tested?
Run paragraphs with spark code(scala, pyspark, sql, R).
The paragraph will display a button on the top right corner, which on click 
will open up the corresponding job UI

### Screenshots (if appropriate)

![spark_jobs](https://cloud.githubusercontent.com/assets/5082742/20488337/a07fe35a-b02c-11e6-9400-db9f1c10df90.gif)


### Questions:
* Does the licenses files need update? NA
* Is there breaking changes for older versions? NA
* Does this needs documentation? NA


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/karuppayya/incubator-zeppelin ZEPPELIN-1692

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1663


commit b91f047ff8c7f052b722b56bacf77bae5f7fdcf7
Author: karuppayya 
Date:   2016-11-20T15:00:40Z

Ability to view spark job urls in each paragraph

commit 56e3f394235ecfda634281e8d61a0dd8395ef3cf
Author: karuppayya 
Date:   2016-11-21T14:48:59Z

Fix checkstyle

commit 6c786cf7ef5f3406b848eda9e61016ce048db6bd
Author: karuppayya 
Date:   2016-11-21T15:44:12Z

Fix NPE and some refactoring

commit 2ead2f5424b212dd1bf5dff7f5b5d3d0ea7730c3
Author: karuppayya 
Date:   2016-11-22T05:12:37Z

Fix NPE in tests

Signed-off-by: karuppayya 

commit 931c7e21e3b81081989f73e71b4a9bb05a067af8
Author: Karup 
Date:   2016-11-26T03:02:47Z

Address review comments

Signed-off-by: Karup 

commit 0594582e11ac94ce3cdd24692c7ac13fc93ea77a
Author: Karup 
Date:   2016-11-26T03:38:21Z

Clear job urls when we clear output

Signed-off-by: Karup 

commit 0cc397ac25f26615edf5b747f1609ef41757381c
Author: Karup 
Date:   2016-11-27T09:00:35Z

Add tests , refactor

Signed-off-by: Karup 

commit 8748f0a4ea90d235a67e3ad1a4520ae37ca5479f
Author: Karup 
Date:   2016-11-27T10:57:00Z

Fix test

Signed-off-by: Karup 

commit e050f73d3d3f966baf8260a26941ec37a7ffacf1
Author: karuppayya 
Date:   2016-12-01T16:04:00Z

Address review feedbacks

Signed-off-by: karuppayya 

commit 55cabc6de1de7e932e223eb35529cd70abecef40
Author: karuppayya 
Date:   2016-12-02T04:06:23Z

Fix test

Signed-off-by: karuppayya 

commit fbb3cb06f93ee938a9d17e58e06900cb274775e5
Author: karuppayya 
Date:   2016-12-08T14:55:19Z

Fix incorrect variable used

Signed-off-by: karuppayya 

commit 54e33dc7fb378064b7277d8bd93ee06cb77ccb9f
Author: Karup 
Date:   2016-12-18T04:00:37Z

Address review comments

Signed-off-by: Karup 

commit d690c055b7bc79efa758ddf0b31ccf3a72d68aad
Author: Karup 
Date:   2016-12-18T04:33:50Z

Fix compilation

Signed-off-by: Karup 

commit 8f525251f2a187d3b3abb77a3375164f188400eb
Author: Karup 
Date:   2017-01-01T16:45:54Z

Send para runtimeinfos via websocker, but dont persist in json

commit ff8328f7c1ca2e79d6a582df9849dac9d66fa871
Author: Karup 
Date:   2017-01-01T17:24:57Z

Fix incorrect rebase

commit 2acb200341417346af3517b466b95ea87b155bf7
Author: Karup 
Date:   2017-01-01T18:03:53Z

Adding license header

commit 7bbf3466e28739d5b6fc8085121f406c6c752d0d
Author: Karup 
Date:   2017-01-27T15:33:36Z

Fix tooltip




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-28 Thread karuppayya
Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
I see the following errors in the SELENIUM test

`org.openqa.selenium.NoSuchElementException: Unable to locate element: 
{"method":"xpath","selector":"//i[@tooltip='WebSocket Connected']"}`
`org.openqa.selenium.NoSuchElementException: Unable to locate element: 
{"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])`

Reopening the PR to see it is intermittent


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1663: ZEPPELIN-1692: Ability to access Spark jobs UI ...

2017-01-28 Thread karuppayya
Github user karuppayya closed the pull request at:

https://github.com/apache/zeppelin/pull/1663


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
@karuppayya tried again with clean build and i don't see problem now. Maybe 
my test branch has been messed up. 

Now, two CI profiles are failing
https://travis-ci.org/apache/zeppelin/jobs/195910315 (SELENIUM)
https://travis-ci.org/apache/zeppelin/jobs/195910316 (python/pyspark)

Later one doesn't look related but i think it worth to make sure first 
one(SELENIUM) passes the test.
Could you trigger CI again and see if test goes green?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-28 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1902
  
CI failure looks unrelated, since it only removed commented-out code from 
last CI success.
Thanks @bbonnin for great contribution.
LGTM and merge to master if no further discussions!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1936: [ZEPPELIN-2004] List all helium packages in Zep...

2017-01-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1936


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1949: [MINOR] Refactor to modern apis

2017-01-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1949


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-28 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1955
  
@minahlee Thanks for review! 

I updated notebook layout and it looks like

## Large Size


![full-size](https://cloud.githubusercontent.com/assets/4968473/22398815/cd2d003c-e5d2-11e6-9b3d-7f3a816aaef6.gif)

## Medium Size


![medium](https://cloud.githubusercontent.com/assets/4968473/22398816/d09d113a-e5d2-11e6-8f90-a0f23dd278c0.gif)

## Small Size


![small](https://cloud.githubusercontent.com/assets/4968473/22398820/d4ab4ef4-e5d2-11e6-9e27-c84cf254f2bb.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1956: Groovy Interpreter

2017-01-28 Thread dlukyanov
Github user dlukyanov closed the pull request at:

https://github.com/apache/zeppelin/pull/1956


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1956: Groovy Interpreter

2017-01-28 Thread dlukyanov
Github user dlukyanov commented on the issue:

https://github.com/apache/zeppelin/pull/1956
  
wrong pull request


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-28 Thread karuppayya
Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
Than @Leemoonsoo for the explanation

I am not able to repro it.

The following two lines takes care of it
1. 
[Note.java#567](https://github.com/apache/zeppelin/pull/1663/files#diff-0f40daff726ba29c9a004b342d422dfeR567)
 -  Clears the runtime info of paragraph , when we `run` the paragraph
2. 
[paragraph.controller.js#1054](https://github.com/apache/zeppelin/pull/1663/files#diff-52fa6628f0b6793d22ffe1f3e4763635R1054)
 - When the status of paragraph gets updated when we run a 
paragraph(`FINISHED`, `ABORTED` etc -> `PENDING`), paragraph update message is 
sent to UI(which has `runtimeInfos` nullified , from #1), which in turn hides 
the link.

If you have any specific steps, can you please let me know. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1956: Groovy Interpreter

2017-01-28 Thread dlukyanov
GitHub user dlukyanov opened a pull request:

https://github.com/apache/zeppelin/pull/1956

Groovy Interpreter

### What is this PR for?
Create a Groovy Interpreter

### What type of PR is it?
Feature 

### Todos
* [Code] - Task
* [Samples] - Task
* [Documentation] - Task
* [Test cases] - Task

### What is the Jira issue?
TODO

### How should this be tested?
Outline the steps to test the PR here.

### Samples

```groovy
%groovy
//get a parameter defined as z.angularBind('ngSearchParam', value, 
'paragraph_id')
//g is a context object for groovy to avoid mix with z object?
def param = g.angular('ngSearchParam')
//send request 
https://www.googleapis.com/customsearch/v1?q=ngSearchParam_value
def r = HTTP.get(
  //assume you defined groovy interpreter property 
`search_baseurl`='https://www.googleapis.com/customsearch/v1'
  //in groovy object o.getProperty('A') == o.'A' == o.A == o['A']
  url : g.search_baseurl,
  query: [ q: param ],
  headers: [
'Accept':'application/json',
//'Authorization:' : g.getProperty('search_auth'),
  ] 
)
//check response code
if( r.response.code==200 ) {
  g.html().with{ 
//g.html() renders %angular to output and returns 
groovy.xml.MarkupBuilder
h2("the response ${r.response.code}")
span( r.response.body )
h2("headers")
pre( r.response.headers.join('\n') )
  }
} else {
  //just to show that it's possible to use println with multiline groovy 
string to render output
  println("""%angular
 alert ("code=${r.response.code} \n msg=${r.response.message}") 

  """)
}
```


```groovy
%groovy

//renders a table with headers a, b, c  and two rows
g.table(
  [
['a','b','c'],
['a1','b1','c1'],
['a2','b2','c2'],
  ]
)
```

### Questions:
* Does the licenses files need update?
no
* Is there breaking changes for older versions?
no
* Does this needs documentation?
yes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/zeppelin branch-0.6

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1956.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1956


commit c503f450c78c55e2c1369ecc3e11f082e865b048
Author: CloverHearts 
Date:   2016-06-15T05:01:28Z

ZEPPLIN-976 ] HotFix - zeppelin server does not restart when incorrect 
credentials data.

### What is this PR
zeppelin server does not restart when incorrect credentials data.

reproduce.
1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written 
to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.
# but, Zeppelin does not work.

It creates the wrong json file. 'conf / credentials.json' according to the 
null.

### What type of PR is it?
Hot Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-976

### How should this be tested?

1. Click to zeppelin home for web ui.
2. Click to zeppelin Credentials.
3. 'Entity' information without writing, username and password only written 
to storage.
4. Click to zeppelin home for web ui.
5. Click to zeppelin Credentials.
and zeppelin restart.

zeppelin does work!

### Reproduced Screenshots

![zeppelin-server-error2](https://cloud.githubusercontent.com/assets/10525473/15889828/b92590d8-2da7-11e6-9b51-0a82c3bb9f1f.gif)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: CloverHearts 

Closes #976 from cloverhearts/hotfix/CredentialsJsonBug and squashes the 
following commits:

293ab08 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
ef256c2 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
5079495 [CloverHearts] add test code for credentials backends about invalid 
request.
e9a1e93 [CloverHearts] Merge branch 'master' into hotfix/CredentialsJsonBug
4b9aba3 [CloverHearts] changed status code for CredentialsRestapi
1e5cd72 [CloverHearts] Credentials Json serialize backend bug.

commit ee7ebca065bbe3a2e81ca10118baf047dd3fa561
Author: Jongyoul Lee 
Date:   2016-06-14T15:58:21Z

ZEPPELIN-992 Move some tests from InterpreterFactoryTest to 
LazyOpenInterpreterTest


[GitHub] zeppelin pull request #1948: [ZEPPELIN-2016] add test case for cron job sche...

2017-01-28 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1948


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---