date:20170305

[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

2017-03-05 Thread soralee

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2042
  
cc @1ambda @AhyoungRyu :smile: 
In my case, I fixed same error with click `Delete all repository cache` as 
explained in [Travis 
document](https://docs.travis-ci.com/user/caching/#Clearing-Caches)  

I guess this error is occurred by cache of Travis.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

2017-03-05 Thread AhyoungRyu

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2042
  
@soralee Thanks for digging it out! Since it's because of the cache in 
travis, someone who contributed to Zeppelin for the first time didn't went 
through this issue and saw green light. I think we need to guide contributors 
for a while to clear their cache as you did. 
@1ambda Could you try like this to make sure? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...

2017-03-05 Thread mgarmash

Github user mgarmash commented on the issue:

https://github.com/apache/zeppelin/pull/2085
  
Nice feature! +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

2017-03-05 Thread AhyoungRyu

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2042
  
@1ambda Thanks for reporting it. Let me check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2042: [ZEPPELIN-1588]: bumping nvd3 to 1.8.5

2017-03-05 Thread 1ambda

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2042
  
I think bumping nvm3 version causes CI failure in profile 2, 3 and 6

- https://travis-ci.org/apache/zeppelin/builds/207845221
- https://travis-ci.org/apache/zeppelin/builds/208059749 (the most recent 
merged PR based on this PR)

```
[WARNING] warning Unmet peer dependency "eslint@>=3.8.1".
[ERROR] [{
[ERROR]   "code": "ECONFLICT",
[ERROR]   "name": "d3",
[ERROR]   "picks": [
[ERROR] {
[ERROR]   "endpoint": {
[ERROR] "name": "d3",
[ERROR] "source": "d3",
[ERROR] "target": "~3.3.13"
[ERROR]   },
[ERROR]   "canonicalDir": 
"/home/travis/build/apache/zeppelin/zeppelin-web/bower_components/d3",
[ERROR]   "pkgMeta": {
[ERROR] "name": "d3",
[ERROR] "version": "3.3.13",
[ERROR] "main": "d3.js",
[ERROR] "scripts": [
[ERROR]   "d3.js"
[ERROR] ],
[ERROR] "ignore": [
[ERROR]   ".DS_Store",
[ERROR]   ".git",
[ERROR]   ".gitignore",
[ERROR]   ".npmignore",
[ERROR]   ".travis.yml",
[ERROR]   "Makefile",
[ERROR]   "bin",
[ERROR]   "component.json",
[ERROR]   "index-browserify.js",
[ERROR]   "index.js",
[ERROR]   "lib",
[ERROR]   "node_modules",
[ERROR]   "package.json",
[ERROR]   "src",
[ERROR]   "test"
[ERROR] ],
[ERROR] "homepage": "https://github.com/mbostock-bower/d3-bower;,
[ERROR] "_release": "3.3.13",
[ERROR] "_resolution": {
[ERROR]   "type": "version",
[ERROR]   "tag": "v3.3.13",
[ERROR]   "commit": "50df7cbc7f55d8b3a43304a7b029516255c10bdc"
[ERROR] },
[ERROR] "_source": "https://github.com/mbostock-bower/d3-bower.git;,
[ERROR] "_target": "~3.3.13",
[ERROR] "_originalSource": "d3"
[ERROR]   },
[ERROR]   "dependencies": {},
[ERROR]   "nrDependants": 1,
[ERROR]   "dependants": [
[ERROR] {
[ERROR]   "endpoint": {
[ERROR] "name": "nvd3",
[ERROR] "source": "nvd3",
[ERROR] "target": "~1.8.5"
[ERROR]   },
[ERROR]   "canonicalDir": 
"/home/travis/build/apache/zeppelin/zeppelin-web/bower_components/nvd3",
[ERROR]   "pkgMeta": {
[ERROR] "name": "nvd3",
[ERROR] "version": "1.7.1",
[ERROR] "homepage": "http://www.nvd3.org;,
[ERROR] "authors": [
[ERROR]   "Bob Monteverde",
[ERROR]   "Tyler Wolf",
[ERROR]   "Robin Hu",
[ERROR]   "Frank Shao",
[ERROR]   "liquidpele"
[ERROR] ],
[ERROR] "description": "Re-usable charts and chart components 
for d3.",
[ERROR] "main": [
[ERROR]   "build/nv.d3.js",
[ERROR]   "build/nv.d3.css"
[ERROR] ],
[ERROR] "keywords": [
[ERROR]   "d3",
[ERROR]   "visualization",
[ERROR]   "svg",
[ERROR]   "charts"
[ERROR] ],
[ERROR] "license": "Apache License, v2.0",
[ERROR] "dependencies": {
[ERROR]   "d3": "~3.3.13"
[ERROR] },
[ERROR] "ignore": [
[ERROR]   "**/.*",
[ERROR]   "node_modules",
[ERROR]   "bower_components",
[ERROR]   "test",
[ERROR]   "src",
[ERROR]   "examples",
[ERROR]   "GruntFile.js",
[ERROR]   "*.html",
[ERROR]   "*.log",
[ERROR]   "*.xml",
[ERROR]   "*.json",
[ERROR]   "*.md"
[ERROR] ],
[ERROR] "resolutions": {
[ERROR]   "d3": "~3.3.13"
[ERROR] },
[ERROR] "devDependencies": {
[ERROR]   "d3": "~3.3.13"
[ERROR] },
[ERROR] "_release": "1.7.1",
[ERROR] "_resolution": {
[ERROR]   "type": "version",
[ERROR]   "tag": "v1.7.1",
[ERROR]   "commit": "679fe2ff96c194e442970cb9959ebccd79f6bd43"
[ERROR] },
[ERROR] "_source": "https://github.com/novus/nvd3.git;,
[ERROR] "_target": "~1.7.1",
[ERROR] "_originalSource": "nvd3"
[ERROR]   },
[ERROR]   "dependencies": {
[ERROR] "d3": {
[ERROR]   "endpoint": {
[ERROR] "name": "d3",
[ERROR]

[jira] [Created] (ZEPPELIN-2217) AdvancedTransformation for Helium Visualization

2017-03-05 Thread Hoon Park (JIRA)

Hoon Park created ZEPPELIN-2217:
---

 Summary: AdvancedTransformation for Helium Visualization
 Key: ZEPPELIN-2217
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2217
 Project: Zeppelin
  Issue Type: New Feature
  Components: front-end
Reporter: Hoon Park


Even if we already have 2 useful transformation, they have limitations.

- we can't configure axises in {{PivotTransformation}}
- we can't use aggregator functions in {{ColumnselectorTransformation}}

{{AdvancedTransformation}} provides both functionality. Additionally, it 
supports

- dynamic parameter panel for configuring charts
- maximizing / minimizing each panels



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread tinkoff-dwh

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@Leemoonsoo 
https://issues.apache.org/jira/browse/ZEPPELIN-2216
what to do with this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2092: [ZEPPELIN-2148] On creation of Bar graph zeppelin UI s...

2017-03-05 Thread prabhjyotsingh

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2092
  
Thank you @1ambda.
Will merge this soon based on reviews in 
https://github.com/apache/zeppelin/pull/2074.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2051: [ZEPPELIN-1968] Added property to disable hive user im...

2017-03-05 Thread prabhjyotsingh

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2051
  
Sure thank you @gfalcone, will merge this soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2216) Common solution to execute precode after/before open/close interpreter

2017-03-05 Thread Maks (JIRA)

Maks created ZEPPELIN-2216:
--

 Summary: Common solution to execute precode after/before 
open/close interpreter
 Key: ZEPPELIN-2216
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2216
 Project: Zeppelin
  Issue Type: New Feature
  Components: Interpreters
Reporter: Maks
Priority: Minor


discussion https://github.com/apache/zeppelin/pull/2096



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread vipul1409

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2090
  
There is not SparkRInterpreterTest.java, looks like there are no test for 
SparkR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2059: [ZEPPELIN-2139] Interpreters based on scala_2.11 aren'...

2017-03-05 Thread minahlee

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/2059
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2077: [ZEPPELIN-2191] Helium package should be able to impor...

2017-03-05 Thread 1ambda

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2077
  
Rebased to resolve conflict.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread sravan-s

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@Leemoonsoo Who is the go to person at JIRA, if I need to ask clear  some 
of my doubts. I found some interesting bugs, but, I would like to verify some 
of my doubts


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2095: [ZEPPELIN-2094] Decrease npm install retry time (for b...

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2095
  
LGTM and merge to branch-0.7 if no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2071: [ZEPPELIN-2166] HeliumBundleFactoty can't trans...

2017-03-05 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2071


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2215) Add progress bar for spell execution

2017-03-05 Thread Hoon Park (JIRA)

Hoon Park created ZEPPELIN-2215:
---

 Summary: Add progress bar for spell execution
 Key: ZEPPELIN-2215
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2215
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end, helium
Reporter: Hoon Park


Paragraphs executed by spell doesn't show progress bar



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin pull request #2060: [ZEPPELIN-2094] Decrease npm install retry time

2017-03-05 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2060


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-2214) Should provide node / npm / package installation proxy for Helium

2017-03-05 Thread Hoon Park (JIRA)

Hoon Park created ZEPPELIN-2214:
---

 Summary: Should provide node / npm / package installation proxy 
for Helium
 Key: ZEPPELIN-2214
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2214
 Project: Zeppelin
  Issue Type: Bug
  Components: helium
Affects Versions: 0.7.0, 0.8.0
Reporter: Hoon Park
 Fix For: 0.7.1, 0.8.0


1. Zeppelin installs nodejs / npm on startup but there might be trouble if you 
can connect to the official nodejs site. So we need proxy option for them. 

- For example we should use https://npm.taobao.org/mirrors/node in China

2. Additionally, helium will install nodejs packages at runtime. So we have to 
provide proxy option for that too.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread AhyoungRyu

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
LGTM 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@sravan-s Thanks, that would be helpful!
LGTM and merge to master and branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@masyan 

Do you mind open PR or JIRA issue and discuss there for more generic way of 
run code before/after open/close ? I think it can be little complicated to 
discuss here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2078: [ZEPPELIN-1988] add property "precode" to JDBCInterpre...

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2078
  
@felixcheung I think we can merge this one first. A way we're discuss in 
#2096 may replace the this PR we don't have the implementation yet. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread tinkoff-dwh

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@felixcheung 
1. Yes.
2. Code will be executed after method open() (at the end of this method).
accordingly:
 1) Per Note - executes once for note + Interpreter. For different code, 
percode is equals (the same).
 2) Per User - executes once for each user + Interpreter. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2039: [MINOR] Use standard java API to interrupt thread

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2039
  
Ok I wasn't aware of the thread.interrupt semantic in JVM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2089: [ZEPPELIN-791] Build infra: move all RAT to roo...

2017-03-05 Thread asfgit

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2089


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2089: [ZEPPELIN-791] Build infra: move all RAT to root pom.x...

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2089
  
merged to master.
thanks!



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2078: [ZEPPELIN-1988] add property "precode" to JDBCInterpre...

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2078
  
@Leemoonsoo let me know if you want to hold this when we are discussing in 
#2096.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
Also, is `precode` a concept at the interpreter instance level?
Would there be need to run different code per note - how is this going to 
interact with interpreter mode like `per note`, `isolated` and so on?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2056: ZEPPELIN-2151. Add integration test for livy cancel ap...

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2056
  
one failure: https://travis-ci.org/zjffdu/zeppelin/jobs/204447551


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2090
  
Do we have unit tests for SparkR? If so it would be good to add a test for 
this.
Otherwise looks good to me


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2090
  
@Leemoonsoo Travis CI everything passes actually - it looks like Jenkins 
has timed-out while the last suite was still running.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

2017-03-05 Thread felixcheung

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1582
  
@jexp it would be great if you could review the neo4j parts in this PR.
@conker84 would you be opening a new PR? please link to this one (type 
#1582) so I could help review and get this in soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan

Github user masyan commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
and InterpreterContext is unavailable in method close


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2080: [ZEPPELIN-1964] Layout info is lost after refresh

2017-03-05 Thread astroshim

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/2080
  
@Leemoonsoo I did. thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2080: [ZEPPELIN-1964] Layout info is lost after refre...

2017-03-05 Thread astroshim

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/2080


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread sravan-s

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@Leemoonsoo  The CI is green now
Is it okay if I try to work on some other bugs 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

GitHub user sravan-s reopened a pull request:

https://github.com/apache/zeppelin/pull/2087

[ZEPPELIN-2172] Redirect to home if notebook authentication fails in 
realtime

### What is this PR for?
Redirect to home page, if a user declines the access failure message on a 
notebook

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user 
test_user3
3. Now in another tab, open the notebook with test_user1 user who has write 
permissions
4. In the original tab, have user qa_user (owner of the notebook) remove 
the write permissions from test_user1 user and grant it to some other user 
test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an 
error message
6. On click of close button, UI should redirect to homepage


### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2087


commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess 
Date:   2017-03-01T15:11:39Z

[ZEPPELIN-2172] Redirect to home if auth fails

If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page

commit 0b9b1dd1f2b2f739ef64b730f6be1f67c8767c53
Author: ess_ess 
Date:   2017-03-05T10:47:39Z

Add explanatory comment




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

Github user sravan-s closed the pull request at:

https://github.com/apache/zeppelin/pull/2087


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...

2017-03-05 Thread zjffdu

Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/2056


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2056: ZEPPELIN-2151. Add integration test for livy ca...

2017-03-05 Thread zjffdu

GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/2056

ZEPPELIN-2151. Add integration test for livy cancel api

### What is this PR for?

Just add integration test for livy cancel api. Only do it for livy 0.3 as 
the cancel api is only available in livy 0.3


### What type of PR is it?
[ Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2151

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2151

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2056.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2056


commit e5fe4914879948e3981d104f296871a20e04977f
Author: Jeff Zhang 
Date:   2017-02-22T11:59:47Z

ZEPPELIN-2151. Add integration test for livy cancel api




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1545: [WIP] ZEPPELIN-1571. Support pig udf interpreter

2017-03-05 Thread zjffdu

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1545
  
@AhyoungRyu @felixcheung I changed this PR to WIP. As there's still one 
issue I need to fix. The issue is that if user change the udf, the class can 
not been reloading unless restarting the interpreter. I need to fix this 
classloading issue in pig side first, then I will continue this PR. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan

Github user masyan commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@Leemoonsoo
so not working as I expected, method open not runs (in 
RemoteInterpreterServer). need to better understand the circuit how it works


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@masyan Make sense!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan

Github user masyan commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
@Leemoonsoo 
Although probably implement hooks to do this properly. This may confuse the 
user. If he is going to register these hooks in their paragraphs, and they will 
not work (because they will be executed only when the initialization of the 
interpreter).

I propose, then, is a global solution. Add two parameters
zeppelin.interpretator.after_open
zeppelin.interpretator.before_close

and add `interpetator.interpret(interpetator.getProperty(propertyName))` to 
methods open and close (RemoteInterpreterServer.java)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
Thanks @andreaTP for the contribution.

I left some comment. Please take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread sravan-s

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
Let me try that


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Netwo...

2017-03-05 Thread conker84

Github user conker84 closed the pull request at:

https://github.com/apache/zeppelin/pull/1582


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1582: [ZEPPELIN-1604] Add Neo4j interpreter and Network visu...

2017-03-05 Thread conker84

Github user conker84 commented on the issue:

https://github.com/apache/zeppelin/pull/1582
  
@jexp any help i appreciated!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2097: [MINOR][ZEPPELIN-2154] Enable work in the web d...

2017-03-05 Thread soralee

GitHub user soralee opened a pull request:

https://github.com/apache/zeppelin/pull/2097

[MINOR][ZEPPELIN-2154] Enable work in the web dev mode if changing default 
server port

### What is this PR for?
If user change `zeppelin.server.port` variable in zeppelin-site.xml, 
zeppelin doesn't work in web development. 
In order for user to run zeppelin correctly, so that user can add 
`SERVER_PORT` as an environment variable when running web application 
development mode.

### What type of PR is it?
[Bug Fix | Improvement | Documentation]

### What is the Jira issue?
* [ZEPPELIN-2154](https://issues.apache.org/jira/browse/ZEPPELIN-2154)

### How should this be tested?
1. Change `zeppelin.server.port` from 8080 to  (or another port) in 
`zeppelin-site.xml`
2. Run zeppelin (`bin/zeppelin-daemon.sh start`)
3. Run web development mode under `zeppelin-web` folder such like 
`SERVER_PORT= yarn run dev` 
4. Connect `localhost:9000`

### Screenshots (if appropriate)
[Before]

![z_2130_before](https://cloud.githubusercontent.com/assets/8110458/23586226/37f38252-01d4-11e7-8261-37e4e17c7eaf.gif)

[After]

![z_2130_after](https://cloud.githubusercontent.com/assets/8110458/23586227/3aa4422a-01d4-11e7-8cd0-c0644e315131.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes, added in README.md


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-2154_port_webDevMode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2097.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2097


commit ce9c18e3bef120f99edd32a6fa8ac185cac1ebb9
Author: soralee 
Date:   2017-03-05T09:08:30Z

enable custom server port in web dev mode

commit 54f0a96d92f26236841ed0e5c9647abc54c8089d
Author: soralee 
Date:   2017-03-05T10:11:12Z

add README.md

commit 49128a832ac6e4b78c163b2977d6fa5624e9fce5
Author: soralee 
Date:   2017-03-05T10:21:03Z

add README.md

commit 6f2b8e4e99575d041fba0803f0e95a18d8e921d9
Author: soralee 
Date:   2017-03-05T10:23:29Z

modify typo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2090: ZEPPELIN-2199: Fix lapply issue in sparkR

2017-03-05 Thread vipul1409

Github user vipul1409 commented on the issue:

https://github.com/apache/zeppelin/pull/2090
  
Re ran the failed job and it passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread masyan

Github user masyan commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
I think this is a good idea. I'm trying to implement this and test task 
[#2085](https://github.com/apache/zeppelin/pull/2085) 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2095: [ZEPPELIN-2094] Decrease npm install retry time (for b...

2017-03-05 Thread 1ambda

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2095
  
Thanks @NohSeho. It would be nice if a description for reproducing this 
issue in 0.7.0


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread sravan-s

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@Leemoonsoo Those buttons are on. I'm not sure why travis isn't picking 
this up.

This is my travis settings:
![screenshot from 2017-03-05 15 32 
48](https://cloud.githubusercontent.com/assets/11382805/23586351/434abd52-01b9-11e7-8ee9-478761c85e6a.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2060: [ZEPPELIN-2094] Decrease npm install retry time

2017-03-05 Thread NohSeho

Github user NohSeho commented on the issue:

https://github.com/apache/zeppelin/pull/2060
  
I will update the pr description soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2095: [ZEPPELIN-2094] Decrease npm install retry time (for b...

2017-03-05 Thread NohSeho

Github user NohSeho commented on the issue:

https://github.com/apache/zeppelin/pull/2095
  
I will update the pr description soon.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@sravan-s To make Zeppelin's Jenkins check your travis-ci build status 
correctly, you'll need to turn on 'Build pushes' switch from 
https://travis-ci.org/sravan-s/zeppelin/settings.


![image](https://cloud.githubusercontent.com/assets/1540981/23586229/419cb206-01d4-11e7-91c2-052701249934.png)

Then every push is going to be build and Zeppelin's Jenkins can check and 
display build status correctly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2094: [ZEPPELIN-2162] [ZEPPELIN-2142] Make travis_check.py w...

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2094
  
Merge to master and branch-0.7 if no more comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread Leemoonsoo

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2096
  
Thanks @tinkoff-dwh for the contribution.
I've seen #2078. 

If `precode` is going to be added to all interpreter, how about create some 
facility that runs code when initialize interpreter and then make feature based 
on it?

How about extend 
[Interpreter.Hook()](https://github.com/apache/zeppelin/blob/branch-0.7/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/Interpreter.java#L208)
 which currently has 
[PRE_EXEC](https://github.com/apache/zeppelin/blob/branch-0.7/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterHookRegistry.java#L143)
 and 
[POST_EXEC](https://github.com/apache/zeppelin/blob/branch-0.7/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterHookRegistry.java#L146)
 as event type that make code run before and after the interpret() call 
respectively.

I think we can add event type such as `AFTER_OPEN`, `BEFORE_CLOSE`. Then 
with minimum modification of each interpreter, we can have the feature.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2096: [ZEPPELIN-2194] precode for PySparkInterpreter

2017-03-05 Thread tinkoff-dwh

GitHub user tinkoff-dwh opened a pull request:

https://github.com/apache/zeppelin/pull/2096

[ZEPPELIN-2194] precode for PySparkInterpreter

### What is this PR for?
Added parameter `zeppelin.pyspark.precode` to PySparkInterpreter. This is 
snippet of code which executes when interpreter initialize.

### What type of PR is it?
Feature

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2194

### How should this be tested?
1. Set parameter **zeppelin.pyspark.precode**  `precodeVar='some text'`
2. Run 
```
%pyspark
print(precodeVar)
```

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2194

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2096.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2096


commit 357ac2368a5d62597a0dbc9cd60ed83a5ec428a4
Author: Tinkoff DWH 
Date:   2017-03-03T08:06:28Z

[ZEPPELIN-2194] precode for PySparkInterpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

GitHub user sravan-s reopened a pull request:

https://github.com/apache/zeppelin/pull/2087

[ZEPPELIN-2172] Redirect to home if notebook authentication fails in 
realtime

### What is this PR for?
Redirect to home page, if a user declines the access failure message on a 
notebook

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user 
test_user3
3. Now in another tab, open the notebook with test_user1 user who has write 
permissions
4. In the original tab, have user qa_user (owner of the notebook) remove 
the write permissions from test_user1 user and grant it to some other user 
test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an 
error message
6. On click of close button, UI should redirect to homepage


### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2087


commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess 
Date:   2017-03-01T15:11:39Z

[ZEPPELIN-2172] Redirect to home if auth fails

If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

Github user sravan-s closed the pull request at:

https://github.com/apache/zeppelin/pull/2087


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread sravan-s

Github user sravan-s commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
Yes, I have setup my travis. It got triggered and is green when I raised a 
PR to my fork's master branch(the master branch isn't modified) 
https://travis-ci.org/sravan-s/zeppelin/builds/206654715


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

GitHub user sravan-s reopened a pull request:

https://github.com/apache/zeppelin/pull/2087

[ZEPPELIN-2172] Redirect to home if notebook authentication fails in 
realtime

### What is this PR for?
Redirect to home page, if a user declines the access failure message on a 
notebook

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-2172](https://issues.apache.org/jira/browse/ZEPPELIN-2172)
### How should this be tested?
1. Create a notebook with qa_user user as the owner
2. Give write permissions to user test_user1, and read permissions to user 
test_user3
3. Now in another tab, open the notebook with test_user1 user who has write 
permissions
4. In the original tab, have user qa_user (owner of the notebook) remove 
the write permissions from test_user1 user and grant it to some other user 
test_user5.
5. Goto the other tab where user test_user1 was logged in. It shows an 
error message
6. On click of close button, UI should redirect to homepage


### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2172

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2087.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2087


commit b73cc7364bf0121ff26a7599198f7365cccad92c
Author: ess_ess 
Date:   2017-03-01T15:11:39Z

[ZEPPELIN-2172] Redirect to home if auth fails

If someone restricts the access to a notebook in
realtime, show proper error messsage. If user
chooses not to login, redirect to home page




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2087: [ZEPPELIN-2172] Redirect to home if notebook au...

2017-03-05 Thread sravan-s

Github user sravan-s closed the pull request at:

https://github.com/apache/zeppelin/pull/2087


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2087: [ZEPPELIN-2172] Redirect to home if notebook authentic...

2017-03-05 Thread AhyoungRyu

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/2087
  
@sravan-s Good catch! Tested as you described and it works well.
If your own account CI has been passed, you can make this PR to green light 
by closing & reopening it :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

66 matches

Mail list logo