[GitHub] zeppelin issue #2337: ZEPPELIN-2530: Zeppelin user impersonation with domain...

2017-05-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2337
  
Thank you @VipinRathor, @Leemoonsoo  for the review.
@felixcheung Does this looks OK?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2330: [minor] Remove incorrect configuration and fix descrip...

2017-05-12 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2330
  
Merging this if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2325: [ZEPPELIN-2516] Set offset, tolerance for navbar, acti...

2017-05-12 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2325
  
@soralee please help review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2335: [ZEPPELIN-2426] Improve graph setting DOMs

2017-05-12 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2335
  
@soralee please help review this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Prefix not found when using hive

2017-05-12 Thread Jeff Zhang
The following code would cause this error. Looking at the code, seems
zeppelin would not parse the text in parentheses, can anyone confirm
whether this is a bug ? And the document seems still using the parentheses
syntax.
https://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/interpreter/jdbc.html


%jdbc(hive)

select * from test


[image: image.png]


[jira] [Created] (ZEPPELIN-2541) Parse paragraph text when it is updated rather than do it many times

2017-05-12 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2541:


 Summary: Parse paragraph text when it is updated rather than do it 
many times
 Key: ZEPPELIN-2541
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2541
 Project: Zeppelin
  Issue Type: Improvement
  Components: zeppelin-zengine
Affects Versions: 0.7.1
Reporter: Jeff Zhang
Assignee: Jeff Zhang


We do many times of parsing text, such as getRequiredReplName, getScriptBody, 
getMagic. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...

2017-05-12 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2333
  
Is this HDFS or  WebHDFS protocol?





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2539) /api/login called recursively for role based auth on login

2017-05-12 Thread Sohaib Iftikhar (JIRA)
Sohaib Iftikhar created ZEPPELIN-2539:
-

 Summary: /api/login called recursively for role based auth on login
 Key: ZEPPELIN-2539
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2539
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Affects Versions: 0.7.1
Reporter: Sohaib Iftikhar


Consider a scenario where a zeppelin-server secured using shiro and needs to 
permit access to the web interfact to a select group of user using ldap groups. 
The following shiro.ini should work in such a scenario.

```
[main]
ldapRealm = org.apache.zeppelin.realm.LdapRealm
ldapRealm.userDnTemplate = uid={0},ou=people,dc=my-company,dc=net
ldapRealm.searchBase = dc=my-company,dc=net
ldapRealm.userSearchBase = ou=people,dc=my-company,dc=net
ldapRealm.groupSearchBase = ou=groups,dc=my-company,dc=net
ldapRealm.contextFactory.url = ldaps://auth.my-company:636
ldapRealm.contextFactory.authenticationMechanism = simple
ldapRealm.userObjectClass = posixAccount
ldapRealm.groupObjectClass = posixGroup
ldapRealm.authorizationEnabled = true
ldapRealm.memberAttribute = memberUid
ldapRealm.memberAttributeValueTemplate=uid={0},ou=people,dc=my-company,dc=unbelievable-machine,dc=net
ldapRealm.rolesByGroup = USERS:admin
ldapRealm.userSearchAttributeName = uid
sessionManager = org.apache.shiro.web.session.mgt.DefaultWebSessionManager
shiro.loginUrl = /api/login
securityManager.sessionManager = $sessionManager
securityManager.sessionManager.globalSessionTimeout = 8640
securityManager.realms = $ldapRealm

[roles]
admin = *

[urls]
/api/version = anon
/** = authc, roles[admin]
```

On trying to log in the /api/login gets a 302 redirect to itself and fails. 
This works fine when the roles condition is removed. A workaround for such a 
scenario is:

```
/api/login = authc
/api/login/logout = authc
/api/security/ticket = authc, roles[admin] #To also secure websockets
/** = authc, roles[admin]
```

In this case the user can login but cannot use any api calls if he is part of 
the group however on first login (before refreshing or call to 
/security/ticket) the websockets still work and hence this is not foolproof.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2337: ZEPPELIN-2530: Zeppelin user impersonation with domain...

2017-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2337
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2538) Rewrite SQl completer to work with large data

2017-05-12 Thread Tinkoff DWH (JIRA)
Tinkoff DWH created ZEPPELIN-2538:
-

 Summary: Rewrite SQl completer to work with large data
 Key: ZEPPELIN-2538
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2538
 Project: Zeppelin
  Issue Type: Improvement
  Components: interpreter-auto-completion, Interpreters
Reporter: Tinkoff DWH
Assignee: Tinkoff DWH






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2274
  
LGTM and merge to master if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2327: [ZEPPELIN-2520] DON'T set bottom margin for markdown t...

2017-05-12 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2327
  
LGTM and merge to master if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]

2017-05-12 Thread sohaibiftikhar
Github user sohaibiftikhar commented on the issue:

https://github.com/apache/zeppelin/pull/932
  
So I figured out what was happening. The problem was with my shiro.ini as I 
had not assigned a session manager.
`securityManager.sessionManager = $sessionManager`
After assigning this it works fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2274: [ZEPPELIN-2388] Improve the keyboard shortcuts dialog

2017-05-12 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2274
  
Ping!
And this CI fail is irrelevant this PR.
```
Tests in error: 
  SecurityRestApiTest.testGetUserList:69 » JsonSyntax 
java.lang.IllegalStateExce...
  SecurityRestApiTest.testTicket:55 » JsonSyntax 
java.lang.IllegalStateException...
Tests run: 58, Failures: 5, Errors: 2, Skipped: 1
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro

2017-05-12 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2239
  
Ping!
And this CI fail is irrelevant this PR.
```
Tests in error: 
  SecurityRestApiTest.testGetUserList:69 » JsonSyntax 
java.lang.IllegalStateExce...
  SecurityRestApiTest.testTicket:55 » JsonSyntax 
java.lang.IllegalStateException...
Tests run: 58, Failures: 5, Errors: 2, Skipped: 1
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2327: [ZEPPELIN-2520] DON'T set bottom margin for markdown t...

2017-05-12 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2327
  
Tested and it's work well.
My result are exactly same the above `after and before` screenshots.
LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Reverse commit of 15ecbb49db17f3938ca0b4d584193354ff243429

2017-05-12 Thread Jongyoul Lee
Hi dev,

Recently, Ci has failed because some profiles changed. It's necessary to
enable it but now some tests fails. Then, we revert it first, fix that
problem and merge it later.

Regards,
Jongyoul Lee

-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net


[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

2017-05-12 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2309
  
In `Font size and clone` and firefox browser case, I tested and it's work 
well. LGTM.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...

2017-05-12 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2300
  
Thanks for your opinion. Then I'll revert it. Please reopen this PR and 
rebase it from current master.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...

2017-05-12 Thread hayssams
Github user hayssams commented on the issue:

https://github.com/apache/zeppelin/pull/2333
  
@felixcheung  
HDFSCommand exists without the prefix Web since the beginning



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2537) SecurityRestApiTest Test fails in Zeppelin Server project

2017-05-12 Thread Pravin Dsilva (JIRA)
Pravin Dsilva created ZEPPELIN-2537:
---

 Summary: SecurityRestApiTest Test fails in Zeppelin Server project
 Key: ZEPPELIN-2537
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2537
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-server
Affects Versions: 0.8.0
 Environment: $ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=14.04
DISTRIB_CODENAME=trusty
DISTRIB_DESCRIPTION="Ubuntu 14.04.5 LTS"

$ uname -a
Linux 9efcdb4d8880 3.19.0-37-generic #42-Ubuntu SMP Fri Nov 20 18:22:05 UTC 
2015 x86_64 x86_64 x86_64 GNU/Linux
Reporter: Pravin Dsilva


---
Test set: org.apache.zeppelin.rest.SecurityRestApiTest
---
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 131.195 sec <<< 
FAILURE! - in org.apache.zeppelin.rest.SecurityRestApiTest
testGetUserList(org.apache.zeppelin.rest.SecurityRestApiTest)  Time elapsed: 
0.065 sec  <<< ERROR!
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected 
BEGIN_OBJECT but was STRING at line 1 column 7
at com.google.gson.stream.JsonReader.expect(JsonReader.java:339)
at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:322)
at 
com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:184)
at 
com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:146)
at com.google.gson.Gson.fromJson(Gson.java:791)
at com.google.gson.Gson.fromJson(Gson.java:757)
at com.google.gson.Gson.fromJson(Gson.java:706)
at 
org.apache.zeppelin.rest.SecurityRestApiTest.testGetUserList(SecurityRestApiTest.java:69)

testTicket(org.apache.zeppelin.rest.SecurityRestApiTest)  Time elapsed: 0.034 
sec  <<< ERROR!
com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected 
BEGIN_OBJECT but was STRING at line 1 column 7
at com.google.gson.stream.JsonReader.expect(JsonReader.java:339)
at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:322)
at 
com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:184)
at 
com.google.gson.internal.bind.MapTypeAdapterFactory$Adapter.read(MapTypeAdapterFactory.java:146)
at com.google.gson.Gson.fromJson(Gson.java:791)
at com.google.gson.Gson.fromJson(Gson.java:757)
at com.google.gson.Gson.fromJson(Gson.java:706)
at 
org.apache.zeppelin.rest.SecurityRestApiTest.testTicket(SecurityRestApiTest.java:55)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2300: [ZEPPELIN-2467] Restoring second travis job functional...

2017-05-12 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue:

https://github.com/apache/zeppelin/pull/2300
  
I think we should revert this commit then. I won't be able to fix it fast.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2337: ZEPPELIN-2530: Zeppelin user impersonation with domain...

2017-05-12 Thread VipinRathor
Github user VipinRathor commented on the issue:

https://github.com/apache/zeppelin/pull/2337
  
Looks good to me. +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---