[GitHub] zeppelin issue #2348: ZEPPELIN-2555: Run all paragraphs API does not run all...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2348 @1ambda Thank you for reviewing this. @zjffdu Yes make sense, let's start a different thread, discuss and fix it there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2250: [WIP][ZEPPELIN-2085] Interpret scala code in paste mod...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2250 +1 for not splitting scala code in zeppelin side, that should be handled by scala repl. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2348: ZEPPELIN-2555: Run all paragraphs API does not run all...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2348 I was thinking that we should add test for the rest api. And we should create a test framework to make the test easier. Otherwise it is easy to break the api. And this is not the first time I see the rest api broken. But anyway we could do it in a separated ticket. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2344: [ZEPPELIN-2545] [ZEPPELIN-2546] SecurityRestApiTest, N...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2344 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2348: ZEPPELIN-2555: Run all paragraphs API does not run all...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2348 Tested and works as described. LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: What is the user case for remote of interpreter option is false
Sure Jongyoul, go ahead. Jongyoul Lee于2017年5月13日周六 上午10:19写道: > I have tried to remove it for a while but someone claims he has used it. > Make it again and try to review it! It can also remove some logic in > interpreterFactory, too. May I handle it? > > On Thu, May 11, 2017 at 7:53 AM, Jeff Zhang wrote: > > > ClassloaderInterpreter could also be removed. > > > > > > Jeff Zhang 于2017年5月10日周三 下午3:39写道: > > > > > > > > Hi moon > > > > > > Considering we use remote=true for interpreters now, and seems no user > > > complain about that. So I think we could remove it completely. Agree > with > > > you that It could make code simpler, e.g. We don't need to check to use > > > RemoteAngularObjectRegistry or AngularObjectRegistry. > > > > > > > > > https://github.com/apache/zeppelin/blob/master/zeppelin- > > server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java#L1458 > > > > > > > > > > > > Jeff Zhang 于2017年5月8日周一 下午6:15写道: > > > > > >> Although it can bring some benefits, but there are 2 disadvantages for > > >> remote=false as I can think of > > >> > > >> 1. The interpreter log would mix with zeppelin server log. This may > > cause > > >> diagnosing difficult, markdown might be OK, but I am afraid it would > be > > a > > >> problem for jdbc interpreter. > > >> 2. Extra memory consumption. This might be a problem for jdbc > > interpreter > > >> when it gets large amount of data from database. > > >> > > >> > > >> > > >> moon soo Lee 于2017年5月8日周一 下午5:27写道: > > >> > > >>> The option is legacy and being used in few unit tests as far as i > > >>> remember. > > >>> > > >>> I think we can either try completely remove this code (to keep code > > base > > >>> simple) or we can try re-introduce this feature (to optimize resource > > >>> usage, less restriction on data sharing between interpreters). > > >>> > > >>> I think interpreters like markdown, jdbc will have no big problem > with > > >>> remote=false while Spark interpreter require separate JVM and > > remote=true > > >>> is required. > > >>> > > >>> remote=false will provide some chances to save some system resource > > >>> because > > >>> it does not run separate JVM process for interpreter. > > >>> > > >>> Also communication between interpreter (through ResourcePool) can be > > much > > >>> faster and have less restricted on object serialization. > > >>> > > >>> So remote=false option definitely provides some advantages. > > >>> However, keeping code base for remote=false and remote=true > introduces > > >>> more > > >>> work. > > >>> > > >>> What do you think? > > >>> > > >>> Thanks, > > >>> moon > > >>> > > >>> On Mon, May 8, 2017 at 8:13 PM Jeff Zhang wrote: > > >>> > > >>> > I see all the interpreter setting set remote of interpreter option > as > > >>> true, > > >>> > and didn't find any false case in interpreter-setting.json, does > > anyone > > >>> > know what is the use case of remote of interpreter option is false. > > Is > > >>> this > > >>> > a legacy mode that should be removed ? > > >>> > > > >>> > > > >>> > > > >>> https://github.com/apache/zeppelin/blob/master/zeppelin- > > zengine/src/main/java/org/apache/zeppelin/interpreter/ > > InterpreterSettingManager.java#L183 > > >>> > > > >>> > > >> > > > > > > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net >
[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/1663 Does this feature work for anyone who is using Spark on YARN? It seems to be broken by https://issues.apache.org/jira/browse/SPARK-20772 I've updated https://issues.apache.org/jira/browse/ZEPPELIN-2221 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2348: ZEPPELIN-2555: Run all paragraphs API does not ...
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2348 ZEPPELIN-2555: Run all paragraphs API does not run all paragraph as front-end user. ### What is this PR for? Run all paragraphs API (http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/rest-api/rest-notebook.html#run-all-paragraphs) does not run all paragraph as front-end user. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * [ZEPPELIN-2555](https://issues.apache.org/jira/browse/ZEPPELIN-2555) ### How should this be tested? Testing steps in screenshot ### Screenshots (if appropriate) Before: ![zeppelin-2555-before](https://cloud.githubusercontent.com/assets/674497/26120584/d9990846-3a8e-11e7-897b-754e2075ddc6.gif) After: ![zeppelin-2555-after](https://cloud.githubusercontent.com/assets/674497/26120391/38ba4b2e-3a8e-11e7-9a0c-c214dbc416e4.gif) ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2555 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2348.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2348 commit 13350c2f9ac00bb9d94e097170610cd6ae9b013e Author: Prabhjyot SinghDate: 2017-05-16T17:48:56Z add runAll(AuthenticationInfo authenticationInfo) methond --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2556) NPE in HeliumVisualizationFactory
Simeon H.K. Fitch created ZEPPELIN-2556: --- Summary: NPE in HeliumVisualizationFactory Key: ZEPPELIN-2556 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2556 Project: Zeppelin Issue Type: Bug Components: helium Affects Versions: 0.7.0 Environment: Docker image `dylanmei/zeppelin:0.7.0` Reporter: Simeon H.K. Fitch Not sure what's causing it. Zeppelin runs fine except for no entries in the Helium page. ``` java.lang.NullPointerException: null at org.apache.zeppelin.helium.HeliumVisualizationFactory.bundle(HeliumVisualizationFactory.java:230) at org.apache.zeppelin.helium.HeliumVisualizationFactory.bundle(HeliumVisualizationFactory.java:98) at org.apache.zeppelin.server.ZeppelinServer.(ZeppelinServer.java:129) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createSingletonInstance(CXFNonSpringJaxrsServlet.java:382) at org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createApplicationInstance(CXFNonSpringJaxrsServlet.java:454) at org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.createServerFromApplication(CXFNonSpringJaxrsServlet.java:432) at org.apache.cxf.jaxrs.servlet.CXFNonSpringJaxrsServlet.init(CXFNonSpringJaxrsServlet.java:93) at org.eclipse.jetty.servlet.ServletHolder.initServlet(ServletHolder.java:616) at org.eclipse.jetty.servlet.ServletHolder.initialize(ServletHolder.java:396) at org.eclipse.jetty.servlet.ServletHandler.initialize(ServletHandler.java:871) at org.eclipse.jetty.servlet.ServletContextHandler.startContext(ServletContextHandler.java:298) at org.eclipse.jetty.webapp.WebAppContext.startWebapp(WebAppContext.java:1349) at org.eclipse.jetty.webapp.WebAppContext.startContext(WebAppContext.java:1342) at org.eclipse.jetty.server.handler.ContextHandler.doStart(ContextHandler.java:741) at org.eclipse.jetty.webapp.WebAppContext.doStart(WebAppContext.java:505) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132) at org.eclipse.jetty.util.component.ContainerLifeCycle.doStart(ContainerLifeCycle.java:114) at org.eclipse.jetty.server.handler.AbstractHandler.doStart(AbstractHandler.java:61) at org.eclipse.jetty.server.handler.ContextHandlerCollection.doStart(ContextHandlerCollection.java:163) at org.eclipse.jetty.util.component.AbstractLifeCycle.start(AbstractLifeCycle.java:68) at org.eclipse.jetty.util.component.ContainerLifeCycle.start(ContainerLifeCycle.java:132) at org.eclipse.jetty.server.Server.start(Server.java:387) ``` -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ZEPPELIN-2555) Run all paragraphs API does not run all paragraph as front-end user.
Prabhjyot Singh created ZEPPELIN-2555: - Summary: Run all paragraphs API does not run all paragraph as front-end user. Key: ZEPPELIN-2555 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2555 Project: Zeppelin Issue Type: Bug Reporter: Prabhjyot Singh Assignee: Prabhjyot Singh Run all paragraphs API (http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/rest-api/rest-notebook.html#run-all-paragraphs) does not run all paragraph as front-end user. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin pull request #2339: [ZEPPELIN-2430] The xAxis text in the line and ...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2339 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2342: [ZEPPELIN-2467] Restore travis second job functionalit...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2342 Merge to master if no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2322 I reverted back modifications to concurrency management since it looks like they result in Ui response instability, I'm not sure why this happens, I believe that we can conclude with a clean PR like this. In case I manage to refactor and use proper `java.util.concurrent` into `remote` I will send another PR. WDYT? @Leemoonsoo @felixcheung --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backsl...
GitHub user tinkoff-dwh opened a pull request: https://github.com/apache/zeppelin/pull/2347 [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash) ### What is this PR for? Fix of parser to correctly parse backslash in quotes. ### What type of PR is it? Bug Fix ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Execute `select '\n', ';'` ### Screenshots (if appropriate) before ![before](https://cloud.githubusercontent.com/assets/25951039/26098731/14562fa6-3a42-11e7-8361-5869cbfb42d3.png) text is parsed as 2 queries `select '\n', '` and `'` after ![after](https://cloud.githubusercontent.com/assets/25951039/26098738/18adbaa6-3a42-11e7-97c9-9412de556883.png) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2554 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2347.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2347 commit 3951aa7053e3b33a0288eac879506845b03a1ca7 Author: Tinkoff DWHDate: 2017-05-16T07:29:56Z [ZEPPELIN-2554] sql parser fix (backslash) commit af508f1ca4fbd6765175d01a454b54893054f3bc Author: Tinkoff DWH Date: 2017-05-16T09:19:51Z [ZEPPELIN-2554] fix tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2341: ZEPPELIN-2543: Add ability to change the log level at ...
Github user karuppayya commented on the issue: https://github.com/apache/zeppelin/pull/2341 Checked the page, And i see a build had ran . Not sure why *jenkin* shows a x icon in github page, though the build runs. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2338: [ZEPPELIN-2122] Add execution time for Spell
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2338 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2333: Notebook: (Web) HDFS as a backend storage (Read & Writ...
Github user hayssams commented on the issue: https://github.com/apache/zeppelin/pull/2333 @felixcheung Do you want me to update the docs and the code or the docs only ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2337: ZEPPELIN-2530: Zeppelin user impersonation with...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2337 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Sorry for delayed response. Rerun of failed job passed. I have also addressed all the PR comments. Let me know if anything more is needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2554) Incorrect parsing sql with anti slash
Tinkoff DWH created ZEPPELIN-2554: - Summary: Incorrect parsing sql with anti slash Key: ZEPPELIN-2554 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2554 Project: Zeppelin Issue Type: Bug Reporter: Tinkoff DWH Assignee: Tinkoff DWH -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin issue #2345: [MINOR] Hide pagination button if there is only 1 page...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2345 Tested and I'd like to leave a comment for I found [bug which it's same](https://github.com/apache/zeppelin/pull/2346#issuecomment-301693168). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2346: [gh-pages] Hide pagination btn if there is only 1 page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2346 Nicely Improvement it, Thanks @AhyoungRyu! But, tested and I found a bug which if I moved a last page, the page buttons is disappeared so, I couldn't move to before pages. I attached the following screenshot. [Before] ![before_page_number](https://cloud.githubusercontent.com/assets/8110458/26093280/2ac4887e-3a50-11e7-9fa8-a183f53c1ef2.gif) [After] ![after_page_number](https://cloud.githubusercontent.com/assets/8110458/26093284/2f0728f6-3a50-11e7-866b-8ebbdd15834d.gif) Could you confirm this problem? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---