[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport
Github user vipul1409 commented on the issue: https://github.com/apache/zeppelin/pull/2326 Fixed all the issues and the tests have also passed. Please let me know if any more details are needed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2352: [ZEPPELIN-2570] fix: indistinguishable director...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2352 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2355: [ZEPPELIN-2573] Improve navbar style
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2355 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement] ### Todos * [x] - Fix nav brand text font-size * [x] - Fix nav menu text font-weight * [x] - Removed icon for search input * [x] - Fix bug in notebook menu (focus state remains after it's closed) ### What is the Jira issue? [ZEPPELIN-2573](https://issues.apache.org/jira/browse/ZEPPELIN-2573) ### How should this be tested? 1. Build Zeppelin: ` mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open the main page ### Screenshots (if appropriate) Before: Navbar Style  After: Navbar Style  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2573/improve-navbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2355 commit cbe7390934ab651b20ed86a1b211e2a822f3d0b8 Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T19:29:28Z fix: Move navbar related style to navbar.css commit b936b8a2c75aa550e8f85906e07f7b2d74bb1dcb Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T21:28:42Z feat: Set font style in navbar commit 20364dfcb341b42327363b00f0d16a51cb4d5eed Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:22:10Z fix: Update search input in navbar commit 55a7aad5ef397a7463bfb515a0c9b3f93ad87bd3 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:30:57Z fix: Move username related css into navbar commit 3cbcf952d9ee45e28bcbece258d5bacbebdcc25b Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:45:30Z fix: DON'T use :focus for notebook menu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2268 IMO, It's ok if we are not going to add other types like `JSON` which can be `type` and used for other widgets (e.g `textarea`, ...) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement] ### Todos * [x] - Fix nav brand text font-size * [x] - Fix nav menu text font-weight * [x] - Removed icon for search input * [x] - Fix bug in notebook menu (focus state remains after it's closed) ### What is the Jira issue? [ZEPPELIN-2573](https://issues.apache.org/jira/browse/ZEPPELIN-2573) ### How should this be tested? 1. Build Zeppelin: ` mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open the main page ### Screenshots (if appropriate) Before: Navbar Style  After: Navbar Style  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2573/improve-navbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2355 commit cbe7390934ab651b20ed86a1b211e2a822f3d0b8 Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T19:29:28Z fix: Move navbar related style to navbar.css commit b936b8a2c75aa550e8f85906e07f7b2d74bb1dcb Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T21:28:42Z feat: Set font style in navbar commit 20364dfcb341b42327363b00f0d16a51cb4d5eed Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:22:10Z fix: Update search input in navbar commit 55a7aad5ef397a7463bfb515a0c9b3f93ad87bd3 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:30:57Z fix: Move username related css into navbar commit 3cbcf952d9ee45e28bcbece258d5bacbebdcc25b Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:45:30Z fix: DON'T use :focus for notebook menu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2355 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2349 Yes, we can split. Then, - Let's make CI green - I left one comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2355: [ZEPPELIN-2573] Improve navbar style
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2355 [ZEPPELIN-2573] Improve navbar style ### What is this PR for? Improved navbar style. Refer the screenshots for detail. ### What type of PR is it? [Improvement] ### Todos * [x] - Fix nav brand text font-size * [x] - Fix nav menu text font-weight * [x] - Removed icon for search input * [x] - Fix bug in notebook menu (focus state remains after it's closed) ### What is the Jira issue? [ZEPPELIN-2573](https://issues.apache.org/jira/browse/ZEPPELIN-2573) ### How should this be tested? 1. Build Zeppelin: ` mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. Open the main page ### Screenshots (if appropriate) Before: Navbar Style  After: Navbar Style  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2573/improve-navbar Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2355.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2355 commit cbe7390934ab651b20ed86a1b211e2a822f3d0b8 Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T19:29:28Z fix: Move navbar related style to navbar.css commit b936b8a2c75aa550e8f85906e07f7b2d74bb1dcb Author: 1ambda <1am...@gmail.com> Date: 2017-05-19T21:28:42Z feat: Set font style in navbar commit 20364dfcb341b42327363b00f0d16a51cb4d5eed Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:22:10Z fix: Update search input in navbar commit 55a7aad5ef397a7463bfb515a0c9b3f93ad87bd3 Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:30:57Z fix: Move username related css into navbar commit 3cbcf952d9ee45e28bcbece258d5bacbebdcc25b Author: 1ambda <1am...@gmail.com> Date: 2017-05-20T14:45:30Z fix: DON'T use :focus for notebook menu --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2268 looks good. initially, the idea with the type well, as the type indicated the type of the stored value (widget is pointing to), but **password** all broke) @1ambda what do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry
Github user necosta commented on the issue: https://github.com/apache/zeppelin/pull/2349 @1ambda , thanks for the quick feedback :) This ticket has related ticket ZEPPELIN-2152 which has a recent comment related to your question: https://github.com/NohSeho/zeppelin/commit/032e120d06436e8b6c6b3b881efd20ba2c828fb2 Not sure what is the status of it (if under review or not proposed as a pull request yet) but I think we can separate issues. This is, this ticket to configure the call to a repository manager, ticket ZEPPELIN-2152 to handle proxy configuration. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2125: [ZEPPELIN-2222] Add Network Visualization
Github user conker84 commented on the issue: https://github.com/apache/zeppelin/pull/2125 @jongyoul this contribution is the result of the split of #1582 in two little PR; the classes under `org.apache.zeppelin.interpreter.graph` provide the basic abstraction that can be used by graph dbs (like Neo4j, OrientDB, ArangoDB etc...) or graph processing frameworks (like GraphX or Giraph) and they will be used by the second part of the contribution which is the Neo4j interpreter, if you think is more appropriate I can move these classes into the second contribution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2227: [ZEPPELIN-2359] Support Spell as Display
Github user echarles commented on the issue:
https://github.com/apache/zeppelin/pull/2227
@1ambda thx a lot for the follow-up and your great work.
This branch now supports what we want:
```
println("""%json
{"array":[1,2,3],"boolean":true,"null":null,"number":123,"object":{"a":"b","c":"d","e":"f"},"string":"Hello
World"}""")
```
I would be great if you could test it and give me any feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2354 thanks for clarification, then i may look into #932 as well, and after finalising that we can rebase this one --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...
Github user sohaibiftikhar commented on the issue: https://github.com/apache/zeppelin/pull/2354 @khalidhuseynov At front it seems that the issues are unrelated however for reasons I do not know #2182 is triggered when using the LdapRealm for me. #932 fixes that issue and hence for testing my build with this option I had included the changes for that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2354 @sohaibiftikhar thanks for adding option for authentication with role check, I was wondering if these changes are related to the issue in #932, from first look seems a bit unrelated and i would assume it should work from master as well, WDYT? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
