[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
single mode is default and the user will always get an incorrect result if 
he writes multiple queries to in paragraph


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
Which I think is fine, because in that case, we will not try to use this 
logic, and at least there will be a workaround if the user is facing any 
problem because of this issue, and we can have a document for this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
@felixcheung   @prabhjyotsingh 
have a problem with single mode, if user execute multiple queries (all text 
executes as single query) then result set is incorrect. 

I think this setting is redundant. If the user wants to execute single 
query, he can write a single query


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2145: [ZEPPELIN-2271] encoding password of credential...

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at:

https://github.com/apache/zeppelin/pull/2145


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2317: [ZEPPELIN-2493] Visualization class should thro...

2017-05-22 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2317


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2577) No graphs visible on IE 11

2017-05-22 Thread Danish Khan (JIRA)
Danish Khan created ZEPPELIN-2577:
-

 Summary: No graphs visible on IE 11
 Key: ZEPPELIN-2577
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2577
 Project: Zeppelin
  Issue Type: Bug
  Components: GUI
Affects Versions: 0.7.1
Reporter: Danish Khan
Priority: Blocker
 Fix For: 0.7.2


On IE 11, table is shown in notebook, but clicking on graph does not render the 
graph. Following error is seen in browser console: 

TypeError: Object doesn't support property or method 'endsWith'
   at value (http://psrlxidldev1:8080/app.4ece19b57e6fb1511450.js:1:26463)
   at n (http://psrlxidldev1:8080/app.4ece19b57e6fb1511450.js:4:3696)
   at Anonymous function 
(http://psrlxidldev1:8080/scripts/vendor.ee876a1abacbe752.js:38:17267)
   at e (http://psrlxidldev1:8080/scripts/vendor.ee876a1abacbe752.js:36:22487)
   at Anonymous function 
(http://psrlxidldev1:8080/scripts/vendor.ee876a1abacbe752.js:36:23940)





--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
yes for interpreter settings


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2357: [ZEPPELIN-2429] Improve `import notebook` dialo...

2017-05-22 Thread 1ambda
GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/2357

[ZEPPELIN-2429] Improve `import notebook` dialog style

### What is this PR for?

Improve `import notebook` dialog style. See the attached screenshots.

### What type of PR is it?
[Improvement]

### Todos

DONE

### What is the Jira issue?

[ZEPPELIN-2429](https://issues.apache.org/jira/browse/ZEPPELIN-2429)

### How should this be tested?

1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
2. Run Zeppelin and open browser: `localhost:8080`
3. `import notebook` functionality should work as like before.

### Screenshots (if appropriate)

 Before


![image](https://cloud.githubusercontent.com/assets/4968473/26281995/816eed22-3e42-11e7-8ec5-8bca9f54f919.png)


 After


![image](https://cloud.githubusercontent.com/assets/4968473/26281990/6f8df684-3e42-11e7-8fe5-df6f964e5921.png)


![image](https://cloud.githubusercontent.com/assets/4968473/26281992/74732f52-3e42-11e7-8d40-5083e63c7714.png)


### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin improve-import-dialog

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2357


commit c46516b2f17dccbd9a4c48c6d675d9ad1d78c4d0
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T02:44:24Z

feat: Use note-import-dialog.css

commit 85ecc1062b943e33ceed3eef29488eeada9e34a3
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T02:46:07Z

style: Reformat note import dialog html

commit 2c868c73c6f5c40201a8c85ce9cc6219a656c35e
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T02:47:53Z

feat: Style note import dialog header

commit df702c460724e931ea2682724aece127c10f6514
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T07:16:51Z

feat: Style import dialog body

commit 84251136e9ea7cb6248f52bc16c1a5b8ae2757a3
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T07:29:10Z

fix: Use uppercase for placeholder

commit 95666b43f1e603c861520a0c915faacdf2caf73a
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-21T07:41:52Z

fix: RAT issue

commit 8b966af92132842f5b49efc5cb34f689dcd1a9fe
Author: 1ambda <1am...@gmail.com>
Date:   2017-05-22T09:29:16Z

fix: Set padding, border radius




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-22 Thread necosta
Github user necosta commented on the issue:

https://github.com/apache/zeppelin/pull/2349
  
@1ambda, latest updates:
 - Renamed "registry" to "installer.url" as suggested in your comment
 - Fixed CI
 - "ZEPPELIN-2214 is about setting proxy for Helium. But Actually, this PR 
it not related with proxy itself. Just for configurable URLs." - True in a 
way... Should I create a new ticket? Or should we update ZEPPELIN-2214 
description? What do you suggest? Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
@Leemoonsoo 
done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2309: [ZEPPELIN-2482] added font size for paragraph

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2309
  
Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2357: [ZEPPELIN-2429] Improve `import notebook` dialog style

2017-05-22 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2357
  
LGTM!


![image](https://cloud.githubusercontent.com/assets/8110458/26305492/750c4c58-3f2a-11e7-92a3-1809160a790b.png)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2576) dynamic querying of Temp Table in Spark R returns Error: is.character(x) is not TRUE

2017-05-22 Thread Prasanth (JIRA)
Prasanth created ZEPPELIN-2576:
--

 Summary: dynamic querying of Temp Table in Spark R returns Error: 
is.character(x) is not TRUE
 Key: ZEPPELIN-2576
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2576
 Project: Zeppelin
  Issue Type: Bug
  Components: r-interpreter
Affects Versions: 0.7.1
 Environment: AWS Ubuntu 16.04 Spark 2.1.1
Reporter: Prasanth


I store a temptable in PySpark, which I query in sparkR based the value 
selected as follows:

I have a select in Pyspark, where I choose the state:
{quote}
df.registerTempTable("Tble_State")
selectedState =  z.select("Select Store: " states)
z.put("selectedState",selectedState)
{quote}

I access the *selectedState*  in SparkR and query:
{quote}
state = z.get("selectedState")
query = paste("select * from tableState where state =",state)
dfState = sql(sqlContext,query)
{quote}

The above Spark R code works for the first time, but fails when run again and 
throws the following error:
{quote}
Error: is.character\(x\) is not TRUE
{quote}



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2359: [ZEPPELIN-2575] Improve `rename note` dialog style

2017-05-22 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2359
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...

2017-05-22 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2361
  
@1ambda Thanks for checking and improvement this!
Let me test it out ASAP!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2362: [ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travi...

2017-05-22 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue:

https://github.com/apache/zeppelin/pull/2362
  
We also need to enable the `HeliumBundleFactoryTest` on CI by removing it 
from `-Dtests.to.exclude` variable in `.travis.yml`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2362: [ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travi...

2017-05-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2362
  
@pravin-dsilva Thanks for the contribution. 

To enable jenkins, you have to setup your own travis for your zeppelin fork 
repository.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in focuse...

2017-05-22 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2361
  
@soralee updated.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2362: [ZEPPELIN-2469] HeliumBundleFactoryTest fails o...

2017-05-22 Thread pravin-dsilva
GitHub user pravin-dsilva opened a pull request:

https://github.com/apache/zeppelin/pull/2362

[ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis

### What is this PR for?
There are 6 errors occuring with error: "yarn config set cache-folder 
/tmp/ZeppelinLTest_1494573109020/helium-bundle/yarn-cache 
--registry=http://registry.npmjs.org/' failed."
The failures seem to occur because the "yarnCacheDir" directory is not 
created. For this, I have added code to create the directory before the 
absolute path is stored in yarnCacheDirPath. 

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2469

### How should this be tested?
The tests should pass on the CI

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pravin-dsilva/zeppelin ZEPPELIN-2469

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2362.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2362


commit a045ff6d7ce87550bab423c776c490fef8179a8b
Author: pravin-dsilva 
Date:   2017-05-22T06:45:23Z

[ZEPPELIN-2469] HeliumBundleFactoryTest fails on Travis




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
IMO property in settings of interpreter makes more sense, with a bit of a 
documentation on how to enable/disable it.
cc: @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
@prabhjyotsingh 
checkbox (for paragraph) which indicates to parse the request or not?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
Tested this on local, looks OK. 

Can you also implement this comment 
https://github.com/apache/zeppelin/pull/2347#issuecomment-302747859, i.e. 
default to single query with a switch to make multiple queries work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2347: [Bug Fix][ZEPPELIN-2554] sql parser fix (backslash)

2017-05-22 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2347
  
@prabhjyotsingh 
fixed problems


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---