[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2386 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2386 [ZEPPELIN-2603] fix: Broken Paragraph Title ### What is this PR for? Paragraph titles are split into multiple lines when they are long. - let's applying text-overflow like the note title. - while making paragraph titles have fixed height for seamless title hiding/showing ### What type of PR is it? [Bug Fix | Improvement] ### Todos * [x] - text-overflow for paragraph titles * [x] - fixed height for paragraph titles. ### What is the Jira issue? [ZEPPELIN-2603](https://issues.apache.org/jira/browse/ZEPPELIN-2603) ### How should this be tested? 1. build 2. open any note 3. show / hide a paragraph title 4. insert long a paragraph title. ### Screenshots (if appropriate) Before: paragraph title is split into multiple lines ![image](https://cloud.githubusercontent.com/assets/4968473/26712431/cf229196-47a1-11e7-9b6e-473f1006c743.png) Before: enabling paragraph title has an effect on the height of a paragraph. ![2603_before](https://cloud.githubusercontent.com/assets/4968473/26712476/fd3b618e-47a1-11e7-8a00-3720d46c9ecc.gif) After: enabling / disalbing a paragraph title seamlessly ![2603_after](https://cloud.githubusercontent.com/assets/4968473/26712410/b868b7f0-47a1-11e7-9079-41f160ab7770.gif) After: text-overflow for a paragraph title ![image](https://cloud.githubusercontent.com/assets/4968473/26712357/7bd02616-47a1-11e7-9912-0463fd3a7565.png) ![image](https://cloud.githubusercontent.com/assets/4968473/26712364/82b1f342-47a1-11e7-8431-37a990050a82.png) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2603/fix-broken-paragraph-title Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2386 commit 1608f8b0839e602136cbb32eb9efd8a29c86abdc Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T04:14:32Z fix: use more meaningful css class names commit 01014ba9aeb3145e6bc47496bcaf1114018ba1a5 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T04:35:17Z style: reindent title related DOM commit dd5d37d23e1d8932b36456723ed56b2b50c5e64d Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T05:06:19Z fix: seamless title display with text-overflow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2386: [ZEPPELIN-2603] fix: Broken Paragraph Title
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2386 [ZEPPELIN-2603] fix: Broken Paragraph Title ### What is this PR for? Paragraph titles are split into multiple lines when they are long. - let's applying text-overflow like the note title. - while making paragraph titles have fixed height for seamless title hiding/showing ### What type of PR is it? [Bug Fix | Improvement] ### Todos * [x] - text-overflow for paragraph titles * [x] - fixed height for paragraph titles. ### What is the Jira issue? [ZEPPELIN-2603](https://issues.apache.org/jira/browse/ZEPPELIN-2603) ### How should this be tested? 1. build 2. open any note 3. show / hide a paragraph title 4. insert long a paragraph title. ### Screenshots (if appropriate) Before: paragraph title is split into multiple lines ![image](https://cloud.githubusercontent.com/assets/4968473/26712431/cf229196-47a1-11e7-9b6e-473f1006c743.png) Before: enabling paragraph title has an effect on the height of a paragraph. ![2603_before](https://cloud.githubusercontent.com/assets/4968473/26712476/fd3b618e-47a1-11e7-8a00-3720d46c9ecc.gif) After: enabling / disalbing a paragraph title seamlessly ![2603_after](https://cloud.githubusercontent.com/assets/4968473/26712410/b868b7f0-47a1-11e7-9079-41f160ab7770.gif) After: text-overflow for a paragraph title ![image](https://cloud.githubusercontent.com/assets/4968473/26712357/7bd02616-47a1-11e7-9912-0463fd3a7565.png) ![image](https://cloud.githubusercontent.com/assets/4968473/26712364/82b1f342-47a1-11e7-8431-37a990050a82.png) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2603/fix-broken-paragraph-title Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2386.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2386 commit 1608f8b0839e602136cbb32eb9efd8a29c86abdc Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T04:14:32Z fix: use more meaningful css class names commit 01014ba9aeb3145e6bc47496bcaf1114018ba1a5 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T04:35:17Z style: reindent title related DOM commit dd5d37d23e1d8932b36456723ed56b2b50c5e64d Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T05:06:19Z fix: seamless title display with text-overflow --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2384 Regarding to Promsie polyfill, we need to turn on the `useBuiltIn` option in babel-preset-env - https://github.com/babel/babel-preset-env#usebuiltins - https://github.com/babel/babel-preset-env/issues/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2384 https://github.com/apache/zeppelin/pull/2273 was merged into master only. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2354: Allow group/role based authentication using LdapRealm ...
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2354 @sohaibiftikhar i guess we can rebase it from master now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2326: [ZEPPELIN-2519] Disable watchers not in viewport
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2326 Hi @vipul1409, This PR occurs an error like ```js TypeError: Cannot read property 'create' of undefined at Object.link (http://localhost:9001/app.bundle.js:9662:52) at http://localhost:9001/bower_components/angular/angular.js:1240:18 at invokeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9814:9) at nodeLinkFn (http://localhost:9001/bower_components/angular/angular.js:9215:11) at compositeLinkFn (http://localhost:9001/bower_components/angular/angular.js:8510:13) at publicLinkFn (http://localhost:9001/bower_components/angular/angular.js:8390:30) at lazyCompilation (http://localhost:9001/bower_components/angular/angular.js:8728:25) at boundTranscludeFn (http://localhost:9001/bower_components/angular/angular.js:8527:16) at controllersBoundTransclude (http://localhost:9001/bower_components/angular/angular.js:9265:20) at ngRepeatAction (http://localhost:9001/bower_components/angular/angular.js:29607:15) ``` When I remove `viewport-watch` directive from `notebook.html`, there is no error. Could you fix it? ![image](https://cloud.githubusercontent.com/assets/4968473/26710441/d7940e48-4794-11e7-9b1f-d16462acc49e.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2384 @Leemoonsoo I think we don't need to merge this PR into master. because the master branch supports IE9+ ``` "browsers": ["last 5 version", "> 5%", "edge >= 12", "ie >= 9", "safari 7", "chrome 47", "firefox 31"] ``` - https://github.com/apache/zeppelin/blob/master/zeppelin-web/.babelrc#L8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2384 Thanks @1ambda @prabhjyotsingh for the review. Merge to master and branch-0.7 if no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #932: Replace CXF with Jersey2 [ZEPPELIN-903]
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/932 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/932 Tested and LGTM. Sorry for the late reply. I'll merge it now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2384 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2376: Branch 0.7
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2376 @simulight , Could you close this PR and create a new one ? This PR is mixed with other commits. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2611) `Notebook Search` page doesn't display searched contents
Hoon Park created ZEPPELIN-2611: --- Summary: `Notebook Search` page doesn't display searched contents Key: ZEPPELIN-2611 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2611 Project: Zeppelin Issue Type: Bug Components: front-end Reporter: Hoon Park Fix For: 0.8.0 `Notebook Search` page doesn't display searched contents. I attached screenshots. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (ZEPPELIN-2610) `Link to this paragraph` feature doesn't work at all (0.8.0-SNAPSHOT)
Hoon Park created ZEPPELIN-2610: --- Summary: `Link to this paragraph` feature doesn't work at all (0.8.0-SNAPSHOT) Key: ZEPPELIN-2610 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2610 Project: Zeppelin Issue Type: Bug Components: front-end Affects Versions: 0.8.0 Reporter: Hoon Park `Link to this paragraph` feature doesn't work at all in 0.8.0-SNAPSHOT. - OSX - the most recent Chrome - without any setting (just cloned and built Zeppelin) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...
GitHub user 1ambda reopened a pull request: https://github.com/apache/zeppelin/pull/2385 [ZEPPELIN-2609] Add missing shortcut descriptions ### What is this PR for? Add missing shortcut descriptions. Refer the *TODOs* section and attached screenshots for detail. ### What type of PR is it? [Improvement] ### Todos * [x] - Move `CTRL-N`, `CTRL-P` to the editor shortcut section. * [x] - Remove useless bottom border color. * [x] - Add missing shortcut desc `CTRL-F` and `CTRL-B` ### What is the Jira issue? [ZEPPELIN-2609](https://issues.apache.org/jira/browse/ZEPPELIN-2609) ### How should this be tested? 1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. open any notebook 3. click the keyboard shortcut dialog. ### Screenshots (if appropriate) Before ![image](https://cloud.githubusercontent.com/assets/4968473/26706040/2dd05c96-4775-11e7-8c85-39b6a5e7d2a7.png) After ![image](https://cloud.githubusercontent.com/assets/4968473/26706030/230c7bbe-4775-11e7-83f5-3f2f8e86604a.png) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2609/add-missing-shortcut-desc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2385 commit 58930fb8ca021923d6f301809a49589490fb37d4 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:16:37Z fix: Move CTRL-N,P to editor shortcut section commit 6e6ca8f0be26a0de9e1a334eeb6249951706e744 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:16:48Z style: reindent commit 9b8222e679c5d46998b6f6bd05eed4c5cdd9de12 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:17:46Z fix: Remove useless bottom sep commit 0e2d201d289a7010eb4e0e3163981a85531524da Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:20:12Z feat: Add missing shortcut desc CTRL-F,B --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...
Github user 1ambda closed the pull request at: https://github.com/apache/zeppelin/pull/2385 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2385: [ZEPPELIN-2609] Add missing shortcut descriptions
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2385 @soralee Could you help review this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2385: [ZEPPELIN-2609] Add missing shortcut descriptio...
GitHub user 1ambda opened a pull request: https://github.com/apache/zeppelin/pull/2385 [ZEPPELIN-2609] Add missing shortcut descriptions ### What is this PR for? Add missing shortcut descriptions. Refer the *TODOs* section and attached screenshots for detail. ### What type of PR is it? [Improvement] ### Todos * [x] - Move `CTRL-N`, `CTRL-P` to the editor shortcut section. * [x] - Remove useless bottom border color. * [x] - Add missing shortcut desc `CTRL-F` and `CTRL-B` ### What is the Jira issue? [ZEPPELIN-2609](https://issues.apache.org/jira/browse/ZEPPELIN-2609) ### How should this be tested? 1. build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart` 2. open any notebook 3. click the keyboard shortcut dialog. ### Screenshots (if appropriate) Before ![image](https://cloud.githubusercontent.com/assets/4968473/26706040/2dd05c96-4775-11e7-8c85-39b6a5e7d2a7.png) After ![image](https://cloud.githubusercontent.com/assets/4968473/26706030/230c7bbe-4775-11e7-83f5-3f2f8e86604a.png) ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO You can merge this pull request into a Git repository by running: $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2609/add-missing-shortcut-desc Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2385.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2385 commit 58930fb8ca021923d6f301809a49589490fb37d4 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:16:37Z fix: Move CTRL-N,P to editor shortcut section commit 6e6ca8f0be26a0de9e1a334eeb6249951706e744 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:16:48Z style: reindent commit 9b8222e679c5d46998b6f6bd05eed4c5cdd9de12 Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:17:46Z fix: Remove useless bottom sep commit 0e2d201d289a7010eb4e0e3163981a85531524da Author: 1ambda <1am...@gmail.com> Date: 2017-06-02T00:20:12Z feat: Add missing shortcut desc CTRL-F,B --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2609) Add missing editor shortcut description.
Hoon Park created ZEPPELIN-2609: --- Summary: Add missing editor shortcut description. Key: ZEPPELIN-2609 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2609 Project: Zeppelin Issue Type: Improvement Components: front-end Reporter: Hoon Park Fix For: 0.8.0 Add missing editor shortcut description. - `CTRL-N` and `CTRL-P` should be in editor shortcut, not notebook shortcut. - `CTRL-F` and `CTRL-B` is not described. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin issue #2368: Improved comment, removed admin user definition per de...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2368 @cfries Hi, could you restart or fix the failed job? - https://travis-ci.org/cfries/zeppelin/builds/236343303 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2377: User does not land on Zeppelin UI Login page after cli...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2377 Tested locally and works as described. LGTM except for a comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2384: [ZEPPELIN-2577] No graphs visible on IE11
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2384 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2382: [ZEPPELIN-2185] No tooltip displayed on chart type but...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2382 @0q Hi! Any update? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2370: change the spark version of dockerfile
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2370 Hi @sven0726! Any update? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2379: [MINOR] fix: Remove newlines in spark tutorial output
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2379 @Leemoonsoo @felixcheung Thanks for the review. - I removed all the things which are not related to the output. - and the paragraph in the spark tutorial now looks ![image](https://cloud.githubusercontent.com/assets/4968473/26704535/abf9822e-476a-11e7-9536-db2fb63630bc.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2383 Since R is under spark we need to enable it differently AFAICS now it is enabled at least in one test (where all other interpreters are compiled). Travis is happy I close and re-open this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...
GitHub user andreaTP reopened a pull request: https://github.com/apache/zeppelin/pull/2383 [ZEPPELIN-2606] Fix compilation with R interpreter enabled ### What is this PR for? `mvn -DskipTests clean package -Pr` fails ### What type of PR is it? Bug Fix ### What is the Jira issue? [ZEPPELIN-2606] ### How should this be tested? `mvn -DskipTests clean package -Pr` You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin rInterpreterFix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2383.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2383 commit b237615c83eddc4107d039c6d276a2cf5a089b00 Author: andreaDate: 2017-05-31T15:36:28Z [ZEPPELIN-2606] Fix compilation with R interpreter enabled commit 6ef05953e07e962acab9087133b222435efa1ef1 Author: andrea Date: 2017-06-01T11:41:50Z included R interpreter in travis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...
Github user andreaTP closed the pull request at: https://github.com/apache/zeppelin/pull/2383 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2369: [ZEPPELIN-2591] Show user info in spark job descriptio...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2369 Thanks @karuppayya for the improvement. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2384: [ZEPPELIN-2577] No graphs visible on IE11
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2384 [ZEPPELIN-2577] No graphs visible on IE11 ### What is this PR for? This PR fixes issue described in https://issues.apache.org/jira/browse/ZEPPELIN-2577 by adding .endsWith method. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-2577 ### How should this be tested? Build this PR and make sure built-in visualization is displayed in ie11 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-2577 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2384.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2384 commit 1b3129c015e9b3950bfdb6abf98de795c4379224 Author: Lee moon sooDate: 2017-06-01T20:19:31Z polyfill .endswith --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/932 Tested and LGTM. Merge to master if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2378: [ZEPPELIN-2602] fix: broken navbar-title render...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2378 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2366: [ZEPPELIN-2471] - NotebookTest fails on travis
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2366 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2608) Zeppelin not displaying d3 visualisation in cell
Nassir created ZEPPELIN-2608: Summary: Zeppelin not displaying d3 visualisation in cell Key: ZEPPELIN-2608 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2608 Project: Zeppelin Issue Type: Bug Reporter: Nassir When I run the code below in a cell referencing a rawJson in scala the bubble graph is not displayed. Instead, either I see no display or the bubble graph appears being my cells: %spark print(s"""%html circle { fill: rgb(31, 119, 180); fill-opacity: 0.5; stroke: rgb(31, 119, 180); stroke-width: 1px; } .leaf circle { fill: #ff7f0e; fill-opacity: 1; } text { font: 14px sans-serif; } https://cdnjs.cloudflare.com/ajax/libs/d3/3.5.5/d3.min.js"> var json = { "name": "data", "children": [ { "name": "topics", "children": [ ${rawJson} ] } ] }; var r = 1500, format = d3.format(",d"), fill = d3.scale.category20c(); var bubble = d3.layout.pack() .sort(null) .size([r, r]) .padding(1.5); var vis = d3.select("body").append("svg") .attr("width", r) .attr("height", r) .attr("class", "bubble"); var node = vis.selectAll("g.node") .data(bubble.nodes(classes(json)) .filter(function(d) { return !d.children; })) .enter().append("g") .attr("class", "node") .attr("transform", function(d) { return "translate(" + d.x + "," + d.y + ")"; }) color = d3.scale.category20(); node.append("title") .text(function(d) { return d.className + ": " + format(d.value); }); node.append("circle") .attr("r", function(d) { return d.r; }) .style("fill", function(d) {return color(d.topicName);}); var text = node.append("text") .attr("text-anchor", "middle") .attr("dy", ".3em") .text(function(d) { return d.className.substring(0, d.r / 3)}); text.append("tspan") .attr("dy", "1.2em") .attr("x", 0) .text(function(d) {return Math.ceil(d.value * 1) /1; }); // Returns a flattened hierarchy containing all leaf nodes under the root. function classes(root) { var classes = []; function recurse(term, node) { if (node.children) node.children.forEach(function(child) { recurse(node.term, child); }); else classes.push({topicName: node.topicId, className: node.term, value: node.probability}); } recurse(null, root); return {children: classes}; } """) -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2383 good point, so I added it to the list, I think it fits the scope of this PR (let see what travis says) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2383 @andreaTP That's is intended. It would be converted to inclusive. ``` MODULES="-pl $(echo .,zeppelin-interpreter,${INTERPRETERS} | sed 's/!//g')" ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #932: Replace CXF with Jersey2 [ZEPPELIN-903]
Github user FRosner commented on the issue: https://github.com/apache/zeppelin/pull/932 Hi all, tested it and it works. I understood that https://github.com/apache/zeppelin/pull/2182 is on hold because this one is also going to fix it but in a better way? Can we move forward with this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 I'm improving navigation bar but, I found two bug in navigation bar. so we should resolve those issues together. 1. when resizing window, drop-toggle is appeared. ![bug1](https://cloud.githubusercontent.com/assets/8110458/26674878/d5807f9e-46fc-11e7-936d-d07f413fecd0.gif) 2. after using navigation bar in small window, and then drop-toggle place is misaligned in big window. ![bug2](https://cloud.githubusercontent.com/assets/8110458/26675376/a20547ba-46fe-11e7-94a5-a9206fd8aa2a.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2383 `INTERPRETERS` is surprisingly an exclusion list @zjffdu https://github.com/apache/zeppelin/blob/master/.travis.yml#L40 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2383 I think `r` is missing in `INTERPRETERS` of `.travis.yml` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2367: [ZEPPELIN-2584]. Livy doesn't work under kerber...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2367 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
Github user andreaTP commented on the issue: https://github.com/apache/zeppelin/pull/2373 @1ambda potentially yes @khalidhuseynov thanks for pointing out a public server I can test! I will go through later on B.t.w. I realized that the MVP to get this working is just upgrading shiro and the ui triggers, the rest of the libraries can be provided on an ad-hoc basis (i.e. in a `lib` dir) without any need of packaging them into zeppelin itself, this will enable also users to choose the preferred version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2373 Hi, I have a question. Does this PR means, zeppelin can be OAuth client? For example github, google, ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/2373 i've just tried to login using the config info from online demo for oidc-client in https://demo.c2id.com/oidc-client using modified config below ``` oidcConfig = org.pac4j.oidc.config.OidcConfiguration oidcConfig.discoveryURI = https://demo.c2id.com/oidc-client/cb oidcConfig.clientId = 000123 oidcConfig.secret = 7wKJNYFaKKg4FxUdi8_R75GGYsiWezvAbcdN1uSumE4 oidcConfig.clientAuthenticationMethodAsString = client_secret_basic oidcClient = org.pac4j.oidc.client.OidcClient oidcClient.configuration = $oidcConfig clients = org.pac4j.core.client.Clients clients.callbackUrl = http://localhost:8080/api/callback clients.clients = $oidcClient requireRoleAdmin = org.pac4j.core.authorization.authorizer.RequireAnyRoleAuthorizer #requireRoleAdmin.elements = config = org.pac4j.core.config.Config config.clients = $clients #config.authorizers = admin:$requireRoleAdmin pac4jRealm = io.buji.pac4j.realm.Pac4jRealm pac4jSubjectFactory = io.buji.pac4j.subject.Pac4jSubjectFactory securityManager.subjectFactory = $pac4jSubjectFactory oidcSecurityFilter = io.buji.pac4j.filter.SecurityFilter oidcSecurityFilter.config = $config oidcSecurityFilter.clients = oidcClient callbackFilter = io.buji.pac4j.filter.CallbackFilter callbackFilter.defaultUrl = http://localhost:8080 callbackFilter.config = $config securityManager.realms = $pac4jRealm ... /api/callback = callbackFilter #/** = anon /** = authc ``` but getting exception ``` ERROR [2017-06-01 14:49:39,711] ({qtp764577347-20} LoginRestApi.java[postLogin]:111) - Exception in login: org.apache.shiro.authc.pam.UnsupportedTokenException: Realm [io.buji.pac4j.realm.Pac4jRealm@734cf9ff] does not support authentication token [org.apache.shiro.authc.UsernamePasswordToken - alice, rememberMe=false]. Please ensure that the appropriate Realm implementation is configured correctly or that the realm accepts AuthenticationTokens of this type. at org.apache.shiro.authc.pam.ModularRealmAuthenticator.doSingleRealmAuthentication(ModularRealmAuthenticator.java:178) at org.apache.shiro.authc.pam.ModularRealmAuthenticator.doAuthenticate(ModularRealmAuthenticator.java:267) at org.apache.shiro.authc.AbstractAuthenticator.authenticate(AbstractAuthenticator.java:198) at org.apache.shiro.mgt.AuthenticatingSecurityManager.authenticate(AuthenticatingSecurityManager.java:106) at org.apache.shiro.mgt.DefaultSecurityManager.login(DefaultSecurityManager.java:270) at org.apache.shiro.subject.support.DelegatingSubject.login(DelegatingSubject.java:256) at org.apache.zeppelin.rest.LoginRestApi.postLogin(LoginRestApi.java:80) ``` please let me know if you can see any apparent misconfiguration --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---