[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode

2017-07-04 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2463
  
Few days I too was thinking about this, thanks for the fix. LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
@1ambda 
done


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread tinkoff-dwh
GitHub user tinkoff-dwh reopened a pull request:

https://github.com/apache/zeppelin/pull/2268

[ZEPPELIN-2403] interpreter property widgets

### What is this PR for?
I spoiled the previous PR #2251

Added widgets (string, text, url, password, url, checkbox) to properties of 
interpreters. Those are widgets for properties customization. Properties must 
have the ability to customize the display (for example password).


### What type of PR is it?
Feature

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2403

### How should this be tested?
- remove conf/interpreter.json
- Try new form (create, edit) of interpreter settings

### Screenshots (if appropriate)
edit

![edit](https://cloud.githubusercontent.com/assets/25951039/25130228/e2a28060-245a-11e7-895a-d7c1571f885f.png)

view

![view](https://cloud.githubusercontent.com/assets/25951039/25130227/e2a10906-245a-11e7-9ea3-0bd070219f42.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-2403

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2268.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2268


commit 45f5f6276d731084b3873cb1885f684ab1449e68
Author: Tinkoff DWH 
Date:   2017-04-14T07:44:29Z

ZEPPELIN-2403 added interpreter property types

commit 12499ae1ef7d329c7f3e74b4298031cfe4b9c490
Author: Tinkoff DWH 
Date:   2017-04-17T08:01:39Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403

# Conflicts:
#   docs/install/upgrade.md

commit 14353b1200443582b1fceafabce0e82cdf83a054
Author: Tinkoff DWH 
Date:   2017-04-17T08:02:01Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403

commit dd5d6c809aeb2bdb72357a072954cf4a9c882487
Author: Tinkoff DWH 
Date:   2017-04-17T08:38:59Z

ZEPPELIN-2403 did properties immutable, added new type 'checkbox'

commit 4f271d9b03a1748d83fefdf290abbba68d3cd280
Author: Tinkoff DWH 
Date:   2017-04-18T12:16:00Z

ZEPPELIN-2403  rename to widget  added new widgets  string,  number,  url

commit fd8d27810cfc004216c8ea61ea7fe5d06aa9bde2
Author: Tinkoff DWH 
Date:   2017-04-20T10:42:05Z

Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403_backup

# Conflicts:
#   zeppelin-web/src/app/interpreter/interpreter.controller.js
#   zeppelin-web/src/index.js

commit a495137ffccd7d88adb9593ada3cff2cb6e10698
Author: Tinkoff DWH 
Date:   2017-04-20T10:49:24Z

ZEPPELIN-2403 eslint fix

commit 07160e00eb294f9962b7b4c1bc738c1e7788c870
Author: Tinkoff DWH 
Date:   2017-04-27T10:40:36Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403

commit e92713c72f41e9c1be2fd85bcc8a4ca35f4b5810
Author: Tinkoff DWH 
Date:   2017-04-27T10:44:26Z

[ZEPPELIN-2403] generalized types, added new types

commit 637cb0a155d5e4d525c74f95744a4e9a2edb023d
Author: Tinkoff DWH 
Date:   2017-04-28T10:44:11Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403

# Conflicts:
#   spark/src/main/java/org/apache/zeppelin/spark/SparkInterpreter.java

commit b41e7a3f19ea982f67d7a0d5fc6570a31ae37467
Author: Tinkoff DWH 
Date:   2017-05-01T16:47:50Z

ZEPPELIN-2403 checkstyle

commit 76a9808307e53040a60c01eb5099d9fbe627c520
Author: Tinkoff DWH 
Date:   2017-05-11T04:24:05Z

Merge remote-tracking branch 'origin/master' into ZEPPELIN-2403

commit c6d24c4c35b51628fd1de1f37e0135c4ac8b3e5c
Author: Tinkoff DWH 
Date:   2017-05-11T06:11:07Z

[ZEPPELIN-2403] converter for old settings to new (with widgets)

commit f735c0a9465390b4a083de32719962004d2247b6
Author: Tinkoff DWH 
Date:   2017-05-11T06:51:35Z

[ZEPPELIN-2403] fix test

commit 99daca6d5892c3485162734520470186f128afec
Author: Tinkoff DWH 
Date:   2017-05-11T09:01:32Z

[ZEPPELIN-2403] fix rest api test

commit ca1e2bf7602bb21e410e9e4fe6b7ad41f157163b
Author: Tinkoff DWH 
Date:   2017-05-15T08:14:45Z

Merge remote-tracking branch 'upstream/master' into ZEPPELIN-2403

commit 10ce996a10d19805dba1c1968678f2f72726e1fe
Author: Tinkoff DWH 
Date:   2017-05-22T11:32:13Z

[ZEPPELIN-2403] merge widget and type

commit 

[GitHub] zeppelin pull request #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at:

https://github.com/apache/zeppelin/pull/2268


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2448: [ZEPPELIN-2702] save notes in reader-friendly format w...

2017-07-04 Thread khalidhuseynov
Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/2448
  
rebased from master, /cc @1ambda @Leemoonsoo please help review and test as 
well


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode

2017-07-04 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2463
  
Tested (dev mode), works fine, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Yes, I did. I run `mvn clean package -DskipTests`
I'll check again.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2459: [ZEPPELIN-2716] Change the default value of zeppelin.l...

2017-07-04 Thread jerryshao
Github user jerryshao commented on the issue:

https://github.com/apache/zeppelin/pull/2459
  
There's no failure in my local test, please help to check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2463: Fix zeppelin-web development mode

2017-07-04 Thread Leemoonsoo
GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/2463

Fix zeppelin-web development mode

### What is this PR for?

After https://github.com/apache/zeppelin/pull/2373, zeppelin-web dev mode 
does not work properly.
Dev mode always ask user login (even if authentication is turned off) and 
any login attempt will fail. So it makes difficult to develop front-end.

This PR fixes problem by not adding `X-Requested-With: XMLHttpRequest` 
header in dev mode.

### What type of PR is it?
Bug Fix

### Todos
* [x] - Fix devmode

### How should this be tested?
run zeppelin-web dev mode and see if you can login / open notebook

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin fix_devmode

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2463.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2463


commit bf15efc3e9f543ad9698b5952e285967e0d8a035
Author: Lee moon soo 
Date:   2017-07-05T02:50:12Z

do not apply X-Requested-With : XMLHttpRequest header in dev mode




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2459: [ZEPPELIN-2716] Change the default value of zep...

2017-07-04 Thread jerryshao
Github user jerryshao closed the pull request at:

https://github.com/apache/zeppelin/pull/2459


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2459: [ZEPPELIN-2716] Change the default value of zep...

2017-07-04 Thread jerryshao
GitHub user jerryshao reopened a pull request:

https://github.com/apache/zeppelin/pull/2459

[ZEPPELIN-2716] Change the default value of zeppelin.livy.displayAppInfo to 
true

### What is this PR for?

Since it is quite useful to expose the application info for user to monitor 
and debug, so here propose to enable "zeppelin.livy.displayAppInfo" to true as 
default.

### What type of PR is it?

Improvement

### Todos

### What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-2716

### How should this be tested?

Manual verification.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jerryshao/zeppelin ZEPPELIN-2716

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2459.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2459


commit 203d330ec91c3da46d25e767f59255a49ec795d3
Author: jerryshao 
Date:   2017-07-03T06:06:16Z

Change the default value of zeppelin.livy.displayAppInfo to true




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2462
  
Thanks for the contribution @malayhm. I left a comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2460
  
And could you create a JIRA issue for this? I think this is not a minor 
issue..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2460
  
@soralee Thanks for the contribution.

This PR looks like related with mobile browser rendering of the official 
web page. Can we fix this bug as well?




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
resolved @cacti77's all comments 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
@tinkoff-dwh Please resolve conflict.

Usually, we merge after 1 day when someone left LGTM, but this time, 
conflict occurred before 1 day.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@andreaTP After this PR, an error is thrown like in dev mode. To reproduce,

- `cd zeppelin-web`
- `npm install` (only once)
- `npm run dev`

Could you check it?


![image](https://user-images.githubusercontent.com/4968473/27845151-3129fb02-6167-11e7-93e2-a22f245f5c76.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also...

2017-07-04 Thread necosta
GitHub user necosta reopened a pull request:

https://github.com/apache/zeppelin/pull/2446

[ZEPPELIN-2699] Helium REST API bug-fixes. Also updated documentation

### What is this PR for?
Fixing bug on enabling Helium plugins (artifact is empty, not null) when 
sending curl command.
After noticing out-of-date documentation, I updated it
Also noticed issues on missing try/catch expressions and missing info 
messages on enable/disable packages.

### What type of PR is it?
[Bug Fix | Documentation | Refactoring]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2699

### How should this be tested?
Run "curl -X POST http://localhost:8080/api/helium/enable/{packageName};
Check that the package gets enabled

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? Y (Done)


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin2699

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2446


commit 920465b1cbf032b5da35a54fefcbdda8b794c1e1
Author: Nelson Costa 
Date:   2017-06-30T09:00:23Z

[ZEPPELIN-2699] Helium REST API bug-fixes. Also updated documentation

commit c199401ac4c9091f5e9295b04df5d7bd9753983a
Author: Nelson Costa 
Date:   2017-07-03T21:02:32Z

[ZEPPELIN-2699] Changes after code-review

commit 5384864c0f0b4c51570a278dfbfe5b0e1849b9b9
Author: Nelson Costa 
Date:   2017-07-04T19:33:07Z

[ZEPPELIN-2699] Changes after code review




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also...

2017-07-04 Thread necosta
Github user necosta closed the pull request at:

https://github.com/apache/zeppelin/pull/2446


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread herval
Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Hmm I’ll try again.

Btw, did you `mvn clean` after switching branches? I think changes on the 
js/html files don’t get picked up unless you do that...


From: Sora Lee 
Sent: Tuesday, July 4, 2017 1:23:03 AM
To: apache/zeppelin
Cc: Herval Freire; Mention
Subject: Re: [apache/zeppelin] [ZEPPELIN-2680] allow opening notebook as a 
reader (#2439)


I could reproduce this problem on master branch but, I could not see to 
resolve on your branch.
It has same error.
Could you test it out on your branch?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2375: [ZEPPELIN-2527] Use thin (normal) cursor.

2017-07-04 Thread malayhm
Github user malayhm commented on the issue:

https://github.com/apache/zeppelin/pull/2375
  
Created a PR with css only change so that emacs shortcut can be preserved:
https://github.com/apache/zeppelin/pull/2462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2461: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread malayhm
Github user malayhm commented on the issue:

https://github.com/apache/zeppelin/pull/2461
  
There was an issue with this PR, created a new one: 
https://github.com/apache/zeppelin/pull/2462


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2462: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread malayhm
GitHub user malayhm opened a pull request:

https://github.com/apache/zeppelin/pull/2462

ZEPPELIN-2527 Changed editor cursor to thin

### What is this PR for?
Previously, it's hard to recognize the cursor since it was too thick. After 
this PR, it will show the cursor same as other input boxes for consistency.

See the attached GIFs for comparison.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2527

### How should this be tested?

1. Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
2. Open a paragraph
3. Check the cursor

### Screenshots (if appropriate)
Before

![cursor-change-pr-before](https://user-images.githubusercontent.com/1881135/27830832-cd55ec8e-60e5-11e7-8a0e-f75caecaba30.gif)

After

![cursor-change-pr](https://user-images.githubusercontent.com/1881135/27830837-d01fba30-60e5-11e7-8722-8056f7abaebc.gif)


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/malayhm/zeppelin ZEP-2527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2462.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2462


commit e45f23b3a0acb7f05c4d559d7abf319a125549e3
Author: Malay Majithia 
Date:   2017-07-04T12:50:50Z

ZEPPELIN-2527 Changed editor cursor to thin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2461: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread malayhm
Github user malayhm closed the pull request at:

https://github.com/apache/zeppelin/pull/2461


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2461: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2461
  
\cc @1ambda 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2461: ZEPPELIN-2527 Changed editor cursor to thin

2017-07-04 Thread malayhm
GitHub user malayhm opened a pull request:

https://github.com/apache/zeppelin/pull/2461

ZEPPELIN-2527 Changed editor cursor to thin

### What is this PR for?
Previously, it's hard to recognize the cursor since it was too thick. After 
this PR, it will show the cursor same as other input boxes for consistency.

See the attached GIFs for comparison.


### What type of PR is it?
[Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* [ZEPPELIN-2527]

### How should this be tested?

1. Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
2. Open a paragraph
3. Check the cursor

### Screenshots (if appropriate)
Before the change

![cursor-change-pr-before](https://user-images.githubusercontent.com/1881135/27826498-dd7c27e6-60d0-11e7-887d-f7abf7b2acd8.gif)


After the change

![cursor-change-pr](https://user-images.githubusercontent.com/1881135/27826466-b4fb8028-60d0-11e7-986f-81904a4cb2e6.gif)


### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/malayhm/zeppelin ZEPPELIN-2527

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2461.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2461


commit e9a5cfbeea879acf6d7500cce44529e8d9704978
Author: Malay Majithia 
Date:   2017-07-04T10:06:41Z

ZEPPELIN-2527 Changed editor cursor to thin




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2272: ZEPPELIN-2397. Add toJson and fromJson method f...

2017-07-04 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2272


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Oh, It's great! 
Let me test it out as soon as possible.
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2719) Can't get Spark interpreter to work with Cloudera's YARN cluster

2017-07-04 Thread Miguel (JIRA)
Miguel created ZEPPELIN-2719:


 Summary: Can't get Spark interpreter to work with Cloudera's YARN 
cluster
 Key: ZEPPELIN-2719
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2719
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.7.2
 Environment: OS: Ubuntu 14.04.5 LTS
JRE: 1.7.0_67
Cloudera CDH 5.9.1
Hadoop 2.6.0-cdh5.9.1 in HA mode
Spark 1.6.1 running in a YARN cluster in HA mode
Scala 2.10
Kerberos
Reporter: Miguel


Hi,

I'm having problems getting the Spark interpreter to work. Every time I try to 
run it I get a connection refused error:
{noformat}
java.net.ConnectException: Connection refused
at java.net.PlainSocketImpl.socketConnect(Native Method)
at 
java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:339)
at 
java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:200)
[...]
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
at java.lang.Thread.run(Thread.java:745)
{noformat}

I've spent a few days trying to debug the issue and I'm at a point where I'm 
running out of ideas, so any help is greatly appreciated.

I have built Zeppelin for my environment using:
{noformat}
mvn clean package -Pspark-1.6 -Dhadoop.version=2.6.0-cdh5.9.1 -Phadoop-2.6 
-Pvendor-repo -Pscala-2.10 -Pbuild-distr -DskipTests
{noformat}

And have the following configuration in zeppelin-env.sh
{noformat}
export JAVA_HOME=/usr/lib/jvm/java-7-oracle-cloudera/jre
export SPARK_HOME=/opt/cloudera/parcels/CDH/lib/spark
export HADOOP_HOME=/opt/cloudera/parcels/CDH/lib/hadoop
export HADOOP_CONF_DIR=/etc/hadoop/conf
{noformat}

I read in a different issue that lowering the memory settings could help, so I 
added:
{noformat}
export ZEPPELIN_JAVA_OPTS=" -Dspark.executor.memory=1g -Dspark.cores.max=2"
export ZEPPELIN_MEM=" -Xms512m -Xmx1024m -XX:MaxPermSize=256m"
export ZEPPELIN_INTP_MEM=" -Xms512m -Xmx1024m -XX:MaxPermSize=256m"
export SPARK_SUBMIT_OPTIONS=" --driver-memory 512M --executor-memory 1G"
{noformat}

But it doesn't seem to change anything, I get the same error.

The Spark interpreter is configured as follows
{noformat}
master: yarn-client
spark.app.name: Zeppelin
spark.yarn.keytab:  /opt/zeppelin/zeppelin.keytab
spark.yarn.principal:   zeppelin@
zeppelin.dep.additionalRemoteRepository:
spark-packages,http://dl.bintray.com/spark-packages/maven,false;
zeppelin.dep.localrepo: local-repo
zeppelin.pyspark.python:python
zeppelin.spark.concurrentSQL:   false
zeppelin.spark.importImplicit:  true
zeppelin.spark.maxResult:   1000
zeppelin.spark.printREPLOutput: true
zeppelin.spark.sql.stacktrace:  false
zeppelin.spark.useHiveContext:  true
{noformat}

The zeppelin Kerberos principal and keytab should be ok, I'm using them with 
Livy and it works.

Here are the relevant lines from zeppelin-zeppelin-.log
{noformat}
 INFO [2017-07-04 08:12:14,681] ({qtp1527142660-16} 
InterpreterFactory.java[createInterpretersForNote]:188) - Create interpreter 
instance spark for note 2CGW3RAGX
 INFO [2017-07-04 08:12:14,681] ({qtp1527142660-16} 
InterpreterFactory.java[createInterpretersForNote]:221) - Interpreter 
org.apache.zeppelin.spark.SparkInterpreter 799822533 created
 INFO [2017-07-04 08:12:14,681] ({qtp1527142660-16} 
InterpreterFactory.java[createInterpretersForNote]:221) - Interpreter 
org.apache.zeppelin.spark.SparkSqlInterpreter 1517165558 created
 INFO [2017-07-04 08:12:14,681] ({qtp1527142660-16} 
InterpreterFactory.java[createInterpretersForNote]:221) - Interpreter 
org.apache.zeppelin.spark.DepInterpreter 1928192475 created
 INFO [2017-07-04 08:12:14,681] ({qtp1527142660-16} 
InterpreterFactory.java[createInterpretersForNote]:221) - Interpreter 
org.apache.zeppelin.spark.PySparkInterpreter 1602694095 created
 INFO [2017-07-04 08:12:20,051] ({pool-2-thread-2} 
SchedulerFactory.java[jobStarted]:131) - Job paragraph_1495010482434_695017792 
started by scheduler 
org.apache.zeppelin.interpreter.remote.RemoteInterpretershared_session1222353445
 INFO [2017-07-04 08:12:20,052] ({pool-2-thread-2} Paragraph.java[jobRun]:362) 
- run paragraph 20170517-084122_2115191800 using spark 
org.apache.zeppelin.interpreter.LazyOpenInterpreter@2fac52c5
 INFO [2017-07-04 08:12:20,060] ({pool-2-thread-2} 
RemoteInterpreterManagedProcess.java[start]:126) - Run interpreter process 
[/opt/zeppelin/zeppelin/bin/interpreter.sh, -d, 
/opt/zeppelin/zeppelin/interpreter/spark, -p, 52698, -l, 
/opt/zeppelin/zeppelin/local-repo/2CJKGGV2U]
ERROR [2017-07-04 08:12:50,124] ({Thread-36} 
RemoteScheduler.java[getStatus]:256) - Can't get status information
org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.transport.TTransportException: 

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Yeah all green now! 
(https://travis-ci.org/ebuildy/zeppelin/builds/249550322)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2437: [ZEPPELIN-2582][DOCS] docs for interpreter binding mod...

2017-07-04 Thread cacti77
Github user cacti77 commented on the issue:

https://github.com/apache/zeppelin/pull/2437
  
Apologies @1ambda for not interacting with this PR properly; I may have 
overlooked some of your recent edits in the version of 
interpreter_binding_mode.md I commented on yesterday.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I could reproduce this problem on master branch but, I could not see to 
resolve on your branch.
It has same error.
Could you test it out on your branch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Ah, you don't mind those lines because your 1.8 job became green light!
So, I think that it would be nice to run again about 1.3 and 1.5 jobs.
Could you try again, please?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
I don't know why it fails here:

https://travis-ci.org/ebuildy/zeppelin/jobs/249550330#L776

``ERROR org.apache.zeppelin.spark.SparkVersion:63 - Can not recognize Spark 
version DEV-10.10. Assume it's a future release
java.lang.NumberFormatException: For input string: "DEV"``

Also here https://travis-ci.org/ebuildy/zeppelin/jobs/249550330#L1392

``java.lang.NullPointerException
at 
scala.tools.nsc.interpreter.IMain$ReadEvalPrint.call(IMain.scala:784)``

I took the master branch, is it ok ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
You're welcome! 
Yeah, the current Travis is not good but it's working. 
If when your Travis become green or it is fail but it is not related your 
PR, I can test it out (:



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

2017-07-04 Thread ebuildy
Github user ebuildy commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Ya I think it complains about https://travis-ci.org/ebuildy/zeppelin , some 
jobs have failed, I am checking it. thanks you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Oh, Thanks for quick answer and check! 
Let me test as your comment and come back here!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread herval
Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
@soralee thanks for taking the time :-) there's one more step to your list:

1. login as user1
2. create a note
3. add a paragraph
**4. change the visualization to a chart (instead of table)**
5. set owners and writers field set user1
6. set readers field sets user2
7. logout user1 and login user2.
8. back to note and check whether popup is appeared or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
I have a question quickly.
For reproduce, I just make sure test flow clearly. 
1. login as user1
2. create a note
3. add a paragraph
4. set `owners` and `writers` field set user1
5. set `readers` field sets user2
6. logout user1 and login user2.
7. back to note and check whether popup is appeared or not.

Is it correct?






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2268: [ZEPPELIN-2403] interpreter property widgets

2017-07-04 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2268
  
LGTM, merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2718) Find and replace code in note

2017-07-04 Thread Tinkoff DWH (JIRA)
Tinkoff DWH created ZEPPELIN-2718:
-

 Summary: Find and replace code in note
 Key: ZEPPELIN-2718
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2718
 Project: Zeppelin
  Issue Type: New Feature
  Components: front-end
Reporter: Tinkoff DWH
Assignee: Tinkoff DWH
Priority: Minor


Add ability to find and replace code in note.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
Hi, @herval. Thanks for contribution and sorry for late response.
Let me take a look this one.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader

2017-07-04 Thread herval
Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2439
  
any thoughts on this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2428: [ZEPPELIN-1470] limiting results from jdbc

2017-07-04 Thread herval
Github user herval commented on the issue:

https://github.com/apache/zeppelin/pull/2428
  
any additional thoughts on this? Is it mergeable? @khalidhuseynov 
@tinkoff-dwh @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2456: [ZEPPELIN-2714] Soft-code Spark UI button visua...

2017-07-04 Thread necosta
GitHub user necosta reopened a pull request:

https://github.com/apache/zeppelin/pull/2456

[ZEPPELIN-2714] Soft-code Spark UI button visualization

### What is this PR for?
When "spark.ui.enabled" property is set to "false" we should not show the 
Spark UI button.
We keep the same behaviour when this property does not exist or when it 
exists and it's set to true.

### What type of PR is it?
[ Improvement]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2714

### How should this be tested?
1. Open Zeppelin, go to Interpreter > Spark
1. Click spark ui > msg: "No spark application running"
1. Go to a paragraph, run "sc.parallelize(1 to 100).count()", check "SPARK 
JOB" button
1. Go to Interpreter > Spark > Set "spark.ui.enabled" to "false"
1. Rerun paragraph > "SPARK JOB" button not visible
1. Go to Interpreter > Spark > "spark ui" button not visible
Also, test with "spark.ui.enabled"="true" and other workflow combinations

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? N
* Does this needs documentation? N


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin2714

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2456.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2456


commit 4d7658f423d9e90dd50137edd2f2010952619985
Author: Nelson Costa 
Date:   2017-06-30T09:17:59Z

[ZEPPELIN-2714] Soft-code Spark UI button visualization

commit b0767c2173ae4e3529846388f9617aab291729f1
Author: Nelson Costa 
Date:   2017-07-03T20:38:01Z

[ZEPPELIN-2714] Improvements to change request




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---