[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
LGTM.


---

[jira] [Created] (ZEPPELIN-2923) ipython related message is displayed when enabling a conda env

[Hoon Park (JIRA)]

Hoon Park created ZEPPELIN-2923:
---

 Summary: ipython related message is displayed when enabling a 
conda env 
 Key: ZEPPELIN-2923
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2923
 Project: Zeppelin
  Issue Type: Bug
  Components: python-interpreter
Reporter: Hoon Park
 Fix For: 0.8.0


ipython related message is displayed when enabling a conda env. I attached a 
GIF.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@zjffdu I created one. Thanks. 

- https://issues.apache.org/jira/browse/ZEPPELIN-2923


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@1ambda This is due to IPythonInterpreter, could create a ticket ? I will 
fix it in another PR. 


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
Checked that `conda list` works beautifully. But I am getting this ipython 
related message when activate a new env. Can we remove this message which is 
not related to conda at all.


![image](https://user-images.githubusercontent.com/4968473/30258861-f757bfd8-96f7-11e7-962c-900dd0c519c4.png)



---

[GitHub] zeppelin issue #2579: Zeppelin-2922 Allow removing last paragrap

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2579
  
@malayhm Hi, Thanks for the contribution.

I just read the JIRA issue and have a question. Could you elaborate the 
situation when 

> sometimes user want to delete the last empty paragraph to make the 
notebook interface clean.


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
fixed test case and conda list feature


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@1ambda okay :)


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
Tested locally and works well. @cloverhearts Can we fix `conda list` 
command as well? it will need exactly the same code with `conda install`. 

LGTM except for it.


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@zjffdu Sure, Thank you :)


---

[GitHub] zeppelin issue #2569: ZEPPELIN-2562 Make Add paragraph button more prominent

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2569
  
Merge if no more discussion.


---

[GitHub] zeppelin pull request #2572: [ZEPPELIN-2919] fix: Fallback to table when vis...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2572


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
Thanks @cloverhearts , Is it possible to add unit test for 
`PythonCondaInterpreter` ? Regarding the CI failure, I know this failure and 
will fix it in another PR 


---

[GitHub] zeppelin pull request #2579: Zeppelin-2922 Allow removing last paragrap

[malayhm]

GitHub user malayhm opened a pull request:

https://github.com/apache/zeppelin/pull/2579

Zeppelin-2922 Allow removing last paragrap

### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html


### What type of PR is it?
[Improvement]

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2922

### How should this be tested?
1. Build: mvn clean package -Denforcer.skip -DskipTests -Drat.skip
2. Create paragraphs in a notebook and try to remove it
3. You can delete any paragraphs(even last paragraphs), but when there will 
be only one paragraph, remove button will be hidden

### Screenshots (if appropriate)

After:

![zep-2922 
after](https://user-images.githubusercontent.com/1881135/30252063-78ee443c-9689-11e7-92dc-faae2ca273b2.gif)



### Questions:
* Does the licenses files need an update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? May be


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/malayhm/zeppelin ZEPPELIN-2922

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2579.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2579


commit 73fd0659ad9aa4ca3b88c04b979349d5dddb8a77
Author: Malay Majithia 
Date:   2017-09-09T17:14:02Z

ZEPPELIN-2922 Allow removing last paragraph

commit 1220f13882855eda3fdd2ceced63b4bbabe1a58a
Author: Malay Majithia 
Date:   2017-09-09T17:15:11Z

Merge branch 'master' into ZEPPELIN-2922

commit 7c815ceaa71c8a21ca59de60fb28adb0148d1549
Author: Malay Majithia 
Date:   2017-09-10T18:21:21Z

Removed unwanted line




---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
The problem of CI is irrelevant to this pr.

```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.462 sec 
<<< FAILURE! - in 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest

testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest)
  Time elapsed: 10.043 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62)
```


---

[GitHub] zeppelin pull request #2575: [ZEPPELIN-2921] does not work conda environment...

[cloverhearts]

Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/2575


---

[GitHub] zeppelin pull request #2574: [ZEPPELIN-2921 : 0.7x] does not work conda envi...

[cloverhearts]

Github user cloverhearts closed the pull request at:

https://github.com/apache/zeppelin/pull/2574


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
I have separated this PR.
I'm sorry for the confusion.
https://github.com/apache/zeppelin/pull/2578


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@1ambda @zjffdu @felixcheung 

Sorry.
I divided the existing PR by the minimum function.
Can you review this PR again?
Thank you for your help :)


---

[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...

[cloverhearts]

GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/2578

[ZEPPELIN-2921] does not work conda environment in python interpreter 

### What is this PR for?
It seems that the environment of the python interpreter has changed to the 
py4j environment, causing problems with the library path and the default 
environment.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2921

### How should this be tested?
Please run the following command line for each paragraph.
If the module such as scipy is normally imported, it is a success.
`%python.conda create --name Hello6 python=2.7`
`%python.conda activate Hello6`
`%python.conda install seaborn pandas numpy scipy matplotlib`
```
%python
import scipy as sp
import seaborn as sns
```
`%python.conda deactivate`

### Screenshots (if appropriate)
 Before

![image](https://user-images.githubusercontent.com/10525473/30199920-c75022ca-94af-11e7-8811-0c22310f1bac.png)

 After

![image](https://user-images.githubusercontent.com/10525473/30198880-23aaceb2-94ab-11e7-8bc6-bfad76c675f7.png)


### Questions:
* Does the licenses files need update? no 
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin ZEPPELIN-2921

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2578.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2578


commit 8dfb33b1159695e109a696c38a3fd6a112a79e13
Author: CloverHearts 
Date:   2017-09-10T16:36:19Z

replace conda install environment name




---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
Thank you @1ambda @zjffdu @felixcheung 
I think my code with various purposes is distracting you.
And, unfortunately, my English ability is difficult to describe in a 
sophisticated way.
Therefore, I will share PR.
In this PR, we will only deal with the wrong library installation of conda.

Many thanks for your comments.


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts There is no problem about python lib paths. 

`%python.conda install` and `%python conda list` commands are the problem. 
They don't aware activated env by Zeppelin.

So you don't need to write code for python path.


![image](https://user-images.githubusercontent.com/4968473/30249786-2d97123a-967e-11e7-86e6-bbf97ea25795.png)



---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts 
`There is only one python library path to be added.`
Do you mean the py4j ? IIUC, PythonInterpreter will add py4j to PYTHONPATH, 
it doesn't relate with `PythonCondaInterpreter`. That's why I mention we just 
need to set `zeppelin.python`, Let me know if I miss anything. 


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts There is no problem about python lib paths. 

`%python.conda install` command is the problem.

So you don't need to write code for python path.


![image](https://user-images.githubusercontent.com/4968473/30249786-2d97123a-967e-11e7-86e6-bbf97ea25795.png)



---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@zjffdu @1ambda @felixcheung 
Thank you for your kind reply despite my lack of English.
I hope this PR is merged.
So, i will try to reflect your opinions as much as possible.
Thank you. :)


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
In my opinion, allowing for fluctuations in the python environment is 
itself a problem.
But zeppelin are supporting it.
If it does not, then the semantics of conda activate and conda deactivate 
disappear.

In fact, I also think that changing the python environment can be a problem.
However, the current Zeppelin supports it, and a bug exists.
This PR is a PR that solves the bug.


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
I have a solution to remove conda related members from PythonInterpreter. 
also PythonCondaInterpreter will not have any members.
However, it differs in focus from this PR.
(The problem is that there are changes related to the start of the Python 
Interpreter.)

This PR is intended to be used when the user changes the environment by 
installing new python while using conda.
This also solves the Zeppelin Python Interpreter's infinite loop problem.


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@1ambda 
Currently there is a possibility that it will be structurally.
However, if you store it in PythonCondaInterpreter, the problem is greatly 
aggravated.

1. PythonInterpreter needs to monitor PythonCondaInterpreter at all times.
     (Python Interpreter should check Conda's environment activation 
when restarting.)

2. Other configurations other than PythonCondaInterpreter If an interpreter 
is added (as you might have guessed), the Python Interpreter is in a situation 
where you need to constantly query for all other Interpreter environments. This 
will affect the life cycle of the Python Interpreter.


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@zjffdu 
This change will work exactly as your request.
There is only one python library path to be added.
1. If the user does not install python via conda.
(If the user installs only the library)
Zeppelin use to `zeppelin.python`.
(Used in the original environment.)

2. If you install python via conda.
(separate python from zeppelin.python)
if when the conda environment is active, add to library path and replace to 
installed python via conda from zeppelin.python.
Zeppelin to work in the new python environment.

3. The user disables the environment. (conda deactiavte)
It is restored to the original zeppelin.python environment.



---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts Just to clarify my concern. Here's what I see when I use 
conda outside of zeppelin.

Step 1. Create enviroment `env_1` using conda, and install pandas
Step 2. Set `zeppelin.python` to the binPath of `env_1` and restart python 
interpreter
Step 3. Now when I use python interpreter, I am using python of `env_1` and 
can use any libraries installed under `env_1` 

That means I just need to set `zeppelin.python` to switch to another conda 
env.  That's why I don't understand why you need to set additional Python 
library path for the new environment 


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts I have few questions. 

What happens when we want to implement `PythonPyenvInterpreter` which is 
similar to `PythonCondaInterpreter`?

- In that case, we have to add new functions to PythonInterpreter like 
`setPyEnvLib()...`?


---