[GitHub] zeppelin pull request #2582: fixed jdbc connection issue.

[astroshim]

GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/2582

fixed jdbc connection issue.

### What is this PR for?
This PR fixes JDBC connection release problem.

for example whenever i run not executable command like following

![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png)

new JDBC connection is made like following.
```
$ netstat -an |grep EST |grep 3306 |wc -l
   1
$ netstat -an |grep EST |grep 3306 |wc -l
   2
$ netstat -an |grep EST |grep 3306 |wc -l
   3
```


### What type of PR is it?
Bug Fix


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin feat/fixJdbcIssue

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2582.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2582


commit 9b99d21e9d2e637c34351ff3fdd54dc8748fe962
Author: Shim 
Date:   2017-09-12T05:22:59Z

fixed jdbc connection issue.




---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
I will merge to master


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
@felixcheung 
Thank you :)


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
Ok I think it's fine then




---

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

[astroshim]

Github user astroshim closed the pull request at:

https://github.com/apache/zeppelin/pull/2581


---

[GitHub] zeppelin pull request #2581: Fix/jdbc connection release 0.7

[astroshim]

GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/2581

Fix/jdbc connection release 0.7

### What is this PR for?
This PR fixes JDBC connection release problem.

for example whenever i run not executable command like following

![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png)

new JDBC connection is made like following.
```
$ netstat -an |grep EST |grep 3306 |wc -l
   1
$ netstat -an |grep EST |grep 3306 |wc -l
   2
$ netstat -an |grep EST |grep 3306 |wc -l
   3
```


### What type of PR is it?
Bug Fix


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin 
fix/jdbcConnectionRelease-0.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2581.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2581


commit b62e2e01bbdca87ab68a68ffae5e228217da5679
Author: AhyoungRyu 
Date:   2017-04-04T06:33:39Z

[ZEPPELIN-2341] Remove -Psparkr build profile

### What is this PR for?
Currently users who build Zeppelin from source need to include `-Psparkr` 
to use `%r` with embedded local Spark. But it's quite inconvenient to write 
this build profile every time we build i think. So I removed `-Psparkr` and 
make `r` related libraries automatically downloaded when we build Zeppelin like 
I did #2213

### What type of PR is it?
Improvement

### Todos
* [x] - remove the rest of `-Psparkr` build profile in 
`dev/create_release.sh`, `dev/publish_release.sh`, and `docs/install/build.md` 
after #2213 merged

### What is the Jira issue?
[ZEPPELIN-2341](https://issues.apache.org/jira/browse/ZEPPELIN-2341)

### How should this be tested?
1. Apply this patch
2. Build source with below command
```
mvn clean package -DskipTests -pl 'zeppelin-interpreter, zeppelin-zengine, 
zeppelin-server, zeppelin-display, spark, spark-dependencies'

```
Aftr this step, there will be `R` dir under 
`ZEPPELIN_HOME/interpreter/spark`. Before this PR, only `dep` dir and 
`zeppelin-spark_2.10-0.8.0-SNAPSHOT.jar` is generated without `-Psparkr` build 
profile.

4. Restart Zeppelin. To make sure, run R tutorial note under `Zeppelin 
Tutorial` folder

It should be run successfully without any error

### Screenshots (if appropriate)
If we build without `-Psparkr`
- before : R related properties are not activated by default in Spark 
interpreter
![screen shot 2017-04-03 at 4 31 49 
pm](https://cloud.githubusercontent.com/assets/10060731/24599560/b952e414-188b-11e7-80db-ac649c869c02.png)

 - after

![after](https://cloud.githubusercontent.com/assets/10060731/24599567/bc513a94-188b-11e7-9e93-7abca3428279.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no

Author: AhyoungRyu 
Author: Ahyoung Ryu 

Closes #2215 from AhyoungRyu/ZEPPELIN-2341/includeSparkRByDefault and 
squashes the following commits:

8db18cc [AhyoungRyu] Remove the rest of '-Psparkr' in docs & sh files
f891fd4 [Ahyoung Ryu] Merge branch 'master' into 
ZEPPELIN-2341/includeSparkRByDefault
445be3e [AhyoungRyu] Add SPARKR env to check each test case need to 
download r dep or not
67af02a [AhyoungRyu] Remove -PsparkR in travis file
a00466c [AhyoungRyu] Remove sparkr build profile in pom files

commit 32e86d02d8ea8fdc66a2c1a39bf5cc2317922556
Author: AhyoungRyu 
Date:   2017-04-04T06:47:21Z

[Minor] Fix wrong Python lib path in Matplotlib tutorial note

### What is this PR for?
There is a wrong information about Zeppelin’s matplotlib backend files. 
It actually located under `ZEPPELIN_HOME/interpreter/lib/python/*` but tutorial 
note says it as `ZEPPELIN_HOME/lib/python/*`. So I corrected it.

### What type of PR is it?
kind a typo fix

### What is the Jira issue?
N/A

### Screenshots (if appropriate)
 - Before
![screen shot 2017-04-04 at 3 50 06 
pm](https://cloud.githubusercontent.com/assets/10060731/24644505/e573d3a0-194e-11e7-826f-4022bc5e1572.png)

 - After
![screen shot 2017-04-04 at 3 50 56 
pm](https://cloud.githubusercontent.com/assets/10060731/24644507/e6ae25c2-194e-11e7-91d7-f42b327d820e.png)

### Questions:
* Does the licenses files need 

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@Madhuka Happy to see the icon. 

I just searched the license but couldn't find the license. It only says 
"free for commercial usage". Could you check it can be used even in opensource?

- 
https://docs.google.com/spreadsheets/u/1/d/1E8X2_xmJkkoeZwa1HPNG6jT3ytAZlcAgzTDRX0jDF-Q/pubhtml?gid=0=true
- http://support.iconfinder.com/quick-guide-to-iconfinder/license-overview


---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[malayhm]

Github user malayhm commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@1ambda Please see the 
https://user-images.githubusercontent.com/1881135/30287842-2e72d740-9744-11e7-8468-f9a86766487b.png;>
new screenshot with the new icon:




---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[malayhm]

Github user malayhm commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@1ambda It seems this icon is available in icon finder with free commercial 
use:

https://www.iconfinder.com/icons/476329/continued_detail_details_ellipses_more_icon#size=16

What do you think?


---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/2580

[ZEPPELIN-2924] Fix broken javascript source map

### What is this PR for?

Fixed broken javascript source map. The coverage loader should be used only 
for test env.

**that's really annoying because we can't set breakpoint and even can't see 
the original source code.**

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
[ZEPPELIN-2924](https://issues.apache.org/jira/browse/ZEPPELIN-2924)

### How should this be tested?

1. run the webapp as dev mode: `localhost:9000`
2. open the developer console and click any log message
3. check whether source is minified or not.
4. execute `yarn run test` in the terminal to check that coverage feature 
works well.

### Screenshots (if appropriate)

 Before


![image](https://user-images.githubusercontent.com/4968473/30260684-cc095240-9703-11e7-9fd6-fe5bd370a6bd.png)


![image](https://user-images.githubusercontent.com/4968473/30260690-d4f3494c-9703-11e7-854b-29d6020eaa3c.png)



 After


![image](https://user-images.githubusercontent.com/4968473/30260654-a27579d6-9703-11e7-9d2a-a37c7ae7b148.png)


![image](https://user-images.githubusercontent.com/4968473/30260655-a9c62802-9703-11e7-9d29-be10df0302d7.png)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2924/fix-source-map-is-broken

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2580


commit 375e13945b12a43aec47a4809b6b16be314ba001
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-11T06:09:10Z

fix: Use coverage loader only for test env




---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

Github user 1ambda closed the pull request at:

https://github.com/apache/zeppelin/pull/2580


---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@malayhm it's nice if we can remove `More` text and there is no license 
problem 👍 


---

[GitHub] zeppelin pull request #2578: [ZEPPELIN-2921] does not work conda environment...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2578


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
This is a hot-fix change.
Therefore, they merge quickly.


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
@zjffdu Thank you a lot :)


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
LGTM, just one concern about `PythonCondaInterpreterTest.java`. It is using 
mock which may not found potential bugs. I think we can do unit without mock. 
But anyway this could be done in a following up ticket. 


---

[GitHub] zeppelin issue #2449: [Zeppelin-2676] recent notes list

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2449
  
Ready to review (red for other tests )


---

[GitHub] zeppelin issue #2556: [Zeppelin-2839] permissions for folders

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2556
  
Ready to review (red for other tests )


---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[malayhm]

Github user malayhm commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@1ambda This is generally used for hamburger menu in mobile mode.

What do you think about a custom icon like this, this is used on Facebook?

![more-fb](https://user-images.githubusercontent.com/1881135/30270761-74375816-970b-11e7-8e36-3e68e02fda65.png)




---

[GitHub] zeppelin issue #2568: ZEPPELIN-2904 Show Remove Paragraph button upfront

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2568
  
@malayhm What about this icon? 


![image](https://user-images.githubusercontent.com/4968473/30270278-f62bdcc8-9726-11e7-883a-6204aab6abdb.png)

- http://fontawesome.io/icon/bars/

### Screenshot


![image](https://user-images.githubusercontent.com/4968473/30270330-32004496-9727-11e7-903e-ec99fd025558.png)




---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

[dwhsys]

Github user dwhsys commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
Can someone review please?


---

[GitHub] zeppelin issue #2578: [ZEPPELIN-2921] does not work conda environment in pyt...

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2578
  
If there are no comments anymore, I will merge to master on this pr.


---

[GitHub] zeppelin issue #2544: [ZEPPELIN-2724] Another Attempt to solve the dead lock...

[FireArrow]

Github user FireArrow commented on the issue:

https://github.com/apache/zeppelin/pull/2544
  
Any updates on this?


---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

Github user 1ambda closed the pull request at:

https://github.com/apache/zeppelin/pull/2580


---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

GitHub user 1ambda reopened a pull request:

https://github.com/apache/zeppelin/pull/2580

[ZEPPELIN-2924] Fix broken javascript source map

### What is this PR for?

Fixed broken javascript source map. The coverage loader should be used only 
for test env.

**that's really annoying because we can't set breakpoint and even can't see 
the original source code.**

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
[ZEPPELIN-2924](https://issues.apache.org/jira/browse/ZEPPELIN-2924)

### How should this be tested?

1. run the webapp as dev mode: `localhost:9000`
2. open the developer console and click any log message
3. check whether source is minified or not.
4. execute `yarn run test` in the terminal to check that coverage feature 
works well.

### Screenshots (if appropriate)

 Before


![image](https://user-images.githubusercontent.com/4968473/30260684-cc095240-9703-11e7-9fd6-fe5bd370a6bd.png)


![image](https://user-images.githubusercontent.com/4968473/30260690-d4f3494c-9703-11e7-854b-29d6020eaa3c.png)



 After


![image](https://user-images.githubusercontent.com/4968473/30260654-a27579d6-9703-11e7-9d2a-a37c7ae7b148.png)


![image](https://user-images.githubusercontent.com/4968473/30260655-a9c62802-9703-11e7-9d29-be10df0302d7.png)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2924/fix-source-map-is-broken

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2580


commit 375e13945b12a43aec47a4809b6b16be314ba001
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-11T06:09:10Z

fix: Use coverage loader only for test env




---

[GitHub] zeppelin issue #2558: sc.setLocalProperty(...) should be more deterministic

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2558
  
@ruseel Thanks for the update. Could you resolve zjffdu's last comment?


---

[GitHub] zeppelin pull request #2580: [ZEPPELIN-2924] Fix broken javascript source ma...

[1ambda]

GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/2580

[ZEPPELIN-2924] Fix broken javascript source map

### What is this PR for?

Fixed broken javascript source map. The coverage loader should be used only 
for test env.

**that's really annoying because we can't set breakpoint and even can't see 
the original source code.**

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
[ZEPPELIN-2924](https://issues.apache.org/jira/browse/ZEPPELIN-2924)

### How should this be tested?

1. run the webapp as dev mode: `localhost:9000`
2. open the developer console and click any log message
3. check whether source is minified or not.
4. execute `yarn run test` in the terminal to check that coverage feature 
works well.

### Screenshots (if appropriate)

 Before


![image](https://user-images.githubusercontent.com/4968473/30260684-cc095240-9703-11e7-9fd6-fe5bd370a6bd.png)


![image](https://user-images.githubusercontent.com/4968473/30260690-d4f3494c-9703-11e7-854b-29d6020eaa3c.png)



 After


![image](https://user-images.githubusercontent.com/4968473/30260654-a27579d6-9703-11e7-9d2a-a37c7ae7b148.png)


![image](https://user-images.githubusercontent.com/4968473/30260655-a9c62802-9703-11e7-9d29-be10df0302d7.png)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2924/fix-source-map-is-broken

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2580.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2580


commit 375e13945b12a43aec47a4809b6b16be314ba001
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-11T06:09:10Z

fix: Use coverage loader only for test env




---

[jira] [Created] (ZEPPELIN-2924) javascript source map is broken

[Hoon Park (JIRA)]

Hoon Park created ZEPPELIN-2924:
---

 Summary: javascript source map is broken
 Key: ZEPPELIN-2924
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2924
 Project: Zeppelin
  Issue Type: Bug
  Components: build, front-end
Reporter: Hoon Park
 Fix For: 0.8.0


javascript source map is broken



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)