[GitHub] zeppelin issue #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template so that...

2017-11-15 Thread kjmrknsn
Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2673
  
The build result on Travis CI turned to green: 
https://travis-ci.org/kjmrknsn/zeppelin/builds/302858138


---


[jira] [Created] (ZEPPELIN-3057) search notes by key words and return some same notebooks

2017-11-15 Thread ben teng (JIRA)
ben teng created ZEPPELIN-3057:
--

 Summary: search notes by key words and return some same notebooks
 Key: ZEPPELIN-3057
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3057
 Project: Zeppelin
  Issue Type: Improvement
Reporter: ben teng
Priority: Minor


search notes by key words and return some same notebooks



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ZEPPELIN-3056) Any user can see other users' notebooks from Job Manager

2017-11-15 Thread ben teng (JIRA)
ben teng created ZEPPELIN-3056:
--

 Summary: Any user can see other users' notebooks from Job Manager
 Key: ZEPPELIN-3056
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3056
 Project: Zeppelin
  Issue Type: Improvement
  Components: front-end, security
Affects Versions: 0.7.2
Reporter: ben teng


User can see other users' notebooks from Job 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[jira] [Created] (ZEPPELIN-3055) Zeppelin Spawning a Scala Interpreter

2017-11-15 Thread ajinkya mahakalkar (JIRA)
ajinkya mahakalkar created ZEPPELIN-3055:


 Summary: Zeppelin Spawning a Scala Interpreter
 Key: ZEPPELIN-3055
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3055
 Project: Zeppelin
  Issue Type: Task
Reporter: ajinkya mahakalkar
Priority: Critical


Hi Team,

Can anybody explain to me that how does Zeppelin Spawn a Scala Interpreter 
without using JSch or any other component to execute the flink code.
I am trying to build a flink interpreter in a similar way it is built in 
Zeppelin.
Any guidance will be of great help.

Thank you



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin pull request #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template ...

2017-11-15 Thread kjmrknsn
GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2673

[ZEPPELIN-3054] Update conf/shiro.ini.template so that non-admin users can 
restart interpreters on a notebook page

### What is this PR for?
On the default configuration of `conf/shiro.ini.template`, non admin users 
cannot restart interpreters on their notebook pages because the path 
`/api/interpreter/setting/restart/**` is not allowed to being accessed by non 
admin users.

https://user-images.githubusercontent.com/31149688/32875326-b0d1bf66-cada-11e7-98b7-6fd058cff3f6.png;>

It is convenient that all authenticated users can restart interpreters on 
their notebook pages by default, so the following line should be inserted into 
conf/shiro.ini.template:

```
/api/interpreter/setting/restart/** = authc
```

### What type of PR is it?
[Improvement]

### Todos

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3054

### How should this be tested?
* Tested manually. I confirmed that non admin users can restart 
interpreters on a notebook page but still cannot access to the interpreter 
settings page by using `conf/shiro.ini.template`.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin ZEPPELIN-3054

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2673.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2673


commit 37e736d8b8981b52e48131661c22eebfd66f0868
Author: Keiji Yoshida 
Date:   2017-11-16T05:28:43Z

[ZEPPELIN-3054] Update conf/shiro.ini.template so that non-admin users can 
restart interpreters on a notebook page




---


[GitHub] zeppelin issue #2653: [ZEPPELIN-3038] Network visualization not show "source...

2017-11-15 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2653
  
ah thanks, that seems useful... @1ambda would you like to take a look?


---


[jira] [Created] (ZEPPELIN-3054) Update conf/shiro.ini.template so that non-admin users can restart interpreters on a notebook page

2017-11-15 Thread Keiji Yoshida (JIRA)
Keiji Yoshida created ZEPPELIN-3054:
---

 Summary: Update conf/shiro.ini.template so that non-admin users 
can restart interpreters on a notebook page
 Key: ZEPPELIN-3054
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3054
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Keiji Yoshida
Assignee: Keiji Yoshida


On the default configuration of conf/shiro.ini.template, non admin users cannot 
restart interpreters on their notebook pages because the path 
"/api/interpreter/setting/restart/**" is not allowed to being accessed by non 
admin users.

It is convenient that any login users can restart interpreters on their 
notebook pages by default, so the following line should be inserted into 
conf/shiro.ini.template:

/api/interpreter/setting/restart/** = authc



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2668: ZEPPELIN-3051. Support Interpreter Process Recovery

2017-11-15 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2668
  
Closing `InterpreterSettingManager` is for shutting down interpreter 
processes, otherwise we would get dangling processes.  There's no other side 
effect. 


---


[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-15 Thread matyix
Github user matyix commented on the issue:

https://github.com/apache/zeppelin/pull/2637
  
Hello @echarles, thanks for the feedback, followed up on that and made the 
suggested changes, please see below: 

* use watcher instead of polling
* set driver prefix form config properties `spark.app.name`
* use sparkK8Launcher only if `deploy-mode=cluster`
* no updates needed to interpreter.sh
* added groupId to InterpreterLaunchContext

The branch can be merged as of now - unluckily the master is moving fast. 
I've seen your comment/branch a bit late  but pretty much made the same changes 
(like fixing the build). 


---


[GitHub] zeppelin issue #2650: [ZEPPELIN-3035] Ability to display the same result mul...

2017-11-15 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2650
  
@Leemoonsoo @1ambda what do you think?


---


[GitHub] zeppelin issue #2663: ZEPPELIN-3037 Configure Http Request Header Size Limit...

2017-11-15 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2663
  
looks good!
merging if no more comment


---


[GitHub] zeppelin issue #2672: Fix typo (isNotebokPublic -> isNotebookPublic)

2017-11-15 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2672
  
Thanks @kjmrknsn for the fix. LGTM and merge to master if no further 
comment.


---


[GitHub] zeppelin pull request #2672: Fix typo (isNotebokPublic -> isNotebookPublic)

2017-11-15 Thread kjmrknsn
GitHub user kjmrknsn opened a pull request:

https://github.com/apache/zeppelin/pull/2672

Fix typo (isNotebokPublic -> isNotebookPublic)

### What is this PR for?
Fix typo (isNotebokPublic -> isNotebookPublic)

### What type of PR is it?
[Refactoring]

### Todos

### What is the Jira issue?

### How should this be tested?
* By unit tests

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kjmrknsn/zeppelin feature/fix-typo

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2672.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2672


commit c131dd9c11d1c43abe8b4832a62e7c735ba8221b
Author: Keiji Yoshida 
Date:   2017-11-15T16:30:29Z

Fix typo (isNotebokPublic -> isNotebookPublic)




---


[jira] [Created] (ZEPPELIN-3053) Add authorization on notebook creation

2017-11-15 Thread Pierre Villard (JIRA)
Pierre Villard created ZEPPELIN-3053:


 Summary: Add authorization on notebook creation
 Key: ZEPPELIN-3053
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3053
 Project: Zeppelin
  Issue Type: Improvement
  Components: security
Reporter: Pierre Villard


Currently the creation of a new notebook cannot be managed through specific 
authorizations. Authorizations can only be set on existing notebooks. It would 
be really useful to be able to restrict the creation of new notebooks to admin 
users only.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

2017-11-15 Thread kjmrknsn
Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2671
  
The build result on Travis CI turned to green by rebuilding: 
https://travis-ci.org/kjmrknsn/zeppelin/builds/302473619


---


[GitHub] zeppelin issue #2664: [ZEPPELIN-771] Escape tab and CR when the result is sh...

2017-11-15 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/zeppelin/pull/2664
  
Thanks @zjffdu , then I am closing this. Let me know if I can help somehow.


---


[GitHub] zeppelin pull request #2664: [ZEPPELIN-771] Escape tab and CR when the resul...

2017-11-15 Thread mgaido91
Github user mgaido91 closed the pull request at:

https://github.com/apache/zeppelin/pull/2664


---


[GitHub] zeppelin issue #2637: Add support to run Spark interpreter on a Kubernetes c...

2017-11-15 Thread echarles
Github user echarles commented on the issue:

https://github.com/apache/zeppelin/pull/2637
  
PS1: I have pushed my fixes in 
zeppelin-k8s/tree/spark-interpreter-k8s-fixes branch (which has merge conflict 
with master due to latest commit 3b1a03f that touch the launchers and remote 
executors)

PS2: I have opened on PR to document this on the spark-k8s docs repo 
apache-spark-on-k8s/userdocs/pull/21



---


[GitHub] zeppelin issue #2669: available_interpreters.png replace.

2017-11-15 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2669
  
@AhyoungRyu Can you help to deploy it to the web?


---


[GitHub] zeppelin issue #2663: ZEPPELIN-3037 Configure Http Request Header Size Limit...

2017-11-15 Thread byamthev
Github user byamthev commented on the issue:

https://github.com/apache/zeppelin/pull/2663
  
I squashed commits, and our CI produced a new successfull build: 
https://travis-ci.org/nokia/zeppelin/builds/301902386 .
But it still shows "Jenkins is validating pull request..." after reopening 
the pull request, despite Jenkins build being successfull, this is what I got 
when I clicked on "Details": 
https://builds.apache.org/job/zeppelin-pull-request/3384/

But now that link is gone, it has been replaced with 
https://builds.apache.org/job/zeppelin-pull-request/
Except this everything else is fine. 


---


[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...

2017-11-15 Thread byamthev
GitHub user byamthev reopened a pull request:

https://github.com/apache/zeppelin/pull/2663

ZEPPELIN-3037 Configure Http Request Header Size Limit for Jetty

### What is this PR for?
In some deployment scenarios it is necessary to increase 
jetty.request.header.size, which default value is 8192. This will reduce the 
chance of HTTP Error 413 Request entity too large.
There should be a mechanism to configure this setting.


### What type of PR is it?
[Feature]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3037

### How should this be tested?
* There is an integration test (automated unit test included) for testing 
this feature.
* To test manually, after increasing setting, make any http request to 
zeppelin with a request header bigger than 8K , you should not get an HTTP 
Error 413 Request entity too large.

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin3037

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2663.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2663


commit 8ff2620dd996c64d27f3ec0b2f132234f7dbc957
Author: byamthev 
Date:   2017-11-14T11:42:18Z

[ZEPPELIN-3037] Configure Http Request Header Size Limit for Jetty




---


[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...

2017-11-15 Thread byamthev
Github user byamthev closed the pull request at:

https://github.com/apache/zeppelin/pull/2663


---


[GitHub] zeppelin issue #2664: [ZEPPELIN-771] Escape tab and CR when the result is sh...

2017-11-15 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2664
  
@mgaido91 Check the comments on 
https://issues.apache.org/jira/browse/ZEPPELIN-2992


---


[GitHub] zeppelin issue #2664: [ZEPPELIN-771] Escape tab and CR when the result is sh...

2017-11-15 Thread mgaido91
Github user mgaido91 commented on the issue:

https://github.com/apache/zeppelin/pull/2664
  
@felixcheung Since so far `\t` and `\n` are used as delimiters, there is no 
way to do that only on the front-end side, because currently there is no way 
for the frontend to know whether it is a `\t` or `\n` in the field or a 
separator.
If we want to fix this in the front-end, I think this is a much bigger task 
which would require a whole refactor of the communication protocol between 
back-end and frontend (so that we don't have anymore such separator or that 
there is a way to escape them) and the frontend itself in order to be able to 
manage those things. If this is the way we choose to go I am fine and I can 
help with them, but this would probable require a design document and some 
splitting in subtasks since it is going to be a huge refactor.
What do you think?


---


[GitHub] zeppelin pull request #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cann...

2017-11-15 Thread buxiaoliang
GitHub user buxiaoliang opened a pull request:

https://github.com/apache/zeppelin/pull/2670

[ZEPPELIN-3052] Chrome console: TypeError: Cannot set property 'principal' 
of undefined

### What is this PR for?
To fix console error when user logout after Apache Shiro enabled.


### What type of PR is it?
[Bug Fix]


### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3052

### Screenshots

![image](https://user-images.githubusercontent.com/11644623/32828564-6754c6cc-ca2a-11e7-9020-52a0e8817741.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/buxiaoliang/zeppelin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2670


commit 850c2fd259090dd9489d3602ad51aba276c24d19
Author: bur 
Date:   2017-11-15T09:19:15Z

[ZEPPELIN-3052] Chrome console: TypeError: Cannot set property 'principal' 
of undefined




---


[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

2017-11-15 Thread yu74n
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2416


---


[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

2017-11-15 Thread yu74n
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2416
  
Close this PR because Continued at #2585


---


[GitHub] zeppelin pull request #2525: [ZEPPELIN-2647] Make admin role to bypass auth ...

2017-11-15 Thread yu74n
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2525


---


[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-11-15 Thread yu74n
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
Close this PR because Continued at #2585


---


[jira] [Created] (ZEPPELIN-3052) Chrome console: TypeError: Cannot set property 'principal' of undefined

2017-11-15 Thread Bu Xiao-Liang (JIRA)
Bu Xiao-Liang created ZEPPELIN-3052:
---

 Summary: Chrome console: TypeError: Cannot set property 
'principal' of undefined
 Key: ZEPPELIN-3052
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3052
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.8.0
 Environment: Ubuntu 16.04
Reporter: Bu Xiao-Liang
Priority: Minor


When I enable Apache Shiro and Logout a user, console error:
TypeError: Cannot set property 'principal' of undefined



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin issue #2669: available_interpreters.png replace.

2017-11-15 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/2669
  
Thanks for the contribution. LGTM. Merge it sooner


---


[GitHub] zeppelin pull request #2669: available_interpreters.png replace.

2017-11-15 Thread kimjmin
GitHub user kimjmin opened a pull request:

https://github.com/apache/zeppelin/pull/2669

available_interpreters.png replace.

### What is this PR for?
Change `docs/assets/themes/zeppelin/img/available_interpreters.png` file.
replace old `elasticsearch` logo to new one.

### What type of PR is it?
Documentation

### Todos
* [x] - replace old `elasticsearch` logo to new one on 
`available_interpreters.png` file.

### What is the Jira issue?
N/A

### How should this be tested?
N/A

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N.
* Is there breaking changes for older versions? N.
* Does this needs documentation? N.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/kimjmin/zeppelin master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2669


commit 6134175921d2b2c727a46bc9207ead7c6ce129fc
Author: Jongmin Kim 
Date:   2017-11-15T08:03:46Z

available_interpreters.png file change.

Change `docs/assets/themes/zeppelin/img/available_interpreters.png`
file.
replace old `elasticsearch` logo to new one.

commit b5e5341011a6fea74a6f0d36bdcbc524756299d2
Author: Jongmin Kim 
Date:   2017-11-15T08:07:57Z

Revert "available_interpreters.png file change."

This reverts commit 6134175921d2b2c727a46bc9207ead7c6ce129fc.

commit 349194d9146cb8ce75879f04b4649ba6576a730a
Author: Jongmin Kim 
Date:   2017-11-15T08:16:04Z

available_interpreters.png file change.

Change `docs/assets/themes/zeppelin/img/available_interpreters.png`
file.
replace old `elasticsearch` logo to new one.




---