[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2687
  
@felixcheung Thanks for your reviewing.

> to be explicitly, let's add manually -> manually by an user opening this 
notebook

I fixed it. (I used a correct phrase of `a user`.)

Thanks.


---

[GitHub] zeppelin issue #2699: [MINOR] Fix notebook title bar margin

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2699
  
LGTM


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
this https://github.com/apache/zeppelin/pull/2695#issuecomment-349882841 is 
a good point...


---

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2676
  
@tinkoff-dwh The folder level permission looks nice. However, in my 
company's use case, we'd like to make a notebook readable for many users and 
restrict the user who can edit it only to the cron executing user when the cron 
schedule is set to it.


---

[GitHub] zeppelin issue #2687: [ZEPPELIN-3077] Cron scheduler is easy to get stuck wh...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2687
  
I'd be glad if any committers would review this PR.


---

[GitHub] zeppelin pull request #2699: [MINOR] Fix notebook title bar margin

[Leemoonsoo]

GitHub user Leemoonsoo opened a pull request:

https://github.com/apache/zeppelin/pull/2699

[MINOR] Fix notebook title bar margin

### What is this PR for?
Notebook title bar location is little bit shifted to left.
This minor fix notebook title bar margin. See screenshots below.

### What type of PR is it?
Bug Fix

### Todos
* [x] - fix margin

### Screenshots (if appropriate)
Before

![image](https://user-images.githubusercontent.com/1540981/33742650-3469c2fe-db5e-11e7-8aa6-936d0a28de3a.png)

After

![image](https://user-images.githubusercontent.com/1540981/33742640-250c3dc8-db5e-11e7-8af3-e8a9d7105963.png)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin minor_noteaction_margin

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2699.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2699


commit 703f45830cdb35d3e5d968297ec085534470f324
Author: Lee moon soo 
Date:   2017-12-07T22:50:42Z

fix noteAction magin




---

[GitHub] zeppelin pull request #2685: [ZEPPELIN-3075]Fix unqiue algo for the web side...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2685


---

[GitHub] zeppelin issue #2696: [ZEPPELIN-3091] Correct aggregation functionality in c...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2696
  
Thanks @namanmishra91 for important fix. Do you think you can add test case 
like https://github.com/apache/zeppelin/pull/2685, to ensure no future change 
break this aggregation behavior? Let me know if you need any help.


---

[jira] [Created] (ZEPPELIN-3096) a non owner of a note can change notes permissions

[gilbert marx (JIRA)]

gilbert marx created ZEPPELIN-3096:
--

 Summary: a non owner of a note can change notes permissions
 Key: ZEPPELIN-3096
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3096
 Project: Zeppelin
  Issue Type: Bug
  Components: security
Affects Versions: 0.7.3
 Environment: linux ubuntu 17.10
Reporter: gilbert marx


when i am on  a note as a user that is only Reader , i can change the 
permissions on this note and it is succsessfully done.

example:
admin is owner and writer on thie note and jdcuser is reader. I am loged as 
jdcuser
then i can add jdcuser as owner and writer and when Save this, it is done 
successfuly.

the other permissions are ok; jdcuser can't access to interpretter or to change 
the mode of the note.







--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin issue #2696: [ZEPPELIN-3091] Correct aggregation functionality in c...

[namanmishra91]

Github user namanmishra91 commented on the issue:

https://github.com/apache/zeppelin/pull/2696
  
Ping


---

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2676
  
The security is also important for our team.
I agree with @Leemoonsoo and @felixcheung about the sufficiency of existing 
roles.

We have PR about permissions for folders 
https://github.com/apache/zeppelin/pull/2556
Our plan is to have restricted subfolder in each user and group folder. The 
subfolder with name "restricted" will be viewble only for user/group owner of 
parent folder. If user cares about the security then he will put note in 
restricted subfolder.

@kjmrknsn, could folders with permissions solve your issue?


---

[jira] [Created] (ZEPPELIN-3095) Fix UI when all paragraphs executing sequentially

[Tinkoff DWH (JIRA)]

Tinkoff DWH created ZEPPELIN-3095:
-

 Summary: Fix UI when all paragraphs executing sequentially
 Key: ZEPPELIN-3095
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3095
 Project: Zeppelin
  Issue Type: Improvement
  Components: Core, zeppelin-server
Affects Versions: 0.8.0
Reporter: Tinkoff DWH
Assignee: Tinkoff DWH
 Fix For: 0.8.0


-If you press the clone note button, the new note will appear only after it's 
finished running.

-The paragraph adding button is active, but if you press it, the new paragraph 
will appear after the end of the work of the note. It is advisable not to 
display the paragraph adding button.

-If the note is running on Cron, then the jdbc paragraphs remain in the Running 
status, pyspark and md in the Pending status, until the note finishes running.
Need to display the correct statuses: Finished, Running

-Stop the execution on the paragraph itself also does not work - you need to 
disable the button

-Disable items in the drop-down menu:
- Move up
- Move down
- Insert new
- Clone paragraph
- Disable run
- Remove
!attachment-name.jpg|thumbnail!




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)