[GitHub] zeppelin issue #3018: [ZEPPELIN-3539] Add jceks stored password support for ...

2018-06-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3018
  
Thanks for the review will merge this if no more discussion.


---


[GitHub] zeppelin pull request #3022: ZEPPELIN-3519. zeppelin.spark.printREPLOutput d...

2018-06-14 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3022

ZEPPELIN-3519. zeppelin.spark.printREPLOutput doesn't work for new 
SparkInterpreter


### What is this PR for?
Straightforward fix to make `zeppelin.spark.printREPLOutput` work in 
`NewSparkInterpreter`


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3519

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3519

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3022.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3022


commit 9d3bbe5786884fafe96ba7550a62ee9c76bc71ec
Author: Jeff Zhang 
Date:   2018-06-01T04:54:16Z

ZEPPELIN-3519. zeppelin.spark.printREPLOutput doesn't work for new 
SparkInterpreter




---


[GitHub] zeppelin pull request #3021: ZEPPELIN-3352. Improve RemoteInterpreterProcess...

2018-06-14 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3021

ZEPPELIN-3352. Improve RemoteInterpreterProcess creation timeout mechanism

### What is this PR for?
This PR allow interpreter override `zeppelin.interpreter.connect.timeout` 
in zeppelin-site.xml. So that each interpreter can specify its own timeout 
threshold without restarting the zeppelin server in case he hit the timeout 
issue. Besides that I change the default timeout to be 60 seconds. This is what 
zeppelin did before. Although the default timeout is 30 seconds before, but 
RemoteInterpreterManagedProcess will still wait for 2 times of timeout 
threshold. So I directly change it to 60 secodns in this PR. 


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3352

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versons? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3352

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3021.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3021


commit 9426d8e415c40264c191af44c434dc9f9952c150
Author: Jeff Zhang 
Date:   2018-06-15T03:32:19Z

ZEPPELIN-3352. Improve RemoteInterpreterProcess creation timeout mechanism




---


[GitHub] zeppelin pull request #2986: ZEPPELIN-2035. BI directional RPC framework bet...

2018-06-14 Thread zjffdu
Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/2986


---


Re: Disable Flaky Test

2018-06-14 Thread Jeff Zhang
BTW, please* add unit test for any new PR* unless it is very trivial change
and other committer agree it is OK without unit test.  If you find it is
difficult to add unit test. There will be several reasons according my
experience.

1. It is due to the architecture and evolution of zeppelin, as more and
more components and features added to zeppelin, many things may be coupled
together which make it difficult to add unit test. In this case, please
comment in your PR why it is difficult to add unit test, and what is your
plan for that. Code refactoring in some component of zeppelin or unit test.

2. It is due to your PR that introduce too much complexity or didn't do it
in a elegant approach. In this case, please rethink your PR to improve it.




Jeff Zhang 于2018年6月15日周五 上午8:59写道:

> Hi Folks,
>
> The zeppelin travis become unstable again recently. I know it is really
> annoying and frustrated, so I create a PR to disable these flaky tests.
> There still some flaky test, but happens in low frequency. According my
> experience, if you still have travis build failure after this PR, you can
> try to rerun the travis build to get travis build pass. Just rerun the
> failed one, don't run the whole travis build matrix and also please clear
> travis cache first. If there's no objection, I would commit this PR. And
> after that, please keep travis build passed before you commit any new
> changes. Thanks.
>
> https://github.com/apache/zeppelin/pull/3020
>
>


[GitHub] zeppelin issue #3018: [ZEPPELIN-3539] Add jceks stored password support for ...

2018-06-14 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3018
  
LGTM


---


Disable Flaky Test

2018-06-14 Thread Jeff Zhang
Hi Folks,

The zeppelin travis become unstable again recently. I know it is really
annoying and frustrated, so I create a PR to disable these flaky tests.
There still some flaky test, but happens in low frequency. According my
experience, if you still have travis build failure after this PR, you can
try to rerun the travis build to get travis build pass. Just rerun the
failed one, don't run the whole travis build matrix and also please clear
travis cache first. If there's no objection, I would commit this PR. And
after that, please keep travis build passed before you commit any new
changes. Thanks.

https://github.com/apache/zeppelin/pull/3020


[GitHub] zeppelin pull request #3020: ZEPPELIN-3535. Disable flaky test

2018-06-14 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/3020

ZEPPELIN-3535. Disable flaky test

### What is this PR for?
This PR is trying to disable the flaky test of zeppelin that fails very 
frequently. 


### What type of PR is it?
[Bug Fix | Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3535

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3535

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3020.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3020


commit c30cd1f3712b658cd48a754e29baa30da8050fa5
Author: Jeff Zhang 
Date:   2018-06-13T03:13:04Z

ZEPPELIN-3535. Disable flaky test




---


[jira] [Created] (ZEPPELIN-3544) Option to show "hours ago" style timestamps at end of each paragraph

2018-06-14 Thread Matthew J Meyer (JIRA)
Matthew J Meyer created ZEPPELIN-3544:
-

 Summary: Option to show "hours ago" style timestamps at end of 
each paragraph
 Key: ZEPPELIN-3544
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3544
 Project: Zeppelin
  Issue Type: Improvement
  Components: GUI
Affects Versions: 0.7.3
Reporter: Matthew J Meyer


Currently the last execution duration and timestamp are show at the bottom of 
each paragraph as in these two examples:

Took 1 sec. Last updated by anonymous at June 13 2018, 7:26:11 PM. (outdated)

Took 2 sec. Last updated by anonymous at June 14 2018, 3:43:07 PM.

 

Mostly in the case where a paragraph is marked (outdated), it would be helpful 
to see the last execution timestamp expressed as "n Hours Ago" | "n Minutes 
ago" |"Moments Ago", etc.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZEPPELIN-3543) PDF export function for a printable business report

2018-06-14 Thread FlorianKuckelkorn (JIRA)
FlorianKuckelkorn created ZEPPELIN-3543:
---

 Summary: PDF export function for a printable business report
 Key: ZEPPELIN-3543
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3543
 Project: Zeppelin
  Issue Type: Wish
  Components: Core
Reporter: FlorianKuckelkorn


Hi,

it would be a very nice feature if it would be possible to integrate a pdf 
export function to create printable business reports. Maybe with the option to 
upload templates, maybe like a jinja template :)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ZEPPELIN-3542) Stop a pyspark paragraph cancels all the pyspark jobs of other users

2018-06-14 Thread Jhon Cardenas (JIRA)
Jhon Cardenas created ZEPPELIN-3542:
---

 Summary: Stop a pyspark paragraph cancels all the pyspark jobs of 
other users
 Key: ZEPPELIN-3542
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3542
 Project: Zeppelin
  Issue Type: Bug
  Components: pySpark
Affects Versions: 0.8.0
 Environment: This happen when the spark context is shared between 
users (scoped).
Reporter: Jhon Cardenas


Stop a pyspark paragraph cancels all the pyspark jobs of other users.

Cancel button in pyspark paragraph cancels Spark jobs for all users.

This happen when the spark context is shared between users (scoped).

It seems to be related with [the 
solution|https://github.com/apache/zeppelin/commit/9f22db91c279b7daf6a13b2d805a874074b070fd]
 for the task 
[ZEPPELIN-2075|https://issues.apache.org/jira/browse/ZEPPELIN-2075].

This solution is causing that when one particular user cancels his py-spark 
job, the py-spark jobs from all the users are being canceled !!.

When a py-spark job is cancelled, the method PySparkInterpreter interrupt() is 
invoked, and then the SIGINT event is called, causing that all the jobs in the 
same spark context be cancelled:

context.py:

# create a signal handler which would be invoked on receiving SIGINT
def signal_handler(signal, frame):
self.cancelAllJobs()
raise KeyboardInterrupt()



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin pull request #2615: [ZEPPELIN-1999][IMPROVEMENT] refactoring replac...

2018-06-14 Thread tinkoff-dwh
Github user tinkoff-dwh closed the pull request at:

https://github.com/apache/zeppelin/pull/2615


---


[jira] [Created] (ZEPPELIN-3541) (NameError) cannot load Java class org.apache.hadoop.hbase.quotas.ThrottleType

2018-06-14 Thread Bixing Xie (JIRA)
Bixing Xie created ZEPPELIN-3541:


 Summary: (NameError) cannot load Java class 
org.apache.hadoop.hbase.quotas.ThrottleType
 Key: ZEPPELIN-3541
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3541
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.7.3
 Environment: Apache Zeppelin: 0.7.3

Apache Spark: 2.3.1

Hadoop: 3.1.0

Hbase: 1.2.6.1

Java: 1.8.0_172

 

 
Reporter: Bixing Xie


I am having trouble setting up Hbase interpreter on Apache Zeppelin. I tested 
Zeppelin with Spark and it worked. I was also able to run Hbase shell from the 
command line. However, when I tried to run Hbase on Zeppelin, I got the 
following error: 

 
org.jruby.exceptions.RaiseException: (NameError) cannot load Java class 
org.apache.hadoop.hbase.quotas.ThrottleType
at 
org.jruby.javasupport.JavaUtilities.get_proxy_or_package_under_package(org/jruby/javasupport/JavaUtilities.java:54)
at (Anonymous).method_missing(/builtin/javasupport/java.rb:51)
at (Anonymous).(root)(/usr/local/Hbase/lib/ruby/hbase/quotas.rb:23)
at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1062)
at (Anonymous).(root)(/usr/local/Hbase/lib/ruby/hbase/quotas.rb:24)
at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1062)
at (Anonymous).(root)(/usr/local/Hbase/lib/ruby/hbase/hbase.rb:98)
at org.jruby.RubyKernel.require(org/jruby/RubyKernel.java:1062)
at (Anonymous).(root)(/usr/local/Hbase/lib/ruby/hbase.rb:118)
 
 I found relevant posts that address this problem and the solution there was to 
use Hbase from 1.2.0. But it didn't really work. Any help would be appreciated. 
Thank you very much. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-14 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3013
  
Tested this PR locally on FF, Safari, Chrome, and Edge25 works well.

The only concern over here is which one should we be removing the "legacy 
method" or the one that is avail with the data-grid table. I mean the "legacy 
method"  is always shown even when the visualization is selected, and the 
download button on data-grid get hidden as soon as visualization.

If we all agree to this then LGTM.


---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread andreaTP
Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
actually a more detailed description is available here: 
https://github.com/apache/zeppelin/pull/2552/files


---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread andreaTP
Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
I think the link is broken.
here: https://github.com/apache/zeppelin/pull/2373/files


---


[GitHub] zeppelin issue #3013: [ZEPPELIN-3511] remove old button "Download Data as CS...

2018-06-14 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3013
  
LGTM, @prabhjyotsingh Could you please verify it finally? I'll merge it 
there's no more discussion.


---


[GitHub] zeppelin issue #2974: ZEPPELIN-3472 No interpreter status is shown after res...

2018-06-14 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2974
  
I think the green light can be easily mis-interpreted. If you have any 
other suggestion on the icon to use perhaps we could revisit.



---


[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

2018-06-14 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@xixikaikai 
https://github.com/apache/zeppelin/pull/2373#issuecomment-323267967


---