[GitHub] felixcheung opened a new pull request #3317: [ZEPPELIN-4026] document anonymous access
felixcheung opened a new pull request #3317: [ZEPPELIN-4026] document anonymous access URL: https://github.com/apache/zeppelin/pull/3317 ### What is this PR for? doc update ### What type of PR is it? [Documentation] ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4026 ### Questions: * Does the licenses files need update? N * Is there breaking changes for older versions? N * Does this needs documentation? N This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4026) Doc should warn about anonymous access
Felix Cheung created ZEPPELIN-4026: -- Summary: Doc should warn about anonymous access Key: ZEPPELIN-4026 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4026 Project: Zeppelin Issue Type: Bug Reporter: Felix Cheung -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] liuxunorg commented on issue #3316: [ZEPPELIN-3985]. Move note permission from notebook-authorization.json to note file
liuxunorg commented on issue #3316: [ZEPPELIN-3985]. Move note permission from notebook-authorization.json to note file URL: https://github.com/apache/zeppelin/pull/3316#issuecomment-468980057 This improvement will be very helpful. To solve the problem of a large number of notes, The `notebook-authorization.json` file is too large for performance issues. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] felixcheung commented on a change in pull request #3316: [ZEPPELIN-3985]. Move note permission from notebook-authorization.json to note file
felixcheung commented on a change in pull request #3316: [ZEPPELIN-3985]. Move
note permission from notebook-authorization.json to note file
URL: https://github.com/apache/zeppelin/pull/3316#discussion_r261848513
##
File path:
zeppelin-plugins/notebookrepo/git/src/test/java/org/apache/zeppelin/notebook/repo/NotebookRepoSyncTest.java
##
@@ -1,417 +1,414 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- *http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-package org.apache.zeppelin.notebook.repo;
-
-import static com.google.common.truth.Truth.assertThat;
-import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertTrue;
-import static org.mockito.Mockito.mock;
-
-import com.google.common.io.Files;
-import java.io.File;
-import java.io.IOException;
-import java.util.HashSet;
-import java.util.Map;
-import java.util.Set;
-import org.apache.commons.io.FileUtils;
-import org.apache.zeppelin.conf.ZeppelinConfiguration;
-import org.apache.zeppelin.conf.ZeppelinConfiguration.ConfVars;
-import org.apache.zeppelin.display.AngularObjectRegistryListener;
-import org.apache.zeppelin.helium.ApplicationEventListener;
-import org.apache.zeppelin.interpreter.InterpreterFactory;
-import org.apache.zeppelin.interpreter.InterpreterSettingManager;
-import org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcessListener;
-import org.apache.zeppelin.notebook.Note;
-import org.apache.zeppelin.notebook.NoteInfo;
-import org.apache.zeppelin.notebook.Notebook;
-import org.apache.zeppelin.notebook.NotebookAuthorization;
-import org.apache.zeppelin.notebook.Paragraph;
-import org.apache.zeppelin.search.SearchService;
-import org.apache.zeppelin.storage.ConfigStorage;
-import org.apache.zeppelin.user.AuthenticationInfo;
-import org.apache.zeppelin.user.Credentials;
-import org.junit.After;
-import org.junit.Before;
-import org.junit.Test;
-import org.quartz.SchedulerException;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
-
-// TODO(zjffdu) move it to zeppelin-zengine
-public class NotebookRepoSyncTest {
-
- private File ZEPPELIN_HOME;
- private ZeppelinConfiguration conf;
- private File mainNotebookDir;
- private File secNotebookDir;
- private Notebook notebookSync;
- private NotebookRepoSync notebookRepoSync;
- private InterpreterFactory factory;
- private InterpreterSettingManager interpreterSettingManager;
- private SearchService search;
- private NotebookAuthorization notebookAuthorization;
- private Credentials credentials;
- private AuthenticationInfo anonymous;
- private static final Logger LOG =
LoggerFactory.getLogger(NotebookRepoSyncTest.class);
-
- @Before
- public void setUp() throws Exception {
-ZEPPELIN_HOME = Files.createTempDir();
-new File(ZEPPELIN_HOME, "conf").mkdirs();
-String mainNotePath = ZEPPELIN_HOME.getAbsolutePath() + "/notebook";
-String secNotePath = ZEPPELIN_HOME.getAbsolutePath() +
"/notebook_secondary";
-mainNotebookDir = new File(mainNotePath);
-secNotebookDir = new File(secNotePath);
-mainNotebookDir.mkdirs();
-secNotebookDir.mkdirs();
-
-System.setProperty(ConfVars.ZEPPELIN_HOME.getVarName(),
ZEPPELIN_HOME.getAbsolutePath());
-System.setProperty(ConfVars.ZEPPELIN_NOTEBOOK_DIR.getVarName(),
mainNotebookDir.getAbsolutePath());
-System.setProperty(ConfVars.ZEPPELIN_NOTEBOOK_STORAGE.getVarName(),
"org.apache.zeppelin.notebook.repo.VFSNotebookRepo,org.apache.zeppelin.notebook.repo.mock.VFSNotebookRepoMock");
-System.setProperty(ConfVars.ZEPPELIN_NOTEBOOK_ONE_WAY_SYNC.getVarName(),
"false");
-System.setProperty(ConfVars.ZEPPELIN_CONFIG_FS_DIR.getVarName(),
ZEPPELIN_HOME.getAbsolutePath() + "/conf");
-System.setProperty(ConfVars.ZEPPELIN_PLUGINS_DIR.getVarName(), new
File("../../../plugins").getAbsolutePath());
-
-LOG.info("main Note dir : " + mainNotePath);
-LOG.info("secondary note dir : " + secNotePath);
-conf = ZeppelinConfiguration.create();
-
-ConfigStorage.reset();
-
-interpreterSettingManager = new InterpreterSettingManager(conf,
-mock(AngularObjectRegistryListener.class),
mock(RemoteInterpreterProcessListener.class),
mock(ApplicationEventListener.class));
-factory = new
[GitHub] felixcheung commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter
felixcheung commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter URL: https://github.com/apache/zeppelin/pull/3092#issuecomment-468976886 ah yes, thanks for looking into this. it's a long standing problem with scala version in scala builds. I think it's a good idea to upgrade beam This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zjffdu commented on a change in pull request #3308: [ZEPPELIN-3986]. Cannot access any JAR in yarn cluster mode
zjffdu commented on a change in pull request #3308: [ZEPPELIN-3986]. Cannot
access any JAR in yarn cluster mode
URL: https://github.com/apache/zeppelin/pull/3308#discussion_r261828124
##
File path:
zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/SparkIntegrationTest.java
##
@@ -80,7 +85,14 @@ public static void tearDown() throws IOException {
}
}
- private void testInterpreterBasics() throws IOException,
InterpreterException {
+ private void testInterpreterBasics() throws IOException,
InterpreterException, XmlPullParserException {
+// add jars & packages for testing
+InterpreterSetting sparkInterpreterSetting =
interpreterSettingManager.getInterpreterSettingByName("spark");
+sparkInterpreterSetting.setProperty("spark.jars.packages",
"com.maxmind.geoip2:geoip2:2.5.0");
Review comment:
It may already shipped to spark driver and put under classpath. So it is
better to use some other libraries.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] asfgit closed pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
asfgit closed pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2 URL: https://github.com/apache/zeppelin/pull/3307 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] zjffdu commented on a change in pull request #3307: ZEPPELIN-4005. SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
zjffdu commented on a change in pull request #3307: ZEPPELIN-4005.
SparkRInterpreter is broken for spark 2.1.3 and 2.2.2
URL: https://github.com/apache/zeppelin/pull/3307#discussion_r261827398
##
File path:
zeppelin-interpreter-integration/src/test/java/org/apache/zeppelin/integration/ZeppelinSparkClusterTest21.java
##
@@ -34,7 +34,7 @@ public ZeppelinSparkClusterTest21(String sparkVersion)
throws Exception {
@Parameterized.Parameters
public static List data() {
return Arrays.asList(new Object[][]{
-{"2.1.2"}
+{"2.1.3"}
Review comment:
0.5.0 is the latest livy release, livy community is discussing release of
0.6.0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] selvinsource edited a comment on issue #3092: [ZEPPELIN-3653] - New Java interpreter
selvinsource edited a comment on issue #3092: [ZEPPELIN-3653] - New Java interpreter URL: https://github.com/apache/zeppelin/pull/3092#issuecomment-468902863 > oh wait, I didn't realize this comment [#3092 (comment)](https://github.com/apache/zeppelin/pull/3092#issuecomment-410957256) is not related to ZEPPELIN-3742 > > do we need a fix for `beam-runners-flink_2.10` As I mentioned before, that's nothing new, it's been there since the Beam interpreter was added, it never supported scala 2.11, see the notes on https://github.com/apache/zeppelin/blob/master/beam/README.md "Flink runner comes with binary compiled for scala 2.10. So, currently we support only Scala 2.10". By doing a quick search somebody else already created JIRAs for this https://issues.apache.org/jira/browse/ZEPPELIN-3903 https://issues.apache.org/jira/browse/ZEPPELIN-3899 @novelari perhaps is in the best position to update the beam-runners-flink to a most up to date version to support both scala 2.10 and 2.11, I am not that familiar with Beam/Flink. A solution could be to use profiles in beam/pom.xml to activate either https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink_2.10/2.2.0 or https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink_2.11/2.3.0 depending on the scala version. For example ```xml scala-2.10 true org.apache.beam beam-runners-flink_2.10 2.2.0 scala-2.11 org.apache.beam beam-runners-flink_2.11 2.3.0 ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] selvinsource commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter
selvinsource commented on issue #3092: [ZEPPELIN-3653] - New Java interpreter URL: https://github.com/apache/zeppelin/pull/3092#issuecomment-468902863 > oh wait, I didn't realize this comment [#3092 (comment)](https://github.com/apache/zeppelin/pull/3092#issuecomment-410957256) is not related to ZEPPELIN-3742 > > do we need a fix for `beam-runners-flink_2.10` As I mentioned before, that's nothing new, it's been there since the Beam interpreter was added, it never supported scala 2.11, see the notes on https://github.com/apache/zeppelin/blob/master/beam/README.md "Flink runner comes with binary compiled for scala 2.10. So, currently we support only Scala 2.10". By doing a quick search somebody else already created JIRAs for this https://issues.apache.org/jira/browse/ZEPPELIN-3903 https://issues.apache.org/jira/browse/ZEPPELIN-3899 @novelari perhaps is in the best position to update the beam-runners-flink to a most up to date version to support both scala 2.10 and 2.11, I am not that familiar with Beam/Flink. A solution could be to use profiles in beam/pom.xml to activate either https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink_2.10/2.2.0 or https://mvnrepository.com/artifact/org.apache.beam/beam-runners-flink_2.11/2.3.0 depending on the scala version. For example scala-2.10 true org.apache.beam beam-runners-flink_2.10 2.2.0 scala-2.11 org.apache.beam beam-runners-flink_2.11 2.3.0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
