[GitHub] [zeppelin] zjffdu opened a new pull request #3882: [ZEPPELIN-4987]. CLASSPATH is polluted in zeppelin-daemon.sh

2020-08-18 Thread GitBox


zjffdu opened a new pull request #3882:
URL: https://github.com/apache/zeppelin/pull/3882


   ### What is this PR for?
   
   This PR fix the CLASSPATH issue by using `ZEPPELIN_CLASSPATH` instead of 
`CLASSPATH`. Otherwise for some systems, zeppelin/lib will be put on the 
classpath of spark interpreter which cause conflicts with spark dependencies. 
   
   ### What type of PR is it?
   [Improvement]
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * https://issues.apache.org/jira/browse/ZEPPELIN-4987
   
   ### How should this be tested?
   
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update? No
   * Is there breaking changes for older versions? No
   * Does this needs documentation? No
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[jira] [Created] (ZEPPELIN-5002) JDK version in docs is not updated

2020-08-18 Thread Yurim Jay Jin (Jira)
Yurim Jay Jin created ZEPPELIN-5002:
---

 Summary: JDK version in docs is not updated
 Key: ZEPPELIN-5002
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5002
 Project: Zeppelin
  Issue Type: Bug
  Components: documentation
Affects Versions: 0.9.0
 Environment: Java 8 is required to building from source.

In 'install' page, it is 1.8 (151+)
[http://zeppelin.apache.org/docs/0.9.0-preview2/quickstart/install.html]

 

but in 'build' page, it's 1.7
Reporter: Yurim Jay Jin
Assignee: Yurim Jay Jin






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ZEPPELIN-5003) Add property to add new repository for flink dependencies

2020-08-18 Thread Jeff Zhang (Jira)
Jeff Zhang created ZEPPELIN-5003:


 Summary: Add property to add new repository for flink dependencies
 Key: ZEPPELIN-5003
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5003
 Project: Zeppelin
  Issue Type: Improvement
  Components: flink
Affects Versions: 0.9.0
Reporter: Jeff Zhang






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [zeppelin] zjffdu commented on pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly

2020-08-18 Thread GitBox


zjffdu commented on pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881#issuecomment-675541232


   Thanks for the contribution @milooy +1



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] Reamer commented on a change in pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

2020-08-18 Thread GitBox


Reamer commented on a change in pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880#discussion_r472267915



##
File path: docs/setup/basics/how_to_build.md
##
@@ -41,8 +41,8 @@ If you want to build from source, you must first install the 
following dependenc
 3.1.x or higher
   
   
-JDK
-1.7
+OpenJDK or Oracle JDK  

Review comment:
   Can you please remove the tab character after `JDK`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] Reamer commented on a change in pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

2020-08-18 Thread GitBox


Reamer commented on a change in pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880#discussion_r472267915



##
File path: docs/setup/basics/how_to_build.md
##
@@ -41,8 +41,8 @@ If you want to build from source, you must first install the 
following dependenc
 3.1.x or higher
   
   
-JDK
-1.7
+OpenJDK or Oracle JDK  

Review comment:
   Can you please remove the tab character after 'JDK'?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] milooy opened a new pull request #3881: [ZEPPELIN-4777] Fix - Number types are not sorted correctly

2020-08-18 Thread GitBox


milooy opened a new pull request #3881:
URL: https://github.com/apache/zeppelin/pull/3881


   ### What is this PR for?
   
   
   **Before**
   set sort type 'Number' but still sorted with string 
   
![image](https://user-images.githubusercontent.com/3839771/90523012-5d571e80-e1a7-11ea-8721-2586dbbf7407.png)
   
   After
   Sorted with correct type
   
![image](https://user-images.githubusercontent.com/3839771/90523292-a8713180-e1a7-11ea-9ae7-9d896fe4bfe9.png)
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5002
   
   ### How should this be tested?
   * First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   * Is there breaking changes for older versions?
   * Does this needs documentation?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] milooy opened a new pull request #3880: [ZEPPELIN-5002] Update JDK version in documentation

2020-08-18 Thread GitBox


milooy opened a new pull request #3880:
URL: https://github.com/apache/zeppelin/pull/3880


   ### What is this PR for?
   Java 8 is required to building from source.
   
   In 'install' page, it is 1.8 (151+)
   http://zeppelin.apache.org/docs/0.9.0-preview2/quickstart/install.html
   
   
   but in 'build' page, it's 1.7
   
http://zeppelin.apache.org/docs/0.9.0-preview2/setup/basics/how_to_build.html#how-to-build-zeppelin-from-source
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5002
   
   ### How should this be tested?
   * First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed 
behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   * Is there breaking changes for older versions?
   * Does this needs documentation?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] Reamer commented on pull request #3875: [ZEPPELIN-4989] Update to Maven resolver

2020-08-18 Thread GitBox


Reamer commented on pull request #3875:
URL: https://github.com/apache/zeppelin/pull/3875#issuecomment-675329068


   I notice a strange behaviour with the `zeppelin-interpreter-shaded.jar`. 
With this PR, `org/apache/commons/logging/` is now part of the jar
   
   To reproduce:
- Checkout this PR
- Run Maven `mvn clean package -DskipTests -am -pl 
zeppelin-interpreter-shaded`
- Take a look into 
`zeppelin-interpreter-shaded/target/zeppelin-interpreter-shaded-0.9.0-SNAPSHOT.jar`
   ```
  0  Defl:N2   0% 2020-08-18 09:53   
org/apache/commons/logging/
  0  Defl:N2   0% 2020-08-18 09:53   
org/apache/commons/logging/impl/
   2063  Defl:N  628  70% 2020-08-18 09:53 9cb659ff  
org/apache/commons/logging/impl/NoOpLog.class
   1097  Defl:N  589  46% 2020-08-18 09:53 33ccd884  
org/apache/commons/logging/impl/SimpleLog$1.class
   9385  Defl:N 4173  56% 2020-08-18 09:53 8147c2bb  
org/apache/commons/logging/impl/SimpleLog.class
   3258  Defl:N 1157  65% 2020-08-18 09:53 b06f724a  
org/apache/commons/logging/impl/SLF4JLocationAwareLog.class
   2999  Defl:N 1061  65% 2020-08-18 09:53 bdd4455d  
org/apache/commons/logging/impl/SLF4JLog.class
   3983  Defl:N 1829  54% 2020-08-18 09:53 43798863  
org/apache/commons/logging/impl/SLF4JLogFactory.class
479  Defl:N  263  45% 2020-08-18 09:53 38ec5139  
org/apache/commons/logging/Log.class
   1298  Defl:N  664  49% 2020-08-18 09:53 d5b8f550  
org/apache/commons/logging/LogConfigurationException.class
   4828  Defl:N 1792  63% 2020-08-18 09:53 c89451e3  
org/apache/commons/logging/LogFactory.class
   ```
   
   **I need some help here, because I don't know why this is happening.**



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [zeppelin] Reamer edited a comment on pull request #3859: [ZEPPELIN-4978] Build separate Zeppelin server and interpreter images

2020-08-18 Thread GitBox


Reamer edited a comment on pull request #3859:
URL: https://github.com/apache/zeppelin/pull/3859#issuecomment-674858227


   Hello @zhoulii,
   Thank you very much for checking and reviewing this PR. I have changed 
ZEPPELIN_HOME in our example 
[configMapKeyRef](https://github.com/apache/zeppelin/blob/master/k8s/zeppelin-server.yaml#L33)
 to /opt/zeppelin. I have also added your provided code in 
K8sRemoteInterpreterProcess.java
   
   I will change the default home of Zeppelin in a separate PR to conform to 
the [Filesystem Hierarchy 
Standard](https://en.wikipedia.org/wiki/Filesystem_Hierarchy_Standard).
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org