[GitHub] [zeppelin] zhugezifang commented on pull request #4606: feat:improve query efficiency
zhugezifang commented on PR #4606: URL: https://github.com/apache/zeppelin/pull/4606#issuecomment-1569408191 hi @Reamer @jongyoul @huage1994 ,could you help me to review this pr? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings
Reamer commented on PR #4609: URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568471013 Let's wait for the tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] matthias-koch commented on pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings
matthias-koch commented on PR #4609: URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568393762 Let's do it this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings
Reamer commented on PR #4609:
URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568373139
It seems that the data types are different. What do you think about simply
counting down?
```
rowNumber = min(len(rows), len(df.index.values))
for idx, row in zip(index, rows):
rowNumber = rowNumber - 1;
if (rowNumber == 0)
body_buf.write("\n")
```
A screenshot of my reproduction
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [zeppelin] matthias-koch commented on pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings
matthias-koch commented on PR #4609: URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568120874 I could limit it to DeprecationWarnings. Another option would be to check the type of index. However to do this I would have to import numpy in zeppelin_context.py, which I wanted to avoid. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] matthias-koch opened a new pull request, #4610: [ZEPPELIN-5921] Fix sync with remote repository
matthias-koch opened a new pull request, #4610: URL: https://github.com/apache/zeppelin/pull/4610 ### What is this PR for? If you use the plugin GithubNotebookRepo to sync the notes with a remote git repository, moved and deleted notes are not synced. This issue has been fixed. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5921 ### How should this be tested? * New unit test were added ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] Reamer commented on pull request #4609: [ZEPPELIN-5920] Fix deprecation warnings
Reamer commented on PR #4609: URL: https://github.com/apache/zeppelin/pull/4609#issuecomment-1568088732 Do you think it would be smart to ignore all the warnings? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ZEPPELIN-5921) GithubNotebookRepo does not sync moved and deleted notes to remote
Matthias Koch created ZEPPELIN-5921: --- Summary: GithubNotebookRepo does not sync moved and deleted notes to remote Key: ZEPPELIN-5921 URL: https://issues.apache.org/jira/browse/ZEPPELIN-5921 Project: Zeppelin Issue Type: Bug Components: zeppelin-zengine Affects Versions: 0.10.1 Reporter: Matthias Koch If you use the plugin GithubNotebookRepo to sync the notes with a remote git repository, moved and deleted notes are not synced. *Observed result:* * Moving a note produces an empty commit * Deletion of a note produces no commit *Expected result:* * Moving and deletion of notes are synced with the remote repository. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [zeppelin] matthias-koch opened a new pull request, #4609: [ZEPPELIN-5920] Fix deprecation warnings
matthias-koch opened a new pull request, #4609: URL: https://github.com/apache/zeppelin/pull/4609 ### What is this PR for? If z.show is used with a Panda DataFrame that has a timestamp as index, then a DeprecationWarning appears for every row in the data frame. This issue was fixed. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-5920 ### How should this be tested? * A new nit test was added ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ZEPPELIN-5920) DeprecationWarning when using z.show with non Integer index in DataFrame
Matthias Koch created ZEPPELIN-5920:
---
Summary: DeprecationWarning when using z.show with non Integer
index in DataFrame
Key: ZEPPELIN-5920
URL: https://issues.apache.org/jira/browse/ZEPPELIN-5920
Project: Zeppelin
Issue Type: Bug
Components: python
Affects Versions: 0.10.1
Reporter: Matthias Koch
If z.show is used with a Panda DataFrame that has a timestamp as index, then a
DeprecationWarning appears for every row in the data frame.
*Steps to reproduce:*
* Execute the following code with python interpreter:
{code:python}
import pandas as pd
idx = pd.date_range('20230530', periods=3, freq='D')
df = pd.DataFrame({'name':['a','b','c']}, index= idx)
z.show(df, show_index=True){code}
*Expected result:*
* A table of the data frame
* No warnings
*Observed result:*
* A table of the data frame
* A deprecation warning for every row in the data frame
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [zeppelin] ntheanh201 opened a new pull request, #4608: fix conjars repository url
ntheanh201 opened a new pull request, #4608: URL: https://github.com/apache/zeppelin/pull/4608 ### What is this PR for? Fix broken url of conjars repository. The old link: https://conjars.org/repo is deprecated, changed to https://conjars.wensel.net/repo ### What type of PR is it? Bug Fix ### What is the Jira issue? ### How should this be tested? * CI ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? * Is there breaking changes for older versions? * Does this needs documentation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4604: [ZEPPELIN-5917] Integration tests with newer spark version
jongyoul merged PR #4604: URL: https://github.com/apache/zeppelin/pull/4604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] jongyoul merged pull request #4605: [ZEPPELIN-5918] Use Classloader class for flink creation
jongyoul merged PR #4605: URL: https://github.com/apache/zeppelin/pull/4605 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
