[GitHub] zeppelin issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3253 I'm not aware of release plan in Zeppelin since I'm just one of contributors. For the current status, the Spark should be downgraded as far as I can tell. ---
[GitHub] zeppelin issue #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3253 Spark 2.4 support was added at https://github.com/apache/zeppelin/pull/3206, which exactly addresses the issue you faced. This will be available in new release of Zeppelin. ---
[GitHub] zeppelin pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/zeppelin/pull/3253 [ZEPPELIN-3551] Upgrade Scala to 2.11.12 ### What is this PR for? This is just to update scala to 2.11.12 which to be consistent with spark (SPARK-24418). This PR takes over and closes #3033 There was a minor conflict which my PR (https://github.com/apache/zeppelin/pull/3206) introduced. That change is compatible with both Scala 2.11.8 and 2.11.12 so we don't need to change it anymore. ### What type of PR is it? [Improvement] ### Todos * [ ] - None ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3551 ### How should this be tested? - CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin scala-2.11.12 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3253.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3253 commit 7d00314f8ec48556f75fe9877dcbee0d6e7ce2fe Author: Jeff Zhang Date: 2018-06-19T07:32:27Z ZEPPELIN-3551. Upgrade Scala to 2.11.12 ---
[GitHub] zeppelin pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/3253 ---
[GitHub] zeppelin issue #3034: [WIP] ZEPPELIN-3552. Support Scala 2.12 of SparkInterp...
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3034 Hey Jeff, I can take over this one too if you're busy since I took a look for similar code paths. ---
[GitHub] zeppelin pull request #3253: [ZEPPELIN-3551] Upgrade Scala to 2.11.12
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/zeppelin/pull/3253 [ZEPPELIN-3551] Upgrade Scala to 2.11.12 ### What is this PR for? This is just to update scala to 2.11.12 which to be consistent with spark (SPARK-24418). This PR takes over and closes #3033 There was a minor conflict which my PR (https://github.com/apache/zeppelin/pull/3206) introduced. That change is compatible with both Scala 2.11.8 and 2.11.12 so we don't need to change it anymore. ### What type of PR is it? [Improvement] ### Todos * [ ] - None ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3551 ### How should this be tested? - CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin scala-2.11.12 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3253.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3253 commit 7d00314f8ec48556f75fe9877dcbee0d6e7ce2fe Author: Jeff Zhang Date: 2018-06-19T07:32:27Z ZEPPELIN-3551. Upgrade Scala to 2.11.12 ---
[GitHub] zeppelin issue #3033: ZEPPELIN-3551. Upgrade Scala to 2.11.12
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3033 Hey @zjffdu, busy? I can take this over - looks there's only minor conflict. ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 This fix is not released yet. This PR exactly fixes the problem you faced. This fix will be available in the next release of Zeppelin. ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Thank you all!! ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Hey all ~ could this get in by any change maybe? ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Thank you guys! ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Ah, yeap. sure. ---
[GitHub] zeppelin issue #3206: [ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 This should be ready for a look as is. I already tested Spark 2.4.0. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Thanks for confirmation. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 I also tested this patch against Spark RC5. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 BTW, I tested this via my Travis CI - https://travis-ci.org/HyukjinKwon/zeppelin/builds/448215776. Tests seems got passed. ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/zeppelin/pull/3206 [WIP][ZEPPELIN-3810] Support Spark 2.4 ### What is this PR for? Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see SPARK-24418). There are two problems for this upgrade at Zeppelin side: 1.. Some methods that are used in private by reflection, for instance, `loopPostInit` became inaccessible. See: - https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala - https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala To work around this, I manually ported `loopPostInit` at 2.11.8 to retain the behaviour. Some functions that are commonly existing at both Scala 2.11.8 and Scala 2.11.12 are used inside of the new `loopPostInit` by reflection. 2.. Upgrade from 2.11.8 to 2.11.12 requires `jline.version` upgrade. Otherwise, we will hit: ``` Caused by: java.lang.NoSuchMethodError: jline.console.completer.CandidateListCompletionHandler.setPrintSpaceAfterFullCompletion(Z)V at scala.tools.nsc.interpreter.jline.JLineConsoleReader.initCompletion(JLineReader.scala:139) ``` To work around this, I tweaked this by upgrading jline from `2.12.1` to `2.14.3`. ### What type of PR is it? [Improvement] ### Todos * [ ] - Wait until Spark 2.4.0 is officially released. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3810 ### How should this be tested? Verified manually against Spark 2.4.0 RC3 ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin ZEPPELIN-3810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit 9ac1797a7e175a73350d61a0e62b3e4f89b29b8f Author: hyukjinkwon Date: 2018-10-17T14:41:29Z Support Spark 2.4 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/3206 ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 It should be usable if the changes is cherry-picked properly. This PR basically just replace one line: https://github.com/apache/zeppelin/blob/v0.8.0/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala#L84 to a private function. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 The error message: ``` [ERROR] /home/cloud-user/ajay/code/csf-cc-zeppelin-k8szep/spark/scala-2.11/src/main/scala/org/apache/zeppelin/spark/SparkScala211Interpreter.scala:37: error: class SparkScala211Interpreter needs to be abstract, since method interpret in class BaseSparkScalaInterpreter of type (code: String, context: org.apache.zeppelin.interpreter.InterpreterContext)org.apache.zeppelin.interpreter.InterpreterResult is not defined ``` complains there's no `interpret` method defined at `BaseSparkScalaInterpreter`. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Does that happen only with this code changes? The change here does not touch signature at `class SparkScala211Interpreter(` and the error message looks pretty unrelated. The whole change proposed here does not change any signature. ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 Nope, it will work for both 2.11.8 and 2.11.12. I manually checked. This change only uses the methods existing in both 2.11.8 and 2.11.12 at Scala. ---
[GitHub] zeppelin issue #3034: [WIP] ZEPPELIN-3552. Support Scala 2.12 of SparkInterp...
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3034 > Spark 2.4 will officially support Scala 2.12, so it will be great if Zeppelin will support it together with Spark. And also, there are some libs that are Scala 2.12 only The default distribution will still be with Scala 2.11 for Spark 2.4 if I am not mistaken. It is nice to support it but Spark 2.4 with 2.11 should be supported first as a higher priority. I can work on 2.4.0 with 2.12 support further after this one got merged. ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/3206 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/zeppelin/pull/3206 [WIP][ZEPPELIN-3810] Support Spark 2.4 ### What is this PR for? Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see SPARK-24418). There are two problems for this upgrade at Zeppelin side: 1.. Some methods that are used in private by reflection, for instance, `loopPostInit` became inaccessible. See: - https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala - https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala To work around this, I manually ported `loopPostInit` at 2.11.8 to retain the behaviour. Some functions that are commonly existing at both Scala 2.11.8 and Scala 2.11.12 are used inside of the new `loopPostInit` by reflection. 2.. Upgrade from 2.11.8 to 2.11.12 requires `jline.version` upgrade. Otherwise, we will hit: ``` Caused by: java.lang.NoSuchMethodError: jline.console.completer.CandidateListCompletionHandler.setPrintSpaceAfterFullCompletion(Z)V at scala.tools.nsc.interpreter.jline.JLineConsoleReader.initCompletion(JLineReader.scala:139) ``` To work around this, I tweaked this by upgrading jline from `2.12.1` to `2.14.3`. ### What type of PR is it? [Improvement] ### Todos * [ ] - Wait until Spark 2.4.0 is officially released. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3810 ### How should this be tested? Verified manually against Spark 2.4.0 RC3 ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin ZEPPELIN-3810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit e2d224aadf0e54533837a9a89f8e9d3586aee3a9 Author: hyukjinkwon Date: 2018-10-17T14:41:29Z Support Spark 2.4 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/zeppelin/pull/3206 [WIP][ZEPPELIN-3810] Support Spark 2.4 ### What is this PR for? Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see SPARK-24418). There are two problems for this upgrade at Zeppelin side: 1.. Some methods that are used in private by reflection, for instance, `loopPostInit` became inaccessible. See: - https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala - https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala To work around this, I manually ported `loopPostInit` at 2.11.8 to retain the behaviour. Some functions that are commonly existing at both Scala 2.11.8 and Scala 2.11.12 are used inside of the new `loopPostInit` by reflection. 2.. Upgrade from 2.11.8 to 2.11.12 requires `jline.version` upgrade. Otherwise, we will hit: ``` Caused by: java.lang.NoSuchMethodError: jline.console.completer.CandidateListCompletionHandler.setPrintSpaceAfterFullCompletion(Z)V at scala.tools.nsc.interpreter.jline.JLineConsoleReader.initCompletion(JLineReader.scala:139) ``` To work around this, I tweaked this by upgrading jline from `2.12.1` to `2.14.3`. ### What type of PR is it? [Improvement] ### Todos * [ ] - Wait until Spark 2.4.0 is officially released. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3810 ### How should this be tested? Verified manually against Spark 2.4.0 RC3 ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin ZEPPELIN-3810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit e2d224aadf0e54533837a9a89f8e9d3586aee3a9 Author: hyukjinkwon Date: 2018-10-17T14:41:29Z Support Spark 2.4 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/3206 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/3206 ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
GitHub user HyukjinKwon reopened a pull request: https://github.com/apache/zeppelin/pull/3206 [WIP][ZEPPELIN-3810] Support Spark 2.4 ### What is this PR for? Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see SPARK-24418). There are two problems for this upgrade at Zeppelin side: 1.. Some methods that are used in private by reflection, for instance, `loopPostInit` became inaccessible. See: - https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala - https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala To work around this, I manually ported `loopPostInit` at 2.11.8 to retain the behaviour. Some functions that are commonly existing at both Scala 2.11.8 and Scala 2.11.12 are used inside of the new `loopPostInit` by reflection. 2.. Upgrade from 2.11.8 to 2.11.12 requires `jline.version` upgrade. Otherwise, we will hit: ``` Caused by: java.lang.NoSuchMethodError: jline.console.completer.CandidateListCompletionHandler.setPrintSpaceAfterFullCompletion(Z)V at scala.tools.nsc.interpreter.jline.JLineConsoleReader.initCompletion(JLineReader.scala:139) ``` To work around this, I tweaked this by upgrading jline from `2.12.1` to `2.14.3`. ### What type of PR is it? [Improvement] ### Todos * [ ] - Wait until Spark 2.4.0 is officially released. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3810 ### How should this be tested? Verified manually against Spark 2.4.0 RC3 ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin ZEPPELIN-3810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit e2d224aadf0e54533837a9a89f8e9d3586aee3a9 Author: hyukjinkwon Date: 2018-10-17T14:41:29Z Support Spark 2.4 ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 oops. I haven't. Will check that too while I am here. BTW, my understanding is that we need this one as well since Spark still can be compiled against Scala 2.11.x, am I in the right way? ---
[GitHub] zeppelin issue #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/3206 This is a WIP. We should wait for Spark 2.4.0. cc @zjffdu and @felixcheung ---
[GitHub] zeppelin pull request #3206: [WIP][ZEPPELIN-3810] Support Spark 2.4
GitHub user HyukjinKwon opened a pull request: https://github.com/apache/zeppelin/pull/3206 [WIP][ZEPPELIN-3810] Support Spark 2.4 ### What is this PR for? Spark 2.4 changed it's Scala version from 2.11.8 to 2.11.12 (see SPARK-24418). There are two problems for this upgrade at Zeppelin side: 1.. Some methods that are used in private by reflection, for instance, `loopPostInit` became inaccessible. See: - https://github.com/scala/scala/blob/v2.11.8/src/repl/scala/tools/nsc/interpreter/ILoop.scala - https://github.com/scala/scala/blob/v2.11.12/src/repl/scala/tools/nsc/interpreter/ILoop.scala To work around this, I manually ported `loopPostInit` at 2.11.8 to retain the behaviour. Some functions that are commonly existing at both Scala 2.11.8 and Scala 2.11.12 are used inside of the new `loopPostInit` by reflection. 2.. Upgrade from 2.11.8 to 2.11.12 requires `jline.version` upgrade. Otherwise, we will hit: ``` Caused by: java.lang.NoSuchMethodError: jline.console.completer.CandidateListCompletionHandler.setPrintSpaceAfterFullCompletion(Z)V at scala.tools.nsc.interpreter.jline.JLineConsoleReader.initCompletion(JLineReader.scala:139) ``` To work around this, I tweaked this by upgrading jline from `2.12.1` to `2.14.3`. ### What type of PR is it? [Improvement] ### Todos * [ ] - Wait until Spark 2.4.0 is officially released. ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3810 ### How should this be tested? Verified manually against Spark 2.4.0 RC3 ### Questions: * Does the licenses files need update? Yes * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/HyukjinKwon/zeppelin ZEPPELIN-3810 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/3206.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3206 commit e2d224aadf0e54533837a9a89f8e9d3586aee3a9 Author: hyukjinkwon Date: 2018-10-17T14:41:29Z Support Spark 2.4 ---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/1763 Thanks @fellixcheng, would I maybe have to retrigger the build for the green? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/1763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
GitHub user HyukjinKwon reopened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
Github user HyukjinKwon closed the pull request at: https://github.com/apache/zeppelin/pull/1763 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/1763 Thank you, @AhyoungRyu. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1763: [MINOR] Add trivial cosmetic changes on STYLE.md
Github user HyukjinKwon commented on the issue: https://github.com/apache/zeppelin/pull/1763 Hi @felixcheung, it seems the last change was by you. Could you please take a look? I think I am not used to this and also not sure if this change is good or not but just decided to submit this as it just looks a little bit prettier apparently. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1763: [MINOR] Add trivial cosmetic changes on STYLE.m...
GitHub user HyukjinKwon opened a pull request:
https://github.com/apache/zeppelin/pull/1763
[MINOR] Add trivial cosmetic changes on STYLE.md
### What is this PR for?
This PR proposes a little bit of cosmetic changes on `STYLE.md`.
**Before**
```
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
**After**
```diff
"src-noconflict/mode-sql.js",
"src-noconflict/mode-markdown.js",
"src-noconflict/keybinding-emacs.js",
"src-noconflict/ext-language_tools.js",
+ "src-noconflict/theme-github.js"],
"version": "1.1.8",
"name": "ace-builds"
},
"highlightjs": {
"main": ["highlight.pack.js",
+ "styles/github.css"],
"version": "8.4.0",
"name": "highlightjs"
}
```
```diff
- $scope.editor.setTheme('ace/theme/github');
+ $scope.editor.setTheme('ace/theme/monokai');
```
```diff
- "src-noconflict/theme-github.js"],
+ "src-noconflict/theme-monokai.js"],
```
### What type of PR is it?
[Documentation]
### What is the Jira issue?
MINOR
### How should this be tested?
Manually checked the rendering
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HyukjinKwon/zeppelin minor-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1763.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1763
commit a6fcbd31baa92c726a54e7b917f54903160396bf
Author: hyukjinkwon <gurwls...@gmail.com>
Date: 2016-12-15T02:44:24Z
Add trivial cosmetic changes on STYLE.md
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
