[GitHub] zeppelin issue #2663: ZEPPELIN-3037 Configure Http Request Header Size Limit...
Github user byamthev commented on the issue: https://github.com/apache/zeppelin/pull/2663 I squashed commits, and our CI produced a new successfull build: https://travis-ci.org/nokia/zeppelin/builds/301902386 . But it still shows "Jenkins is validating pull request..." after reopening the pull request, despite Jenkins build being successfull, this is what I got when I clicked on "Details": https://builds.apache.org/job/zeppelin-pull-request/3384/ But now that link is gone, it has been replaced with https://builds.apache.org/job/zeppelin-pull-request/ Except this everything else is fine. ---
[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...
GitHub user byamthev reopened a pull request: https://github.com/apache/zeppelin/pull/2663 ZEPPELIN-3037 Configure Http Request Header Size Limit for Jetty ### What is this PR for? In some deployment scenarios it is necessary to increase jetty.request.header.size, which default value is 8192. This will reduce the chance of HTTP Error 413 Request entity too large. There should be a mechanism to configure this setting. ### What type of PR is it? [Feature] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3037 ### How should this be tested? * There is an integration test (automated unit test included) for testing this feature. * To test manually, after increasing setting, make any http request to zeppelin with a request header bigger than 8K , you should not get an HTTP Error 413 Request entity too large. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin3037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2663.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2663 commit 8ff2620dd996c64d27f3ec0b2f132234f7dbc957 Author: byamthev <byamt...@gmail.com> Date: 2017-11-14T11:42:18Z [ZEPPELIN-3037] Configure Http Request Header Size Limit for Jetty ---
[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...
Github user byamthev closed the pull request at: https://github.com/apache/zeppelin/pull/2663 ---
[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...
GitHub user byamthev reopened a pull request: https://github.com/apache/zeppelin/pull/2663 ZEPPELIN-3037 Configure Http Request Header Size Limit for Jetty ### What is this PR for? In some deployment scenarios it is necessary to increase jetty.request.header.size, which default value is 8192. This will reduce the chance of HTTP Error 413 Request entity too large. There should be a mechanism to configure this setting. ### What type of PR is it? [Feature] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3037 ### How should this be tested? * There is an integration test (automated unit test included) for testing this feature. * To test manually, after increasing setting, make any http request to zeppelin with a request header bigger than 8K , you should not get an HTTP Error 413 Request entity too large. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin3037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2663.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2663 commit 8ff2620dd996c64d27f3ec0b2f132234f7dbc957 Author: byamthev <byamt...@gmail.com> Date: 2017-11-14T11:42:18Z [ZEPPELIN-3037] Configure Http Request Header Size Limit for Jetty ---
[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...
Github user byamthev closed the pull request at: https://github.com/apache/zeppelin/pull/2663 ---
[GitHub] zeppelin issue #2663: ZEPPELIN-3037 Configure Http Request Header Size Limit...
Github user byamthev commented on the issue: https://github.com/apache/zeppelin/pull/2663 Ok I will check it now, Don't know why link to Jenkins was missing. Will squash commits at same time. ---
[GitHub] zeppelin pull request #2663: ZEPPELIN-3037 Configure Http Request Header Siz...
GitHub user byamthev opened a pull request: https://github.com/apache/zeppelin/pull/2663 ZEPPELIN-3037 Configure Http Request Header Size Limit for Jetty ### What is this PR for? In some deployment scenarios it is necessary to increase jetty.request.header.size, which default value is 8192. This will reduce the chance of HTTP Error 413 Request entity too large. There should be a mechanism to configure this setting. ### What type of PR is it? [Feature] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3037 ### How should this be tested? *There is an integration test (automated unit test included) for testing this feature. * To test manually, after increasing setting, make any http request to zeppelin with a request header bigger than 8K , you should not get an HTTP Error 413 Request entity too large. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin3037 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2663.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2663 commit 8855318b3911198b2566bb55b24b7e5ee7abeefa Author: byamthev <byamt...@gmail.com> Date: 2017-11-06T14:43:38Z increasing request header size limit (adding test) commit ad26190c72ec73483af78c8b1d21c239c20ab112 Author: byamthev <byamt...@gmail.com> Date: 2017-11-06T15:22:31Z increasing request header size limit (adding test) commit ad8a3ce2573824e103c35c2b861e50c0d72aea11 Author: byamthev <byamt...@gmail.com> Date: 2017-11-06T15:52:42Z increasing request header size limit commit 7ad5fc8535e04e08306920004f720a057ab8899b Author: byamthev <byamt...@gmail.com> Date: 2017-11-07T08:40:17Z increasing request header size limit (debug test in CI) commit 35d4ef0692b997836cb5c4c4382d311839e788d0 Author: byamthev <byamt...@gmail.com> Date: 2017-11-07T11:12:55Z increasing request header size limit (debug test in CI) commit 9b55a9829d88b8e9708e64d3a7b4213d22beca7f Author: byamthev <byamt...@gmail.com> Date: 2017-11-08T08:23:33Z investigating why test passed with 200 commit ff99271bf0e282f539fd040ff41a1a53e8f17b18 Author: byamthev <byamt...@gmail.com> Date: 2017-11-08T08:44:37Z investigating why test passed with 200 commit bdc3a0dd96e79662d713fa334c0adbd6fff4816a Author: byamthev <byamt...@gmail.com> Date: 2017-11-08T09:47:05Z test is ok removing debugging code commit f6590d15397a8cffb5876c75bf11b0a585bf1437 Author: byamthev <byamt...@gmail.com> Date: 2017-11-08T12:37:53Z adding license information commit 3d8879801ab6bd091fe42b55353b3fded39affa8 Author: byamthev <byamt...@gmail.com> Date: 2017-11-10T07:29:37Z adding test for default value commit d6174405248b7d9527804e872a656f61170fb31f Author: byamthev <byamt...@gmail.com> Date: 2017-11-10T10:27:06Z adding test for default value ---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Github user byamthev commented on the issue: https://github.com/apache/zeppelin/pull/2551 ping @felixchang ---
[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...
Github user byamthev commented on the issue: https://github.com/apache/zeppelin/pull/2551 Yes, I have now added a JUnit test. ---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
GitHub user byamthev reopened a pull request: https://github.com/apache/zeppelin/pull/2551 [ZEPPELIN-2880] - Fix username output when OIDC is enabled ### What is this PR for? When OIDC is enabled, user's roles/permissions/tokens are sent to Zeppelin's client via websocket and appears in the web browser when running a paragraph in a notebook. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2880](https://issues.apache.org/jira/browse/ZEPPELIN-2880) ### How should this be tested? Enable OIDC , login to Zeppelin and run a paragraph. Check the text "Last updated by". ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin_2880 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2551.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2551 commit 72636897ca17d8702a79decc4cbdf9a024d70ab5 Author: byamthev <byamt...@gmail.com> Date: 2017-08-25T08:04:52Z [ZEPPELIN-2880] - Fix username output when OIDC is enabled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
Github user byamthev closed the pull request at: https://github.com/apache/zeppelin/pull/2551 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2551: [ZEPPELIN-2880] - Fix username output when OIDC...
GitHub user byamthev opened a pull request: https://github.com/apache/zeppelin/pull/2551 [ZEPPELIN-2880] - Fix username output when OIDC is enabled ### What is this PR for? When OIDC is enabled, user's roles/permissions/tokens are sent to Zeppelin's client via websocket and appears in the web browser when running a paragraph in a notebook. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2880](https://issues.apache.org/jira/browse/ZEPPELIN-2880) ### How should this be tested? Enable OIDC , login to Zeppelin and run a paragraph. Check the text "Last updated by". ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin zeppelin_2880 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2551.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2551 commit 72636897ca17d8702a79decc4cbdf9a024d70ab5 Author: byamthev <byamt...@gmail.com> Date: 2017-08-25T08:04:52Z [ZEPPELIN-2880] - Fix username output when OIDC is enabled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-1...
Github user byamthev closed the pull request at: https://github.com/apache/zeppelin/pull/2527 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-1...
GitHub user byamthev reopened a pull request: https://github.com/apache/zeppelin/pull/2527 [ZEPPELIN-2770] Zeppelin is not working in IE-11 ### What is this PR for? There is a javascript error while loading zeppelin homepage in IE-11, causing a blank page to appear. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2770](https://issues.apache.org/jira/browse/ZEPPELIN-2770) ### How should this be tested? Try opening Zeppelin homepage in IE-11. ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin IE_COMPATIBILITY Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2527 commit 81cfde88ecfe2fa04b800c19e4a874396f12fa2d Author: yammathe <boutros.yamma_theve...@nokia.com> Date: 2017-07-12T10:49:50Z fix IE bug: startsWith do not exists for string commit 2d7230e92d0f88fa03619d198a2af3aa0305b476 Author: yammathe <boutros.yamma_theve...@nokia.com> Date: 2017-08-16T09:38:46Z [ZEPPELIN-2770] Zeppelin is not working in IE-11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-11
Github user byamthev commented on the issue: https://github.com/apache/zeppelin/pull/2527 @1ambda I checked your comment and corrected, thanks. (note: I restarted the CI job that failed because of flaky tests) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2527: [ZEPPELIN-2770] Zeppelin is not working in IE-1...
GitHub user byamthev opened a pull request: https://github.com/apache/zeppelin/pull/2527 [ZEPPELIN-2770] Zeppelin is not working in IE-11 ### What is this PR for? There is a javascript error while loading zeppelin homepage in IE-11, causing a blank page to appear. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2770](https://issues.apache.org/jira/browse/ZEPPELIN-2770) ### How should this be tested? Try opening Zeppelin homepage in IE-11. ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/nokia/zeppelin IE_COMPATIBILITY Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2527.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2527 commit 81cfde88ecfe2fa04b800c19e4a874396f12fa2d Author: yammathe <boutros.yamma_theve...@nokia.com> Date: 2017-07-12T10:49:50Z fix IE bug: startsWith do not exists for string --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
