[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1777 @prabhjyotsingh I resolved the conflict. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1792: Change gitignore for font files
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1792 Change gitignore for font files ### What is this PR for? Some web fonts were changed by 5552319378e8361a16c91df2ba3cdf5519b74d58 but `.gitignore` was not changed accordingly. ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? ### How should this be tested? Build zeppelin and check `git status` whether there are untracked files. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin gitignore Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1792.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1792 commit 7e6e6a2ea3e92d2bf594c81b1bc13f4298e46625 Author: Sangwoo Lee Date: 2016-12-22T13:55:17Z Change gitignore for font files --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1777: [ZEPPELIN-1831] Fix paragraph control dropdown ...
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1777 [ZEPPELIN-1831] Fix paragraph control dropdown alignment ### What is this PR for? Paragraph control dropdown is displayed outside when the browser width is small. To fix this problem, this PR uses `.dropdown-menu-right` bootstrap css class to make the dropdown right aligned with its parent so that it is always displayed inside of the paragraph. ref. http://v4-alpha.getbootstrap.com/components/dropdowns/#menu-alignment ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1831 ### How should this be tested? Decrease browser width and click a paragraph control icon. ### Screenshots (if appropriate) [Before]  [After]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1831 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1777.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1777 commit 1ab98f4b4eac09772b9efc1511c05857d462fcd4 Author: Sangwoo Lee Date: 2016-12-16T16:21:41Z Fix paragraph control dropdown alignment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1771: [ZEPPELIN-1820] Fix action bar layout broken is...
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1771 [ZEPPELIN-1820] Fix action bar layout broken issue ### What is this PR for? Action bar buttons and paragraph are overlapped when the browser width is small. To fix this issue, this PR replaces `height` css property for action bar with `min-height` and adds a binding code for `window resize` to dynamically change the paragraph position based on the height of action bar. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1820 ### How should this be tested? Change browser width ### Screenshots (if appropriate) [Before]  [After]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1820 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1771.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1771 commit 01e2a9841a981d2dea454de1f67e849e2f2dc71d Author: Sangwoo Lee Date: 2016-12-15T16:27:49Z Fix action bar layout broken issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable for notename is used directly as the model of input field and it doesn't revert the blank notename back to its existing name even though the notename was actually not updated to the blank value. (Temporarily lost notename from scope) To resolve this issue, I added a variable to `ElasticInputCtrl` for the model of input field. This change can always make the notename valid. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1753 ### How should this be tested? Input blank notename on action bar and.. - Check the notename on action bar - Click 'Export this note' button and check the downloaded json filename. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1753 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1733 commit 25c2ebf6df01b28a551ff7a0f3fc2af1de19db52 Author: Sangwoo Lee Date: 2016-12-07T13:34:03Z Fix blank notename issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1733: [ZEPPELIN-1753] Fix blank notename issue
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1733 @cuspymd Thank you for review! Maybe ZEPPELIN-1763 should be fixed by another PR. :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun It works well! Thank you very much for accepting my opinions. :smiley: I think that handling `~Trash` prefix in the future is fine to me because it is not a bug but just my opinion :) However, I found a minor problem. When a folder name has a trailing space, it is not moved to trash. For example, "My folder /My note". I think that you can handle this corner case in the future work! Thanks again for considering my opinions. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1728 I've tested it and works as expected. LGTM! But please trigger CI again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable for notename is used directly as the model of input field and it doesn't revert the blank notename back to its existing name even though the notename was actually not updated to the blank value. (Temporarily lost notename from scope) To resolve this issue, I added a variable to `ElasticInputCtrl` for the model of input field. This change can always make the notename valid. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1753 ### How should this be tested? Input blank notename on action bar and.. - Check the notename on action bar - Click 'Export this note' button and check the downloaded json filename. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1753 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1733 commit 25c2ebf6df01b28a551ff7a0f3fc2af1de19db52 Author: Sangwoo Lee Date: 2016-12-07T13:34:03Z Fix blank notename issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable for notename is used directly as the model of input field and it doesn't revert the blank notename back to its existing name even though the notename was actually not updated to the blank value. (Temporarily lost notename from scope) To resolve this issue, I added a variable to `ElasticInputCtrl` for the model of input field. This change can always make the notename valid. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1753 ### How should this be tested? Input blank notename on action bar and.. - Check the notename on action bar - Click 'Export this note' button and check the downloaded json filename. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1753 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1733 commit 25c2ebf6df01b28a551ff7a0f3fc2af1de19db52 Author: Sangwoo Lee Date: 2016-12-07T13:34:03Z Fix blank notename issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1733 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1733: [ZEPPELIN-1753] Fix blank notename issue
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1733 [ZEPPELIN-1753] Fix blank notename issue ### What is this PR for? Note ID is displayed on action bar after pressing enter key with blank notename. This is because the scope variable for notename is used directly as the model of input field and it doesn't revert the blank notename back to its existing name even though the notename was actually not updated to the blank value. (Temporarily lost notename from scope) To resolve this issue, I added a variable to `ElasticInputCtrl` for the model of input field. This change can always make the notename valid. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1753 ### How should this be tested? Input blank notename on action bar and.. - Check the notename on action bar - Click 'Export this note' button and check the downloaded json filename. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin ZEPPELIN-1753 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1733.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1733 commit 25c2ebf6df01b28a551ff7a0f3fc2af1de19db52 Author: Sangwoo Lee Date: 2016-12-07T13:34:03Z Fix blank notename issue --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1723 @tae-jun Thanks for your quick reply. I triggered CI again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
GitHub user marchpig reopened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of the input field. Getting the placeholder text from `noteName()` is unnecessary because the text is visible only when the notename is blank. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1747 ### How should this be tested? Type Korean notename in action bar using Firefox browser. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin fix-korean-notename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1723 commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52 Author: Sangwoo Lee Date: 2016-12-03T13:52:47Z Fix Korean notename input problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
Github user marchpig closed the pull request at: https://github.com/apache/zeppelin/pull/1723 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1723: [ZEPPELIN-1747] Fix Korean notename input probl...
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1723 [ZEPPELIN-1747] Fix Korean notename input problem ### What is this PR for? Korean notename is incorrectly typed on Firefox. This PR fixes the issue by changing placeholder attribute of the input field. Getting the placeholder text from `noteName()` is unnecessary because the text is only visible when the notename is blank. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1747 ### How should this be tested? Type Korean notename in action bar using Firefox browser. ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin fix-korean-notename Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1723.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1723 commit 666f30ced0acdbf05aa4c4ce445f4d090f461c52 Author: Sangwoo Lee Date: 2016-12-03T13:52:47Z Fix Korean notename input problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1684 I've tested it on both Win7 and Ubuntu 12.04. > Win7 32bit (IE11, Chrome 54.0) > Ubuntu 12.04 64bit (Firefox 43.0) This issue only occurred on Ubuntu 12.04 so I think @1ambda's guess is reliable. Is there anyone who can test it on Win7 64bit? Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1684: Fix filter icon not displaying problem
Github user marchpig commented on the issue: https://github.com/apache/zeppelin/pull/1684 @AhyoungRyu This issue occurs on the two different browsers in my environment(Ubuntu 16.04 64-bit). > Firefox 50.0 > Chromium browser 53.0.2785.143 So I guess it doesn't depend on browsers. Could you please check whether `.note-name-query` class is the latest in the file below? > zeppelin/zeppelin-web/dist/styles/main.css Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1684: Fix filter icon not displaying problem
GitHub user marchpig opened a pull request: https://github.com/apache/zeppelin/pull/1684 Fix filter icon not displaying problem ### What is this PR for? Filter icon is not displayed properly due to the css font-family order. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? ### How should this be tested? See filter input box in the home page or navbar. ### Screenshots (if appropriate) [Before]  [After]  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/marchpig/zeppelin fix-filter-icon Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1684.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1684 commit bc92c4ec0efb48ab80a65bac19b55a7828db7757 Author: Sangwoo Lee Date: 2016-11-26T05:47:22Z Fix filter icon not displaying problem --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
