[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR. Thanks for your patient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 I am not sure what is my next step. And this PR was created very long time ago. So enviroment changed before. I think other contributor can resolve better than me. So I closed this PR. Thanks for your patient. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 Can anyone help this PR? I don't know the next step. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 @Leemoonsoo When paragraph received a SIGTERM, Job result code is INCOMPLETE. Before When Job result code is INCOMPLETE, Status is FINISHED. I think in this situation user can not realize paragraph received a SIGTERM. Because Status is FINISHED. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 @corneadoug Thanks for your comment. I rebased my branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 I added test. Please review PR, thanks for your consideration. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 There are 2 errors. 1. `ZeppelinSparkClusterTest.zRunTest:204 expected: but was:` does not reproduce. 2. `AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait:96 쨩 Timeout` also does not reproduce. I am not sure that those errors are related this PR. @corneadoug I finished rebase onto master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 I'm sorry for no-reply long time. my plate was full. I will finish other 2 PRs and then If ZEPPELIN-1437 and ZEPPELIN-1438 are status is unresolved, I will try to resolve. If is it okay.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1350: [ZEPPELIN-1351]Paragraph status should be ERROR if Par...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1350 @felixcheung Okay! I will add unit test. Thanks for your comment! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1350: [ZEPPELIN-1351]Paragraph status should be ERROR...
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1350 [ZEPPELIN-1351]Paragraph status should be ERROR if Paragraph is terminated with SIGTERM ### What is this PR for? When Paragraph received a SIGTERM. ExitValue: 143, Status of the paragraph should be marked as "ERROR" instead of "FINISHED". ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1351 ### How should this be tested? I have online test. But hope to get some advice or guides from reviewers or committer. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1351 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1350.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1350 commit 300db3f2dca5f7171de7fddc3c59e75bc022ca6f Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-20T08:34:44Z While Code.INCOMPLETE, Set Status.ERROR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? * Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl + Enter: Run paragraph, focus stays * Moves the cursor to the end of the paragraph, When new paragraph is added ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-708 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1290 commit 490beb0018d22b4783814bf5f84abc24097fccd6 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T14:44:11Z Add if shift + , positions automatically to the next cell. if Ctrl + , keep focus. Moves the cursor to the end of the paragraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [WIP][ZEPPELIN-708]shift positions automaticall...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 CI Fail msg is `[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:npm (npm install) on project zeppelin-web: Failed to run task: 'npm install --color=false' failed. (error code 1) -> [Help 1]` It is not relevant this PR. Re-trigger CI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [WIP][ZEPPELIN-708]shift positions autom...
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [WIP][ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? * Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl + Enter: Run paragraph, focus stays * Moves the cursor to the end of the paragraph, When new paragraph is added ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-708 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1290 commit 490beb0018d22b4783814bf5f84abc24097fccd6 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T14:44:11Z Add if shift + , positions automatically to the next cell. if Ctrl + , keep focus. Moves the cursor to the end of the paragraph --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 @bzz https://github.com/apache/zeppelin/pull/1330#issuecomment-239997747 It did not reproduce in local. Can you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 ping @bzz --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 @bzz I will check it. Thanks for review. When I fix CI, I'll mention you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1330: [ZEPPELIN-1144]Zeppelin home page should only list not...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1330 CI error ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 76.102 sec - in org.apache.zeppelin.integration.SparkParagraphIT Results : Tests in error: ZeppelinIT.testAngularDisplay:118->AbstractZeppelinIT.waitForParagraph:70->AbstractZeppelinIT.pollingWait:96 쨩 Timeout AuthenticationIT.testGroupPermission:179->AbstractZeppelinIT.pollingWait:96 쨩 Timeout Tests run: 15, Failures: 0, Errors: 2, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue:
https://github.com/apache/zeppelin/pull/1290
I remove `angular.element('#' + focusedParagraph +
'_paragraphColumn_main').scope().goToLineEnd()`, When paragraph runs.
Because each ace editor keeps cursor position.
So.. user enter `shift+enter`, cursor move next paragraph and cursor
position is with locates in latest position.
I add screen shot. It is helpful to understand what I said.
@Leemoonsoo Could you mind if I request to review this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz I think This PR have some trouble merging to master. Because When bzz leave comment, I also leave comment immediately. So bot did not recognize this PR. Could you mind if you check again? (I'm worried about this PR open forever.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz Thanks for your review. I rebase on to master and force push. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure. But I think it is persist error. ``` Failed tests: ParallelSchedulerTest.testRun:63 expected: but was: ``` Anyway.. @Leemoonsoo I change code that it does not use `paragraph.config`. Can you review this PR? Is it okay? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @bzz No, It does not persists every time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 > If you re-trigger CI more (close this PR) - does the same issue persists every time? I'm not sure if it persists. I will re-tigger after fix the issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I am not sure it is related with this PR. When I run it, it passed. ``` Failed tests: ParallelSchedulerTest.testRun:63 expected: but was: ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I am not sure this error is related with this issue. ``` Failed tests: ZeppelinSparkClusterTest.zRunTest:204 expected: but was: ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl + Enter: Run paragraph, focus stays ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-708 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1290 commit 1de67ec67ccc3d7ceca814ffcbce951aee4e2dd2 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T14:44:11Z Add if shift + , positions automatically to the next cell. if Ctrl + , keep focus. commit 4a58c67509302a140beaa141e4602717bcd6d92d Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T15:30:42Z Add test cases commit 73de2658f6919f5b2de5c06c8981ef9eed3cb2eb Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T15:47:12Z Update tooltip and shortcut commit 63e6a3a4d5cf96deb0fc245efb8a0aae14c6e601 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-08T13:30:04Z Avoid passing information through paragraph.config commit da224d353df999213c033bdd44ad569a136c0999 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-08T14:50:04Z Fixed CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
GitHub user mwkang reopened a pull request: https://github.com/apache/zeppelin/pull/1248 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked to https://github.com/apache/zeppelin/pull/806#issuecomment-227041293 This PR is related to #1113 ZEPPELIN-1069 branch was force push, so couldn't reopen that PR. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1069 ### How should this be tested? Unit test Run-time checking ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1069 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1248 commit 0b3cb383870e77037b79035c34a6dd146fb37ec0 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-07-29T07:21:53Z Add function that is replName is binding. commit d1c074887dc419a68014b912e0ed852d8d029df7 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-07-30T05:31:10Z Add test cases commit c3b5ddd0891a534ff015b02048b293e8c45b5e22 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-03T04:49:15Z Refactor method name commit ab8e78f9bcf037b46ced635966df59b61b695966 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T01:28:30Z Modify that StringUtils is static import commit c0f2af06d61c2e7b627eafbe471828898c8cef39 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T14:47:17Z Modify static import position. commit a8eede2fd24a647401e03f8149bef6d7e81754b4 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-08T14:58:24Z Fixed CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/1248 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 I handle that unnecessary persisted in note.json. I find some problem. While new paragraph is added in runParagraph, focus is not end of line. It ignore space character. But While just add paragraph, it does not ignore space character. I think it is not relate in unnecessary persisted in note.json. So.. I want to resolve it in another issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Sorry, I missed it. I will check. I appreciate your review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1290: [ZEPPELIN-708]shift positions automatically to ...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1290 Could you mind if I am going to resolve that consider running paragraph is successful on new issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1290: [ZEPPELIN-708]shift positions automatica...
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1290 [ZEPPELIN-708]shift positions automatically to the next cell ### What is this PR for? Add and modify shortcut function * Shift + Enter: Run paragraph, move focus to next * Ctrl + Enter: Run paragraph, focus stays ### What type of PR is it? Improvement ### Todos ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-708 ### How should this be tested? * unit test * online test ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-708 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1290.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1290 commit 1de67ec67ccc3d7ceca814ffcbce951aee4e2dd2 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T14:44:11Z Add if shift + , positions automatically to the next cell. if Ctrl + , keep focus. commit 4a58c67509302a140beaa141e4602717bcd6d92d Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T15:30:42Z Add test cases commit 73de2658f6919f5b2de5c06c8981ef9eed3cb2eb Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-08-05T15:47:12Z Update tooltip and shortcut --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 I refactor method name. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1248: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1248 @jongyoul Can you review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1248: [ZEPPELIN-1069]Ignore implicit interpreter when...
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1248 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked to https://github.com/apache/zeppelin/pull/806#issuecomment-227041293 This PR is related to #1113 ZEPPELIN-1069 branch was force push, so couldn't reopen that PR. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1069 ### How should this be tested? Unit test Run-time checking ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1069 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1248.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1248 commit 0b3cb383870e77037b79035c34a6dd146fb37ec0 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-07-29T07:21:53Z Add function that is replName is binding. commit d1c074887dc419a68014b912e0ed852d8d029df7 Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-07-30T05:31:10Z Add test cases --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 @AhyoungRyu Thanks for your advice. Next time, I will try to do that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 This PR is temporarily closed, While I refactor my codes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1113: [ZEPPELIN-1069]Ignore implicit interpreter when user e...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/1113 @jongyoul Sure, I will do that. I have a question. Is it okay that wrong interpreter is ignored in [here](https://github.com/apache/zeppelin/pull/1113/files#diff-0f40daff726ba29c9a004b342d422dfeR270)? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1113: [ZEPPELIN-1069]Ignore implicit interpreter when...
GitHub user mwkang opened a pull request: https://github.com/apache/zeppelin/pull/1113 [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name ### What is this PR for? Ignore implicit interpreter when user enter wrong interpreter name linked to https://github.com/apache/zeppelin/pull/806#issuecomment-227041293 ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1069 ### How should this be tested? unit test Run-time checking ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/zeppelin ZEPPELIN-1069 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1113 commit 3a20fa7408b303fb79646b251da665b7c1ca6b7b Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-07-02T08:32:23Z [ZEPPELIN-1069]Ignore implicit interpreter when user enter wrong interpreter name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Wow thanks for your patience. This PR is a long period and lots of comments. I'll keep on trying my best. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 - [ ] https://travis-ci.org/apache/zeppelin/jobs/138874097 `ZeppelinSparkClusterTest.sparkRTest:90` - [ ] https://travis-ci.org/apache/zeppelin/jobs/138874103 ``` Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 104.235 sec - in org.apache.zeppelin.integration.ZeppelinIT Results : Failed tests: ParagraphActionsIT.testTitleButton:343 After Show Title : The title field contains Expected: "Untitled" but: was "" Tests in error: ParagraphActionsIT.testRemoveButton:143->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ParagraphActionsIT.testMoveUpAndDown:180->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ParagraphActionsIT.testCreateNewButton:75->AbstractZeppelinIT.waitForParagraph:84->AbstractZeppelinIT.pollingWait:110 쨩 Timeout ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #806: [ZEPPELIN-707]Automatically adds %.* of previous...
Github user mwkang closed the pull request at: https://github.com/apache/zeppelin/pull/806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I reopened this PR. But I think I have to fix some test case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @jongyoul If user enter wrong name, I ignore that name. Is it okay? Or do I try to figure similar name out ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 I am not sure that this test case is you expected --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 Okay. I am going to fix it. I show real interpreter name instead of '%..' @jongyoul I think about single responsibility. But if you have thought it is redundant, I will change code. You think it is redundant, don't you? (It's redundant.. And I think I lack of develop experience. So I sometimes have a mistake. But I have a can-do attitdue to learn from other's opinion.) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #806: [ZEPPELIN-707]Automatically adds %.* of previous paragr...
Github user mwkang commented on the issue: https://github.com/apache/zeppelin/pull/806 @corneadoug I fix whole issue. Can you check my code? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 Oh.. I closed JIRA issue. I am so sorry that I act at my discretion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 Related PR: https://github.com/apache/incubator-zeppelin/pull/860 Related Issue: https://issues.apache.org/jira/browse/ZEPPELIN-828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request #904: [ZEPPELIN-835]Don't persist authentica...
Github user mwkang closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin issue #904: [ZEPPELIN-835]Don't persist authentication in...
Github user mwkang commented on the issue: https://github.com/apache/incubator-zeppelin/pull/904 While I rebase this PR, I found this issue was been resolved [AuthenticationInfo in master]. So I closed PR. [AuthenticationInfo in master]: https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Paragraph.java#L53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-707]Automatically adds ...
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/806#issuecomment-222479738 - [ ] When you create a new notebook, the interpreter is listed as: %... Any way to get the default interpreter from back-end and insert it instead? - [ ] After running a query, the cursor is placed on the next paragraph where the interpreter name was injected, however the cursor is placed at the beginning of the line (so you can't start typing) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221245539 I made 2 issue for failing CI. [ZEPPELIN-876](https://issues.apache.org/jira/browse/ZEPPELIN-876), [ZEPPELIN-877](https://issues.apache.org/jira/browse/ZEPPELIN-877) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221146929 @Leemoonsoo Part of Ci are failed. Because.. [ERROR] Failed to execute goal on project zeppelin-zrinterpreter: Could not resolve dependencies for project org.apache.zeppelin:zeppelin-zrinterpreter:jar:0.6.0-incubating-SNAPSHOT: Could not transfer artifact org.apache.spark:spark-core_2.10:jar:1.4.1 from/to central (http://repo.maven.apache.org/maven2): GET request of: org/apache/spark/spark-core_2.10/1.4.1/spark-core_2.10-1.4.1.jar from central failed: Connection reset -> [Help 1] ``` Is it Okay? I'm not sure it is not related this PR, isn't it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...
GitHub user mwkang reopened a pull request: https://github.com/apache/incubator-zeppelin/pull/904 [ZEPPELIN-835]Don't persist authentication info into note.json ### What is this PR for? Don't persist authentication info into note.json ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-835 ### How should this be tested? unit test ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/mwkang/incubator-zeppelin ZEPPELIN-835 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-zeppelin/pull/904.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #904 commit 328eddacbbfb258aed419147ebe14cb032013e6c Author: Minwoo Kang <minwoo.k...@outlook.com> Date: 2016-05-19T12:54:23Z [ZEPPELIN-835]Don't persist authentication info into note.json --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...
Github user mwkang commented on the pull request: https://github.com/apache/incubator-zeppelin/pull/904#issuecomment-221143687 Of course. I close the PR and re-open to re-trigger the ci. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-zeppelin pull request: [ZEPPELIN-835]Don't persist authe...
Github user mwkang closed the pull request at: https://github.com/apache/incubator-zeppelin/pull/904 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
