[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 @ebuildy could you check CI? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Thanks a lots :slightly_smiling_face: Let me test it out again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Hey, @ebuildy! If you don't want to improve my suggestion(#2458 (comment)), please let us know so that we will start merge process, I guess. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2472: [ZEPPELIN-2749] Use scalable file structure for zeppel...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2472 Cool, I also experienced as like what your describing at especially filename and messy folders. And Tested and LGTM. Everything is working. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2477: [ZEPPELIN-2342] Improving Test Environment for zeppeli...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2477 Oh, it looks great improvement! Tested and LGTM. It works well and it's cool! Thanks @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2460 Cool! Thanks @1ambda for checking! I also just checked it works well on mobile --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Tested and LGTM! It looks cool that when a `writers` logins a note, it shows report mode. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 I tested this one and it looks better than before, except above a my comment about CI failure. And I suggest one thing. in this chance, how about changing landing page name from `localhost:8080/#/` to `Zeppelin` or something? ![image](https://user-images.githubusercontent.com/8110458/28008400-5cb67f14-6592-11e7-8c5b-152d4e2579c7.png) I know my suggestion is not related with this PR. But if you want to improve, you can make a PR or involve code in this PR. What do you think of? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2468: [ZEPPELIN-2733] Remove System Information Leak in Auth...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2468 @yanboliang Thanks for taking care of this. Yeah, It makes sense. I guess this PR works well, because you just removed log. But it would be great to make sure that CI pass. Could you confirm it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2460 @1ambda Yeah, I agree as your comment. That problem related this branch. So we should fix this more pretty, for mobile :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2460: [gh-pages] fix hover event in technologies section on ...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2460 Oh, I checked such as a your comment when it is work on `Iphone 5` in chrome developer mode. ![image](https://user-images.githubusercontent.com/8110458/27898098-38d501c8-625f-11e7-9d91-b9674ad944b1.png) Thanks for detail confirming this! @1ambda Let me improve this one! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I just checked again, but there is still a same problem. could you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Could you remove the `{{ $root.pageTitle }}` word when loading page like this? ![title](https://user-images.githubusercontent.com/8110458/27855590-fdc1a76c-61a5-11e7-9940-028ae2c60597.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2463: Fix zeppelin-web development mode
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2463 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Yes, I did. I run `mvn clean package -DskipTests` I'll check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Oh, It's great! Let me test it out as soon as possible. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I could reproduce this problem on master branch but, I could not see to resolve on your branch. It has same error. Could you test it out on your branch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Ah, you don't mind those lines because your 1.8 job became green light! So, I think that it would be nice to run again about 1.3 and 1.5 jobs. Could you try again, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 You're welcome! Yeah, the current Travis is not good but it's working. If when your Travis become green or it is fail but it is not related your PR, I can test it out (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Oh, Thanks for quick answer and check! Let me test as your comment and come back here! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 I have a question quickly. For reproduce, I just make sure test flow clearly. 1. login as user1 2. create a note 3. add a paragraph 4. set `owners` and `writers` field set user1 5. set `readers` field sets user2 6. logout user1 and login user2. 7. back to note and check whether popup is appeared or not. Is it correct? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2439: [ZEPPELIN-2680] allow opening notebook as a reader
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2439 Hi, @herval. Thanks for contribution and sorry for late response. Let me take a look this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2458 Hi, @ebuildy. Thanks for improving it. But Travis is fail, could you check this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2438: [ZEPPELIN-2693] Test: interpreter mode action t...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2438 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2438: [ZEPPELIN-2693] Test: interpreter mode action test
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2438 reopen for CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2438: [ZEPPELIN-2693] Test: interpreter mode action t...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2438 [ZEPPELIN-2693] Test: interpreter mode action test ### What is this PR for? Adding to interpreter mode (globally shared mode, Per user/Scoped mode, Per user/isolated mode) action case on Selenium test. Here is for checking scenario. 1. globally in shared mode ``` admin : set 'globally in shared' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print userâ in the second paragraph and run it User 2: Check if the result is user2 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 1: Run the second paragraph again. User 1: Check if the result is user2 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter and python process is 0 ``` 2. Per user in scoped mode ``` admin : set 'Per user in scoped' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print userâ in the second paragraph and run it User 2: Check if the result is user2 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 2 User 1: Run the second paragraph again. User 1: Check if the result is user1 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: Restart python interpreter in the note. System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 User 1: Run the first paragraph User 2: Run the first paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 2 admin: Restart python interpreter in interpreter tab System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 ``` 2. Per user in isolated mode ``` admin : set 'Per user in isolated' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print user" in the second paragraph and run it User 2: Check if the result is user 2 in the second paragraph System: Check if the number of python interpreter process is 2 System: Check if the number of python process is 2 User 1: Run the second paragraph again. User 1: Check if the result is user1 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: Restart python interpreter in the note. System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 User 1: Run the first paragraph User 2: Run the first paragraph System: Check if the number of python interpreter process is 2 System: Check if the number of python process is 2 admin : Restart python interpreter in interpreter tab System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 ``` ### What type of PR is it? [ Test ] ### Todos - * [x] - add logic to check process - interpreter process and python pr
[GitHub] zeppelin issue #2450: [ZEPPELIN-2707][DOCS][HOTFIX] fix: broken image URLs i...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2450 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661]Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 please review again @jongyoul :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2438: [ZEPPELIN-2693] Test: interpreter mode action test
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2438 Ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2451: [ZEPPELIN-2708][DOCS] feat: Add v scroll to setup, usa...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2451 Cool! it looks better than before. LGTM ![image](https://user-images.githubusercontent.com/8110458/27707690-2db383a4-5d51-11e7-9b55-54fc48525e55.png) ![image](https://user-images.githubusercontent.com/8110458/27707716-4adcb928-5d51-11e7-9353-113c4fa51b9b.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2450: [ZEPPELIN-2707][DOCS][HOTFIX] fix: broken image URLs i...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2450 Looks good! Let me test and come back here. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661]Test: personalized mode action
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661]Test: personalized mode action
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2415 [ZEPPELIN-2661]Test: personalized mode action ### What is this PR for? Adding to personalized mode action case on Selenium test. Here is for checking scenario. 1. Simple action test : ``` 1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout. > checkpoint : result of paragraph is 'Before'. 2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout. > checkpoint 1 : enabling personalized mode > checkpoint 2 : result of paragraph is 'Before'. 3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout. > checkpoint : changed from 'Before' to 'After' in paragraph result. 4. (user1) login, check whether result of paragraph is 'Before' or not. > checkpoint : result of paragraph is 'Before', 'After' means test fail. ``` 2. Graph action test : ``` 1. (admin) login, create a new note, run a paragraph with data of spark tutorial, change active graph to 'Bar Chart', turn on personalized mode, logout. > checkpoint 1: result string of paragraph contains import 'org.apache.commons.io.IOUtils'. > checkpoint 2 : check active graph is 'Bar Chart' 2. (user1) make sure it is on personalized mode and graph mode is on 'Bar Chart', try to change active graph to 'Table' and then check result > checkpoint 1 : enabling personalized mode > checkpoint 2 : final result of active graph is 'Bar Chart', 'Table' means test fail. ``` 3. Dynamic form action test : ``` 1. (admin) login, create a new note, run a paragraph with data of spark tutorial, logout. > checkpoint 1: result string of paragraph contains import 'org.apache.commons.io.IOUtils'. > checkpoint 2 : check a dynamic form value is '30' 2. (user1) make sure it is on personalized mode and dynamic form value is '30', try to change dynamic form value to '10' and then check result > checkpoint 1 : enabling personalized mode > checkpoint 2 : final result of dynamic form value is '30', '10' means test fail. ``` ### What type of PR is it? [ Test ] ### What is the Jira issue? * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661) ### How should this be tested? - build zeppelin with `mvn clean package -DskipTests' - 1. execute for Simple text test : `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testSimpleAction` - 2. execute for Graph test : `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testSimpleAction` - 3. execute for Graph test : `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testDynamicFormAction` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin personalize_mode_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2415 commit ad77924a86fd749e016d972bf49a8f79821c81e6 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T03:32:27Z personalize mode integration test commit 49a339a892efb6b039854f04705109157b32774e Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:34:02Z test: add to check point about being turned on personalized mode in user1 commit 8e13fad00bf74d99212ecc93a69776f207642799 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:41:43Z style: added new line commit cb281a8906ad4607434562777c7a65592c28cd88 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T06:15:23Z style: [minor] modify annotation commit ecac3c3644a42c16c13f2115fee26cc546a49819 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T06:34:26Z style: modify method name commit 043e838732b64eaf51cd6d3694f3db745bd94790 Author: soralee <sora0...@zepl.com> Date: 2017-06-19T08:56:14Z fix: using minimum 'sleep' method commit 2581af1abda5da24f474517dae8c57df4224afa9 Author: soralee <sora0...@zepl.com> Date: 2017-06-21T05:29:50Z Fix: re
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661]Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 reopen CI becoming green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661]Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 @1ambda, I updated regarding login, logout code because I think that it would be better to reuse in AuthenticationIT code and to resolve passing CI test. Regarding CI failure seems like related with`sleep` code. I just want to let you know about `sleep` code, because you don't want to use it and it's flaky code. I agree that but, Travis often gives error messages if there are not `sleep`. We should improve this part but, it would be better to fixed when we improve overall selenium test code or split. what do you think about this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2441: [ZEPPELIN-2683] fix: should provide horizontal scrollb...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2441 Cool! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda Fixed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 Yeah, I updated it (: thanks @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda, How about that connecting the latest version documentation? we'd better to guide the latest version to user. ``` spark - http://zeppelin.apache.org/docs/0.7.2/interpreter/spark.html sql - http://zeppelin.apache.org/docs/0.7.2/interpreter/jdbc.html python - http://zeppelin.apache.org/docs/0.7.2/interpreter/python.html single user - http://zeppelin.apache.org/docs/0.7.2/install/install.html multi user - http://zeppelin.apache.org/docs/0.7.2/security/shiroauthentication.html ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 @jongyoul sounds good! I'll created JIRA ticket to improve personalized mode and test, after merge. @zjffdu in my local, it works very well. and even my CI is failing other selenium. one thing, I can test in Travis many times. so let me test more on Travis. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda Thanks for arranging list Updated it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2438: [WIP][ZEPPELIN-2693] Test: interpreter mode act...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2438 [WIP][ZEPPELIN-2693] Test: interpreter mode action test ### What is this PR for? Adding to interpreter mode (globally shared mode, Per user/Scoped mode, Per user/isolated mode) action case on Selenium test. Here is for checking scenario. 1. globally in shared mode ``` admin : set 'globally in shared' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print userâ in the second paragraph and run it User 2: Check if the result is user2 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 1: Run the second paragraph again. User 1: Check if the result is user2 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter and python process is 0 ``` 2. Per user in scoped mode ``` admin : set 'Per user in scoped' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print userâ in the second paragraph and run it User 2: Check if the result is user2 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 2 User 1: Run the second paragraph again. User 1: Check if the result is user1 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: Restart python interpreter in the note. System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 User 1: Run the first paragraph User 2: Run the first paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 2 admin: Restart python interpreter in interpreter tab System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 ``` 2. Per user in isolated mode ``` admin : set 'Per user in isolated' mode of python interpreter User 1: create new note User 1: Code â%python user = user1â in the first paragraph User 1: Code â%python print userâ in the second paragraph and run it User 1: Check if the result is user1 in the second paragraph System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: create new note User 2: Code â%python user = user2â in the first paragraph User 2: Code â%python print user" in the second paragraph and run it User 2: Check if the result is user 2 in the second paragraph System: Check if the number of python interpreter process is 2 System: Check if the number of python process is 2 User 1: Run the second paragraph again. User 1: Check if the result is user1 in the second paragraph User 1: Restart python interpreter in the note. System: Check if the number of python interpreter process is 1 System: Check if the number of python process is 1 User 2: Restart python interpreter in the note. System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 User 1: Run the first paragraph User 2: Run the first paragraph System: Check if the number of python interpreter process is 2 System: Check if the number of python process is 2 admin : Restart python interpreter in interpreter tab System: Check if the number of python interpreter process is 0 System: Check if the number of python process is 0 ``` ### What type of PR is it? [ Test ] ### Todos 1. globally in shared mode scenario - * [ ] - add logic to check pr
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @1ambda, @Leemoonsoo suggested the latest link so I already fix `0.7.2` version. @Leemoonsoo could you confirm this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2432: [ZEPPELIN-2652] Can't open spark tutorial note in 0.8....
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2432 LGTM! Make sure that CI become green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] [WIP] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 Hi, there. I just added two test cases as the @1ambda comment and have written PR description as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 @1ambda Thanks for review and Sounds good! Let me make two scenarios which is based above code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 reopen for CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2239 Show dialog if owners field set to be empty on shiro ### What is this PR for? This PR is for a showing dialog when note's permission set `Readers/Writers` but `Owners` is empty. Currently, after merged #849, if user set `Owners` is empty, it's automatically set as the current user. So, It would be better to show a dialog before `Owners` is fill with the current user because user might think it is not intended. Plus, if a user only set `Readers` role, all field(`Writers` and `Owners`) role is filled as the current user like below. It's not necessary to fill because the `Owner` role can read and write note. ![not_need_wirters](https://cloud.githubusercontent.com/assets/8110458/24869746/2a77d2da-1e4f-11e7-86a5-794e1aac02d0.gif) ### What type of PR is it? [ Improvement ] ### What is the Jira issue? * [ZEPPELIN-2206; Be added a writer account when adding a reader account on Shiro](https://issues.apache.org/jira/browse/ZEPPELIN-2206) * [ZEPPELIN-2418; show dialog if user set to the empty owner permission](https://issues.apache.org/jira/browse/ZEPPELIN-2418) ### How should this be tested? 1. Turn on shiro. 2. Set permission `Writers` and `Readers` except `Owner` role. 3. Check the dialog appears ### Screenshots (if appropriate) [Before] * Set `Readers` and `Writers` except `Owners` ![zeppelin-2206_auto_shiro_b_1](https://cloud.githubusercontent.com/assets/8110458/24869964/cf382676-1e4f-11e7-8e95-30c149a4aba5.gif) * Set only 'Writers` ![zeppelin-2206_auto_shiro_b_2](https://cloud.githubusercontent.com/assets/8110458/24870112/3821f518-1e50-11e7-9310-fcafd4e26376.gif) * set only `Readers`; this screen is attached above. [After] * Set `Readers` and `Writers` except `Owners` ( Set only `Writers`; this result is same) ![zeppelin-2206_auto_shiro_a_1](https://cloud.githubusercontent.com/assets/8110458/24870781/61d8f1c0-1e52-11e7-8faa-38ff4fd64f6f.gif) * Set only 'Readers` ![zeppelin-2206_auto_shiro_a_2](https://cloud.githubusercontent.com/assets/8110458/24870811/76f547ca-1e52-11e7-98b2-f6a5541284ab.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin ZEPPELIN-2206_auto_shiro Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2239.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2239 commit 6168166fc39af5cf5df37a17ec17a488d145b531 Author: soralee <sora0...@zepl.com> Date: 2017-04-10T09:54:25Z check empty and anonymous and revert config when cancel click --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2239: Show dialog if owners field set to be empty on ...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 reopen for CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2239: Show dialog if owners field set to be empty on shiro
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2239 Ready to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 @1ambda, Thanks for quick fix. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 Ping, ready to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 Ping, Ready to review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 @1ambda Sorry for late response. except one more thing bug : ![don t_revet_navbarcolor](https://user-images.githubusercontent.com/8110458/27277972-0ffd97a2-551b-11e7-92e0-9206403bca35.gif) FYI : https://github.com/apache/zeppelin/pull/2401/commits/c645ee0762df7ca51ef22dd390d9770a3223, I hope It would be help to you :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 @1ambda, changed some code so that using minimum `sleep` method. I tried to change all sleep, but I checked If changing page, it needed a little `sleep`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2415 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalized mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 reopen for CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalized mode action
GitHub user soralee reopened a pull request: https://github.com/apache/zeppelin/pull/2415 [ZEPPELIN-2661] Test: personalized mode action ### What is this PR for? Adding to personalized mode action case on Selenium test. Here is for checking scenario. 1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout. > checkpoint : result of paragraph is 'Before'. 2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout. > checkpoint 1 : enabling personalized mode > checkpoint 2 : result of paragraph is 'Before'. 3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout. > checkpoint : changed from 'Before' to 'After' in paragraph result. 4. (user1) login, check whether result of paragraph is 'Before' or not. > checkpoint : result of paragraph is 'Before', 'After' means test fail. ### What type of PR is it? [ Test ] ### What is the Jira issue? * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661) ### How should this be tested? - build zeppelin with `mvn clean package -DskipTests' - execute `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testGroupPermission` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin personalize_mode_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2415 commit 5f7788f4fca2c82ded2cec1f189bdc99e144e53b Author: soralee <sora0...@zepl.com> Date: 2017-06-16T03:32:27Z personalize mode integration test commit b5c2a435c07f7ee9ca415fe42375e301950fb66a Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:34:02Z test: add to check point about being turned on personalized mode in user1 commit 2aa3e6d468de8c624396fe4337ed765cc82b0586 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:41:43Z style: added new line commit c14de44743f877ea554d1fe4baff4e97d866fe9a Author: soralee <sora0...@zepl.com> Date: 2017-06-16T06:15:23Z style: [minor] modify annotation commit 92b3a6f6eb09c730a8a5440dd1f5372ddcc073ec Author: soralee <sora0...@zepl.com> Date: 2017-06-16T06:34:26Z style: modify method name --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2415: [ZEPPELIN-2661] Test: personalize mode action
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2415 @jongyoul @1ambda please help to review :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2415: [ZEPPELIN-2661] Test: personalize mode action
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2415 [ZEPPELIN-2661] Test: personalize mode action ### What is this PR for? Adding to personalized mode action case on Selenium test. Here is for checking scenario. 1. (admin) login, create a new note, run a paragraph with 'Before' text, turn on personalized mode, logout. > checkpoint : result of paragraph is 'Before'. 2. (user1) login, make sure it is on personalized mode and 'Before' in result of paragraph, logout. > checkpoint 1 : enabling personalized mode > checkpoint 2 : result of paragraph is 'Before'. 3. (admin) login, run after changing paragraph contents to 'After', check result of paragraph, logout. > checkpoint : changed from 'Before' to 'After' in paragraph result. 4. (user1) login, check whether result of paragraph is 'Before' or not. > checkpoint : result of paragraph is 'Before', 'After' means test fail. ### What type of PR is it? [ Test ] ### What is the Jira issue? * [ZEPPELIN-2661](https://issues.apache.org/jira/browse/ZEPPELIN-2661) ### How should this be tested? - build zeppelin with `mvn clean package -DskipTests' - execute `TEST_SELENIUM="true" mvn test -pl 'zeppelin-server' --am -DfailIfNoTests=false -Dtest=PersonalizeActionsIT#testGroupPermission` ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin personalize_mode_test Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2415.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2415 commit 5f7788f4fca2c82ded2cec1f189bdc99e144e53b Author: soralee <sora0...@zepl.com> Date: 2017-06-16T03:32:27Z personalize mode integration test commit b5c2a435c07f7ee9ca415fe42375e301950fb66a Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:34:02Z test: add to check point about being turned on personalized mode in user1 commit 2aa3e6d468de8c624396fe4337ed765cc82b0586 Author: soralee <sora0...@zepl.com> Date: 2017-06-16T05:41:43Z style: added new line commit c14de44743f877ea554d1fe4baff4e97d866fe9a Author: soralee <sora0...@zepl.com> Date: 2017-06-16T06:15:23Z style: [minor] modify annotation --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @1ambda Thank you for all your comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 Fixed 6.2 comments and, here is more improvement list 1. main section - changed PR phrase to `font-size : 22px`, `line-height: 1.4` - added padding-top/bottom in main section - changed button font and weight - added button margin-side - added button interval - added interval between PR phrase in main section and buttons 2. revert to original what's new section --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 Great! it looks better! And @1ambda Thank you for accepting suggest and quickly updating as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 @1ambda, I mean removing `Apache Zeppelin` phrase in description. (Sorry for my confusing screenshot) ![image](https://user-images.githubusercontent.com/8110458/27031423-235114de-4fab-11e7-8a04-2d11db687ae9.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 ### 4. (bug) didn't revert original color when I click a navbar icon and escape. it is same bug with https://github.com/apache/zeppelin/pull/2401#issuecomment-307058027 as well. ![don t_revet_navbarcolor](https://user-images.githubusercontent.com/8110458/27030167-34fb0ab4-4fa6-11e7-8809-f5f67dcfa750.gif) And I fixed a commit : https://github.com/apache/zeppelin/pull/2401/commits/762635d09c879233cd498440e9f8b36d2e8c6988 although the two contents are in one commit, I hope it would help you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 ### 3. removing `zeppelin` word in first line in description. ![image](https://user-images.githubusercontent.com/8110458/27029881-1ed96092-4fa5-11e7-85f2-f93256e2a003.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @1ambda Thanks for opinions! IMO, regarding of no.7, it would be better to match navigation bar with #2371. Let's use light such as `box-shadow: 0px 3px 6px rgba(0, 0, 0, 0.4);` and revert to original color in main section. What do you think? And no.8 is a good idea. Let's change the buttons color! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 ### 2. (bug) Navbar doesn't fold when I click other components. This is same bug in https://github.com/apache/zeppelin/pull/2401#issuecomment-307291921 ![navbar_bug](https://user-images.githubusercontent.com/8110458/27029447-5cf5a996-4fa3-11e7-9008-18d57a002e09.gif) and I fixed as a commit : https://github.com/apache/zeppelin/pull/2401/commits/b2e0c63381838ff1d96b9311679628202698ac92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 1. changing starter sentence in overview page how about change the following sentence instead of `Apache Zeppelin` in `Spark with zeppelin`, `SQL with zeppelin` and `Python with zeppelin`? I mean, this part. ``` For a brief overview of Apache Spark fundamentals with Apache Zeppelin, see the following guide: ``` but, I'm not sure if this sentence is good. if you have more better sentence, It would be great! [before] ![image](https://user-images.githubusercontent.com/8110458/27028598-2fa861b6-4fa0-11e7-9173-e08ab84b0110.png) [after] ![image](https://user-images.githubusercontent.com/8110458/27028633-50927ec0-4fa0-11e7-9f6f-557c61affdc1.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 I just improved No 2 and 3. And, regarding No 3, there is not favicon.ico file. So, I added favicon.ico package files. - not connected page ![image](https://user-images.githubusercontent.com/8110458/26977235-12485a30-4d62-11e7-84bd-98c12c7867ad.png) - connected page ![image](https://user-images.githubusercontent.com/8110458/26977134-be4e2086-4d61-11e7-8610-d3530f3ee0f7.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #:
Github user soralee commented on the pull request: https://github.com/apache/zeppelin/commit/110ead1734d5ec2d48d0b38faefb2dd47b1254a0#commitcomment-22464599 In _includes/themes/zeppelin/_navigation.html: In _includes/themes/zeppelin/_navigation.html on line 78: I guess there is no problem. Let's update again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @1ambda I've just updated as your comments except number 2 and 3. It might take time to resolve that. Let me inform if I finish to-do list. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #:
Github user soralee commented on the pull request: https://github.com/apache/zeppelin/commit/110ead1734d5ec2d48d0b38faefb2dd47b1254a0#commitcomment-22463443 In _includes/themes/zeppelin/_navigation.html: In _includes/themes/zeppelin/_navigation.html on line 78: Sorry, my misunderstood. this is updated as your suggested. ![image](https://user-images.githubusercontent.com/8110458/26970857-c82b71a6-4d45-11e7-8422-507fef126f44.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #:
Github user soralee commented on the pull request: https://github.com/apache/zeppelin/commit/110ead1734d5ec2d48d0b38faefb2dd47b1254a0#commitcomment-22463365 In _includes/themes/zeppelin/_navigation.html: In _includes/themes/zeppelin/_navigation.html on line 78: It's better than before. Oh, I thought that your suggested is remove sentence. you mean just remove word. right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @Leemoonsoo could you confirm this color? ![chagne_button_color](https://user-images.githubusercontent.com/8110458/26965974-2d26e558-4d33-11e7-811d-29a1bda85d0d.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 @1ambda Sure, Thank you for your helping always! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 Some adding fix list - fix : when navbar-toggle in collapsed, do not revert color. [Before] ![before](https://user-images.githubusercontent.com/8110458/26922864-63697cba-4c7b-11e7-96fb-824aaaf0b6d6.gif) [After] ![after](https://user-images.githubusercontent.com/8110458/26922863-63383ea2-4c7b-11e7-8195-a7826a28cb6a.gif) --- - fix: not fully hover in dropdown-menu title ![before](https://user-images.githubusercontent.com/8110458/26923275-986a311a-4c7c-11e7-9043-ea559ed682ef.gif) ![after](https://user-images.githubusercontent.com/8110458/26923162-35bad1a0-4c7c-11e7-9bac-14ae118c229d.gif) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and main se...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2401 Hi, @AhyoungRyu @1ambda @Leemoonsoo. Please review again :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial mai...
Github user soralee closed the pull request at: https://github.com/apache/zeppelin/pull/2381 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 I remade a PR about navigation bar and blue section - https://github.com/apache/zeppelin/pull/2401. Let's move on to 2401 PR. and, I close this issue! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2401: [gh-pages] [ZEPPELIN-2597] updating navbar and ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2401 [gh-pages] [ZEPPELIN-2597] updating navbar and main sections and what's new. ## What is this PR for? For more comfortable guidance, improved navigation bar, main blue section and what's new section. And if anyone suggests idea or give me feedback, it would be appreciated! 1. In main blue section - add zeppelin logo - change buttons, `Get started` and `Download` - change button color. - change font style of description - change title font-size more smaller - change background color for dividing navbar and this section. 2. regarding to improve navbar - improve: change position of items - improve: change font option in dropdown-menu - fix : when not active, revert color - fix : when resizing window, dropdown-menu toggle text is disappeared. - fix : after using navigation bar in small window, and then drop-toggle place is misaligned in big window. 3. what's new sections - (minor) improve: aligned title text when small size windows ## What type of PR is it? [ Bug Fix | Improvement | Documentation ] ## Todos * describe above `What is this PR for?` part ## What is the Jira issue? * [ZEPPELIN-2597](https://issues.apache.org/jira/browse/ZEPPELIN-2597) ## How should this be tested? 1. run `bundle exec jekyll serve --watch` in this branch 2. `open localhost:4000` ## Screenshots (if appropriate) ### 1. blue section [Before] ![image](https://user-images.githubusercontent.com/8110458/26919645-640fe532-4c71-11e7-9073-8acfd6100d08.png) [After] ![image](https://user-images.githubusercontent.com/8110458/26919850-023b7f96-4c72-11e7-9069-5d3e5cf77c46.png) ### 2. navbar - change position of items (Before -> After) ![image](https://user-images.githubusercontent.com/8110458/26920156-fdbff20c-4c72-11e7-8171-0e426889c3ef.png) ![image](https://user-images.githubusercontent.com/8110458/26920075-c23689da-4c72-11e7-95a5-7ab4e3fe4f5a.png) --- - change font option in dropdown-menu (Before -> After) ![image](https://user-images.githubusercontent.com/8110458/26920330-a8caf336-4c73-11e7-8539-fd7604b7146f.png) ![image](https://user-images.githubusercontent.com/8110458/26920306-92a3fb66-4c73-11e7-965e-e24a9042f912.png) --- - fix : when not active, revert color ![before](https://user-images.githubusercontent.com/8110458/26920990-a3476eb0-4c75-11e7-8ea6-c2d457f5dae7.gif) ![after](https://user-images.githubusercontent.com/8110458/26920991-a3581bfc-4c75-11e7-9640-d4aaa3a523cb.gif) --- - fix : when resizing window, dropdown-menu toggle text is disappeared. ![image](https://user-images.githubusercontent.com/8110458/26920443-0541f2fe-4c74-11e7-8d69-b845cff872b8.png) ![image](https://user-images.githubusercontent.com/8110458/26920544-4c5120a2-4c74-11e7-91b1-e41f074b9b82.png) --- - fix : after using navigation bar in small window, and then drop-toggle place is misaligned in big window. ![before](https://user-images.githubusercontent.com/8110458/26920746-ecf31092-4c74-11e7-8d34-9ff01e6692a7.gif) ![after](https://user-images.githubusercontent.com/8110458/26920745-ecef8e18-4c74-11e7-967b-e05789f14d28.gif) --- ### 3. what's new sections - (minor) improve: aligned title text when small size windows ![image](https://user-images.githubusercontent.com/8110458/26921198-43f4c326-4c76-11e7-845d-07225cc64bf6.png) ![image](https://user-images.githubusercontent.com/8110458/26921228-5179a804-4c76-11e7-89a1-5251675090d1.png) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, this is. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin updating_navbar_whatsnew Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2401.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2401 commit 912742e9c910d254ebd092fe3c9119e54f7e78cd Author: soralee <sora0...@zepl.com> Date: 2017-06-05T15:57:04Z improve navbar and what's new, change main section commit 52431fd79e206c5807d11e388ac874b6fb79dee1 Author: soralee <sora0...@zepl.com> Date: 2017-06-08T08:07:49Z fix: navbar bugs, improve: main section and what's new section commit 0f52df03a658633f97f8e9a32dbe0ecf01a1764d Author: soralee <sora0...@zepl.com> Date: 2017-06-08T08:12:55Z use title class --- If your project is set up for it, you
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @AhyoungRyu I updated as your mentions. ![image](https://user-images.githubusercontent.com/8110458/26912241-117e2a68-4c4e-11e7-9827-6ee01e514ad3.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 or to decorate in Deployments section, How about this structure? ![image](https://user-images.githubusercontent.com/8110458/26861081-70ce8f80-4b7c-11e7-881d-c7fa9e6d95c5.png) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @AhyoungRyu, Thanks for review and suggestions! Sure, I can change the border color in Technologies section and, I can remove icons in Deployments section. IMO, about Deployments section, actually the current structure is good to me (including icons). And especially the buttons, it would be better to keep the current structure to match the buttons in the above technologies. ![screenshot from 2017-06-07 12-03-09](https://user-images.githubusercontent.com/8110458/26860704-5625eab8-4b7a-11e7-8f04-a9b509b8ab8c.png) How about this? :slightly_smiling_face: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda Thanks a lots of! you're the best! :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 some improving list - arranged to same line each 'use now' button in the Technologies. - changed contents font style in Technologies and Deployments. - removed bold font of buttons in the Deployments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda, I just finished the list about all your comment. For help to easy your review, I involved comment numbers in title message when I commit. I appreciate for taking care of this PR, all detailed comment as well! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 I really thank @1ambda and your a kind explanation as well! I'll update the following list and let you know that. ``` - comment 4 (SQL text font styling) - comment 8 - comments 9-1, 9-2, 9-3 - comment 10 - comment 11 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @1ambda , I've update regarding of `7.Improve layout for mobile browsers.` could you confirm, again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @sravan-s, I've fixed to match font size as your mention. Regarding of `uniform margin / padding scheme` I tried to fit the box ratio. could you check this if you have time? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2394: [gh-pages] [ZEPPELIN-2597] adding technologies and dep...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2394 @AhyoungRyu @1ambda @Leemoonsoo, please review again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 @1ambda, @Leemoonsoo, @AhyoungRyu, I created a PR regrading `Technologies and Deployments` #2394. Let me make a remainder PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2394: [gh-pages] [ZEPPELIN-2597] adding technologies ...
GitHub user soralee opened a pull request: https://github.com/apache/zeppelin/pull/2394 [gh-pages] [ZEPPELIN-2597] adding technologies and deployments (Main Page) ### What is this PR for? This PR is for Improving more comfortable guidance for point of user view in the main zeppelin homepage. To sum up, Technologies section is consist of 3 interpreters most people search or want (already talking about this on the mailing list.) and, Deployments section describes single or multiple user setting. ### What type of PR is it? [Improvement] ### What is the Jira issue? * [ZEPPELIN-2597](https://issues.apache.org/jira/browse/ZEPPELIN-2597) ### How should this be tested? 1. run `bundle exec jekyll serve --watch` in this branch 2. open `localhost:4000` ### Screenshots (if appropriate) - Look `Technologies` and `Deployments` sections ![peek 2017-06-05 15-14](https://cloud.githubusercontent.com/assets/8110458/26772663/d5ba7cbe-4a01-11e7-8715-03569d00509a.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes, this is. You can merge this pull request into a Git repository by running: $ git pull https://github.com/soralee/zeppelin adding_technologies_and_deployments Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2394.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2394 commit b8105cd3c09a8c2b56e190a4e18fb64a2c7b114d Author: soralee <sora0...@zepl.com> Date: 2017-06-05T06:08:14Z adding technologies and deployments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Um.. So, for quickly review, I'll separate this PR to 2 PR. 1. updating navbar and main sections. 2. adding technologies and deployments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [gh-pages] [ZEPPELIN-2597] Updating offcial main websi...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 ![image](https://cloud.githubusercontent.com/assets/8110458/26771309/5e6b8b8e-49f8-11e7-941c-8efd7ef7c1e9.png) this part is different between #2371. Let me update to match it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2371: [ZEPPELIN-2596] Improving documentation page
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2371 Sorry for my late response I quickly checked some navbar bug about https://github.com/apache/zeppelin/pull/2381#issuecomment-305451690 and https://github.com/apache/zeppelin/pull/2381#issuecomment-305705051 in #2381. and this branch has same those bugs. @1ambda, could you check those bugs? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2381: [WIP] [gh-pages] [ZEPPELIN-2597] Updating offcial main...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/2381 Hi, finally I finished the above To-do list. @1ambda @Leemoonsoo Could you confirm this, again? For now, the quick links is connected with 0.8.0-SNAPSHOT documentation. @Leemoonsoo could you advice this, please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---