[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2078: [ZEPPELIN-1988] add property "precode" to JDBCInterpre...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/2078 Looks Good To Me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2048: [ZEPPELIN-1999] get interpreter property with r...
Github user sotnich closed the pull request at: https://github.com/apache/zeppelin/pull/2048 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2048: [ZEPPELIN-1999] get interpreter property with r...
GitHub user sotnich opened a pull request:
https://github.com/apache/zeppelin/pull/2048
[ZEPPELIN-1999] get interpreter property with replaced context parameâ¦
What is this PR for?
Adds posibility to use context parameters (types: String.class,
Double.class, Float.class, Short.class,
Byte.class, Character.class, Boolean.class, Integer.class, Long.class, )
into property of interpreter.
What type of PR is it?
Feature
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1999
How should this be tested?
Add text with markers #{contextFieldNAme} (ex. #{noteId} or
#{paragraphTitle}) to interpreter property value (or add new property of
interpreter)
Get this property (getProperty(key)), markers should be replaced by
context values
Questions:
Does the licenses files need update? no
Is there breaking changes for older versions? no
Does this needs documentation? yes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/TinkoffCreditSystems/zeppelin ZEPPELIN-1999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2048.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2048
commit 5c322d475a35bd14d2371a352c95c7d71e68a2b3
Author: TinkoffCreditSystems <jmas...@gmail.com>
Date: 2017-02-21T06:12:43Z
[ZEPPELIN-1999] get interpreter property with replaced context parameters
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2019: [ZEPPELIN-2117] jdbc autocomplete for exasol database
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/2019 @Leemoonsoo, I cheched with postresql and mysql. All worked well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts @astroshim, check it now, please. If it's still not working send me details: configuration of the interpreter and jdbc log file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts @astroshim Made a little change - now mysql also works as well as postgresql. I have tested it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts Please, clirify your question. This PR supports every JDBC driver that can return schema and table names. I have tested it on postgres, but I am sure it would correctly run on mysql and other relational databases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 Made a rebase, now CI tests have only one error related with DistributedResourcePoolTest. Think it's still not related to my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 Don't think CI errors are related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1886: [ZEPPELIN-1876] improved comptetion with schema...
GitHub user sotnich opened a pull request: https://github.com/apache/zeppelin/pull/1886 [ZEPPELIN-1876] improved comptetion with schema/table/column separati⦠â¦on + sqlcompleter tests ### What is this PR for? This PR changes autocompletion behaviour in jdbc interpeter. There are some changes: * [main change] autocompletion now depends on what are you typing. Now there are four types of competion: schema, table, column and keywords. If you typing new word then autocompetion suggests only keywords and schema names. If you are typing after schema name with point then you get list of tables in that schema. Also if you typing a name after point after a table name you will get a list of column names of this table. * autocomption now supports aliases in sql. If you write alias for a table in sql you will get a list of columns for an aliased table if you write down alias and point. * autocompletion now load keywords only in low case (otherwise there are so many keywords in a list of autocompletion that it is becomes uncomfortable) ### What type of PR is it? Improvement ### Todos * [ ] - sort names in the output of autocompletion * [ ] - list only schema names if we are typing a schema name (for example after keywork FROM) * [ ] - add description in autocompletion list for schema names - schema, for table names - table and so * [ ] - autocompletion must initialize on opening of interpeter (not only after execution of sql) * [ ] - update autocompletion schemas only after execute update sql, not after every sql ??? * [ ] - new option for postgresql interpreter: postgresql.completer.schema.filter. Filter schema names loaded into autocompletion (no more garbage schema names). ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/sotnich/zeppelin jdbc-1876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1886.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1886 commit e9fde84884226f600455cdbd035d9a59b538300c Author: Sotnichenko Sergey <s.sotniche...@tinkoff.ru> Date: 2017-01-11T11:40:46Z [ZEPPELIN-1876] improved comptetion with schema/table/column separation + sqlcompleter tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1828: [ZEPPELIN-1876] smart psql autocomplition
Github user sotnich closed the pull request at: https://github.com/apache/zeppelin/pull/1828 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1828: [ZEPPELIN-1876] smart psql autocomplition
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1828 @jongyoul , sure, I will do it. I'll close this PR and will open a new one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1828: [ZEPPELIN-1876] smart psql autocomplition
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1828 Looks like CI error does not have any relation with my PR. Could anyone confirm that? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1828: [ZEPPELIN-1876] smart psql autocomplition
GitHub user sotnich opened a pull request: https://github.com/apache/zeppelin/pull/1828 [ZEPPELIN-1876] smart psql autocomplition ### What is this PR for? This PR changes autocompletion behaviour in postgresql interpeter. There are some changes: * [main change] autocompletion now depends on what are you typing. Now there are four types of competion: schema, table, column and keywords. If you typing new word then autocompetion suggests only keywords and schema names. If you are typing after schema name with point then you get list of tables in that schema. Also if you typing a name after point after a table name you will get a list of column names of this table. * autocomption now supports aliases in sql. If you write alias for a table you will get a list of columns of an aliased table if you write down the alias and a point. * new option are availble for postgresql interpreter: postgresql.completer.schema.filter. It allows filter schema names loaded into autocompletion (no more garbage schema names). * autocompletion now load keywords only in low case (otherwise there are so many keywords in a list of autocompletion that it is becomes uncomfortable) ### What type of PR is it? Improvement ### Todos * [ ] - sort names in the output of autocompletion * [ ] - list only schema names if we are typing a schema name (for example after keywork FROM) * [ ] - add description in autocompletion list for schema names - schema, for table names - table and so ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1876 ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? Yes You can merge this pull request into a Git repository by running: $ git pull https://github.com/sotnich/zeppelin psql-1876 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1828.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1828 commit c33778f468174535e0345d2b3a64d592f89cdd60 Author: Sotnichenko Sergey <s.sotniche...@tinkoff.ru> Date: 2016-12-31T17:33:27Z Main changes commit 4e9d4dd65fc27bff6e58fe3ffebc653c116d4815 Author: Sotnichenko Sergey <s.sotniche...@tinkoff.ru> Date: 2016-12-31T18:24:01Z [ZEPPELIN-1876] Main changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
