[GitHub] zeppelin pull request #1093: [ZEPPELIN-1103] Fix "stackedAreaChart", "lineWi...
Github user voyageth closed the pull request at: https://github.com/apache/zeppelin/pull/1093 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1144: [ZEPPELIN-1128] add try-catch in close() method.
Github user voyageth commented on the issue: https://github.com/apache/zeppelin/pull/1144 @jongyoul I change this just for more stability. I can't find that bug case just now. But if some Connection or Statement's close() method has some bug(like NPE is some circumstance), zeppelin can not clear that resource. But if you think Exception is too much, I'll change SqlException. Thanks for feedback. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1144: [ZEPPELIN-1128] add try-catch in close() method.
Github user voyageth commented on the issue: https://github.com/apache/zeppelin/pull/1144 Change catch SQLException to Exception. I think connection.close() can throw other Exception. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1144: add try-catch in close() method.
GitHub user voyageth opened a pull request:
https://github.com/apache/zeppelin/pull/1144
add try-catch in close() method.
### What is this PR for?
Fix bug on JdbcInterpreter when hive server restarted.
each connection.close() should be wraped by try-catch.
### What type of PR is it?
Bug Fix
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1128
### How should this be tested?
Restart hive while zeppelin still alive.
After that, Zeppelin notebook's hive query execution will be fail
Stacktrace is like this.
It was HiveInterpreter because i use zeppelin by yum install on centos(some
old version).
But JdbcInterpreter & HiveInterpreter's close() method is same.
> ERROR [2016-07-07 18:23:46,676] ({pool-1-thread-2}
HiveInterpreter.java[close]:166) - Error while closing...
java.sql.SQLException: Error while cleaning up the server resources
at
org.apache.hive.jdbc.HiveConnection.close(HiveConnection.java:721)
at
org.apache.zeppelin.hive.HiveInterpreter.close(HiveInterpreter.java:151)
at
org.apache.zeppelin.interpreter.ClassloaderInterpreter.close(ClassloaderInterpreter.java:88)
at
org.apache.zeppelin.interpreter.LazyOpenInterpreter.close(LazyOpenInterpreter.java:78)
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.close(RemoteInterpreterServer.java:232)
at
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$close.getResult(RemoteInterpreterService.java:1432)
at
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$close.getResult(RemoteInterpreterService.java:1417)
at
org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
at
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.transport.TTransportException:
java.net.SocketException: Broken pipe
at
org.apache.thrift.transport.TIOStreamTransport.flush(TIOStreamTransport.java:161)
at
org.apache.thrift.transport.TSaslTransport.flush(TSaslTransport.java:501)
at
org.apache.thrift.transport.TSaslClientTransport.flush(TSaslClientTransport.java:37)
at org.apache.thrift.TServiceClient.sendBase(TServiceClient.java:65)
at
org.apache.hive.service.cli.thrift.TCLIService$Client.send_CloseSession(TCLIService.java:177)
at
org.apache.hive.service.cli.thrift.TCLIService$Client.CloseSession(TCLIService.java:169)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.apache.hive.jdbc.HiveConnection$SynchronizedHandler.invoke(HiveConnection.java:1380)
at com.sun.proxy.$Proxy0.CloseSession(Unknown Source)
at
org.apache.hive.jdbc.HiveConnection.close(HiveConnection.java:719)
... 12 more
Caused by: java.net.SocketException: Broken pipe
at java.net.SocketOutputStream.socketWrite0(Native Method)
at
java.net.SocketOutputStream.socketWrite(SocketOutputStream.java:109)
at java.net.SocketOutputStream.write(SocketOutputStream.java:153)
at
java.io.BufferedOutputStream.flushBuffer(BufferedOutputStream.java:82)
at java.io.BufferedOutputStream.flush(BufferedOutputStream.java:140)
at
org.apache.thrift.transport.TIOStreamTransport.flush(TIOStreamTransport.java:159)
... 24 more
### Screenshots (if appropriate)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/voyageth/zeppelin patch-2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1144
commit b3d0ef61cb0588c17b629facc927bb31d624513f
Author: SungjuKwon <sungju.k...@campmobile.com>
Date: 2016-07-07T10:04:06Z
add try-c
[GitHub] zeppelin issue #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart"...
Github user voyageth commented on the issue: https://github.com/apache/zeppelin/pull/1093 Oh, empty string also make wired graph too! This PR doesn't consider that condition. This PR can fix following condition. `%sh echo -e "%table key\tvalue\nnull\t1000\n1\t100\n2\t200\n99\t900"` - before apply PR  - after apply PR  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1093: [Bug Fix] Fix "stackedAreaChart", "lineWithFocu...
GitHub user voyageth opened a pull request:
https://github.com/apache/zeppelin/pull/1093
[Bug Fix] Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset
contains "NULL" value.
### What is this PR for?
Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset contains
"NULL" value.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Check side effect.
* [ ] - Need fix when maxRowValue == rowIdx
### How should this be tested?
Test when row data set is like this on 1777 line.
rowIndexValue : Object {0: "0", 1: "1", 2: "2", 3: "3", 4: "4", 5: "5", 6:
"6", 7: "7", 8: "8", 9: "9", 10: "10", 11: "11", 12: "12", 13: "13", 14: "14",
15: "15", 16: "16", 17: "17", 18: "18", 19: "19", 20: "20", 21: "21", 22: "22",
23: "23", 24: "24", 25: "25", 26: "26", 27: "27", 28: "28", 29: "29", 30: "30",
31: "31", 32: "32", 33: "33", 34: "34", 35: "35", 36: "36", 37: "37", 38: "38",
39: "39", 40: "40", 41: "41", 42: "42", 43: "43", 44: "52"}
rowNameIndex : Object {0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8:
8, 9: 9, 10: 10, 11: 11, 12: 12, 13: 13, 14: 14, 15: 15, 16: 16, 17: 17, 18:
18, 19: 19, 20: 20, 21: 21, 22: 22, 23: 23, 24: 24, 25: 25, 26: 26, 27: 27, 28:
28, 29: 29, 30: 30, 31: 31, 32: 32, 33: 33, 34: 34, 35: 35, 36: 36, 37: 37, 38:
38, 39: 39, 40: 40, 41: 41, 42: 42, 43: 43, 52: 44}
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/voyageth/zeppelin patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1093.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1093
commit 48bc8a498764558526b126af60a35595bace9aff
Author: SungjuKwon <sungju.k...@campmobile.com>
Date: 2016-06-27T10:22:11Z
Update paragraph.controller.js
### What is this PR for?
Fix "stackedAreaChart", "lineWithFocusChart" graph when dataset contains
"NULL" value.
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Check side effect.
* [ ] - Need fix when maxRowValue == rowIdx
### How should this be tested?
Test when row data set is like this on 1777 line.
rowIndexValue : Object {0: "0", 1: "1", 2: "2", 3: "3", 4: "4", 5: "5", 6:
"6", 7: "7", 8: "8", 9: "9", 10: "10", 11: "11", 12: "12", 13: "13", 14: "14",
15: "15", 16: "16", 17: "17", 18: "18", 19: "19", 20: "20", 21: "21", 22: "22",
23: "23", 24: "24", 25: "25", 26: "26", 27: "27", 28: "28", 29: "29", 30: "30",
31: "31", 32: "32", 33: "33", 34: "34", 35: "35", 36: "36", 37: "37", 38: "38",
39: "39", 40: "40", 41: "41", 42: "42", 43: "43", 44: "52"}
rowNameIndex : Object {0: 0, 1: 1, 2: 2, 3: 3, 4: 4, 5: 5, 6: 6, 7: 7, 8:
8, 9: 9, 10: 10, 11: 11, 12: 12, 13: 13, 14: 14, 15: 15, 16: 16, 17: 17, 18:
18, 19: 19, 20: 20, 21: 21, 22: 22, 23: 23, 24: 24, 25: 25, 26: 26, 27: 27, 28:
28, 29: 29, 30: 30, 31: 31, 32: 32, 33: 33, 34: 34, 35: 35, 36: 36, 37: 37, 38:
38, 39: 39, 40: 40, 41: 41, 42: 42, 43: 43, 52: 44}
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
