Re: [DISCUSS] Adjust test logs for CI
+1 on that too From: Jongyoul Lee <jongy...@gmail.com> Sent: Sunday, April 22, 2018 9:30:27 PM To: dev Subject: Re: [DISCUSS] Adjust test logs for CI I like this idea!! On Mon, Apr 23, 2018 at 12:14 PM, Jeff Zhang <zjf...@gmail.com> wrote: > Another thing we can do is to skip the remaining test when we hit test > failure. Currently, zeppelin wont't stop run testing code even hit failed > test. > > http://maven.apache.org/surefire/maven-surefire- > plugin/examples/skip-after-failure.html > > > Jeff Zhang <zjf...@gmail.com>于2018年4月23日周一 上午11:00写道： > > > > > Regarding selenium test, I agree with you that the log in selenium is > > almost useless. It is hard to figure out what's wrong when selenium test > > fails. Maybe other frontend expert can help on that. > > > > > > > > Jongyoul Lee <jongy...@gmail.com>于2018年4月23日周一 上午10:55写道： > > > >> @felix, > >> We can enforce to set different log level like ERROR or WARN but I don't > >> think it's a proper solution. > >> > >> @Jeff, > >> I found current master might have a problem with Integration test of > using > >> Selenium but It's hard to see all logs from that tests because there are > >> so > >> many unrelated logs like "sleep...". I can fix this issue, but > generally, > >> I > >> think every contributor doesn't want to see unrelated logs except my > >> tests. > >> When developing a new feature, it would be helpful to see debugger/test > >> logs but after it's implemented, I think it's a bit less-useful and > it's a > >> bit bothersome for another developer. > >> > >> So it would be better to have a consensus to do our best to reduce my > >> logs, > >> especially made by test cases. > >> > >> How do you think of it? > >> > >> JL > >> > >> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang <zjf...@gmail.com> wrote: > >> > >> > Jongyoul, > >> > > >> > What kind of problem do you have ? Each module has log4j.properties > >> under > >> > its test folder that we can change the log level. > >> > > >> > > >> > > >> > Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： > >> > > >> > > Is there a way to do this via enable/disable component for logging > in > >> > > log4j? > >> > > > >> > > > >> > > From: Jongyoul Lee <jongy...@gmail.com> > >> > > Sent: Sunday, April 22, 2018 7:01:54 AM > >> > > To: dev > >> > > Subject: [DISCUSS] Adjust test logs for CI > >> > > > >> > > Hello contributors, > >> > > > >> > > I wonder how you guys think of reducing test logs to help to debug > >> with > >> > CI. > >> > > Recently, Zeppelin's Travis log is too big to read anything. > >> > > > >> > > So I suggest these kinds of step: > >> > > 1. leave test logs as much as you want to test your code passed in > CI > >> > > 2. If passed, please remove all of your test's logs > >> > > > >> > > How do you think of your guys? I know and understand our CI is not > >> good > >> > for > >> > > running multiple times with same code because of lack of resources. > >> > > > >> > > Best regards, > >> > > Jongyoul Lee > >> > > > >> > > -- > >> > > 이종열, Jongyoul Lee, 李宗烈 > >> > > http://madeng.net > >> > > > >> > > >> > >> > >> > >> -- > >> 이종열, Jongyoul Lee, 李宗烈 > >> http://madeng.net > >> > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
Re: [DISCUSS] Adjust test logs for CI
I like this idea!! On Mon, Apr 23, 2018 at 12:14 PM, Jeff Zhang <zjf...@gmail.com> wrote: > Another thing we can do is to skip the remaining test when we hit test > failure. Currently, zeppelin wont't stop run testing code even hit failed > test. > > http://maven.apache.org/surefire/maven-surefire- > plugin/examples/skip-after-failure.html > > > Jeff Zhang <zjf...@gmail.com>于2018年4月23日周一 上午11:00写道： > > > > > Regarding selenium test, I agree with you that the log in selenium is > > almost useless. It is hard to figure out what's wrong when selenium test > > fails. Maybe other frontend expert can help on that. > > > > > > > > Jongyoul Lee <jongy...@gmail.com>于2018年4月23日周一 上午10:55写道： > > > >> @felix, > >> We can enforce to set different log level like ERROR or WARN but I don't > >> think it's a proper solution. > >> > >> @Jeff, > >> I found current master might have a problem with Integration test of > using > >> Selenium but It's hard to see all logs from that tests because there are > >> so > >> many unrelated logs like "sleep...". I can fix this issue, but > generally, > >> I > >> think every contributor doesn't want to see unrelated logs except my > >> tests. > >> When developing a new feature, it would be helpful to see debugger/test > >> logs but after it's implemented, I think it's a bit less-useful and > it's a > >> bit bothersome for another developer. > >> > >> So it would be better to have a consensus to do our best to reduce my > >> logs, > >> especially made by test cases. > >> > >> How do you think of it? > >> > >> JL > >> > >> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang <zjf...@gmail.com> wrote: > >> > >> > Jongyoul, > >> > > >> > What kind of problem do you have ? Each module has log4j.properties > >> under > >> > its test folder that we can change the log level. > >> > > >> > > >> > > >> > Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： > >> > > >> > > Is there a way to do this via enable/disable component for logging > in > >> > > log4j? > >> > > > >> > > > >> > > From: Jongyoul Lee <jongy...@gmail.com> > >> > > Sent: Sunday, April 22, 2018 7:01:54 AM > >> > > To: dev > >> > > Subject: [DISCUSS] Adjust test logs for CI > >> > > > >> > > Hello contributors, > >> > > > >> > > I wonder how you guys think of reducing test logs to help to debug > >> with > >> > CI. > >> > > Recently, Zeppelin's Travis log is too big to read anything. > >> > > > >> > > So I suggest these kinds of step: > >> > > 1. leave test logs as much as you want to test your code passed in > CI > >> > > 2. If passed, please remove all of your test's logs > >> > > > >> > > How do you think of your guys? I know and understand our CI is not > >> good > >> > for > >> > > running multiple times with same code because of lack of resources. > >> > > > >> > > Best regards, > >> > > Jongyoul Lee > >> > > > >> > > -- > >> > > 이종열, Jongyoul Lee, 李宗烈 > >> > > http://madeng.net > >> > > > >> > > >> > >> > >> > >> -- > >> 이종열, Jongyoul Lee, 李宗烈 > >> http://madeng.net > >> > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
Re: [DISCUSS] Adjust test logs for CI
Another thing we can do is to skip the remaining test when we hit test failure. Currently, zeppelin wont't stop run testing code even hit failed test. http://maven.apache.org/surefire/maven-surefire-plugin/examples/skip-after-failure.html Jeff Zhang <zjf...@gmail.com>于2018年4月23日周一 上午11:00写道： > > Regarding selenium test, I agree with you that the log in selenium is > almost useless. It is hard to figure out what's wrong when selenium test > fails. Maybe other frontend expert can help on that. > > > > Jongyoul Lee <jongy...@gmail.com>于2018年4月23日周一 上午10:55写道： > >> @felix, >> We can enforce to set different log level like ERROR or WARN but I don't >> think it's a proper solution. >> >> @Jeff, >> I found current master might have a problem with Integration test of using >> Selenium but It's hard to see all logs from that tests because there are >> so >> many unrelated logs like "sleep...". I can fix this issue, but generally, >> I >> think every contributor doesn't want to see unrelated logs except my >> tests. >> When developing a new feature, it would be helpful to see debugger/test >> logs but after it's implemented, I think it's a bit less-useful and it's a >> bit bothersome for another developer. >> >> So it would be better to have a consensus to do our best to reduce my >> logs, >> especially made by test cases. >> >> How do you think of it? >> >> JL >> >> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang <zjf...@gmail.com> wrote: >> >> > Jongyoul, >> > >> > What kind of problem do you have ? Each module has log4j.properties >> under >> > its test folder that we can change the log level. >> > >> > >> > >> > Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： >> > >> > > Is there a way to do this via enable/disable component for logging in >> > > log4j? >> > > >> > > >> > > From: Jongyoul Lee <jongy...@gmail.com> >> > > Sent: Sunday, April 22, 2018 7:01:54 AM >> > > To: dev >> > > Subject: [DISCUSS] Adjust test logs for CI >> > > >> > > Hello contributors, >> > > >> > > I wonder how you guys think of reducing test logs to help to debug >> with >> > CI. >> > > Recently, Zeppelin's Travis log is too big to read anything. >> > > >> > > So I suggest these kinds of step: >> > > 1. leave test logs as much as you want to test your code passed in CI >> > > 2. If passed, please remove all of your test's logs >> > > >> > > How do you think of your guys? I know and understand our CI is not >> good >> > for >> > > running multiple times with same code because of lack of resources. >> > > >> > > Best regards, >> > > Jongyoul Lee >> > > >> > > -- >> > > 이종열, Jongyoul Lee, 李宗烈 >> > > http://madeng.net >> > > >> > >> >> >> >> -- >> 이종열, Jongyoul Lee, 李宗烈 >> http://madeng.net >> >
Re: [DISCUSS] Adjust test logs for CI
Regarding selenium test, I agree with you that the log in selenium is almost useless. It is hard to figure out what's wrong when selenium test fails. Maybe other frontend expert can help on that. Jongyoul Lee <jongy...@gmail.com>于2018年4月23日周一 上午10:55写道： > @felix, > We can enforce to set different log level like ERROR or WARN but I don't > think it's a proper solution. > > @Jeff, > I found current master might have a problem with Integration test of using > Selenium but It's hard to see all logs from that tests because there are so > many unrelated logs like "sleep...". I can fix this issue, but generally, I > think every contributor doesn't want to see unrelated logs except my tests. > When developing a new feature, it would be helpful to see debugger/test > logs but after it's implemented, I think it's a bit less-useful and it's a > bit bothersome for another developer. > > So it would be better to have a consensus to do our best to reduce my logs, > especially made by test cases. > > How do you think of it? > > JL > > On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang <zjf...@gmail.com> wrote: > > > Jongyoul, > > > > What kind of problem do you have ? Each module has log4j.properties under > > its test folder that we can change the log level. > > > > > > > > Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： > > > > > Is there a way to do this via enable/disable component for logging in > > > log4j? > > > > > > ____ > > > From: Jongyoul Lee <jongy...@gmail.com> > > > Sent: Sunday, April 22, 2018 7:01:54 AM > > > To: dev > > > Subject: [DISCUSS] Adjust test logs for CI > > > > > > Hello contributors, > > > > > > I wonder how you guys think of reducing test logs to help to debug with > > CI. > > > Recently, Zeppelin's Travis log is too big to read anything. > > > > > > So I suggest these kinds of step: > > > 1. leave test logs as much as you want to test your code passed in CI > > > 2. If passed, please remove all of your test's logs > > > > > > How do you think of your guys? I know and understand our CI is not good > > for > > > running multiple times with same code because of lack of resources. > > > > > > Best regards, > > > Jongyoul Lee > > > > > > -- > > > 이종열, Jongyoul Lee, 李宗烈 > > > http://madeng.net > > > > > > > > > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net >
Re: [DISCUSS] Adjust test logs for CI
@felix, We can enforce to set different log level like ERROR or WARN but I don't think it's a proper solution. @Jeff, I found current master might have a problem with Integration test of using Selenium but It's hard to see all logs from that tests because there are so many unrelated logs like "sleep...". I can fix this issue, but generally, I think every contributor doesn't want to see unrelated logs except my tests. When developing a new feature, it would be helpful to see debugger/test logs but after it's implemented, I think it's a bit less-useful and it's a bit bothersome for another developer. So it would be better to have a consensus to do our best to reduce my logs, especially made by test cases. How do you think of it? JL On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang <zjf...@gmail.com> wrote: > Jongyoul, > > What kind of problem do you have ? Each module has log4j.properties under > its test folder that we can change the log level. > > > > Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： > > > Is there a way to do this via enable/disable component for logging in > > log4j? > > > > > > From: Jongyoul Lee <jongy...@gmail.com> > > Sent: Sunday, April 22, 2018 7:01:54 AM > > To: dev > > Subject: [DISCUSS] Adjust test logs for CI > > > > Hello contributors, > > > > I wonder how you guys think of reducing test logs to help to debug with > CI. > > Recently, Zeppelin's Travis log is too big to read anything. > > > > So I suggest these kinds of step: > > 1. leave test logs as much as you want to test your code passed in CI > > 2. If passed, please remove all of your test's logs > > > > How do you think of your guys? I know and understand our CI is not good > for > > running multiple times with same code because of lack of resources. > > > > Best regards, > > Jongyoul Lee > > > > -- > > 이종열, Jongyoul Lee, 李宗烈 > > http://madeng.net > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
Re: [DISCUSS] Adjust test logs for CI
Jongyoul, What kind of problem do you have ? Each module has log4j.properties under its test folder that we can change the log level. Felix Cheung <felixcheun...@hotmail.com>于2018年4月23日周一 上午3:52写道： > Is there a way to do this via enable/disable component for logging in > log4j? > > > From: Jongyoul Lee <jongy...@gmail.com> > Sent: Sunday, April 22, 2018 7:01:54 AM > To: dev > Subject: [DISCUSS] Adjust test logs for CI > > Hello contributors, > > I wonder how you guys think of reducing test logs to help to debug with CI. > Recently, Zeppelin's Travis log is too big to read anything. > > So I suggest these kinds of step: > 1. leave test logs as much as you want to test your code passed in CI > 2. If passed, please remove all of your test's logs > > How do you think of your guys? I know and understand our CI is not good for > running multiple times with same code because of lack of resources. > > Best regards, > Jongyoul Lee > > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net >
Re: [DISCUSS] Adjust test logs for CI
Is there a way to do this via enable/disable component for logging in log4j? From: Jongyoul Lee <jongy...@gmail.com> Sent: Sunday, April 22, 2018 7:01:54 AM To: dev Subject: [DISCUSS] Adjust test logs for CI Hello contributors, I wonder how you guys think of reducing test logs to help to debug with CI. Recently, Zeppelin's Travis log is too big to read anything. So I suggest these kinds of step: 1. leave test logs as much as you want to test your code passed in CI 2. If passed, please remove all of your test's logs How do you think of your guys? I know and understand our CI is not good for running multiple times with same code because of lack of resources. Best regards, Jongyoul Lee -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
[DISCUSS] Adjust test logs for CI
Hello contributors, I wonder how you guys think of reducing test logs to help to debug with CI. Recently, Zeppelin's Travis log is too big to read anything. So I suggest these kinds of step: 1. leave test logs as much as you want to test your code passed in CI 2. If passed, please remove all of your test's logs How do you think of your guys? I know and understand our CI is not good for running multiple times with same code because of lack of resources. Best regards, Jongyoul Lee -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
