[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-495549253 Nice! One thought: Is the "any chars" needed for some common guard against running empty paragraphs, or could any chars actually be no chars? I feel it is a bit confusing for end users to have to provide some text that doesn't matter just to start the interpreter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter
FireArrow commented on issue #3359: [ZEPPELIN-4131] Refactoring shell interpreter URL: https://github.com/apache/zeppelin/pull/3359#issuecomment-492659189 We are using %sh pretty much exactly like @Leemoonsoo described it above. I think this is a really cool feature, but I don't think it should replace the %sh magic, but rather get its own, new, magic (as @Tagar suggested above). `%terminal` or `%shell` perhaps? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
