[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582337500 Thanks for your reply. I understand. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1582052448 Mybe a synchronized at the `org.apache.zeppelin.util.FileUtils#atomicWriteToFile(java.lang.String, java.io.File, java.util.Set)` is a better option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581997675 Yes, i also think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1581779073 Thanks for your reply. This pull request migrates solve the concurrency problem caused by multiple concurrent calls to `org.apache.zeppelin.notebook.AuthorizationService#saveNoteAuth`, but this can result in concurrent modifications to `notebook authorization.json`.   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078356 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0.10.1-bin-all/conf/notebook-authorization.json at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:447) at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262) at java.nio.file.Files.move(Files.java:1395) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:60) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:71) at org.apache.zeppelin.storage.LocalConfigStorage.save(LocalConfigStorage.java:71) at org.apache.zeppelin.notebook.AuthorizationService.saveNoteAuth(AuthorizationService.java:109) at org.apache.zeppelin.notebook.Notebook.createNote(Notebook.java:258) at org.apache.zeppelin.service.NotebookService.createNote(NotebookService.java:168) ``` whether this method requires a lock ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580078089 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0.10.1-bin-all/conf/notebook-authorization.json at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:447) at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262) at java.nio.file.Files.move(Files.java:1395) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:60) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:71) at org.apache.zeppelin.storage.LocalConfigStorage.save(LocalConfigStorage.java:71) at org.apache.zeppelin.notebook.AuthorizationService.saveNoteAuth(AuthorizationService.java:109) at org.apache.zeppelin.notebook.Notebook.createNote(Notebook.java:258) at org.apache.zeppelin.service.NotebookService.createNote(NotebookService.java:168) ``` whether this method requires a lock ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [zeppelin] youshaojun commented on pull request #4563: [ZEPPELIN-5885] Solve the concurrency clone note
youshaojun commented on PR #4563: URL: https://github.com/apache/zeppelin/pull/4563#issuecomment-1580071482 hi~, I tried to use the above modifications, but now occasionally throw java.nio.file.NoSuchFileException ``` Caused by: java.nio.file.NoSuchFileException: /usr/local/zeppelin-0.10.1-bin-all/conf/notebook-authorization.json at sun.nio.fs.UnixException.translateToIOException(UnixException.java:86) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:102) at sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:107) at sun.nio.fs.UnixCopyFile.move(UnixCopyFile.java:447) at sun.nio.fs.UnixFileSystemProvider.move(UnixFileSystemProvider.java:262) at java.nio.file.Files.move(Files.java:1395) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:60) at org.apache.zeppelin.util.FileUtils.atomicWriteToFile(FileUtils.java:71) at org.apache.zeppelin.storage.LocalConfigStorage.save(LocalConfigStorage.java:71) at org.apache.zeppelin.notebook.AuthorizationService.saveNoteAuth(AuthorizationService.java:109) at org.apache.zeppelin.notebook.Notebook.createNote(Notebook.java:258) at org.apache.zeppelin.service.NotebookService.createNote(NotebookService.java:168) ``` whether this method requires a lock ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
