[GitHub] fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

[GitBox]

fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue
URL: https://github.com/apache/zeppelin/pull/3264#issuecomment-457055731
 
 
   the problem of the code is for loop in the line 166 can't sort for number,
   have to add extra check the variable is number or string
   
   "for (let k in rows)"
   
   
   
   On Wed, Jan 23, 2019 at 7:16 PM Kentaro Ishihara 
   wrote:
   
   > Any update to this?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > , or 
mute
   > the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue

[GitBox]

fred521 commented on issue #3264: [ZEPPELIN-3908] Fix Date Sorting issue
URL: https://github.com/apache/zeppelin/pull/3264#issuecomment-455042924
 
 
   > is there js test we could add?
   
   I agree, just will take more time to write the test framework for this bug. 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services