[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @minahlee Sorry for bothering you. I just made PR for fixing compile error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @minahlee Thank you for addressing that. I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user minahlee commented on the issue: https://github.com/apache/zeppelin/pull/1117 @astroshim this PR causes compile error in current master. Do you mind to create another PR to fix it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1117 Sorry, it took me a while to get back. Done! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 Ping --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1117 Sounds as a great plan to me! Merging this one then, if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @bzz Thank you kindly for telling like that. What do you think about tagging meta value than removing keywords like following image?  I think it looks more nicer than removing keywords. If it is okay, let me make it at the another PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1117 Got it! Thanks a lot for looking into it. Let me know when you think its ready and I will try again. You did great job already, making it auto-complete names so in case it's too hard - we could merge as it is now, its already very useful! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @bzz I totally agree with you so I did try to remove things you mentioned but it's not easy. Let me try one more. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1117 What I mean is - as a user, when I auto-complete the interpreter name, I would expect a suggestion list that contains only interpreter names and nothing else. Right now list of suggestion includes things like "NoSuchMethod" and `AbstractMethodError`. If it is hard to remove such things from the suggestions list in this case - let's keep them. But if that is something we could implement in this PR - that would be nice. How do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @bzz Thank you for reviewing. You mean that blocking the keyword and local meta values? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1117 @astroshim looks awesome, thank you for implementing! How do you think, would it improve user experience with this feature if we could remove from suggestion list things, that are not interpreters? Like function names, etc. And how hard would that be to implement? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @Leemoonsoo As you can see the following screenshot, I fixed bug and changed completion results.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @bzz @Leemoonsoo please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1117 @astroshim Oh sorry for my late response. Yeah that would be better ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 @AhyoungRyu Thank you for your review! I think it's better to make zeppelin manual on zeppelin homepage than adding shortcut info page. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1117 @astroshim Awesome! :+1: I'm not sure where can be the proper place, it would be better users can know this feature's existence since it's really useful. How about adding this info in [here](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/components/modal-shortcut/modal-shortcut.html#L211)? This is just my personal opinion :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1117: [ZEPPELIN-1086] Auto Completion for Interpreter.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1117 re-trigger CI --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
