[GitHub] zeppelin issue #1343: ZEPPELIN-1328 - z.show in python interpreter does not ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1343 There actually are tests, but we do not have CI profiles with both Python2 and Python3 yet. I think, I will take a look into creating one soon. Though @felixcheung is right, there are no Integration Tests for Python interpreter yet, the one that might verify that image appears in the paragraph. It would be nice to have one, but I guess it's a bit out of scope for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1343: ZEPPELIN-1328 - z.show in python interpreter does not ...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1343 LGTM. is it easy to add automated unit test for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1343: ZEPPELIN-1328 - z.show in python interpreter does not ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1343 Thank you @agoodm for taking care, looks great to me. I think it sets an excellent example of Python version compatibility. Will merge to master if there is no further discussion --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1343: ZEPPELIN-1328 - z.show in python interpreter does not ...
Github user agoodm commented on the issue: https://github.com/apache/zeppelin/pull/1343 @bustios Thanks for the catch. I agree that the second option you posted would be a lot cleaner, so I'll go ahead and test it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1343: ZEPPELIN-1328 - z.show in python interpreter does not ...
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1343
Looks great to me, thank you for taking care @agoodm !
Merging to master if there is no further discussion.
[CI
failure](https://s3.amazonaws.com/archive.travis-ci.org/jobs/153350047/log.txt)
is not relevant and is due to flaky `RemoteInterpreterTest` test
```
Running org.apache.zeppelin.interpreter.remote.RemoteInterpreterTest
18:31:23,153 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreterManagedProcess:116 -
Run interpreter process
[/home/travis/build/apache/zeppelin/zeppelin-interpreter/../bin/interpreter.sh,
-d, fake, -p, 50714, -l, fakeRepo]
18:31:23,660 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 - Create remote
interpreter org.apache.zeppelin.interpreter.remote.mock.MockInterpreterA
18:31:23,906 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreter:223 - Create remote
interpreter org.apache.zeppelin.interpreter.remote.mock.MockInterpreterB
18:31:23,945 ERROR
org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller:192 - Can't
handle event RemoteInterpreterEvent(type:OUTPUT_UPDATE,
data:{"data":"","noteId":"note","paragraphId":"id"})
java.lang.NullPointerException
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller.run(RemoteInterpreterEventPoller.java:174)
18:31:23,986 ERROR
org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller:192 - Can't
handle event RemoteInterpreterEvent(type:OUTPUT_APPEND,
data:{"data":"","noteId":"note","paragraphId":"id"})
java.lang.NullPointerException
at
org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller.run(RemoteInterpreterEventPoller.java:160)
18:31:23,999 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcess:127 - shutdown
interpreter process
18:31:26,114 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcess:137 - Exception
in RemoteInterpreterProcess while synchronized dereference, can safely ignore
exception while client.shutdown() may terminates remote process
18:31:26,116 INFO
org.apache.zeppelin.interpreter.remote.RemoteInterpreterManagedProcess:154 -
Interpreter process exited 0
18:31:26,616 INFO org.apache.zeppelin.interpreter.InterpreterGroup:140 -
Close interpreter group InterpreterGroup_1471545083152_-1987997814
18:31:26,634 INFO org.apache.zeppelin.interpreter.InterpreterGroup:204 -
Destroy interpreter group InterpreterGroup_1471545083152_-1987997814
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
