[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, This PR looks like unbacked from the point of view design. I will close this issue. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Hi all, Let me know if anything needed to be changed from design to code style! Thanks :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user bzz commented on the issue: https://github.com/apache/zeppelin/pull/1734 Guys, if I may, I would suggest keep the discussion in PR focused on the subject of the PR and move general topics of project's CI stability to the public dev@ mailing list and appropriate JIRA issues. Main reason beeing that people in community, who are interested in the subject of CI stability have hirer chanced on collaborating and fixing it together that way. Here is JIRA for the CI failing on `spark-csv` - [ZEPPELIN-1797](https://issues.apache.org/jira/browse/ZEPPELIN-1797), \w some logs and failure examples. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda. Seems it much better! Let me test again. So true. Currently the CI test result makes us more confused and really hard to find what the problem is :( --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 Totally agree with @zjffdu's opinion. [Here are unresolved flaky tests](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20AND%20text%20~%20flaky%20ORDER%20BY%20status%20ASC) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1734 I also notice this failed test in travis. I think there're several jiras tracking the flaky test. The flaky test waste every developer's time. I think we should spend some time to fix them. What do you think ? \cc @Leemoonsoo @AhyoungRyu @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 - Selenium tests passed by fixing https://github.com/apache/zeppelin/pull/1734/commits/c377cf8f255fa714d4b65061daf5239e86e8f641 - The profile 3 (scala 2.10, spark 1.6.3) failed but irrelevant with this PR ``` // https://api.travis-ci.org/jobs/183520147/log.txt?deansi=true Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.646 sec <<< FAILURE! - in org.apache.zeppelin.dep.DependencyResolverTest testLoad(org.apache.zeppelin.dep.DependencyResolverTest) Time elapsed: 0.633 sec <<< ERROR! org.sonatype.aether.RepositoryException: Cannot fetch dependencies for com.databricks:spark-csv_2.10:1.3.0 at org.apache.zeppelin.dep.DependencyResolver.getArtifactsWithDep(DependencyResolver.java:181) at org.apache.zeppelin.dep.DependencyResolver.loadFromMvn(DependencyResolver.java:131) at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:79) at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:96) at org.apache.zeppelin.dep.DependencyResolver.load(DependencyResolver.java:88) at org.apache.zeppelin.dep.DependencyResolverTest.testLoad(DependencyResolverTest.java:77) Results : Tests in error: DependencyResolverTest.testLoad:77 » Repository Cannot fetch dependencies for ... ``` @AhyoungRyu @Leemoonsoo please let me know if there is anything to be fixed. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda Great initiative for improving interpreter binding page UI! I also agree that current binding page is getting longer (thanks to the Zeppelin contributors :D) and getting hard to find. Definitely needs to be improved. I tested this branch and checked the improvement. Let me share my thought about this patch in here. - Currently the restart button is exposed so that ppl can know "I can restart this interpreter by clicking this button" by instinct. But \w this patch, ppl need to click "Carrot" button to open the dropdown menu and need to click "Restart" button to restart interpreter. And the user need to click at least one time to know about this. - Seems don't need another tooltip in here since there is already the text "Restart"  - The color change for default interpreter is good idea i think! But the color is gone when it comes out as a result.  - Shirking overall size also good idea. Was quite verbose. But the thing that interpreter button has smaller height than dropdown menu is quite awkward to me.  - How about "Search bindable interpreters(?)" instead of "Search interpreter Bindings"? :D https://cloud.githubusercontent.com/assets/10060731/21041595/6681d904-be2f-11e6-82c2-c7499f0d0875.png;> Most of them in the above are just my personal opinion. So surely you don't need to apply all of them. And thanks again for your effort to improve the UI! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1734 I like a green button for default interpreter feedback. especially, it seems to be a good choice for separating roles of interpreter. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 @Leemoonsoo I'v just fixed as commented above and updated GIF in the PR description --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda that looks more make sense to me. fyi, a related PR https://github.com/apache/zeppelin/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1734 @Leemoonsoo Thanks for your opinion! That's true there will be scrollbar anyway if we have many bindings. So What about adding scroll bar to the binding list? so that users can find **save**, **close** button easily (I attached GIF)  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda for working on UX improvement. Personally, i'd prefer keep items in 1 column. Because it displays interpreter names (e.g. %spark, %pyspark, etc) at predictable location. i.e. beginning of each rows. This change doesn't newline after each item and each item has variable length and it's hard to quickly read interpreter through eyes, even though there's filter. IMO. Scrollbar will be there anyway when user have enough numbers of interpreter settings. Or when user have small screen size. For this reason, how about think other way to help user easily find 'save' button? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
