[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1812 Thanks for explanation. LGTM and merge if no more discussions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1812 @Leemoonsoo :) - Now user doens't need to care about `yarn.lock` and can use npm commands. - CI failure is irrelevant --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1812 @Leemoonsoo 1. `yarn remove` and `yarn add` will update package.json as well. 2. But some people might not know how to use yarn, so it would be better to - remove `yarn.lock` from git - run `yarn install --no-lockfile` (don't read, generate lock file) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1812 Tested and it works well. @1ambda Could you explain little bit about how `zeppelin-web/yarn.lock` can be updated in case of new dependency or dependency version change in `package.json` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---