[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1813 LGTM. Merge if there are no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1813 @soralee Thank you for reviewing and commenting!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1813 Tested and It works as expected like below!! [Before]  [After]  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1813 @astroshim It's great work! I will test it! But, I would like to suggest one thing. According to what I understand, your screenshot and `Then you can see the login button like as screen shot.` is the content before fixing bug in this PR description, right? I think in this part, It makes confusing for your description of PR. So, it would be clear if there is content after fixing the bug. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1813: [ZEPPELIN-1868]fix to not shows up the login button on...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1813 Yeah it makes sense. Tested and it's working well ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
