[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...

2017-01-02 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1815
  
Merge to master if there're no more discussions 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...

2017-01-01 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1815
  
Addressed comments. 

I don't think style `visualization(el).transform(...).render();` is 
important topic here.
Because this `Visualization` class is intended to be used by developer who 
want to create new visualization. And the developer doesn't need to call either 
`visualization(el).transform(...).render(); ` or `new ;` because instantiation 
of visualization is managed by `result.controller.js`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---