[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 Thank you @AhyoungRyu :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1834 Yup thanks for the explanation. Merge if there are no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 @AhyoungRyu Yes, you're right. I mean, If I change **navbar** folder option, it works together both the filter in the **home** and **navbar**. So, I did not include this part because I think this improvement should be opened other PR. Thanks for review again! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1834 @soralee Thanks for the update and kind reminder! Let me test again :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 @AhyoungRyu I updated the filter of Navbar. But, the folder of notes in navbar don't have previous status. Because If using the hidden value of the note, it works together both the filter in the home and navbar.  I think it will take more time to add this feature so it would be nice to improve this part by separating PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1834 Thanks for detailed test @AhyoungRyu! :heart_eyes: Sure, actually I missed the filter in the Navbar! Let me check and update PR!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1834 @soralee Thanks for the improvement. I've also seen those issues when I was using filter. Let me test this :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
