[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1886 LGTM and merge to master if no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich now Well working! good works! Thank you for great feature!  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts @astroshim, check it now, please. If it's still not working send me details: configuration of the interpreter and jdbc log file. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1886  Hello, I was check again. but, does not work on mysql. Is there anything I missed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Great Job! but still doesn't work with `mysql`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts @astroshim Made a little change - now mysql also works as well as postgresql. I have tested it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1886 CI failure is not related to this change. LGTM and merge to master if no further discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Thank you for great improvement. I tested `mysql` and `postgresql` and only `postgresql` is working expectedly like @cloverhearts. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 @cloverhearts Please, clirify your question. This PR supports every JDBC driver that can return schema and table names. I have tested it on postgres, but I am sure it would correctly run on mysql and other relational databases. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich I was test. LGTM. I have a question. Is it possible to only support pgsql? (actually, i am mysql/maria user) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 Made a rebase, now CI tests have only one error related with DistributedResourcePoolTest. Think it's still not related to my PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 @sotnich Can you rebase it onto current master? Recently, we fixed some flaky tests including your case. It would make your CI green --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 There is a flaky test in the result: ``` WelcomePageSuite ``` Never mind the result. that test is being fixed now. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/1886 Don't think CI errors are related to this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...
Github user jongyoul commented on the issue: https://github.com/apache/zeppelin/pull/1886 @astroshim Could you please review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
