[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1892 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1892 @1ambda I updated to extract `require('express')` module as variable and CI is green :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1892 Sorry for late reply. I will review and comment ASAP @soralee --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1892 cc @1ambda --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1892: [MINOR] broken logo url in web dev mode
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1892 @minahlee I updated and resolved another way. When web application develop mode, the source base of production mode is different to web application develop mode. So, I updated to correct source base path for develop mode of web application. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---