[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@del680202 Thanks, if you finish to test it, we will make a new rc 
including it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[del680202]

Github user del680202 commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@jongyoul Thanks, I will test it later


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
I'm testing it now and found something weird.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[del680202]

Github user del680202 commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@zjffdu  @AhyoungRyu 
Yes, I tested it by latest branch-0.7.

Latest commit
```
commit 53e90578621574f466a58ad02a6577bca6335a5a
Author: Guillermo Cabrera 
Date:   Mon Mar 20 16:00:52 2017 +0300
```

Oh..Sorry, I suppose I miss some steps.
I tested this problem with ``%python``  and ``%pyspark`` at the same time

1. Enable shiro for login
2. Execute sample code by ``%python`` and  ``%pyspark``
![2017-03-24 20 59 
28](https://cloud.githubusercontent.com/assets/3747345/24293388/d4603266-10d4-11e7-9883-6bc600f65924.png).
 
3. Switch ``spark`` interpreter from ``global`` mode to ``Per user`` mode 
and save it.
4. Switch ``python`` interpreter from ``Per user`` mode to ``global`` mode 
save it.
5. Shutdown zeppelin

It was success when I change ``spark`` interpreter setting, but it make 
zombie process when I change ``python`` interpreter setting.







---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@del680202  I can not reproduce the issue on 0.7.1 rc2, regarding your 
instruction, when you do step 2, zeppelin would ask you to restart the 
interpreter, did you click the button to restart it ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[del680202]

Github user del680202 commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@AhyoungRyu  Thanks for your reply.

>>But I seem when I edit interpreter config then the zombie process 
will be occurred

Sorry, I miss this test case.
I test it by current ``branch-0.7`` too.
My test steps as below:

1. Execute sample code with ``%python`` in ``global`` mode.
2. Switch python interpreter to ``per user`` mode
3. Restart/Shutdown Zeppelin

It looks like a issue of switching interpreter mode function.

![2017-03-24 16 57 
23](https://cloud.githubusercontent.com/assets/3747345/24285457/7617215e-10b3-11e7-9239-8d64f8b491b6.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@del680202 Thanks for your time and effort to test it out.

>But I seem when I edit interpreter config then the zombie process 
will be occurred 

I checked it with current `branch-0.7` and I could see the interpreter 
process was killed. 
Actually just tested in basic case (anonymous / global mode) with Spark 
interpreter. 

 1. Run some paragraphs \w Spark intp
 2. Edit `zeppelin.spark.maxResult` from 1000 to 20  in the interpreter 
setting page  -> save
 3. The remote interpreter process was killed 

Was your case different with mine? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[del680202]

Github user del680202 commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@AhyoungRyu 
I test #2149 in my machine.
It works well, Thanks. 
But I seem when I edit interpreter config then the zombie process will 
be occurred.
Anyway, ``Restart`` button looks well, I close this PR, thanks.

## Test cases:

### Global mode
Restart by button in notebook page:  SUCCESS
Restart by button in interpreter page: SUCCESS

### Per user & isolated mode
Restart by button in notebook page:  SUCCESS
Restart by button in interpreter page: SUCCESS



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[del680202]

Github user del680202 commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@AhyoungRyu  Thanks, I will check it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@del680202 
>When I enable authentication with shiro or switch interpreter mode to Per 
user & isolated, Restart does not work and it is possible to make zombie 
process.

This issue has been solved by #2149. And the issue status was updated to 
`RESOLVED` in https://issues.apache.org/jira/browse/ZEPPELIN-2037. Can you 
check again? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
Is it caused by ZEPPELIN-1921 ? It works in zeppelin 0.7 but not in master.
BTW, I think these methods are a little confusing, we might need to improve 
them later.  @jongyoul is working on refactor the interpreter component, we 
might also need to consider to clean up the APIs that those components should 
expose. (InterpreterFactory, InterpreterSetting, InterpreterGroup)
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  

Thank you for your reply, @del680202 
I understand your publicity purpose.
And I think it's right.
What I am worried call "terminateRemoteProcess ();" From "public void close 
(String sessionId) in InterpreterGroup.java".
"Close (String sessionId)" should only perform the action corresponding to 
the session.
And if all sessions are closed, the process must be terminated.
However, the current code always performs "terminateRemoteProcess ();" 
Within "close (String sessionId)".
"TerminateRemoteProcess ();" The function forces all sessions to be 
terminated and the process is terminated.
I think this is the wrong behavior of "close (String sessionId)".
We think this can be a problem, because we can write several users with an 
interpreter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@jongyoul sure :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1976: [ZEPPELIN-2037] Restart button does not work

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1976
  
@cloverhearts Can you check it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---