[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM and merge to master if no further discussions. Thanks @tinkoff-dwh for the improvement! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user sotnich commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 ready to review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 travis does not work (build was not created for last commit) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 @Leemoonsoo Yes you were right, this margin from alert (bootstreap class). fix it  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh Thanks! Looks good :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 > I can add the close button @tinkoff-dwh Yeah that's better. Having close button will be better for other cases as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 @AhyoungRyu if you configure the note and working only in report mode then you will not see when the report is incomplete.I can add the close button --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user masyan commented on the issue: https://github.com/apache/zeppelin/pull/2134 @AhyoungRyu if you configure the note and working only in report mode then you will not see when the report is incomplete.I can add the close button --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 Tested and basically agree with @Leemoonsoo. But one thing I just noticed is this new message can be seen in report mode.  I think it would be better we can hide this msg in this case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh Ah, i see. i didn't see where this margin comes from. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 @Leemoonsoo possible. This margin within HTML Message maybe there are problems in other messages (without bootstrap). I'll try. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh thanks! It's nit, but bottom margin is bit much compare to other margins in paragraph. i tried mark other margins.  Of course there's no rule that all the margin should be the same, but the margin on bottom looks bit inconsistent. Message is already decorated by bootstrap box so it already gives good visual separation. What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 @Leemoonsoo I think now is fine (data table + message separated from footer), but I can increase the top margin --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134  Top margin looks bit small and bottom margin looks too large. What do you think adjust them little bit and make top and bottom margin the same? @1ambda @AhyoungRyu @prabhjyotsingh @felixcheung @zjffdu @jongyoul Can you guys take a look and give some feedback how this new message style looks like? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/213063178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134         --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2134
@Leemoonsoo
*location*
I think it's better to display above table because the output can be large
and user will not see message.
*style*
Bootstreap attracts attention and this is important
*text*
Output is truncated to {count} rows. Learn more about {variable_name}
sorry for offtopic. @Leemoonsoo can you watch
https://github.com/apache/zeppelin/pull/2085
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 Message location Because of existing message `Results are limited by X.` and `Output exceeds 10240. Truncated.` are displayed below the table. I think showing `Attention! Result is incomplete ...` below the table helps keep user experience more consistent. Message style Bootstrap decoration is pretty. If we apply bootstrap alert to all 3 messages, then that means existing 2 message ux is changed, too. From taking less height of the screen, receiving less attention, To taking more height of the screen, receiving more attention. So which is the way we should go do you guys think? @tinkoff-dwh @1ambda Message text All three message are different. `Results are limited by X.` `Output exceeds 10240. Truncated.` `Attention! Result is incomplete ...` It'll be better use similar form of message. But how they're limited are all different. And it'll be great if we user give some link how they're limited. So for example, `Output is truncated to X rows. Learn more about common.max_count` `Output is truncated to 10240 bytes. learn more about ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` What do you think? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 @Leemoonsoo what final version, bootstrap? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 In addition to @prabhjyotsingh mentions, there are another type of message controlled by `ZEPPELIN_INTERPRETER_OUTPUT_LIMIT` env variable.  All three messages Color, location, Decorations are different. Basically these three messages are saying the same thing "Not a complete data". So it make sense to display all three message in similar way, i think. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2134 Just saw it, this definitely looks better. I don't have a strong opinion, I just saw there is a small diff, hence, highlighting it. This is how it gets displayed in spark/livy, with some extra information. https://cloud.githubusercontent.com/assets/674497/24008365/70a6eaa0-0a97-11e7-901c-59cfe7ad7913.png;> And this is how it will look like if there were multiple queries. https://cloud.githubusercontent.com/assets/674497/24008366/70aa1360-0a97-11e7-965a-9f5acafe01fe.png;> --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2134 @tinkoff-dwh Then you can make this CI status green by reopening-closing this PR :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 CI green https://travis-ci.org/tinkoff-dwh/zeppelin/builds/211619211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user tinkoff-dwh commented on the issue: https://github.com/apache/zeppelin/pull/2134 ok.  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2134 Sorry for late reply. - regarding to design, it would be great if we use bootstrap-alert. (`warning` level would be ok) For example,  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 Merge to master and branch-0.7 if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2134: [ZEPPELIN-2257] notification about incompleteness of d...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2134 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
